From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 576E880E7E for ; Mon, 9 Nov 2026 15:55:38 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9FsKJ6001096; Mon, 9 Nov 2026 18:54:21 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9FsKJ6001096 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="S/tcPCbm" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9FsIZw001092 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 9 Nov 2026 18:54:18 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9FsIZw001092 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-49205554e17so684503f8f.1 for ; Mon, 09 Nov 2026 07:54:18 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErHZ2P2K+shKPDykNMnghb8b81yynIqEM7kMYH7YjxhbJk+k5nl6emzvFgJj7dmAx2tMtPw10g==@openvz.org X-Gm-Message-State: APuU4Z9iLkxjaipGVBXm4XvYOYx+xvTHE1oDoaOZO4a4lmChsK065V9B fmaLa8kzQbKv/sSpSFDMK4ILvFJWeeJ1SUf0JMAQ0L3LlYXvr5O5JUMGehTmU+OoO4XUqEdsHjp pIwcZNDdgJMdnPgyATmHNfiBdJGUdQzWbHax8G7LG/r+D8m8ELk9tAQ== X-Gm-Gg: AYBFou0WmzgT9m9DXV1p8WahaQ9590otYoohpu2ZZROlmw8iKEf3TziFnbJTnmQV8Pb +SIrQZkxjZ8+GaPbEzxatfBwk2TrllfY09VUpZqDHZMGWnh1HrbWIIi8pR9nn7hD3JTmV4tcLnk fI4Xfxgc7BWpQKeFst0c43nnna+ufouosyaL8YJg5/WTmouyd+rR6KZpvM/3YLS98HAKfeZRuY/ 5/AoXTiwtx5k+uiXwir4C65ztuVFXB1xxRW+FktY08uwv6WotSJy6RNXSPxuMnX9LGZB4RaP839 3qHeMN1CQYNqXeUEgYkMGIZV0x7To0nObgJU38CUD+VGKYG2W0A50u5wbXXjUSxee4bOC8bxWeT anOgD2tsS2t5LOKX4cw== X-Received: by 2002:a05:6000:4815:b0:491:7ede:60e5 with SMTP id ffacd0b85a97d-49582e8e55cmr8629885f8f.20.1794239658193; Mon, 09 Nov 2026 07:54:18 -0800 (PST) X-Received: by 2002:a05:6000:4815:b0:491:7ede:60e5 with SMTP id ffacd0b85a97d-49582e8e55cmr8629856f8f.20.1794239657711; Mon, 09 Nov 2026 07:54:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794239657; cv=none; d=google.com; s=arc-20260327; b=OOikYA6Bdrae+m5THL86vWFun3LvHmSz3FNT7xjU9Kz1r5x1xuVQNQyWcI4xUpOmyw PhE3Zp7CWy3VOxyEuzc0DBVpYMFoDMTAhqoWBUyGuRgMSwVmO0b1L/bXqI/HcQM9Ri+t emnyl2qDG5QQG61037z/CE6+vDpJGnAkoBCwSuyOfZnNNkQ6LEPdJPkgpXvpkfgd3OFg SpM1vA1+TVUobFwE8fOIxCqjsVAgX6pb9ss9+UPengZb7CK52ynm0ApPqrLuBIiyZFJI g6jZzbqvB+PNbfEn94Tb2CNlpWnHhSD1KrboOnhX1yQ/qgfA+bJlcgdI3bESo3jncBpV b1AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=fZnEuMEYMbcvWQjdP/lO39Y01dFJpclB3fDMzKLEWDk=; fh=AXaEMap9UVXDT/x707nN5u9hAuW2OOlHA2h2MmC//Kg=; b=hSBPZ3JPHWeYJ+YhXMvd57qnCtUhjq2C07R65g576lqD0Z29FbERaosVZGNAxPGJ9h pnE5x7nWTLb+YePDr0PAWHtGVdecBuN6INl8Co7zNfNrwZf/hYDy6ELOXiXf++rNdqLs zLArgoxBtTBgpq//9eyoIZYuQzE3artw3ay9PZVRimRBNMaMcMfW3AhQjY1HUx+usvYH n4WNOnlW7I3fG4Zx91d4y3usEYjsTE5rcyQ6DEkf695GaCYFBbtt91hvba+eg5Z9AiLy Jp7tzkrG8v00Unt9YoddOPAFLo1nQjt6LmYhFlmUxyen8+tmg8QKFsO14cHnIDbUrogx T0ZA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="S/tcPCbm"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-497a032a2e5si2468315f8f.388.2026.11.09.07.54.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2026 07:54:17 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="S/tcPCbm"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=fZnEuMEYMbcvWQjdP/lO39Y01dFJpclB3fDMzKLEWDk=; b=S/tcPCbmTkYr C0Dc1JWXmHsnUz9axb1zZHF75UArdzeQHcGmh4nQMLl/LXVNKc69wxBf4qnai2KZVkWNzlLbZMYV5 tC4yf1v/knHO5jwO5zmf7wfn7cdBBsKP9grSHex0HH5+vGKqrgQoXBNqWoge9B78MK4ys+12pIDub w5AFdrJSARawKtuxsWhc6V2E/3QqRIG3IvMKNR6fhhOr/L7hkbT9LQZpE+N/NQUYnKLbnD8l231qZ MRjJp2B6MpEl+nZRng4kHJEBxb/9wGn0XgauS1qORmylP2ObpAgJ9AdbPp7gtQwOGMtorpCJEGFup aa7h010IcJMfKIce4zVb5w==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xQRdE-0083Fw-2Z; Mon, 09 Nov 2026 16:54:08 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexander Ivanov In-Reply-To: <20261109140143.1408038-1-alexander.ivanov@virtuozzo.com> References: <20261109140143.1408038-1-alexander.ivanov@virtuozzo.com> Date: Mon, 09 Nov 2026 16:54:12 +0100 Message-Id: <179423965293.3398823.17613808411761019799.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1280; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=ZVd5g52cuHfW7H+CbAAcpTeVTtK4PUUcQ155pY6Oq8E=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq8eyoTLomLTy2A/v8dWERSvr14XIj6gQH+Pnti 4CctOO5qRGJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavHsqAAKCRBRlgpH+WFc KrViEADB4Gy9PX8VXAJHd9THMQrlbjkiJuB0Z9QIwG+1A9q/bgUrKbaoRWcKQSHNNWDxbBJTUsI 26P7iPYKDAn4z4KS+Hus4kQIhooF+WjRXXV0JP4uolEXBKYDg1DAb08oXI0EANKMFN0vwU0SOHP faMrO1SVspQ05SZqhJTYp9/TwhDaI9o1ZejopII1IrCEOfLUkV9+oMpkjud1jI+ajM8rSVpwApg 11xILG3k1g2mPpPvKSPpRLP0bZrgIgc6sdwc3cGNuHDXfHYWXEs3UN/JhITj4HiBCNwFemMo+/N EMtzerMq9f0bMz3btnfbWVazrYWO00dVDaw64hTXshd0luHuJpZ1nAoBq1pW5UktQ5xpX+lXtdx Aa4UPP0+48J/XvpVQcrznTFtQGdMmzmDklL9hmZjuPqYNNclZiWaCMKpCEdbWljHoGwPPVpiOK9 iCo78QeFm5IoSEOyOXPirUjkPWw5dvUzYECKDUJ9rg9tuW/Yxp7vtovBI4Co+YF8QKFtlwCLLTm SFLbIrK+nhjDsPzMX5KuiHm1fOrNEgcLiYSKeeNx3eLarQ6I5GW4yf2w4cPazir8BPDIcKsmc6/ u8nQZleuYDrjFAsd7RGPzoLqpIEZvHUI6ZVyZVXjhbrSGLskC2wumyi8tKmQZcP2jwO9ZHpHmXs 7TyjUCPrr1OlSVQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v11 00/10] dm-qcow2: truncate unused tail of image on suspend X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Sasha, One more thing to my v11 review, the item I listed under "Separate patches": a REQ_OP_FLUSH whose fsync fails with ENOSPC hits WARN_ON_ONCE(!op_is_write()) in qrq_endio(). I checked this one to the end, it is real. Please send a separate patch for it. The path: - qcow2_clone_and_map() sets endio_cb = qrq_endio for every request, a flush included; - qcow2_submit_embedded_qio() puts an empty request on QLIST_FLUSH; - do_qcow2_fsync_work() ends it with errno_to_blk_status(fsync_ret), so a failed vfs_fsync() with -ENOSPC gives BLK_STS_NOSPC; - qrq_endio() then does WARN_ON_ONCE(!op_is_write(qio->bi_op)), and op_is_write(REQ_OP_FLUSH) is false. fsync returns ENOSPC on file systems that allocate on writeback (NFS, FUSE, thin or reflink backends), or when ext4/xfs report a failed delayed write. The rest of the handling is already right: the flush is delayed and resubmitted like a write. Only the WARN is wrong, and with panic_on_warn it takes the node down. Suggested fix: WARN_ON_ONCE(!op_is_write(qio->bi_op) && qio->bi_op != REQ_OP_FLUSH); The WARN came with 7d49e18c5c36f ("dm-qcow2: Pause IO and notify about ENOSPC events"), so that is the Fixes tag. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel