From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 4FA76803F6 for ; Tue, 10 Nov 2026 17:05:09 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAH3kBq016566; Tue, 10 Nov 2026 20:03:47 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAH3kBq016566 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="SFuPfBDS" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAH3iKB016553 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 20:03:44 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAH3iKB016553 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-4915ba023d4so1574133f8f.0 for ; Tue, 10 Nov 2026 09:03:44 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErG7VMKjxj40Zxni0g3hmz2toVa+iAx6ts6L9WAIqYHvuS7dE2HNh/3WrfYWi5P3Vp7FBSW+7g==@openvz.org X-Gm-Message-State: APuU4Z99q+l4GBBIQBfSEUnAvjXrGPdfsKF5bCC4sR+LrdlSnx5LEUw5 uToqLSSQu0hoacUE8N+LBsJe4lupdEt8r5wTYyKglto+O1jiC96FPx1zwvDXHSLgU7rGHn1tzpt rkJjJbo3GC68NbTOySJV4jQTuuY0KaIzIPqbKcJoJFe6ZUF622JmJiw== X-Gm-Gg: AYBFou2H/GKeVn+PIl5dmLN2jZq/VhdPK0UD4qgGOILq6mz7LeaASfBrQep5nf1elNr bulHTqC0Zdu5KLcT1epjd2C2y8ZGvDkSlpuWvSrgpPWjexnylYvDH8gEGkMl0BYKI7NSxT/GrAB vGZveAaoAJ9xG0sriclo7zoSQuu8GydXBGPKZsc/COGf8UIdGEx1cPSbtyaj7tK5mG/xcvhmgcj ZFdQ5cNstmh37A7Z4j6Klt1Z2xkeXY789a1xtJQ7/ozKKt6XwYwM1S8GjrmUG5mpOhFc6/I7AlG D0gsV2E2GTbieOoWORF5D8n/Eculv+U3KA/H+brbL91+uAib9HscHyTd4jzVuAze8MhNfHKz859 jz5H/9vjuDudzjEg92g== X-Received: by 2002:a05:6000:4381:b0:48d:f3a5:4563 with SMTP id ffacd0b85a97d-4982e82c2e5mr7447892f8f.20.1794330223926; Tue, 10 Nov 2026 09:03:43 -0800 (PST) X-Received: by 2002:a05:6000:4381:b0:48d:f3a5:4563 with SMTP id ffacd0b85a97d-4982e82c2e5mr7447823f8f.20.1794330223358; Tue, 10 Nov 2026 09:03:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794330223; cv=none; d=google.com; s=arc-20260327; b=TswqR0DrwjUy/hhbZcewsI1oHEgMrzuBiYM7g+eY6cYXS1ESNneBVNpmnW7Px6PeUZ 6rLpPkaqEToA7FTGJqAxWG2JIa1mW8pAU+l8pcD+QwghcZU2nJ6HSHsXgPC84B59z/Ri JZFkli02vNQS+hLIT8/SLlJHLcrHoASTngemJ+CKtgIJMbuIge286uDcLESuukBh67sn 4OZBdnKl/kucKj8Kv+1ts9xJgstwU1YoD4iGFf08NkplxwUzEDe7R95bXE3+B7zmlmjL 1F2AfUG+xr7gXEOGqiNt3YgLw3GFpkXjjCTpKO3w1MAzIQtKAQ25T/wgLgfCbLBwAlUN c5cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=u75AJthq2nJwbHGra4PlzfEE9Fpqzl0XgKKxtz00BDY=; fh=+5xttkgkwONswRd2Oq13QsL3ym20IqW/INZ9jy2C/wI=; b=lsewwqIPGI+HL2T4GiLAShGHDeKLXQR41EWDDqjne63guIsZrHeigUaJoFJKoBsPpX 4nJHRbt0TTZlC3451AoHCDBJUbaA1Z+6XEtgRh3dzABpDb1Pvy9Mfl4dxCT+ZnWEQhvS Nem0b4bVma0u70fjPlRJG4ZlDIRou65/pKLWzPjBmHF1UE+OuVhPlJsW+AOxp/kC4sUR cqsdlebmoN6JTctfVkdaJBYaGS4OFArAJ6SyCknbk5igBGb8r6wXhv4tk9Bg/+wFi1H1 0/6EvQ0iwvCoT6rX3ivdzdunQi8b3GdtOpXSFF3cuzzxmQX9DLOG+eWmhcgZa3rU82Zb 2UHQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=SFuPfBDS; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-498364d6e9esi6370524f8f.248.2026.11.10.09.03.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 09:03:43 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=SFuPfBDS; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=u75AJthq2nJwbHGra4PlzfEE9Fpqzl0XgKKxtz00BDY=; b=SFuPfBDSgEw/ lXRVIUeom25fi2ffRl4E12oQoPkf62OxWGbXvPUjHp1UMh54pf9xkkmWrxxoIY7/lVnYFHEPlSQMB IreaJb1SsKL6m+eBb/WBKkd8mdeg7aJxOm7RtxNiExP2vvfjj4DLd7SJyp4yzFswVkDgI3Pa4E8bY e0N7ZiLga4j6jCUsxxnwk+Y0CEO03OeP/GfEzsDwJuPDzChtEae/ZJz1RPXq2YZ07pOVAmnElE1H0 WQOeSJKUQErdUBa/vapGBN77EcJzNYQ/H79rNj5krNaCXVYHD53MG5E0IfHxal/q0DAhi6+RUwk/M 9RPMwj1+B6XnlMGrigDNpw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xQpBw-001avS-1W; Tue, 10 Nov 2026 18:03:32 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261109190657.1851487-1-den@openvz.org> References: <20261109190657.1851487-1-den@openvz.org> Date: Tue, 10 Nov 2026 18:03:39 +0100 Message-Id: <179433021952.3552165.1138458329605355940.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1991; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=Du15tqABDjLDPHAF1iSpIyozjHPz2XJX1qXLY1XBYI0=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq805tiEXLu3x+tq2pazQfLiGogaxdLjeV8En1w zwPt+Sr7BCJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavNObQAKCRBRlgpH+WFc Kl4mD/wP9AcZNGVcNc34yO2rSl4dJb38uD8nhdAnCzAWJxKp9kyPjk96wWsVcS0jjT/gP6BajxL Hc3FJDstTkaXYreQwuiZsegNzCvkI9srIvwu7MA1feRbvJ5FQz9780JxgCEDsRK6f8JRcmQbUcw iIh1Q+3IHOXqnXyscNgz4fH4F/WGA/G/ykGpto4hACT4jZDJmWa+0r9PPIm3ifAtHBGjKI8GmST IJQTrDZ8KpBgMooy0Et+99rAgDKiYpm6KJmf3AxOBEKQ3dvi1gIXrrFEHKtp8H5eAPIH05y26bC xwtweu48c7DBv11UrrUlUB2TsIS3g5S3Sa5jT75P2/aG1l+oklxi2uPU4N51GwkkKyOSpjB9Cp8 zMQQh7kY65jeOtCWzYjwYe3Ds1/wuqTl8dzjHIYipL17kumg2i9MRG3j6R2u5J0K2djidRkc2Va V1E14OcK8BtG2LtofxUNF4HBoyin4/+uwUYLQ6tGFCxiKJCn0Gh00ejZHXbTJnNRC95sZQjoeWM 3hu1Mjzlk4XuO6tJ6G+85IOjP2BcwLmmut2d7/1jlVrUiw5IFtf9yO6RnTfkQo9oi1IBGIjkLi+ 8RoubC+WUISfgWABpSb+La1qYC6/smZyiX9FQ4SH6TkcEh/LAA8neceiatulat0TzGSMuIpbt/H u22vKc8Pc4vBVRw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 0/2] dm-ploop: fix writes held on ENOSPC never being retried X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On Mon, 9 Nov 2026 20:06:55 +0100, Denis V. Lunev wrote: > dm-ploop: fix writes held on ENOSPC never being retried The code of both patches is right. For v2: 1. Patch 1: cancel event_work in ploop_destroy() next to the timer. 2. Patch 1 message: name mod_timer() after the wants_suspend test as the race, not the lockless test, and say what the user gets. 3. Patch 2 message: drop the wrong reason given for xchg(). 4. Patch 2 message: start a new paragraph at "The held writes are retried only...". 5. Cover letter: drop the vmcore paragraph and the measured numbers. > Found in a vmcore: 16 writers in D state, submit_enospc set, all 16 > pios on enospc_pios, the timer expired 12 s before the crash. Item 5. The cover letter goes into each commit as the "Patchset description", so this ends up in the git log. How the bug was found and the timings belong in VSTOR-154182, not in a commit message. > Tested on 6.12.0-211.52.1.22.19.vz10, dm-ploop built out of tree: > - 16 O_DIRECT writers held on a full host ext4, then the space freed > with no other I/O on the device. Stock: still stuck after 60 s, one > unrelated read releases them. With the series: done 8 s after the > space is freed, on the next timer tick; > - ploop test suite, make -j48 test on dev-cl04, green for ploop and > qcow2 with this series together with the VSTOR-154096 one. Same here: say what was tested (writers held on a full image, space freed with no other I/O, they finish when enospc_timer next expires; the ploop test suite passes), without the numbers and the host name. Separate patch, not for this series: dm-qcow2 has the same hole. qcow2_tgt_destroy() stops neither enospc_timer nor event_work, the mod_timer() in the ENOSPC path runs after event_lock is dropped, and presuspend uses timer_delete_sync_try() as well. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel