From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 9F31C803F7 for ; Tue, 10 Nov 2026 17:05:12 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAH3nPY016573; Tue, 10 Nov 2026 20:03:50 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAH3nPY016573 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="ooISPXps" Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAH3iv1016555 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 20:03:44 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAH3iv1016555 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4a318cd95e8so19684105e9.0 for ; Tue, 10 Nov 2026 09:03:44 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErHMRbR24ZjXICrr7rvB6RrWGariwB42pda2Dz9jCjsB6T2Wf/CeKs3MOaNSY2e+FF/zPPeukg==@openvz.org X-Gm-Message-State: APuU4Z/EOCc7Lvd2rawqMRCTNboNfOqLefVFIJL9jHr90Y0PbEOCer2j BsWkUdBIhJdpC/Iz0b9aprpKptJjHzJUgNrAz0vO5zJIVfggjjOJP+BcC+bR85/VEvIhtdBqc6d Y+MILsxTjRn131gjYu/wikJ1bDCOVzTbFg1VPRvS9pYIZu7/JuTPUCQ== X-Gm-Gg: AYBFou33q4/1EdkBFcb3QycHkIbSqLnblNmL7xtPzsZzTXpO6FnlhfKMDzp/QMd9WKq 7Tqv/P3uBsyf+X2xokc8IlGJ1Hir1nA3jnFERj24RQzolE3bVOpGCEtWu8UxoD5EbJcHPb8YKNF R9pQ2JOoBW4OhGgYEOT3iL2bqb9kMR3XR+FOqSuIQEr+/Uer9lSooZYyLLE74O8uF3QIh6ZkAQT pSjElhdwU0Qh+N6sMvXCmn6zTjOHiVYzpoUlObrdqVUuEUfbyxDnR+Tkz2KbHc76djsKhqDVgUb QsPH65LMcTREvikRT+cv7eTCtCZ/wvCIKViaTisHG1OmIfBEgbnLJUfwJvjaRL8E28iPKMfOCgD ERe/383Cgp3dLlP7ESw== X-Received: by 2002:a05:600c:4410:b0:4a1:d49e:9ce with SMTP id 5b1f17b1804b1-4ba01d8aab0mr48119035e9.2.1794330224048; Tue, 10 Nov 2026 09:03:44 -0800 (PST) X-Received: by 2002:a05:600c:4410:b0:4a1:d49e:9ce with SMTP id 5b1f17b1804b1-4ba01d8aab0mr48118715e9.2.1794330223535; Tue, 10 Nov 2026 09:03:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794330223; cv=none; d=google.com; s=arc-20260327; b=BmWrNhYLryDftC2erLreFgw8/v0O1zwuojhzzwzEINyuhT4H1vvf+WcJwM7azWlfQW YJeAeo4ZxHQlO7Tiwm1fjKfN21JAEr1J6I6w2fzGTPyuTaq75aHlH+ojmTN77i+8nDgn 7LdLraHG1SxCK4++ijzr+qioO5GUCLMCOzZDxv79Bd04ks/s6NyNl1WSkA5Hnrq35Ks0 RLeMaVh+/jftW0ivfKpYvS0BvR0xLie8/Jw10Kj+vwpK60SqrCl3nHmHZ2eA93MNn9vQ +bQ6uXvhBiBL11LssOj/AedEqfv3DkqPrh1/ctolGMNoRN1s0mNTIlujm0Nz7alHk74j NZDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=0cSEA2/K58lX0JL9GQWGn61OfQYng5qmF2ovhk0PU4w=; fh=+5xttkgkwONswRd2Oq13QsL3ym20IqW/INZ9jy2C/wI=; b=QsaXmQW48g7IWeUfT+ncO804JO7PD6sZSajliwy8jmYaszr+KNar3cGzeJBeOYdphE AIqJpWnvXMNCQM6eHIuzZzCVonxW7ZguOrsMCrGUmlBCjGyo//Rkai2Qo8J1fM5gqyWN elsTdfdEzDgE/TtYgvL2vSUp4BfSF6fAWt+7lwSTmho+od0VMT9ijuzKVXQxk85D6NQQ eZv7TktzddZsjdr4jQfcfAHrRHR4eT+XmmG61OswkxJYB/5xc6fcnevAIWXCMchUUJrX TTQgp0aQQR50Q37HUt8r7/U2Af72qTWh1MfbDZaedIReXFAwdeVmgp+0ziz1WlN9Nv0I FO9Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ooISPXps; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4983585d2f1si6249270f8f.139.2026.11.10.09.03.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 09:03:43 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ooISPXps; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=0cSEA2/K58lX0JL9GQWGn61OfQYng5qmF2ovhk0PU4w=; b=ooISPXpsHtap advp4Pn3EUaI+Z7rgOOrYMUEGK+wXGs4DQ78HTFiaddUx6monzRR8uerWrlcDpqg9eG0HzFywARMe XdujEEl/d1UXj8rvocXZrGC+8jfXeLr+3ErrTcgZrRCxT1Hnl04rPq2yvRAPXryIdy81YKIM7hT4D GppmZU5aQoYOmF8yerWvioNikHa+vEvFW+Yy+nl6nctOCsit9qKG7b4bKFeFPdToHl+UQTVVQ55an uTssOCIi/sb5D0+Bj/KB2w1HXHga2eCRgqfGTbtiuolKQ419sH4zsQMaAXA8YezhCZHxqaoJc1ur2 mmdzKJjMizDNY3XdnCIUvw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xQpBw-001avS-29; Tue, 10 Nov 2026 18:03:32 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261109190657.1851487-2-den@openvz.org> References: <20261109190657.1851487-1-den@openvz.org> <20261109190657.1851487-2-den@openvz.org> Date: Tue, 10 Nov 2026 18:03:39 +0100 Message-Id: <179433021952.3552165.16408029362614329367.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2366; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=hVSsahMu5UfU5yqvM7VlRdKhpb0Pn0peeksYo2v6ujQ=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq805tYh66t0o8iBmoUkwpUksvZZtdc3z/txXyR GyiUlw+R1iJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavNObQAKCRBRlgpH+WFc KgtEEACYPHg6EYK37HF8XB/LhapZhyP8Y2CAsLXh3wrPkgRecWOnarR5WeOetNvBY6sx5bkQFQq m99A438v3FSuxGCZGlWA6NIxsCPX8kfSD70k2WaD+ZwlIvVsQpRhxGfinjzPRntVOOOFCtmWwcQ lce6urP2pYqExohO929aaNq6EXGqcAaOYifsAC1Cc0WJEtLVi10bOwuTKjR38UaIkmOVY5+OVjd MqVO6sKzEG5XcJ7xsB3m8/MpyaYnWMH6yoSRJM2kqXdeCmMlEfr251x/4z3xn9HlN37cAa6L1d8 30KsE/dvgTnXp+KEaY6GbYO4bCZxgp+8tmZcX1E3eYoBhO1aVSZ2FVFx2QQBqBnBBZBTipZ6nA1 GO4pTAvc/qUg+mg8vtDWaGMyRV0gMNdiQmN42RRi/dBwezBOEP86B7CAbGnVYvjAnHNc8dmtUfh hCDcaMbApRh5KUmrMRGLUOBGR6vvL3FEvYFEwwgj5Pl4MS8Oxgrawu0LZyF2t2bnEl/0iXSQeK5 LofWLV1yITvgi9m/oe7L7nsPHB6dGE1z7HjQ5LzidhC6ijYmo0Ze9E2AgshyTujBoNLQ46K77XN bY5NACwVPrHYP/AfgK/CohF7Sb7LaF7m5nRHdVre6deyjIg+0d65PxJgD8uvjAtF7+hHtAE3zzY 4usfg/H1+kdjI0w== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 1/2] dm-ploop: stop enospc_timer in ploop_destroy() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On Mon, 9 Nov 2026 20:06:56 +0100, Denis V. Lunev wrote: > The destructor never stops enospc_timer. ploop_presuspend() deletes it > with timer_delete_sync_try(), which does not wait for a callback that > runs on another CPU, and ploop_try_delay_enospc() tests wants_suspend > without deferred_lock, so a write that fails with ENOSPC around the > presuspend can arm the timer again. The callback dereferences the > struct ploop that ploop_dtr() frees. - Item 2 of the cover letter reply: the race is mod_timer() after the test, and the message should say what the user gets. The lockless test is not the cause. In 6ddad5a4d226 the test was under deferred_lock, but mod_timer() ran after the unlock, so the timer could be armed after presuspend's timer_delete_sync_try() from the start. That is also why the Fixes tag is right. "does not wait for a callback that runs on another CPU" can go: a callback that runs during presuspend is done long before dtr. Say what happens then: the timer expires on freed memory, and with patch 2 it also calls wake_up_process() on a freed task. The paragraph is one sentence chained with commas; something like: The destructor never stops enospc_timer. ploop_try_delay_enospc() arms it after testing wants_suspend, and nothing orders that against timer_delete_sync_try() in ploop_presuspend(). A write that fails with ENOSPC around the presuspend leaves the timer pending after the suspend, and it expires on the struct ploop that ploop_dtr() freed. > if (ploop->kt_worker) { > + timer_shutdown_sync(&ploop->enospc_timer); > ploop->force_md_writeback = 1; - Item 1 of the cover letter reply: cancel event_work here too. ploop_try_delay_enospc() calls schedule_work(&ploop->event_work) right after mod_timer(), so the same race queues event_work after presuspend's flush_work(). Nothing in ploop_destroy() waits for it, and do_ploop_event_work() reads ploop->ti after the free. The window is much shorter than the timer's, but it is the same race: timer_shutdown_sync(&ploop->enospc_timer); cancel_work_sync(&ploop->event_work); INIT_WORK() runs before kt_worker is created, so it is valid under the same check. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel