From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 5147781553 for ; Tue, 10 Nov 2026 17:05:09 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAH3rBo016580; Tue, 10 Nov 2026 20:03:54 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAH3rBo016580 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="jgEi5B8J" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAH3irG016557 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 20:03:44 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAH3irG016557 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a20e41008cso15333185e9.1 for ; Tue, 10 Nov 2026 09:03:44 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGz/uHRXNyqC5wMD2H8NFdRNAte2xZs+WovmlSwiybdEa0Zc6n/haf9tsF7Vp3Ysy1eTIfu4Q==@openvz.org X-Gm-Message-State: APuU4Z9QxB7krP0uuX4L/ZXDfDvzNXk9QKQdHA/zZhmdZaLaep35nOKN PIgimJwnkOi2wc6/tXgJS90mGuzCpB7JhkA5eVzhR9WlwK9t8SKVtnGBAf1z84SW1RkbOfMSy71 u1BFJtZ+nGANx+tiChFyN0yXgGZjlGjyzuUS72qpe/TWOjTDTOjKRVA== X-Gm-Gg: AYBFou2B/+JwsY2Xg4CgZBPOdF6o88i0Mu1Mgf1xDToWY0RNP5ECZZzHxGi1FEx+X+f P6Sjnxm8oVBm7YK9sIu66Pa2k9b9hUiVBT+vMZyhPFX2EHtwngQ9mReMjWAYZInQg03Rm6wZaXS YY+QhHUnXdkoYP7Y1FtXTwWGC2Jx9yp4El8/Kj4t7oD3PUYcy+Ik1XXEa47quNNSsyzGmZx5PtI 1gHk4irraCneiaxFbr0r/ZgK19qYrxof42+ALTO3ymH4ipVfG3grnbbsFhfb+CtRDnfJTYtR6jh GnVwMu/ddQ43PKhTYhQ954l7/hms/D+NhwiAKFAq7poGc6FOyKqbRXpe40OE9rif1Io0Xh3Gq3E hcl7joF5amfWMBwP7 X-Received: by 2002:a05:600c:6214:b0:4b5:d95c:2378 with SMTP id 5b1f17b1804b1-4ba02357d71mr55637875e9.34.1794330224139; Tue, 10 Nov 2026 09:03:44 -0800 (PST) X-Received: by 2002:a05:600c:6214:b0:4b5:d95c:2378 with SMTP id 5b1f17b1804b1-4ba02357d71mr55637445e9.34.1794330223687; Tue, 10 Nov 2026 09:03:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794330223; cv=none; d=google.com; s=arc-20260327; b=X6HBJp6olCdIkvcisbe7+DUKFk5FJpp/2YQQjsD61mWDBMceRuFp3vnP43S+0N6sh9 1r50wdMxwqXZ7TWkrITHxIFrQFSJgisiojS4AeLCxLKDtaLil7yRaASEl3RiEow2DugY sPj8JJMMRqokJDLIAQb6eQI3sKjpuvEMhbs1gFiNHDLT0gK9KimPcfl9iwTQI0kqPUM6 f/AwVSr4sU202Na9Jp6LdriMRww2WMLDwnRfvE/GpJSm1sdmx4CL2G5bod5BTSXtIBNj pN0vu8WyO7KqbnYHw9nhYY26lNMprJ5H6yAapDdUY/fR7HyXUX4Ihxl5UmloaavGbajg 06Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=2ymX90b6o0IcnRrQ5KE9iBW7eiWKWQdC9x3x8rPqjYE=; fh=+5xttkgkwONswRd2Oq13QsL3ym20IqW/INZ9jy2C/wI=; b=LSkjklsFJmKlOihYXxPzyc3ecxwYYnGXWHNuXnSRTZtL7MdhT9lCINPBg9pROjU6oO ZFqJhSn47a0jDJPykvX3GsLinTze5Etqg1ECjCV3gQDFjNMvC3hClHX6BfH7QD/e0oGq iI2jbAsRs6D1HSAkeMbHbBLpbb2qwcqWjuOa2L0LRLpcL2WbSQyRlZzFZRsblnUUlCMI eq3/ThpX07Mlk0HdUZkPQ1+ylEpTt670zYK3MvB6uc5X8iRWYgAuAHreBzMruiXY5zqS je6IBGlLRFO3xRXiIiAkUYG6ZidGzhdmU3SS3nI2BzU+EZC5JFQVQLIxJuO8ORESYelI oXvQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=jgEi5B8J; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-498359525b2si5994351f8f.131.2026.11.10.09.03.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 09:03:43 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=jgEi5B8J; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=2ymX90b6o0IcnRrQ5KE9iBW7eiWKWQdC9x3x8rPqjYE=; b=jgEi5B8JqLly b8P4rN98ps3XL96nqppuk/DeuFKr5g1JIeo3sKCqOgl0JXlFsvByMLwSUcGtdqlEKkpbt12fUJ+NR XXcT71Fa5zGCO1ME8o25/r/+5dyr3PPN2yIlq4hmnrxXXpOynKP8FBAoweBQkjZgGb4ocL+8g9Cgx 5lV0vrjPbO8VDd/agQAeWip076xpOfiEcs4QYtrt8k67RRGzImj2bX9vEJhEGO6Y3mA7vzq5f7kpa ByB7+DTBC6NZl5r4jA42HemldQefN/lFxD8Ak7tWzJbHzsvYVEOQns78+Gk5HYYagXw4YT7OuJJ36 ztlxMUyDYrLLW3frJwn9Ow==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xQpBw-001avS-2l; Tue, 10 Nov 2026 18:03:32 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261109190657.1851487-3-den@openvz.org> References: <20261109190657.1851487-1-den@openvz.org> <20261109190657.1851487-3-den@openvz.org> Date: Tue, 10 Nov 2026 18:03:39 +0100 Message-Id: <179433021952.3552165.6570046133131073588.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1399; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=s48DHM5LepA/CYp/H/my1+/+kPKlh3nA7mVXTE4H0jg=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq805tHlxs0qaGLtC09hErkHMK80oyZjkg0qtp4 /59Iny10/2JAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavNObQAKCRBRlgpH+WFc KruGD/9Iu96wTJzcWios93srrGTktWB4STNTeDOtFXofpA/jzZ596ypLAZ2JNqhKfOmhIt/vvjo Tl9p0GLvkiMnqccWaegXsaagJlYP+MIAhWfhiPh9UhLhaoktgQtKYhgRrq4l4VvU6tsyON2aUaL R1YpScdDEUjyJPB/kQ2TGoO66sSTQg2e8G+rhsGLFhDpbpIWtvsU1U42stfu+uMAVXf8C9YCzQG 7O5QkL1/Xw7w34jDHBnrmkzMseyjPxg55HFjay1xkSfS4IR+e7cpiJtH0yaDqjPHOQkfnPgACv7 i61j2JcgvR6m30/3T+hUDPquKbSWuuqCaVb+WML7ldA9x1elhohRo5NDj50n/PuERnJi3a/zzgr ICSaWkrwGT5L3NFeDSFPEdRuNRgavwWqYGYiEaPT3CggowTu3Hr78t6bbspBVO7vi7ECF0acfC9 fBzPrDMvUpl1fFpneycaoqRvaS0S16jCFJyOkT1HybaEf0beXJ7k17w0xgtsYBGBqIlFv+7sJmM sDNwN7IZogl8jJLCrHT/cdBDFpJkg5a7UukZfHXhUP1pnY3AmI6y2/KemKuaWvbp3HKK6HTp7x8 2qRnmGEV9GXXjgp1eeWkREcbmkAhyCfb9yXX8VcK4OAifrRa4k8tO0P5ThSTSR/kzixtOboSO8U M9LbZsjS44TCgUA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 2/2] dm-ploop: fix the ENOSPC retry timer not waking the dispatcher X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On Mon, 9 Nov 2026 20:06:57 +0100, Denis V. Lunev wrote: > ploop_worker() also goes to sleep with the flag set, as its sleep > condition checks the pio lists only. The held writes are retried only > when other I/O reaches the device: on a device whose only I/O is the > held writes, the writers stay in D state after the space is freed. The code is fine, only the message needs two changes. - Item 4 of the cover letter reply: start a new paragraph at "The held writes are retried only...". The first paragraph then says what the code does and why that is wrong, the second what the user sees. > Wake the dispatcher from the timer, and keep ploop_worker() awake while > submit_enospc is set, so that a wakeup that comes while the dispatcher > is busy is not lost. Test and clear the flag with xchg() in > do_ploop_run_work(), as the timer now sets it from another CPU. - Item 3 of the cover letter reply: "now" is not right, drop the reason or give a true one. The timer has set the flag from softirq on any CPU since afc60480b037, this patch does not change that. The old test-then-clear lost nothing either, as ploop_resubmit_enospc_pios() takes the whole list after the clear. xchg() is fine as a cleanup, just without that clause. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel