From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 72606803F6 for ; Tue, 10 Nov 2026 17:48:15 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHktbn017662; Tue, 10 Nov 2026 20:46:56 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHktbn017662 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="nEIFX9Wv" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHksMX017650 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 20:46:54 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHksMX017650 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-4903fc8537aso1578098f8f.0 for ; Tue, 10 Nov 2026 09:46:54 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErEiBdUyRsbOmJ33/9CKZUObqIHQS7ZLBZ5/Br6TzvX1XbWba82275RRc5Pw2Ff2m2Vlesrajw==@openvz.org X-Gm-Message-State: APuU4Z/tFaaDrcLHZvy3AB3B5zhyE7TLZf3LXlVPdW+u0eRWsBZLEGHT hB2WJGUiHdvzlMW+5ghW+fQ/RKzvpyL/g6tsMooFsgtCa8tFhLfKFsC5mIO8+qJkm+QDlMXxu8a w42B2K9WSWzUeuSSSkElAugWuHHpRe/skoV4HVHVyyogxMc5OVWX4FA== X-Gm-Gg: AYBFou3bxTu5zI9AwBEaQB7gx8WTSTxAi6fiaMBY6sgINsbx5gvhF0TWiMPPf5RxXF3 6uydraQEYbqnUGKcXzK0Z7nrVOvNEtn/NbwFbLclWiT+4M+TOi3PK+2luq4T8DSwAtLF/7ZVfdl HZWjjSKl8MfhacHKloadIEZzA1wxmH+T8r7R/kCTNxFLS7exGnU3t4YS86nb0dPGENgImPhBtX4 xF000FSFXrqNaDCQRXV6DByGgdHyRxYkZLxuZZiohSwUmhuE8Afj9JE0RdCfm9qtCLbsx+wpyT5 ev+nJywa7BIA3Jvzw5I6Mhiqp0kOtyh54WQEU62uOx7zWbG/cSQwSne4v6uJakOOBlEpOex6Kb1 /WiOWNqsvZf8qv3UNNA== X-Received: by 2002:a05:600d:82d3:b0:4a3:59c2:b41e with SMTP id 5b1f17b1804b1-4ba023064f4mr64886655e9.4.1794332813953; Tue, 10 Nov 2026 09:46:53 -0800 (PST) X-Received: by 2002:a05:600d:82d3:b0:4a3:59c2:b41e with SMTP id 5b1f17b1804b1-4ba023064f4mr64886375e9.4.1794332813451; Tue, 10 Nov 2026 09:46:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794332813; cv=none; d=google.com; s=arc-20260327; b=rAqHo8WftwkFqOU3SxArNkFIKLeDvgSkv2k5bx7f6V/9bCC3NSJljnNv5SsFxteTMX roi4Yh9lRXGed1WoGaJ8S1QR5T3TdxpQgtfmS85Ro0yD6pe8sMNFoiuOovdmmmY2SyjK ELXupPQvYl3KjKZZadC3B+qZACKYOvVhiT0vIAgd3urQwwOJVDFPcEa5z6u9w02lgJJr SCL0CBA7x7wwI2+ViA8XYkxfIcqfs9C8uFMNQHZ9Ha/jziDMO6QfWIrnfHkr2prZ9JZb LVAst4OIfTgeTlykjFYbFxzakiMsjMmS1cRHfjEXT27Q8/Qhdv4AI/b947uEyH8us2RP TH1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=zKjbgRGh0zBxKNpGqSOq9o5t8ut7WQzKhQ3Ng3Zu0Xw=; fh=NNIHAR0oQq9xcHtG6fvuNrouibWQy9PtHjAIRR7/XzE=; b=iWNyt10RKiwORBK8uCDEoRgyrPYpoOxQrmWcb9IL3Aj7/3mxQ20KioluEmuLPUUXCt DJaftpa9FsBGAhpfI2cefxsBx5wNGAKheKBF6Otz+e5KBY20ANbYQBNlzNWABCCZB6+F /BP3KcSBTWVbrFpEYrw0cOSzOfbzvEier7d/VPyCTb2AgHaidgwYHbSv83RtSKjT6ZUv 7nP6p3fM+xxSkos4QmwE4kR2rf6pH7Sg4EMopcJz4OJvylJxTLtxPXmWWczCa00LaNiE ZrNe2DOAOHeLjUMz8upKRtzICScOOolD4dUCJXxFOIyQRef8cJOuKgs/Txue4yJZ5XWs RLoQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=nEIFX9Wv; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id 5b1f17b1804b1-4ba02242e12si61322715e9.22.2026.11.10.09.46.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 09:46:53 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=nEIFX9Wv; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=zKjbgRGh0zBxKNpGqSOq9o5t8ut7WQzKhQ3Ng3Zu0Xw=; b=nEIFX9Wvy6Kh z18sGaKMfUyYjEyqPPISF4yiYcfqwJJb6BLlZlsLA42bovJCMIrJ10ODarW2ChnXR8SDeujQfeq9h ukiE7KepgLMjB1Z2v0PJXzunkJt31wOwMHiBim1E8HRKaAxNu0TlkUqD0jxSbVwGS4LkbWsE2kE65 DBoE94XTvvPjgS1GfM7xudEN7/gR0KKPsXNd3XCV4Pcd3xyF4C1Ao1eb4JLpvI5kkQztBaLdb1Kk3 V7UbSZuXH5YPo8ZpUJecWG6aLGK/7h+Hr/EigxDEjPF5Pw8pDbDUhH6wLhcz4T9SrXrgcBC6m8Hld MFDOlxd8spm+W4Sm8RwYng==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xQpri-002Q9Y-35; Tue, 10 Nov 2026 18:46:43 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Andrey Zhadchenko In-Reply-To: <20261109153619.277888-2-andrey.zhadchenko@virtuozzo.com> References: <20261109153619.277888-1-andrey.zhadchenko@virtuozzo.com> <20261109153619.277888-2-andrey.zhadchenko@virtuozzo.com> Date: Tue, 10 Nov 2026 18:46:49 +0100 Message-Id: <179433280956.3561434.15657331017953110200.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1493; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=yYmVMvjFoReaSjs/7qZ7is+UwHB69Xn7wB8kx+yjrzk=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq81iMPjl9xyeFMxqoHbMjvkOZAoIzjIYjBYF38 eMuSOXE56uJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavNYjAAKCRBRlgpH+WFc KksXD/9iLsfdsZIRkURoKX5LbXfEhsBO06TkZfwntw9MwB8PJ+1d9rfwORqjivqMJYzFut17+Y9 7MeZixMCD5701N4KVbSSq1tqW1KjIJoWo3X1eg8V1Y9nYPoqt6XVfaHZqNcuVuGMbb7PEiRetA6 Ig6zETaAAtc1srv1wJEYxakjSkdJaJQx2aJ31v77Ahg0lRPAwHGQsLj4BqpnKploHvGUWoAwady ZuwHx1D4pZr8XxxqSyKZCQzJBd/ItEJzI2cjkp/iuepQMNl8ePkYrjBItEFHBExPDfmffOCXvAq EwYW616Ex/sCxY+JhQbyhlGdw8Ny5GYHS+3MEQMEHf03LU3275I7LsoBze/ViBvT+uSfjf7Bslw QdO1eXeeLshrfAbzeolSMGl9UDWcZQsmJB/XhMa2/RooHb8RDem74kmexBSgKKwlarNNjnLIDm7 fYzgsNCROfreJDPyXntTgDKehvetRUauaT3ZeQG1X+B3R8NdtK9T0x6fiiMy6c4FYv756OUaGRd SP0o9AbVSbTxgC7mys9bLkYTnp4hTh1o8f3IAsPkvHEMi8koYQ3R9ZwyDODfLHLt6JIPDoUq7M6 FC5bPAVO3j11ajd4glXk5FwptHrUH8ZzPYfk65f4D9zOGrvUrvYM2ErJICMpeqmiIs3KP1Re8Yh kZXzY+PyinhjJrg== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 1/2] dm-qcow2: set max discard segments to one X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying with these fixes on my side: - the example: bios [0, 8) and [16, 24) in sectors instead of [0, 512) and [1024, 1536) with no unit - "range in the file" -> "range of the device", "always" dropped - added why the limit is USHRT_MAX and what the user sees, split into paragraphs On Mon, 09 Nov 2026 18:36:18 +0300, Andrey Zhadchenko wrote: > Imagine we have a request with starting sector 0 and length 1024, > so read or write means [0, 1024) range in the file. For discard this > request can have 2 bios [0, 512) and [1024, 1536), but we always > discarded [0, 1024). qcow2_io_hints() caps max_hw_discard_sectors at one cluster, so with the default 64K cluster a 1024-sector request is never built. blk_rq_pos() is an offset on the device, the file offset comes from the L2 table. The message now reads: Discard is a special type of request that can have non-contiguous bios: dm-qcow2 keeps the dm stacking default max_discard_segments = USHRT_MAX, so the block layer merges discard bios with gaps. Imagine we have a request with starting sector 0 and length 16 sectors, so read or write means the [0, 16) range of the device. For discard this request can have 2 bios [0, 8) and [16, 24), but we discarded [0, 16). Data in sectors 8-15 reads back as zeroes, and sectors 16-23 are not discarded. Set max_discard_segments to 1 to avoid such merges. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel