From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id AFE19803BB for ; Tue, 10 Nov 2026 17:58:03 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHup93017855; Tue, 10 Nov 2026 20:56:52 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHup93017855 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="vOEU0q0p" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHug1s017815 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 20:56:42 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHug1s017815 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4931c89d228so1655159f8f.2 for ; Tue, 10 Nov 2026 09:56:42 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGj6aYLuhaFmrBcB0QjaWjtpzMHrcH3eerBY6HrGb9dfWNPUam6zjs/8yKMuvyeEisXRSGhWw==@openvz.org X-Gm-Message-State: APuU4Z+WG1P9vB21a5nDoub9W9Rg1mYai7BsBDG5wggVPPmSYqmRVPA+ WXV0a+NaHt5EaE+WUk9pRteGjXFVl3rZ5Ly7aD5VYhmAbEy5BCtz0roqxYZ6h7OI3A1RGxfeQpt KE2r1fb4+ZxG7eR32gF14h9aIjeSLQuj+JrOnAc7WwU6TevG3xE1AKw== X-Gm-Gg: AYBFou1sl2nOQra0IKzSgS9I/Hny0wt0xybiQvTRpDJ2/Vqq5j8lO6iaJE3zUlvlOQr cycEBCaObQ6m5VgJXrZp+Cjo4TuGWq9wgjzYjaPbACDIf47/zYRHwz83W40/qmFFWkRrU9CMe7z 36Rzdr+LHhWpaGtLoQbn5Ud2PZep0K0WGRIqPTybTf0l7aSlMqlPY2tJyYyFnY0Fq+5b+/WTki5 XpmPFeycPc17HBuSqRSN67B8n90k2avsCQSUrMHK+g8sex8t7V8iDCBo6PII1zZXsLkRExHi4p3 YZ6uzz8Ku3CiGkeCumcAGaYFDmSNk5AUwxOt3BqTOHDinwhTODeBtmpIH5mPqymJrNf+iKZFJEw ZlxjP8aGrtSD79izK X-Received: by 2002:a05:6000:993:b0:48f:d7cd:a5ac with SMTP id ffacd0b85a97d-49828d36961mr6822434f8f.0.1794333401854; Tue, 10 Nov 2026 09:56:41 -0800 (PST) X-Received: by 2002:a05:6000:993:b0:48f:d7cd:a5ac with SMTP id ffacd0b85a97d-49828d36961mr6822401f8f.0.1794333401400; Tue, 10 Nov 2026 09:56:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794333401; cv=none; d=google.com; s=arc-20260327; b=FKtO9LEdehZyQu+HF649xlbMFbAb54jbs4cfxGIl+r1A17Oc3P+8Zh38OaREnXdllx PqNyRnd5/r+Jrx5iQ15nmdONrwwrQkjG9FFZdsfOB8LGZS8jBaQA1vRlNXoIqvkvvZkk C4+v/28XogS7uEtw0MWUzS52q56i0WBhREUcs+E0ZjVtgDpIius1A9toi2DEJz172S4h OeSiOjhkvjC75o3W5YN+1Ry7ktqcMTN6WnV1l3UtbYEyeQ8dGeta2DoInJubrs5ssWrJ Vaydvw7Jea19pMUxq6vqKjnSm+N1jVHpkRAy/PKIcr+yFUBdrMlBz9LE215Z7ZZg+YAc 9fQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=svZ/l8zCpaWMn2azxpeVkYWTux7bMqW/h5ycMYcUrOo=; fh=NNIHAR0oQq9xcHtG6fvuNrouibWQy9PtHjAIRR7/XzE=; b=qGK7gtT73FOmgbQlbFEi66xUGA2j8M/RffGp8GrVf0r2iaTyufghFs6ECaouiLWOq7 XKQzKfsBJRWG0gO8f3cGcCXDLe3dsH9y/EwmP02cAx1507wHzAGBGX9SPEuj/NlQcYP6 DOYeh6UfUGFACNEiveOxDW3kINybzgAmzqT4zMQYVvdSGxV8omjZz94Sfm+NkM9q8QGZ sPrvoBT5VGG+sKgDIbbb0LDxI2gu4I/EUYNFwbv+yaAIPUyPMijauvtwRSP+wzFX/EXj bf5R6fpueZV4xFrwiPVREIp6e1afN4FYMa7V4AEwL0fLDQLj0R0DWX0PxeiIMHZqb6Zo B5EQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=vOEU0q0p; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49837dc2805si6339896f8f.437.2026.11.10.09.56.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 09:56:41 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=vOEU0q0p; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=svZ/l8zCpaWMn2azxpeVkYWTux7bMqW/h5ycMYcUrOo=; b=vOEU0q0p/mWm 3v+18cOwztrIk5fQOeCYP1qgqi9nTcL+V6O1SJxGRJuGy55CXdf3eLZNBWlyNfeLf3XebHgPZV/l2 q6prXaTcL6ARkq7inotjrSeXMIwgQa0Af/wgggf0S0ImmGmRpdxKS4805wOJkZq+++YlfGX7n7Ojl udY/tkGK0wJfABWWt8FcQQwMvYRfaHxqSdifQ+QgbCytahaTgySLRl9XRx+Cay9wbsgKmK4GOqkqK ETrCvohd8PGOLewja+u2dWLN/YKV/cNPcfpjSON6DSgWZ+qf4gCKUwtWM0HVQsxTmZGSad5CgPPCh UB7AIP1/NZrewrgXh6dyvw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xQq1C-002c2t-32; Tue, 10 Nov 2026 18:56:31 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Andrey Zhadchenko In-Reply-To: <20261110114629.416695-4-andrey.zhadchenko@virtuozzo.com> References: <20261110114629.416695-1-andrey.zhadchenko@virtuozzo.com> <20261110114629.416695-4-andrey.zhadchenko@virtuozzo.com> Date: Tue, 10 Nov 2026 18:56:36 +0100 Message-Id: <179433339615.3573054.12317761297921013878.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1137; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=ymC2vlO5+rZEiG3pfoctcMO/y8FPJqmb2a9O9ak3ZO8=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq81rWbb1+5BGFSLIxfPYvT9YiGXPLZUzsR0O0b ouZah+bIm6JAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavNa1gAKCRBRlgpH+WFc KjXOD/wJcxcG9uOyrksmif4nNJ+Rt/kHDH7p//DnDy4sFUzH9kCtLRt8i7jT7d3U9K5PbQf47Hw 4efW9p+355KsBOY1Sp9xndHWR9G44+6bmLPAMBkh1rGQnpaE1MVYNcZKKYVs1uZSVb/K213YBa1 eQAaAlhP02ACUhymwCyfDOfxpHhmIf1w4B888P+Atd1gB4+zZT+FX2ONyw3Mpop9NmC7I9toAAG TuVvYcDRxwIQ6asiODRi+q7kCfB3rJdeNgB7lWHLmcL2eRoUO+GaeVN4TGbPYqlvi6pi1vVw6C3 b/Kvwxy2NS4dQpamNNfodkPpOdfr5ig1WCjua+mhAabOul5YXQviIa5rhFplpgMSJkhVRARtRKX ErqrWyRpBTEg7f1sCPzdmeTLSn7F1/ZJFhtIRZHjBQ2wehD795jXR8oCmKb5eNcLcEhamHlhuAq dOTr1LK2uusTswPkFIug9KTzAyuZJO3Yr9mon46T429umC7QPNvK+K7q6jbcOtVEJSQ63ba8ViU JrtMYyPruedf0qrFryPIzvOJxctdPriGrmytCRJ9nprsmkvurTTyRcn/+2hS29jkv9yYHL8cKUB LUdpMnR8v/IwWHXEszF+ZzorbguNDd9l5O57GGv78hJ5UcuefKKo1vuV/+/CVSb7h41cD7dMwg7 agdE4CrNGMdSfIQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 3/7] dm-qcow2: prepare process_one_qio() for fastpath X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v3 with the changes below. On Tue, 10 Nov 2026 14:46:25 +0300, Andrey Zhadchenko wrote: > + if (avoid_metadata_changes) > + return QIO_NEEDS_MAIN_KWORK; No code changes in this patch for v3. On your answer to Sashiko about the discard race, handled by item 3 of the cover letter reply: - "The same scenario is possible for base dm-qcow2" holds only on FUSE. On ext4 and xfs main kwork parses and submits a write in one call, so its direct I/O is in flight before the discard is even parsed, and the punch hole waits for it in inode_dio_wait(). fuse_file_fallocate() does not wait for direct I/O. - "It should outsleep two inode-wide exclusive locks" does not cover a fast worker that has parsed but not yet entered the filesystem: the inode locks do not see it at all. The window is new and needs a guest discarding and accessing the same cluster at once, so a follow-up series is fine with me, as agreed. Say it in the patches (item 3), and keep the switch of item 2 for the time until it is fixed. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel