From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 76E23803BB for ; Tue, 10 Nov 2026 17:57:59 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHukDP017841; Tue, 10 Nov 2026 20:56:46 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHukDP017841 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="BHQLzVZO" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHufYv017808 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 20:56:41 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHufYv017808 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a80bd45e1cso13251285e9.3 for ; Tue, 10 Nov 2026 09:56:41 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErEUjXCC8IgBg/bjPwnt2+UwSpUCvcBtVjSXEGBAfju5J3S5mUrMMFkEYX/DfqVe9xTNVR1uJA==@openvz.org X-Gm-Message-State: APuU4Z8FCs96jvKuILJhJhC4POgukKiLoQJK9tPXtJMsP6f/QhmNNUXQ feN2ZK4sN8lb4aPvriGo2M/Ms0CAgq3jmOX7jiD6IcLmuXl1ozyKHjl7RZlPF4QcCEY9XQys6r4 v/sO8mp8voEL7Cy6sN1z85rhENC20sI+hlaSeoUg8MQdBiqqLWBU0oA== X-Gm-Gg: AYBFou0Q0IkpY0761v5JBAihtQJTnrJk9gd7rWQ3vfsoAISu3eHPpYPVkwgtoLnRcpe tNNKVfmRsKnaXz9qsX9Cue2+fLb9dEDRyhDHEcyrRGey4MTE2HMYP1wU8QnzAcToDnOQhQHoUvg muUYN1JDg2GYZNlS3SycKrBAhtb7CwepvzXKKMgMVFPCoDjVfXMNqFpgMLGkxl1R1lNc3DCVmuI BMone1s8G6KBqxU8Nij38H5Kt4uUbpI3YKcv1CTJmzxZFqkqtm7vfBDjclT19lMPymzRJj47+4b /0cuL/66TefNc+cbRiQXkamxNQLRCA51RR5Y53ZO8Wq8iRi883RH/9+UL1slISv2v48z9m5VfTN HUcUapKtqVSCh/8w+ X-Received: by 2002:a05:600c:1d18:b0:4a1:702f:c736 with SMTP id 5b1f17b1804b1-4ba02305439mr57078345e9.3.1794333401518; Tue, 10 Nov 2026 09:56:41 -0800 (PST) X-Received: by 2002:a05:600c:1d18:b0:4a1:702f:c736 with SMTP id 5b1f17b1804b1-4ba02305439mr57078015e9.3.1794333400992; Tue, 10 Nov 2026 09:56:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794333400; cv=none; d=google.com; s=arc-20260327; b=FjVfus1bJ9GRCH408RsK+wHLZ1bbIbEwBIWGtOcCUGndJXnEGRjQ/8eEmxeO1neDR3 7NqTX1dD7/e/+oEpbsnLAPWMdam2I0F7b4Xf1d8C3r4LVKkppNqN1jjmpSSnYgydWAin mLvHEbWJFz9kc5o9FN1P0B9cqDuvbHax5Zof6Gtq3qLmu1PPq9SYHDcvjt0C6jBXRUbX qmDGv4098j7lT2uMnCWtGAl1IVJCwwz4VojSgTUjDf7bJFoAFRxTfcQOOqn1Pocl44LH JRe8h3Y32DivIxBDibiDWMCdUtA47UmjBESD9bQ/ZxtkxZ1/i2C2Wp/I+4jAq+m87F9A tosw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=GnSjtJT4V5q1mVtoNbe9oQ8FPJBFSjlM/4nbfPv/fbI=; fh=NNIHAR0oQq9xcHtG6fvuNrouibWQy9PtHjAIRR7/XzE=; b=Gb/CNSs0fq9NPYY5jpAA/KU+1KqgKujTbbLuj7Lamp3UojIp+yJfSLfJKeAc9ylxBi n5vh5b3LU7bVvNFfaS3iXrdAIJYj4X0KDBt4hxuww3jTm6EIp5AH4F67Aqfkm0W27pq7 tbxzGlrPYROyrqRB9MXkP6abA3wdjwiEOx0egWIgghThBNvIIbtlcDEw1T+RlSCB4AoV E/ZysVEHS6a31zfSAsdRtvnohq4K+jSgKdoL7B5X8q9kYC7bLUD/FGwHXYiSp3qzfJc3 E2lArCyz5iB6Fbf+FClcNS/yvWsfSX+If3S+qGofZLvEryj7Gh5+Du52EQcoCZ11K2o9 vJTQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=BHQLzVZO; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4983585d3a7si6720743f8f.58.2026.11.10.09.56.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 09:56:40 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=BHQLzVZO; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=GnSjtJT4V5q1mVtoNbe9oQ8FPJBFSjlM/4nbfPv/fbI=; b=BHQLzVZOdsd2 7UQkLjQICEZrvn/PmDLPZT6stGJCJc0e8BdazGgzhymjSoDVVcVehkh6djszTIsISKF7UIvxsI3Gb S81YPLRbapbmWLCQRpBMg280+dAWOycsOMWHgDecgJbuAioi/zIo/arGOe417jIHdwZHandX6/pBe R1bJyEdac6L3U2tWc3cMaX0u7grytAvzkHzg3t53BXtHGM9Abh8zuqxz52SlV8zmdQiIuEeJI7Wgj Qi6YTqtX8tioA6O8vx2PLcsF+F1CiR6tBBh9v36qE1JrhwpAzTgd1/oGxjYlD1nQr/iL9S2aYiuVt 3/uqF9eb3Y098zjP6FL5HQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xQq1C-002c2t-1n; Tue, 10 Nov 2026 18:56:30 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Andrey Zhadchenko In-Reply-To: <20261110114629.416695-2-andrey.zhadchenko@virtuozzo.com> References: <20261110114629.416695-1-andrey.zhadchenko@virtuozzo.com> <20261110114629.416695-2-andrey.zhadchenko@virtuozzo.com> Date: Tue, 10 Nov 2026 18:56:36 +0100 Message-Id: <179433339615.3573054.15011344770189522717.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=863; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=cb7Rq1UitQZC+v5RZTZhiDEkJ5G3u0/qUKYhgyLFQzU=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq81rWWC/JzQXGBQos1GqdVxca5TmP4EpSsDDuO lpH2nC++A+JAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavNa1gAKCRBRlgpH+WFc KpgeEADFW3ehTufPrg6W4GwNCZNhhguGuJ42ilHJhEQElqrlP/Sf20oZAauP3SRs8KZHxOM2Has bpYmCovNWZtFIBNoaIphUF2bHP1VXxG+q+DGYOIhBlh1Jl2OU7Z5fVVf1K+w3HfnUDYybFNF1+y FTLLYdYAC9aUxtMWarYvoLGMg0zeqvmyTzkRLeBKGjRYsh4R8FSSrVZjVSI0WpG/lHKnoS42Fq0 D2OGGtsd9Zc1xUnePZJIHC8I7ct2QDW+xypKuRNRljGI99fP1mg5u5TPdt8OzVkesYL3WnCGG1S y36NA+4XOwNZ4/ngaBiaYvmtQMA14/w03gFoH4KnpIzwrsfBn0Ub7o2JQ/wOQ3GOrSj9EglM5cb bFxMhAi7pYMvgieUtKhlU3a7vvtBVFFrHGq5fnpu+qkQVDxzr3Y1409OWkdHU/1yuCpvpf0Wy/3 joLEABcqDLmNkv4BzlxPzos1zfYAEQsF88QU+cgUWPMeX5cghx0Otw/CiAb6e2V/QXS2bSGVZm7 pzYUtakntlz1ua1f9RkPuXUUZeYH5Z1I89Vr9gI82pGjxUJdR3CSHsjPBbmw1QJdoo2eEdBXulZ 0bCca6dIlGn4rBeiJNLwOIkJTGwMhXOVOLY//UGhP/RjTfxvc8dBONK9GFI3aonTRhPYWyACALK 1WwFI6L15SskmTA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 1/7] dm-qcow2: repeat md page lookup if it was inserted in parallel X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v3 with the changes below. On Tue, 10 Nov 2026 14:46:23 +0300, Andrey Zhadchenko wrote: > + if (qio && *qio) { > + ret = submit_read_md_page(qcow2, qio, page_id); > + if (unlikely(ret == -EEXIST)) > + goto again; > + return ret; > + } Item 4 of the cover letter reply: answer Sashiko's remark on the unbounded retry, or retry only once. Why: Sashiko raised it on v1 and again on v2. With fail_function injecting -EEXIST into qcow2_alloc_and_insert_md_page(), or NULL into qcow2_md_page_find_or_postpone(), this loop never ends, and cond_resched() cannot help under md_pages_lock. A real -EEXIST means the page is in the tree, so one retry always finds it. The code is otherwise fine, and the message and the Fixes tag are right. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel