From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 1FE98803BB for ; Tue, 10 Nov 2026 17:57:57 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHuhil017834; Tue, 10 Nov 2026 20:56:43 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHuhil017834 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="lnIe/wK+" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHufNR017806 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 20:56:41 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHufNR017806 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4925ef75fc4so1958066f8f.1 for ; Tue, 10 Nov 2026 09:56:41 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErFbBBM9bp3maMLaPpu6wQdqVTECn4hYGpetsY7/y8++JJYe7H1Cd8fTPfesJoakI3GKj571bA==@openvz.org X-Gm-Message-State: APuU4Z8K4gWClHrAU3hN7vfRF6Pzqx8YmnYTKFDxEZDdusVvaO3oAXjI K/Uf5dU4q13aje4oipoOyH+TGQhglzGXkrZlDfI7WZLBHyMoiCDyh9l+i2KmrDB+tIq5ysy9Lu7 deEG45DQXlqlJDsBfuqAD6Lnf9+wJufd/IMZDfJKo8CKgH4oeovtyaQ== X-Gm-Gg: AYBFou3wBHhWcu+hVhjGE8G2UPqDTvkrvmskqowaeeK3BiFj/O0HnLy1R4nzAeutrji wDdnRyN7zDiW8YLqQQwIvKpFWwsXaqfxwQ+/A4pZ6vARPGZbZKnVUdUNtKGkyOuUkklOuJfek1S ogCVfYDCDBfW0W9IgapBaa/Ji88F+tW1kls3elvgX7JuNnrgRTtwRIPbxWrJ4+S1gMvouZAhGZl 18nXhylFaEAcXKLHzEny+Bhpz2Qe8MUgW9G+je/guN9ZjgW4absIXZwovgBJNInJgTOv8oxSGZC BRmG0xF2ijdtwI9n2SGMKvL+qdj+pJtUkNb0kRs07CfORHTvlAeRUsTq23zhZD7JBPildOjwt2Y rhvQaq65d9ws/j6eP X-Received: by 2002:a05:6000:1a85:b0:493:c0a:507d with SMTP id ffacd0b85a97d-4982b28a86cmr7445478f8f.1.1794333401297; Tue, 10 Nov 2026 09:56:41 -0800 (PST) X-Received: by 2002:a05:6000:1a85:b0:493:c0a:507d with SMTP id ffacd0b85a97d-4982b28a86cmr7445445f8f.1.1794333400785; Tue, 10 Nov 2026 09:56:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794333400; cv=none; d=google.com; s=arc-20260327; b=qQ9XAwu9Vvhlarrgx50iWEcdswUSV3hA4bVp81DXrbN4Aj3UuYdfQEmmaSQnbf7w50 v8uWUABSwHskBjgB9HQw3XPqein+w/IcFWXxfdj9KDPa2RzggYPitBAnN9kt0ETrscRm znM9kJJwGOVkJTxKMgbu+8qIxsOy70oGHFuNR2Gnlrwwv0SZ2RsWud22LbyRog1mtxSH Hb4gE4sNBOYwBMfyalemhJydp5+j1/7SjbnnIS0Cp15Wk/Se5loQ7RNIKh2gKNcm85I8 VKOMH8JYUf4H5OdlJy3jiupme7i1JCQ0OWsBUGVRN4FjHCWLWHXt2lZC/b9KwOFLUgqY lRNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=2n9qxO5lko5/+LBzyfvOjWcB5qXTlMwa3yfDaFVZqY0=; fh=NNIHAR0oQq9xcHtG6fvuNrouibWQy9PtHjAIRR7/XzE=; b=FUOdx/10z5ziSDCTEHe1+7gxWOY2xQEzARf6MYaxK+KcNW8L/C2rCzwPX9ZjZNnrPT 5wYG0zGWFrXIc0zVzQF1282agMcZY93QZALQ6wVtvVnBMMX9/NMvnUxo0gWMui7ZdB+M pN7PsXMN1CP9+VMotJOigbkjUJKVpyez/+GudCet/XGfIO2xArCUsWK0PLfFbM76zmDR yUQa8RYS0L9JV1kY5op8I6/EaN0ovr8CbEDoYRo7kaEm1Vi2qNCRS9yIJLWkO10cc7fx E/Uz3mthNnxmx7Y/8lrRBx0VPz93bbPR7hwKswBq3XcVL+k0chcq8aipRCIDkpMe2fC0 AJjg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="lnIe/wK+"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-498364d69e0si6031785f8f.242.2026.11.10.09.56.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 09:56:40 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="lnIe/wK+"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=2n9qxO5lko5/+LBzyfvOjWcB5qXTlMwa3yfDaFVZqY0=; b=lnIe/wK+0GZe GLUTwC8bcZGw8/+reTp/2XRoRmQ/WUZbyNoUnCd37cOhgzFAR2lTHdnHuuFS+NQooNHkF62cnrTde 2aJiPLZ2t90BJMoGpDnPN1P13gyyyVhDx0Gwk855pGGugEIh/QUkzqNNfgdKB2qbz0sRbbSiYzK1Y A9M9pp3k8SoQYxfvFR/ia0x+gDtQxVWeuUALjvn4E0vomnqco52FQwGK+m4RVLJX70datmwuXTcOQ uwQyJdD4yFrBBg/9NIumm1QfGdpvAREgk/dJPfRTXYAzqYDgs0OZdtHeCF2QkEIFVCIn3fBf8QliT xlFpmZQtgLy23wZZ60m7ZA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xQq1C-002c2t-19; Tue, 10 Nov 2026 18:56:30 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Andrey Zhadchenko In-Reply-To: <20261110114629.416695-1-andrey.zhadchenko@virtuozzo.com> References: <20261110114629.416695-1-andrey.zhadchenko@virtuozzo.com> Date: Tue, 10 Nov 2026 18:56:36 +0100 Message-Id: <179433339615.3573054.6008120892143626996.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2023; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=WEJw0DLZM1Geyu8Cf41QMbgYkzKDATr4hNSfQ3sG40g=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq81rVcjcy7Jym/BkgyrF09w14lC+2g9QLRBLyG NNvfhMIiuuJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavNa1QAKCRBRlgpH+WFc KmAfD/oC8q8CgrdmZPCA8vew6sIBUxnBRAzwZtrG22C6naJkl+NEgAIQtpuvrCZ0k4p6VKxpVVy QAoBkN9sAIbfiWNo1drRJbH827PGCZcBptHs884Zg5wPZooRTwhVG7igH1ZAgm6cYcP1qoalSCx MBFBZheADHBTTfCSBew7qdnrE3fIKHUvEl3+AieHjh3VYq02jD3QCkXfYxWM75LcwBGf/uNTpoZ tN/o3nZ7tve6NQ05ms/CxC7KsNh7mmoqTqtQPVLyLc+oiJwnstxbGrOYkCdIgrD/2Xj/8H23VzI Ke4z2rWLo9cfjjPhcV97vHQ3FbfW8myrGf41oZqo2Fnvv8fKTPnBvVp12o6PGSibZayzz5jQMVm JZJNM0jX2aXm8iQV8tm1uscWnwYyt+kcMm5H3a8hcLaCw/6J+mw9gTwq1LXhH62JtyqKDV7uDQd ASteiHDw9KA14WO+xcMwi8PvZ6k/c6XVFv2R2agUCGVvGsoSN38+hKReSUD6k37+mdRaXWe03Ov S1In3TbRSwH/Dis7p0wRyEni9POmvRmsrh41brlYuVBCQHgBA5EW9AQhCgUsnnGEmE8MMjQZ8VB pZBioMlP0/DxN+xHzwL6INGJlCz7vIphc1jQozPN0i018RsVFbv9K65ayduqlFk461gZd7XaAip +jStYm9KlzB8wZA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 0/7] dm-qcow2: per-qio fast path X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v3 with the changes below. On Tue, 10 Nov 2026 14:46:22 +0300, Andrey Zhadchenko wrote: > Andrey Zhadchenko (7): > dm-qcow2: repeat md page lookup if it was inserted in parallel > dm-qcow2: wait for L2 writeback in perform_rw_mapped() > dm-qcow2: prepare process_one_qio() for fastpath > dm-qcow2: add per-qio work infrastructure > dm-qcow2: implement per-qio fast processing > dm-qcow2: process fast path qios in per-cpu batches on a workqueue > dm-qcow2: declare DM_TARGET_NOWAIT All v1 items are done, and the DIRTY -> WRITEBACK race is closed. What to change for v3: 1. Patch 2, code and commit message: in perform_rw_mapped(), under the lock it already takes, check that the L2 entry (and the ext_l2 word) is still what parse_l2() saw and that the index is not locked; if not, hand the qio back to main kwork. In the message, "X freed" becomes "X leaked", and md->wbd is dropped not only by main kwork. 2. New patch: a writable module parameter (0644, on by default) that turns the fast path off. Check it with READ_ONCE() in qio_try_fast() and send every split to the deferred list when it is off. 3. Patch 5 and the cover letter: describe the window between the fast path parse and the data submit, where main kwork can discard, free and reuse the cluster, as a known limitation fixed by a follow-up series, and name its Jira issue. In patch 5, reword the line that starts with "From here on": it got mbox-escaped to ">From". 4. Answer Sashiko's open remarks: patch 1 (unbounded retry, the third time now; a bound of one retry is enough), patch 4 (qio_pool hold-and-wait) and patch 6 (preparation sleeps too). Separate patches, not needed for v3: 1. Writes and reads racing with a discard of the same cluster: per-md write counters or discard locking, as you planned. Details are in the replies to the patches. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel