From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id CABB88017D for ; Thu, 12 Nov 2026 11:50:22 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACBn6ip008750; Thu, 12 Nov 2026 14:49:07 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACBn6ip008750 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="xH2hxF5R" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACBn6cn008746 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 14:49:06 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACBn6cn008746 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48e0af48c18so3174753f8f.2 for ; Thu, 12 Nov 2026 03:49:06 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErFP/EvkKyIY1YBNOTUfsqsCW+lXXHnMPTXqHW7STbHMKENwsUTvWs9eEWsrNXPT6iOZYyl/fA==@openvz.org X-Gm-Message-State: APuU4Z8aw1EcJ9eikatEUNKw5RStZpGyeei/r5ATwXQVEfIESnTU3IHG HW942UINH1uCrluWolmpBnHCwDGiK/VR6Gp7rmgfNTW2AE5ejs0z0JThHlu8iFPcXz62Awseikr QhN+d11bs9TmDAG7n12dLpBY8dXbllX8LP9oa0+Fc0fYNrIq+/HLwRA== X-Gm-Gg: AYBFou0e4G34W6XKoI2WQsnq4v8W88yvbBByUxB6LSLaHvISofZDMouNaPGanQevCvO CjhCGKqUUMGsKs9J4HzKqrgQju86zBuSc0IktE4D4N+qtPgBdNLoiUbLQSkDGDBhOwZfkl11HqJ veWxTyj9pssdOB305ubUt8WdTvur7lylEBbMhYRxLtvMuXEbfM4/DCH7Th6nqcBY4ay3QaSLUKe DbJBZ8YnXqIcbyjrnWfXLPWTWXCAw4AMskkLKOr1dEiqdfC53vV2Hv62RwQqX2KNubWI46YNbKH iX4nwc1WEs5SMTFPmUP+WroVbyhATN6BfiUMbfx8rC6G/TN0i0Bp4gCLT7d8KMjP/I1Fwna07/y Kpf7oM99t394UXjCR X-Received: by 2002:adf:e00d:0:10b0:49b:b93d:91f1 with SMTP id ffacd0b85a97d-49bb93d9249mr1661073f8f.25.1794484145778; Thu, 12 Nov 2026 03:49:05 -0800 (PST) X-Received: by 2002:adf:e00d:0:10b0:49b:b93d:91f1 with SMTP id ffacd0b85a97d-49bb93d9249mr1661042f8f.25.1794484145344; Thu, 12 Nov 2026 03:49:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794484145; cv=none; d=google.com; s=arc-20260327; b=MQu+xGdBz6pG+6A5Oc0FMeWsULbQda4AmsTcVz9VfS6USdTSMpaNWClh0qrG5nsLs5 6rzDTaUgbhRpAPcUEqbgUv3znC0GpuRIqb6Ouiplximp4HGUUuapChV3hY1VAHIpr4U7 BfTSbk7sR3/JkLVWzrygkhLvvjWTcxytUiDo23c0SYcG8Iq3tx77VBqjm9Sf3iE4Kpwf VENjdkeVXmePrGlzktiFo7xmbW5Fj+x4rfRLl8Lcqt1oJC96cYHgxA9nXWn413RyqluI 5SEadeNOMlfjkWzl9uHV7Jkge4RZhxJVxiU5XmATwBTcjJ1d+jYBs5mnu8nn08nFM7mR riLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=LuswrGEXG6Q0coCWisDuOljtMmShJzxb9pHDZUlEOdM=; fh=CTF2GHyV+XdzB5TROrdG4fdLri6JSHNOBC+LNuNq5bA=; b=K/fd56TyITl/If/BztnIYHvgokfjcKoR2XjbQWdpVTYmKCBNl27BTEbaVISL3U4TMQ i/9/e1YMfDFZ5Jsrd7ZaX82u9FMpXVT/zE78Iejf2Pq2WzdItl4c3mrct3kzaJeUe882 GYuuHlj9gySnB1hzsMxOxwDo03qJZngZRUZHCpkMaTbT9ix3nkEy3N75Upb2KXf9/5kp fjvveMTRNxJGZosHM4E51QUDyYf1AnbqB/cTwZkfrJHAZZOX+IJtFd2+RWrKVer1UBQs KI46TE1Woile9bYNIzZPCRoQLqSphoQTNSrtXBYIV+ZzzWlf6dJQ6jj1EbwhY/cTaby2 DVYA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=xH2hxF5R; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4983761881bsi16825222f8f.371.2026.11.12.03.49.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 03:49:05 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=xH2hxF5R; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=LuswrGEXG6Q0coCWisDuOljtMmShJzxb9pHDZUlEOdM=; b=xH2hxF5RAEgu cLa9Uz/GgNn+pD8hgxY4GT+YE3qAgqJRYxR1lTf5kXlrj+iCupWiKLKK2M0k5SuhJ0ZZ4A4tSxRv9 lUs/faC4CYPa71EojVHFY6zqZMnarYVbDzMDD5KDs0cyr+z6pV+geyelSw1QMEuXNzy++zE4FzYGK iDTGJU+wFBNRLo8N6O7fW2wDVipQQQ8+wbXXuDRcWW/lvErA2f9e/INLcnSRCgzCG3KME2s5Rbx/d LZsXp41YtDvFhnxILSJikvaf8IMY6EhalLs9L/M3xf3q+6JBeTtSttSDyXhhDed2NqxbiUGr24ioS RMWYHMILxLCifvZPx7rgPw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRTEW-00Fc6S-0D; Thu, 12 Nov 2026 12:49:02 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Eva Kurchatova In-Reply-To: <20261112042325.399633-1-eva.kurchatova@virtuozzo.com> References: <20261112042325.399633-1-eva.kurchatova@virtuozzo.com> Date: Thu, 12 Nov 2026 12:49:02 +0100 Message-Id: <179448414276.4060562.1522731532077557261.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1525; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=IdkfY30jt/n2/5XEIby/+SP69yNO1oY2FioIdk2m+O0=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq9aewfPojO61TwEn1FyX5Q1jqDRR1wYXglWOCO X07pBWkJDGJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavWnsAAKCRBRlgpH+WFc KoT0D/9nckwnVj9kAVZGtGvsGbfD2M0na76z4pWgNV3gEV946nex0F64PJWsgztIWOw0fyZ0wpB F0/GqdpiIQOsqzkJeL0v474M9sGkj65bKNorp7ystFwaH8SRA3usPEgv0LWKnpurzSDpcbFiuJT 0EgMsZn5685/DP8YGKteYs8lF7vDWURH8YohGbF8eIDsdhsv8ETGP6PMZBZoqRTbkCB80V29CBZ MnGl3Fa5kzUxRWfIufHmL2QPypsCQPQn/q3GoY0fkGzKdy9K/hGmPgI5XkATKkpuxrdURr4En9U 6NkhUnz8gFYnveOjLu33JktRCvXTRtna8ReN3ohTkG5f+pjom09he0giElWcEoAwvjhXsfx4zmF mJRP7jDPgDlu9DuwmiRcQt+kf/pbnfZ+NStoqyQyjoQFnFWHJshd2EAVjJNAVh+kBON28Ia1p4Y XmaLO2rk/0tjbN1v5xc8B0hWEljSgHAqnXigwJgVrgCzlgejUtoSmN28mqFN9oZKVWUQ9LgC/KU jQafiqIEBuV/EcHsfeUxlt0N3gZCPA8EYA2NOAWhSYAANUeGrbabi8HyglOH6XGAsq7zQcrmDOV jx+K4RtetxLHwlivSIIX+WSAJgVIdBZ07d/FvXKc5xRaPOfyug8seupkG68MaZlMQEvzZZGhD+L m1L/AchKhfNNhsw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1] selftests/cgroup: Pin the hogs of test_cpucg_weight_overprovisioned X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying with these fixes on my side: - subject: "Pin the hogs" -> "pin the hogs", lowercase after the prefix. Asks, not needed for this patch: - Send it to mainline too, see the task below. - Say whether test_cpucg_nested_weight_overprovisioned passes on the same NUMA host; if it does not, pin its hogs in a separate patch. On Thu, 12 Nov 2026 06:23:20 +0200, Eva Kurchatova wrote: > Pin the hogs of each cgroup one per CPU: the test checks the weights, > not the load balancer. This needs to go to mainline too, I created a task for that: https://virtuozzo.atlassian.net/browse/VSTOR-154829 Mainline v7.4-rc1 has the same unpinned hog_cpus_timed(), so the test fails there on the same hosts. For the mainline version, take Sashiko's pthread_attr_destroy() remark: init the attr only when pinning, pass NULL otherwise and destroy it after the loop. Upstream reviewers will ask for it. > - return weight_hog_ncpus(child, get_nprocs()); > + return weight_hog_ncpus(child, get_nprocs(), true); run_cpucg_nested_weight_test() with overprovisioned set starts get_nprocs() unpinned hogs in each of its three leaves through the same hog_cpus_timed(), so the reasoning of this patch applies to it as well. Its tolerance is wider in practice, which may be why it has not failed yet. ".pin = overprovisioned" in its param would cover it; the underprovisioned cases must stay unpinned, or all hogs land on the first CPUs of the mask. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel