From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id F0E478017D for ; Thu, 12 Nov 2026 12:09:32 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACC8Gni008868; Thu, 12 Nov 2026 15:08:17 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACC8Gni008868 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="cmRUiC4D" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACC7oYZ008829 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 15:07:50 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACC7oYZ008829 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-49187ad6a72so2882602f8f.0 for ; Thu, 12 Nov 2026 04:07:50 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErH1CMWBGbf6ZPTQzSNJHAq6576OnxIhtSN/7hfLXW2cBH3ekGTu6RelVyNQOlJw4wbI4oxx+Q==@openvz.org X-Gm-Message-State: APuU4Z9j2rIM2xlvcMirOd7pwUzlYuJKTRUKIzG3CGgMYTPBTyWefSdC VMuLroYsyipoYOzkDDpcpid7G5oAk+w1Co1tNojfL8dif6ZNycHH8U7Ksch37p40o3ncWeSo+UZ Utve3aLOFUfxu6C3uVENh3cU0MpVfEnhURcxuDOO4EIa7ShQ0tqXGrw== X-Gm-Gg: AYBFou0TUpynoRVpa/XWcOn+z7xpIHQqF0pu2oW6t2ujj+4vgnRD0ySm50BPYdLGxM0 ia46IyVM1Ftdtw1lRbAQaRYiHR5QVeaUitaqEgNRv/Mm2V6OwCRticjkIX/LUK4ZNALIeCrYFjg VeHncTY2CL93bq6HYlzEhRMkTZhDlgjVQHvSQy/16BZ58QelxT19n9VVDkJClUIJIMj8Tomqj8q 0/QxANMCRxy0/Z61y0q5wWr1s2lG5IPJs6hgkJ1fPHBVgpzVz55ybY1ob2yVJEDjQpG/lD3gQp+ JfJX4vXavX6nMeOKqkdMXx+RBxLlo7nvuoYkWnAuS0wtxB4AhDRFWNdHVwYYa8n7RFoTHpgGeKS 4hfDamanuXYqIRvGTtQ== X-Received: by 2002:a05:6000:98d:b0:48e:6dd5:30d0 with SMTP id ffacd0b85a97d-499c8f48193mr8278069f8f.53.1794485269996; Thu, 12 Nov 2026 04:07:49 -0800 (PST) X-Received: by 2002:a05:6000:98d:b0:48e:6dd5:30d0 with SMTP id ffacd0b85a97d-499c8f48193mr8278024f8f.53.1794485269447; Thu, 12 Nov 2026 04:07:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794485269; cv=none; d=google.com; s=arc-20260327; b=EAeA4quRC0NWYVJi56xZ5/8Ig3O11UjRtUWRmMuikPGQqby0uL+NqQbHfbYD2NNvBh hp8dj5+O+rBxZNzq+9IgGM/eYMwVjG/2FxAzTTFJIwYVXMrY2E0+Hh9/CVrIpfztjcMV EZjDUt0nQJxyvr0vwfuNNWNs8U8gSOggRGojoeZ1I9kpAFwj0nedJLFVNutcwGUV/ayH K6TAoQV4qsAi6+zjjlQmatrfdDv8KdPMtJncTBPway606X4kerWyQtNFpR/KmXpw3Hb2 BH+KXNy+vtD+UxGyB0883dHDWg53EBiOgwcts9GWkKtq9Auz5OD1AuaX591DXlIHlYmN SbPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=NyASB79Z8yVWjTUR5GhRLziVi9mryocrXfIvGi81ZCA=; fh=8+L1GLzK3OTQKnTfH5/my9NmwzU+1/k679YBeB1tMzs=; b=E2B96G1LYuf7lQocrgFdGPc5g/RfL91Zo6mXxLYmObBXJRdItKHMWv7+hiX3XMJAvi RLK+yMO45VGf1tuAYOHQgLuZuErpOeEpS9jepf3tmksqrME/gHiqeYnkObrvpqurU147 OU+Fu27lZZjKcOpBdxHgiFZ7JFmwE04fi+UOxQaXTyN32r8SpEsp873kxTlCjNNt2rRO z6hZFHfAe731VLI3tbru9DkFSnzcWNbhEWFAmS8+B+EWpqimJ4u/kZQ2efDOWEKehPzX 2clwrTTyH8nj9MR7HwAyodKeiACK2FNIavF5mSxaQMI21uFPaT/VnumaPAPTV4ChYyL6 f3tw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=cmRUiC4D; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4983219aadbsi17242605f8f.31.2026.11.12.04.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 04:07:49 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=cmRUiC4D; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=NyASB79Z8yVWjTUR5GhRLziVi9mryocrXfIvGi81ZCA=; b=cmRUiC4DYBQo eZ6hEb43dHRycWlJ8RBE1idSJif4RxPEXMtDJyP/lkLHkxYxbjxSJBygjXeodhgxOLEUGHL2UajsH GlOGva/5IMQaCVhbLa+ZxUL0+w8rutW1OtIaWioRy+JWIjRqpcR/LEcp/kb368f9UL+3mjpj+ECyG IxFD4Lm2U6Ypnl2EwXESNCtG5NXSaDw0PTBluVsm2loCAbh9vUUMag3T8du84Hi9CyNmU+CmC7rkD pqhrIA9YIu4k+9Igkx7wRREDvTlzFeO+DvLfOEhUCW8r1+tbzd1nytJCuHQq76hPZnegAIntNio2P FC0OQlg+HfGqmzc+Pe5mvw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRTWe-00FyT8-0a; Thu, 12 Nov 2026 13:07:46 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261111113135.4023555-5-den@openvz.org> References: <20261111113135.4023555-1-den@openvz.org> <20261111113135.4023555-5-den@openvz.org> Date: Thu, 12 Nov 2026 13:07:44 +0100 Message-Id: <179448526422.4060562.21919093866463441.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1701; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=ndmytOPV1IdWdI4eFtos1YUzyWzt9eMArF+8v4xEKNk=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq9awTRBUwPwqI+JRgNHtbHQcA1UChDsWdawZra m0BgDUO0DeJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavWsEwAKCRBRlgpH+WFc KivzEACHmP/u5ShV4DFDZ0XCej/vR6k4FeKZ1wMfWp6pDkNVm8GXR1BiUu7VgKhWKkeOpoPI96/ XsserFiECe0GtEftGo31alEUNaBB78y2ep6DyIp89T5QWgN2E+2tzK7unDdfP91kwZ+X6Q3Snv2 jMUicaeKd8RlBnSRyDsEgVvIKIg/gNKfz2bCskwMXVNoEinzzbC/o9kydcU+NExDRnGRpwK95E7 QDwcCIinaLJG27PjFVkmuPt6kJeae28MXqAv8TI0TbCN1vgZ2200i5AQ8h6P+5ikHOgUZiNXETS KMsLJFOL0XXWteMH0NK8fc2+V7bbB1W+tFoON8SIlaP0H/NqlH6oc86ivC2gppJ+/hFguxROdBA QYerUrv7G5gu2NhYj1zP6KUDN6MHXlMaK/zjipqIW4X9Wfj5+U2OwaC1cvbIgPGw48g0hIKV+EB LosS5D8WTcflU4BHuq99PoxZCw6ueM+vrzXrnddZ2nEYW+lw8W4v15ugu2GgFuGtdcVFkxuImch B1oYruYjebPjOYhzER8tttZl3KdCEiV+4S2/ZNuNYbcOvTT+ljcFRt47E8rr65cpinEYTBmPvY2 s4SpgBI0DXUMC7BS48WMr6JrxoSdNrzr4t44V6jcIPK9G14LVh9nRCE9ENzhp5UlkUaWnAAEYak 9FRV/7cZpfNVUeQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 4/5] ext4: discard the balloon on FITRIM X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying with these fixes on my side: - "Physically adjacent extents are merged into one discard" -> "Extents that follow each other both in the file and on disk are merged into one discard" - "opened only through EXT4_IOC_OPEN_BALLOON, which takes CAP_SYS_ADMIN, so the lock only waits for ploop" -> "only a privileged process opens it, through EXT4_IOC_OPEN_BALLOON or a file handle, so in practice the lock waits only for ploop" On Wed, 11 Nov 2026 12:31:34 +0100, Denis V. Lunev wrote: > leave extents past i_size. Physically adjacent extents are merged into > one discard, otherwise every cut at the unwritten extent length limit > leaves a partly covered cluster of the image below. A merged run is Sashiko is right here: the run also ends at a hole, a written extent or an extent placed on disk before the one before it in the file. ploop fills the balloon from offset 0 and never writes it, so the code is fine and only the wording changes. > balloon is hidden from lookup and opened only through > EXT4_IOC_OPEN_BALLOON, which takes CAP_SYS_ADMIN, so the lock only > waits for ploop inflating or shrinking it. open_by_handle_at() opens the balloon too. It needs privileges as well, and the exclusive locks cover any opener, so only the wording changes. > + /* > + * Chunks keep a long run interruptible. They end on multiples of the > + * discard granularity, so no cluster below is split between two. > + */ Item 2 of the cover letter reply. > + ret = sb_issue_discard(sb, pblk, next - pblk, GFP_NOFS, 0); > + if (ret) > + return ret; Item 1 of the cover letter reply. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel