From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 496F18169B for ; Thu, 12 Nov 2026 12:51:43 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACCoNvI009178; Thu, 12 Nov 2026 15:50:25 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACCoNvI009178 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="dcj0Tvkd" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACCoCXf009151 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 15:50:12 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACCoCXf009151 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-4915ba023d4so3061634f8f.0 for ; Thu, 12 Nov 2026 04:50:12 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGpJMrZwOmr2KZCxtgLaUfqcr2BDuIbr49MLIqvwNKSBIse3MMsDr7e9vtjH/7PEYI/QrbP1g==@openvz.org X-Gm-Message-State: APuU4Z+47B1wbAh79WULdsbpK7UnfHzSVi50dtYdT9WGMchqd8/grx05 Wh1ptYVOMbsvKZFVpndtpBPLJQyvQnt08Z6dNMj3YhEswFIjeAcgV76oN92I5f2iT6uKMIv+44q o97odgwkqEdQBKC1CFaBeQ7KFcInTY6xHDgHGoo+sjoH/LSmrtdqtDQ== X-Gm-Gg: AYBFou3mrjPR9TG7JaEejeD3gsjcoUfkLqW3Ak15yjSu2D4Advz9dusTh9O1QUJtbfs Ca0wEJ+xDnLH7bDUe5+sQXUM2XvO2FEB+m4qnGlOYI0g71hWDM+WSfIeFmxn5n374UGQEyoZK2Y MPOW5HxHjndUEa8PhmiY3NPH/W9+HVPUjfUFjQ4Z3cyrbqZ/Qf+NUicBjtSNJDaJT9lGXvaaVac c8h4vlCpePPkoyyw8ugf8h2I/7qasRYim/PDZV003fuKJfZXnbJEz5q6VTKWVKmSuDBNnDJHIo6 5JRzRf5u6ubgcuOcKTVq96773xisZpVbgsPHA3BSt/P4QXLBuOQy0+4q0ytSf94KdpC2J+MEz4c zZeIrDuOOn6hBXDZH/g== X-Received: by 2002:a05:600c:3551:b0:4a6:b49f:9ae5 with SMTP id 5b1f17b1804b1-4ba0938b879mr101552545e9.34.1794487811763; Thu, 12 Nov 2026 04:50:11 -0800 (PST) X-Received: by 2002:a05:600c:3551:b0:4a6:b49f:9ae5 with SMTP id 5b1f17b1804b1-4ba0938b879mr101551405e9.34.1794487810901; Thu, 12 Nov 2026 04:50:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794487810; cv=none; d=google.com; s=arc-20260327; b=ZOybaOhyX80Lc4vKnqctcMXfwa8IZsE4IVpF5waKBRUvn/FdopPSmx4ehT/GSlWXP5 IQo4ywpNkq1msXZJEQAWrchs9u3ItEezZW/jLZqhUDgjO9pHnqivPPu5EUs27GUUVLti FiOdnASO/hUSK0Kl9MAMsIdbqzEqt/P8PSmv8fOC2YRQK25wo6APlLYe50uX7AQD9xyZ XndPGkAChXYsvEg9GZ82lzLzY2J7W19QhOGycPTuZ0yn/KDFmOgQQNHW5XXP6QCD4w28 tSJhCvWglKDf7EfIBnWV2GECZrhhJqchtPRaVIdX5MYML+wExK88ZyiMuBoJqL/zQqKp Ll5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=0vhMqI9StpUFAY9KAiYnwfwP7GFl7i4LrBziMibq/sE=; fh=8+L1GLzK3OTQKnTfH5/my9NmwzU+1/k679YBeB1tMzs=; b=YrU78XWVDBKf/Tj8Kx++tNAC4Rfu/8+7DI92FLEoI/7/H2qoI4ADzCqnjwH7w80wt+ gtunjZkNKMpYguYf1XGDMx6ZvFvoIfCwTBTVBevIDL7AivDde/yL2uFouCvxJ4voYfBD ZP7CNVx7VnoMRT5jab+TMUeBqtisLyuoY06W7VMGJPXkTPsa2gNHCdSvrKws3ot6FRFy CViVEyx8AHdKVH53Pj8FS67LjthhJeDg3bAONjuq/b5zwa+ldjIQb2CiAu94lrL1WzKo pGNwtpjeotS5M5r9vlWDaqDaHm8FTI5oLWJBr00MApQ9pwVttJOg1Cfknu+8lpnmseLY MWog==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=dcj0Tvkd; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49837523399si18312586f8f.354.2026.11.12.04.50.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 04:50:10 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=dcj0Tvkd; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=0vhMqI9StpUFAY9KAiYnwfwP7GFl7i4LrBziMibq/sE=; b=dcj0TvkdnlLL wWzU39XG+DCLGxLEwULCU/1ARNKjHaXkQsZkmW/pQzakPWnwof35o85W1xhIJFYR/6D/gfEqASGoG TJSE/JFUTb11EWytCNOsu8l7DNHJyWYKrD9crHdTB8Qr1n1MJrkEjjFrNejmwUSMaos1/q4EHq066 H5JpFBY4Gg56w136+CpM5mrerQv9wNs6vUdBpeWERVhndD/2EZRSOpYobMa0Rjb1igfF68AwfzNcI S/R4SoRhp64n5SrjUUHz9H3f4V25qqYjsLTDoeqmYBQS8j+z5Bymo5bH4e78AbliGfZa/Ymy0oCA+ XUQ9aYwfwlivCbuSVg70gg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRUBd-00Glrg-16; Thu, 12 Nov 2026 13:50:08 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261110190033.2976967-1-den@openvz.org> References: <20261110190033.2976967-1-den@openvz.org> Date: Thu, 12 Nov 2026 13:50:05 +0100 Message-Id: <179448780588.4060562.1730123165510396382.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2285; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=AIKRjMhcdbyCRkkW6XPxCEtsldnLJVYly33n4aleYfU=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq9bYAhl3k2NMvm9Iv61pfh3lPknAFi5fjt5yOk dysadGNwYGJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavW2AAAKCRBRlgpH+WFc KrOlEACVrPsbG0o1sb+uJVYipiI4VURR1KSG3yKpotZ42hkJRh5/F9O9wor/QwaNloSEF4I65I8 z2uophb9FGTGyGpOsXOqxUrOnze3cl3iz29tAQDv/62l7tEm1WWzMbpfJ1or6tJa4JSoAQexvtK 7F44kehlGUbAtqRCcQXR2z76WcM7oA0rl2pff0pbsp5E+mw+qU5jc2ZBR6BBUiqZwL74VgbcHGw lW4ZUBpYhqn0Z3jDkJxathzCkDAyGB9Kmgmd4sjlTUL3JgQz0vllRMm4HUMR/ov6rZ5IhqU4OKU 80QMfLNEC9WHs8xzcfwZZicmbVIOlKr6j8N/MwbTHT6ZCn4DKszBVtZyphkyQOxhxc3X3f+e5GY lfHwcSn3PdeVYZMuq3IwUyHiJxw00CdEvznXwB9YbJ2WqhGil2ji6X0KMwdNdrJ/SOK5NzUIpfq b1ebFOPZUZwd6K2xM57PJ9zHz0+ZOdkNajKBKCA7It99CTzhqetqECVMZWgibpIycAgBW2pzkBE cemO/4lT2SlylE6T0au1yXSnJLcBOAd3J1rO31534e58rqL4nxy2x0vFN/h4ze1rmfarQ5BlfmT U4vEkb2u0QbMt7sosq3x+7dc3RTY6NAPzJmZICC9qAYt6WIgs1HfubQHb6M4xa8CivcrPmtlNmi AlmRTKHlKSrATeA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 0/2] dm-ploop: fix writes held on ENOSPC never being retried X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying with these fixes on my side: - dropped the "v2:" and "v1:" lines; - "the held writes stay in D state" became "the writers stay in D state"; - put back why patch 1 goes first. On Tue, 10 Nov 2026 20:00:31 +0100, Denis V. Lunev wrote: > the dispatcher for the retry, so the held writes stay in D state until > other I/O reaches the device (VSTOR-154182). The destructor is also > made to stop the timer and the event work. The writers wait in D state, not the held pios. The last sentence replaced the v1 one that said why patch 1 has to come first; that reason is now said nowhere. The new text: A write that fails with ENOSPC on the image is held and retried by enospc_timer, so that I/O resumes once space is freed. Nothing wakes the dispatcher for the retry, so the writers stay in D state until other I/O reaches the device (VSTOR-154182). Patch 1 makes the destructor stop the timer and the event work. It goes first because with patch 2 a timer that expires after the destructor also calls wake_up_process() on a dispatcher thread that is gone. > v2: cancel event_work in ploop_destroy(), reword the messages. > v1: http://lore.virtuozzo.com/kernel/20261109190657.1851487-1-den@openvz.org/ The cover goes into each commit as the "Patchset description", and the version history does not belong in the git log. Separate patch, not needed for this series; I created a task for it: 1. ploop_try_delay_enospc(): hold deferred_lock from the wants_suspend test through schedule_work(). An ENOSPC endio that stalls between llist_add() and mod_timer() can see presuspend resubmit its pio, the request complete and the table go away, and then arm the timer and queue event_work on the freed struct. No cancel in ploop_destroy() can close that, as the endio itself touches the struct after the free. presuspend sets wants_suspend under deferred_lock, so holding it across the whole delay does. It needs an asynchronous ENOSPC completion that stalls across the teardown, and it is as old as the driver. This is what Sashiko's first remark on 1/2 comes down to. https://virtuozzo.atlassian.net/browse/VSTOR-154847 -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel