From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 5AAA8803F7 for ; Thu, 12 Nov 2026 12:51:33 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACCoIe5009165; Thu, 12 Nov 2026 15:50:19 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACCoIe5009165 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="CjGRtYbB" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACCoBIo009146 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 15:50:12 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACCoBIo009146 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-490c69dc02bso3664546f8f.1 for ; Thu, 12 Nov 2026 04:50:12 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErFHqY0mmarEq92Nxkm1g/Jb0plhNZuT1EWEvcFrESkyayj1A2IzuYzx4VHAvZFnriVenESKJA==@openvz.org X-Gm-Message-State: APuU4Z+x5bjknHB+u7t2NyHSSLWhz8jvkehHeQXEzTn9IvZ8yTavfSd8 +YxX7NhI3u2nvv4ffwdvgpD/xRgaH11giF47PcHtrDsxzexErLammZqpBpz2gGTcxSNPBDjbu5x MXlAjVCvzPMAxCayINQrRJlbfCrL7eGGQTrj8Gm4U6EwRztGngLJE8A== X-Gm-Gg: AYBFou3ef08Yyhznz1wax1w9XQkm5LvtiiO4a431k9ZN0kZ6AVigEkQNPwqHCgpY7xH JW9LhzqJMv/ND3FqvQGdky5HvwFKXdMFxzuec4PbsNY5iFTPn13WoJyWbJO5T4XFMttrtQVq9di OMJnd2A3JfgjGO+G5VK4D8ISI7qCd3s4ABvv2ygUb6qhQ5T+Kjd5kyCTIEGHSK8lEU9Izlj7EQ8 8cso3ovUqurw4NmxUyMyBhk4yF/T7HZDPY4UfQktFmXCcMieQ6LJV30+vNsDG25cStXFQpth2eN xQwd6dYqi79a0Mten/NOxHAK3xDyniZIVngP8gFVl2wph6x1iccyAjp7WZlBqlTGgZ6KzEeqhUG AY0Mx2rCNhUPHoZlVLQ== X-Received: by 2002:a05:6000:230f:b0:48d:fbdd:4132 with SMTP id ffacd0b85a97d-499c69cae4emr9825380f8f.18.1794487811475; Thu, 12 Nov 2026 04:50:11 -0800 (PST) X-Received: by 2002:a05:6000:230f:b0:48d:fbdd:4132 with SMTP id ffacd0b85a97d-499c69cae4emr9825313f8f.18.1794487810899; Thu, 12 Nov 2026 04:50:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794487810; cv=none; d=google.com; s=arc-20260327; b=f67CetmTyEWL9viaoCs4Rt3Jz6e9fQVS5gejdGHkwGOkjtZGHIou1ynSkkvfwd7k5l JwMM4WnzoOCF8zWL9bb0bR5XkVu2tiinTUNtjj0tx2hseIrxW3b1JpUH3k5G8GpMq+/e QK3hCbnyfNYtdbUslJlTIhVweh830d7Vawsrvf8leFIS/GAoWrfqPrpFSH6CaCJBJR0o Sz7In5U+sSTpyytKdFV7EzV42B7D95TgnPtfmR+4mHrkX29wwQvJxGTlpp4GI7iP8cuA csJ2DGXvE8Pf8SFt0mcfETwJk+ZMU6ZSt1LePP7QbA5Ekr+NVWU2a8tCIlTNpT3R6gaA M04g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=KYmxNMU6lICv67oZn/tOvwHnxj/GPmPk1/m2pTCw+jw=; fh=8+L1GLzK3OTQKnTfH5/my9NmwzU+1/k679YBeB1tMzs=; b=gerU/EV/17DWJK9qaviDAPMWhMAEWTfRsO4Y662l5UAQlH4qZeCxA0BMVfMerX3lnB kzgle4cu2qio5wuzCtZ1HUHQKmE8NrYgBMbSG9PoOOWLNc072PE7z7hThLc48W4mYV1V TE+zR+v/3fdjs/pEIoivBebcB9bHm67WiaNavN2/m6WMMl+EMHcGqQ/37ojgOcBmSOxV Y0jFIkiHSRnNg1XyE8UNURUqhab8RBvAzlszyhH3j9aInAewowBfw2GnYLApDKF3aEha uzi+4LbD9APR3rJiXRQK/QkBbYlDRwG29thMlTiqYc6gXAt+2SRa0fgJ/VxWhssWRzeT MraA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=CjGRtYbB; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49be86e459asi1417763f8f.499.2026.11.12.04.50.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 04:50:10 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=CjGRtYbB; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=KYmxNMU6lICv67oZn/tOvwHnxj/GPmPk1/m2pTCw+jw=; b=CjGRtYbBn0ZM deVGcTejKDFwC7zNZ7x9aOww6ggqXa98CSCFhM3h8vIU4Xn/hE4L/cWXTf77394R1xFIQ9FxThMyd KQQBMqEs6F4+OfCuwNMcEkCF2gSMycVle2eq1SEsuuGxSnD4vCPgl+GHDDmXbeVA1Mb28p7Q+AAz8 MHCuCrnUGksjS+j/PyqaqkhlmQaFdGpaJQxh+mkG9MWCjCB23k/2rCrLKcHnhmLQ0nPMNerJyZitL HmaGDHLltZcEtn9d5LCAUVkgXdlC4F5baNw9LZr5K1rqIxYJYARK+i7Fpymt9DCJx7IvqGqldFxS9 zk0MbgIIxQz537jzSpoZYQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRUBd-00Glrg-1e; Thu, 12 Nov 2026 13:50:08 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261110190033.2976967-2-den@openvz.org> References: <20261110190033.2976967-1-den@openvz.org> <20261110190033.2976967-2-den@openvz.org> Date: Thu, 12 Nov 2026 13:50:05 +0100 Message-Id: <179448780588.4060562.7357368070934002149.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1532; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=0xlhepc1+QnEuOiSG5OAi4wVVTto6kT1pi4I/MiFP0M=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq9bYBvJCCXEhW5cST+TViE7njmGvTmkVnAxpUf +UnAhPGu3CJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavW2AQAKCRBRlgpH+WFc KklKD/wIIScStYuhYxay9iNCZxAlDyBrTkXyTAxN91V15N4keX8yG+XSDzLE2QhKZNYB1kZRLlf 16TNyZUuF4jsKvk0bPLMuDXkdNAyTzIX+vKOfXiX0GpjQP3T5aib5opE5UqVvgKeJ5zpWBEDbEy 2t6q1zTSmSav9GNRuBnHJ6efwLL+BBGhKMOl0qwCTYF7JTwJSssBixF8RNc4DE3heHbT+CrOyC7 s13ycyp3hIE+Y5/JcOWXUmZQhTJ41S5LUr162UnAGpH9VyPAKAyxLL8+dCHyulBbWnTWRw8OE94 zQtARqAgGMtXhPHPm2JHsjFKx0bVppHZozvm/S0oxhAIQmCqy18jFF+g0UiUh4ESQgcRkw8JGg4 XrYwDDRYSDQQN75ae4+nMsQsNX/j5yKWB8aeXJXZcDGgCEDZfWKomOAZbpv3UQn/jW6u+yPGIba MlkQmnVWUGRIefz63j7zAmb2l7R9VvUGRZf8glQWCPhlucw7T5wwqIShrQGqopwHov6o/4c46jj aqb4GnrSe/WX8dVWAvvF0OJIkJgolxjIEk6k3avwkQSC297eCr4lbdg+yZZjZds8RGGDHdYE0HT Y+RUVOx9R7n4PD4RlozRQB6OW6BKsN2eJ1q81/1VX5VfCMM5LOSxr4v7WZivgjEI30ZfZiX9ysn zsuh7uw4Me5c7Qg== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 1/2] dm-ploop: stop enospc_timer and event_work in ploop_destroy() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying with these fixes on my side: - "Once the device is removed" became "Once the table is destroyed, on device removal or table reload". On Tue, 10 Nov 2026 20:00:32 +0100, Denis V. Lunev wrote: > that fails with ENOSPC around the presuspend leaves the timer pending > and the work queued after the suspend. Once the device is removed, the > timer expires on the struct ploop that ploop_dtr() freed, and > do_ploop_event_work() reads ploop->ti from it. A table reload frees the old struct ploop the same way: do_resume() suspends, swaps and then destroys the old table, so the race is there too. > if (ploop->kt_worker) { > + timer_shutdown_sync(&ploop->enospc_timer); > + cancel_work_sync(&ploop->event_work); > ploop->force_md_writeback = 1; The code is right. Sashiko's two remarks on it do not block it: - Pios stranded on enospc_pios: cannot happen. A parked pio is a request in flight, and dm calls ploop_dtr() only after all requests are done: __dm_destroy() waits for md->holders, a reload waits in dm_suspend(). Until then the timer is alive and, with patch 2, resubmits the pio. - event_work queued after the cancel: the only window left is in the ENOSPC endio itself, between llist_add() and schedule_work(). Its own mod_timer() and schedule_work() hit the freed struct there, so a second cancel would not help. It is older than this patch; see the separate-patch block in the cover letter reply. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel