All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 0/6] net/ipv6: fix host panics on tunnels moved into a CT
Date: Thu, 12 Nov 2026 14:01:35 +0100	[thread overview]
Message-ID: <179448849598.4060562.16737941451112048318.b4-review@b4> (raw)
In-Reply-To: <20261110163130.2776687-1-den@openvz.org>

Applying the series, with the commit message fixes listed in the replies
to 1/6, 2/6 and 6/6. The code is fine as is.

On Tue, 10 Nov 2026 17:31:24 +0100, Denis V. Lunev wrote:
> Patches 1 and 2 take the pernet struct from t->net in ip6_tunnel and
> sit. Patches 3-5 backport the mainline vti6 fixes for moved tunnels,
> patch 6 is the vz-only rest for vti6.

Separate patches, not needed for this series; I created a task for
it:

1. Please backport the mainline v7.2-rc1 series "require CAP_NET_ADMIN
   in the device netns for changelink":
   - 8165f7ff57d96 net: ip_gre (adds rtnl_dev_link_net_capable())
   - 8211a26324667 net: ipip
   - 95cceadbfd52d net: ip_vti
   - 2496fa0b7d180 net: ip6_tunnel
   - f00a50876d281 net: ip6_gre
   - e2ac3b242c37d net: ip6_vti
   - 095515d89b19b xfrm: xfrm_interface
   - 27ccb68e7ccce net: sit
   https://virtuozzo.atlassian.net/browse/VSTOR-154864

Why: the ioctls of a moved tunnel now check CAP_NET_ADMIN in the
creation netns, but changelink does not. rtnetlink checks it only in
the CT user namespace, and changelink then rehashes the tunnel in the
host netns. So container root can run

    ip link set v6 type vti6 local A remote B ikey K okey K

on a vti6 the host moved in and take host IPsec traffic that matches
these addresses and mark into its own device. Until 3/6 this was a
panic for vti6. For ip6tnl, sit and ip6gre it is possible today.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  parent reply	other threads:[~2026-11-12 13:03 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 16:31 Denis V. Lunev
2026-11-10 16:31 ` [Devel] [PATCH hci-8.1 1/6] net/ip6_tunnel: fix a host panic deleting ip6tnl moved into a CT without ipip Denis V. Lunev
2026-11-10 16:35   ` no-reply
2026-11-12 13:01   ` Konstantin Khorenko
2026-11-10 16:31 ` [Devel] [PATCH hci-8.1 2/6] net/sit: fix a host panic deleting sit moved into a CT without sit Denis V. Lunev
2026-11-10 16:36   ` no-reply
2026-11-12 13:01   ` Konstantin Khorenko
2026-11-10 16:31 ` [Devel] [PATCH hci-8.1 3/6] ms/ip6: vti: Use ip6_tnl.net in vti6_changelink() Denis V. Lunev
2026-11-10 16:38   ` no-reply
2026-11-12 13:01   ` Konstantin Khorenko
2026-11-10 16:31 ` [Devel] [PATCH hci-8.1 4/6] ms/ip6: vti: Use ip6_tnl.net in vti6_siocdevprivate() Denis V. Lunev
2026-11-10 16:41   ` no-reply
2026-11-12 13:01   ` Konstantin Khorenko
2026-11-10 16:31 ` [Devel] [PATCH hci-8.1 5/6] ms/ip6_vti: set netns_immutable on the fallback device Denis V. Lunev
2026-11-10 16:41   ` no-reply
2026-11-12 13:01   ` Konstantin Khorenko
2026-11-10 16:31 ` [Devel] [PATCH hci-8.1 6/6] net/ip6_vti: fix host panics on a vti6 tunnel moved into a CT Denis V. Lunev
2026-11-10 16:42   ` no-reply
2026-11-12 13:01   ` Konstantin Khorenko
2026-11-12 13:01 ` Konstantin Khorenko [this message]
2026-11-12 13:01 ` [Devel] [PATCH hci-8.1 0/6] net/ipv6: fix host panics on tunnels " Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179448849598.4060562.16737941451112048318.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=devel@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.