From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 2D18A803BB for ; Thu, 12 Nov 2026 13:03:11 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACD1vLu009299; Thu, 12 Nov 2026 16:01:57 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACD1vLu009299 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="NZ4Is72I" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACD1i4W009267 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 16:01:44 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACD1i4W009267 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4901562b819so3778168f8f.3 for ; Thu, 12 Nov 2026 05:01:44 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErEqVXEBnrCuo9iQDSshFJfoLwqkokhSZZcECANR7IiEx+eimXRmWOhjWfNL6Jfvhn5bVgVDvA==@openvz.org X-Gm-Message-State: APuU4Z/XzouFm6cqzQPdLWhAtBlDUq/1e0fmBSKDD/hGinZIY1ccH/vU O5gI9F4mmQdbAyw53b9pCMbGH+yW33AMcU9EG6lyzQBYBvnCwZGEp60Of8vdwo+kqtKNwc272Pl FLZX2zH+R0oPzL0YwEJCbz24Z+MrNwevcBTd8GFCEeSDziRTm4urSPA== X-Gm-Gg: AYBFou21Tr4h05oycYFEX9CCRh1Dj9luJY5yBPNR8KdNCUV3dS+X7/9X9m5y2b2ZHyt FiU2VTtXTLBin0mXlx/88iSmZqQnmixfhK7Rrie+2Kar+Rv0LzseVzzH+nUT++vmfcQLuaTmcHe hpEdT3sdW637BPQaED2e1iKdjPVEWseSw6yELtD7uKQac35NyN0wmJ776vBTMIMbX4OGIuiMrh1 kghJN5Vu0SfJLa6twquRgbbpG3jrZycairKYe1FROV9sNtl/NVAYGlBzs2qa1L7Iic+QQ9s3cQp bQjiICypFztdvuSrRp0Q6hU9bxzMsVvSKlalCJYzZpgAZTbpISlI0oc42tksGzJVbu55Ju+/j/R iE17uwtpB+OK72V0mWQ== X-Received: by 2002:a05:6000:2401:b0:492:ac00:b3b7 with SMTP id ffacd0b85a97d-499c9415bfbmr10336753f8f.27.1794488503836; Thu, 12 Nov 2026 05:01:43 -0800 (PST) X-Received: by 2002:a05:6000:2401:b0:492:ac00:b3b7 with SMTP id ffacd0b85a97d-499c9415bfbmr10336656f8f.27.1794488502953; Thu, 12 Nov 2026 05:01:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794488502; cv=none; d=google.com; s=arc-20260327; b=Dm4Iu1xA3zKhoEQDjXSB4aoEWPzvp1Uu7ARX7IrVaIo5kgrcFWhGW6HSMFX2Ib5k9u A6VPfVD4nfMD813GF19v/PPS6lJkzaRVRn6E9roBKCye1023qC2L2nKuteZs+iFE4VRq CKhOp2ucrFOSqDe4bZO1Lqp6UysFIt/0pYrkJudrCQ6ax97iUiHzvY8CKg1v8m9/G3Nr l4bys3Q0c9g4uVlMuQi2oZKeibFFKffS2+Ep3yVZ3LwD3a1bWDlOEAzhPVM2Dn9jqE62 Jr7mZ9oaYN0KDrhFeGXoha8qYCUoiUk7DE9Xpqn+wBhgmDIH7KrOP9dwVxeiPwPeSB4s zD5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=NZqoyzSlI1p0FGsovAk0r5peOMN69fJrNl+hOz90ECQ=; fh=8+L1GLzK3OTQKnTfH5/my9NmwzU+1/k679YBeB1tMzs=; b=bcsWHpk6iF6ZbIrKCiI+sPkpSR9afAig02n6AYJhlOr43dsP7pE6DI2u1k7AH7v4HA 974X4cCKm2la5EM6j44blF366HjiMrOxWDf7i5sou/RGOayno+iFfeoEioq3Ni5PBSsP 9azuPZONDTqLlpoLcvYnQymPALWmnIqYhvvptrZ/s+T3ryiWlFquzrc0SgDcpzKf9Q65 /hWH9odEImCF92DsUkHoBvvCmekYBFPEiBZIwSqaH47S8foRRXIb5UvWlg8lyjGofQ/6 9GQW+Di3CZVgJwOtOnvtb5o0NFvlaXTGUQfKBXQ5JI6A3A+ersILAxtUHA0QCg46MUth tDEA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=NZ4Is72I; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-498376189d5si18303151f8f.375.2026.11.12.05.01.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 05:01:42 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=NZ4Is72I; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=NZqoyzSlI1p0FGsovAk0r5peOMN69fJrNl+hOz90ECQ=; b=NZ4Is72ICwwJ FnJquOCcFH0fLANkWecsLjWKxc8rxj8IlkCD/hr+hT1plkxJWE/8niXmGeLzZTqcmKXlZvJoSM6E+ Ju+kZImC30wjzmNMfduCzKQiKf9SLL6VHz0rL0Fw2tbhkkxhzw1MZVw7B19GiInOniiN+1nBdGk+e HpibbgJ8ZgqIkfqWg4Yi7Y+cl7cHOnJ2CwV5Zze5DpxJq/nYuMZZCXYcrOL9nF1NjfnNA/l28hm02 CzA/ts+WT4r93eUlmJbA/t1Ooqoqx4nq5dhfuNbRvbI/pajZ59MA+E1TndM4bchIVyoqP9lzopMlM PxoFIvr71bndb011OoVdHw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRUMm-00GypS-0w; Thu, 12 Nov 2026 14:01:39 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261110163130.2776687-7-den@openvz.org> References: <20261110163130.2776687-1-den@openvz.org> <20261110163130.2776687-7-den@openvz.org> Date: Thu, 12 Nov 2026 14:01:35 +0100 Message-Id: <179448849599.4060562.16427190740606014474.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1998; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=URagxoik/mluWsRQ6O5EhJfvZa4M5RNJoR2Kozc68Fg=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq9biz0rDeEqcrjW0rFJI3YFRVCjlypeY5pSY75 9jTQ3o66keJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavW4swAKCRBRlgpH+WFc KhKiEAC9hzD8rJAF9E10I1hzIxcOWSKUG2ap+Wbbe1u0/Em+BIKKXjxnJvN8oSYZbj67aEpdsU1 63Y/zEaGdzwvZ7I+nKYYicbRYo6TRi57dwO9131DF8vFlKwA9radAJeSD/XLU8uO8g6iAkpwiuG RKrziG1leeDRcQUWwbVSC3xvIUaDzp5vQTi0daPV+37+Gq1wgAEQ1FDOnnI83dK5ifyvNxexB72 IBMeO7MhOi6t/CRxY571ZcfA90tNWNWzYAj265MEZ5FSaduYfo7FrT0I0Od/FQibaky7Gymlyu+ QHBjJnfkGmAobGijRjBD51M/gCMc5zkRrpCNmOK4trTJL50lR8bYRz2KDYvXDr8UzDWSnaFcWLJ sNKKRe/pmBXZRVtgTxWlu/r29LUJNLSpiTXnEFE5LKOh4RvdR51CypG5nMrGgWwyk5qf1/RmsxD tLGUBCvSDSa8j42AdYGeZTjN38FU0TgEMxzezZrRufmtozN/WsvHeKgy2IIfs/xhRzI6kThYk2d Id/WLtz0r9V/yLn7+H6mzx3fEdeaCXRlkBhmQHoY5JAIV6uXxABEwKtJNyMOEECrFRNVetCCD7o V9LpTy5aU63y0SorQ9UP5WTRhSz7z31x7nYDBoiOt9m0AHIQPa7bbLnfXk1D7aO6NMQGRuuLbUA yWvPj54sr2eOaMg== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 6/6] net/ip6_vti: fix host panics on a vti6 tunnel moved into a CT X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying with these fixes on my side: - "container root deletes the tunnel or issues a tunnel ioctl on it" -> "container root deletes the tunnel, when any process in the container issues a tunnel ioctl on it (SIOCGETTUNNEL needs no capability)" - dropped "SIOCADDTUNNEL on such a device also walks the NULL hash in vti6_locate()." - added after "ip link del" keeps working: "A tunnel moved between two host netns now has its ioctls served in the creation netns too, so SIOCADDTUNNEL on it creates the new tunnel there, as for ip6tnl and sit." - the Jira URL moved next to the Fixes tag, a blank line before Feature On Tue, 10 Nov 2026 17:31:30 +0100, Denis V. Lunev wrote: > ip6n->fb_tnl_dev, so the node panics on a NULL pointer dereference when > container root deletes the tunnel or issues a tunnel ioctl on it, when dev_ioctl() passes SIOCDEVPRIVATE commands to the driver without a capability check, and SIOCGETTUNNEL has none in vti6_siocdevprivate() either. Any process in the CT could panic the node, not only root. > unloaded. SIOCADDTUNNEL on such a device also walks the NULL hash in > vti6_locate(). Not after 4/6: the ADD path now reads ip6n->fb_tnl_dev first and faults there, before vti6_locate(). > change. For a moved one the CAP_NET_ADMIN checks of the ioctls now run > against the creation netns and container root gets EPERM, as it does > for ip6tnl and sit; "ip link del" keeps working. With net = self->net for all commands, a vti6 moved between two host netns changes too: SIOCADDTUNNEL issued on it creates the new tunnel in the creation netns, and ADD and DEL check CAP_NET_ADMIN there. Mainline vti6 still uses dev_net(dev) for these. ip6tnl and sit already behave this way, so this is fine, but the message should say it. Also note: this EPERM holds for the ioctls only, changelink is still open to container root. See the reply to the cover letter. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel