From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id BCEA48169B for ; Thu, 12 Nov 2026 13:18:32 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACDHEAZ009450; Thu, 12 Nov 2026 16:17:15 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACDHEAZ009450 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="ZFjCKOrr" Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACDH6pR009410 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 16:17:06 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACDH6pR009410 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-c50681426b9so189628666b.3 for ; Thu, 12 Nov 2026 05:17:06 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGlD7zuaRE57vb5t2bkmCnZ1Rr+GUWr5zMY26AlMMIR28P+/CHfDXp6oQsFoB16G130BXFDrQ==@openvz.org X-Gm-Message-State: APuU4Z9P1Nmem+EJITnRnULxXHkavIJeg48H57bisfWzrq5c33jYL9Jd AR0bOK5gbSRNLSXolDyg336s0bOQudd7QP4njqQRsetxJtlhISakrb2jY6uHoOW36vpLrhqgfQc TXpCbXr7SNIocQVFlTj0l7H28eAdPXOB0fQpeNkpxztbD5pHGcfMz+w== X-Gm-Gg: AYBFou0rYlHIO+hxiY3ANYcBMtLBZjkQPJ3Px5TPiOtkiUo4ArduMm0rFMM6cTKjLX9 gvycx6+6MvoQE8QS9EaJ3MUFyAT0AChK7zI+SZw6S4K2lV+q3DBHtHlz68nUVJNEh/cOILEOtGE 5ivJr+uqxaZvdXe7+9E15LJKw7YcMuiZ2Ww3UykQX28yovbhaBnaoqYsKHr0DFBPWFZJCboN48w GulFGU5m5Z49a3Qv34Pkf++7OTW7yomGx7by+xGF5iJneACI97B4gMerrQlX3UeTjgOYcn3tgmf tZZB9bKTC+AzBfw/n83qEJKoP8vfAqOuZUC9+wQcGA+HqPvDhBSmJINwBUhdD639/E+VPiyWRHZ 5mR2CWKB63E2TE5cIgA== X-Received: by 2002:a17:907:6e8b:b0:c49:a408:f682 with SMTP id a640c23a62f3a-c5066d241f7mr462458366b.42.1794489426335; Thu, 12 Nov 2026 05:17:06 -0800 (PST) X-Received: by 2002:a17:907:6e8b:b0:c49:a408:f682 with SMTP id a640c23a62f3a-c5066d241f7mr462452666b.42.1794489425790; Thu, 12 Nov 2026 05:17:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794489425; cv=none; d=google.com; s=arc-20260327; b=ZabTPjG9Ajcf+FaMtREIDd8up3WnCHcE3DM0rDHkLGEps697j1JVnxFi8j+Xp98Wbn Bj7N1b8g3g6dYSsGWf4mvG1TKgs9qHzf6JMX4eW0Njoz3djkSTkLlfofJm6hAtI1flbk bK18V34PZCJJXVOEUEe7AjU81+1+5lAs8FOO1ml8Ghim3dWJoBAWavlRcYwclNczmQL2 Nbns2vg9qPwqZNH/UeCC3H3kduA7AGFdrvvDJcvwpO9lH0h7dzyaCW6ZwMXvK5H/f7TT httu78AXTXdnSsavsA+ipqpZ4sQ7IM4sl+hdIWvo1qPanBBxqQux3pdfrYnMwG2SY8+5 L6Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=2FHnAPpi3Ywr0sbflU6JfZ1TNrWCkbgOjq/j8mfP/s4=; fh=Q8xrIeKEv9kNt0kBAZ24Zoq+O3GjFEiuW2jIo3+yJG0=; b=mqtgrC9giOGK3nVH6XPXJ/ftrhBp9Gsv8fYmncSTyFnt79kfJtk6AfA14AIsKe9oym mklPGpkvOBMGM0PBmuvWF9dA8u4ryZj+GTmV6O667osR/3jVTBO4V+8A9Nch91tEsiNi qMduW5ERxceQiKH5tTMDudgOgSpRnXMmHeoXuWgwc1E/+sunK4YQdgFrcoXwg1a7wesQ bbK15UgKgDQT26bL+PwIf42t3HJLXt7TrULwNMMMNqPdGPBu+YF5yYmK35NR6JmMUv7g UHCQ6qM9sJ+SJO6wFP4S/dHIQhKjySTHIFM3OSJ9zST7oG96CHFUnswAzl5eHFBCyMcv vdxg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ZFjCKOrr; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4983714d777si15422618f8f.328.2026.11.12.05.17.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 05:17:05 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ZFjCKOrr; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=2FHnAPpi3Ywr0sbflU6JfZ1TNrWCkbgOjq/j8mfP/s4=; b=ZFjCKOrrNRsp QWfvnRF6PMa+FrXyhOeDoKdgEV8n5ohRFhMch0rYvaPeYnseJKDRRw3QW1WnMP00bRtTdcAThojEg +gKdGC6vLv1ICsErhsekTf5mXicRjo86AAm3/bSqZlPIsJWbqyjLt1S2Bqv3xUsEU8nQLzobyJyXk Fu6wVseW8KZsudfYEPKBfwTH9TInb+4ThT7QYVqj5vjQJ7+FTFeLp5ljlajxNkhWZYf0MXBtP5vv9 sJFRu1uXXb1qGuuzBkMDK5mZWZqELjG10oAvfUXy3G9Imm7CAWaIe8ywHoa1cam2I9Jpq5BJfjTUL PVV61v7z5boDgugDuxWozg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRUbg-00HHgf-1r; Thu, 12 Nov 2026 14:17:03 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Vladimir Riabchun In-Reply-To: <20261110-ovl-use-orig-ve-v5-2-f3f2bdb29e23@virtuozzo.com> References: <20261110-ovl-use-orig-ve-v5-0-f3f2bdb29e23@virtuozzo.com> <20261110-ovl-use-orig-ve-v5-2-f3f2bdb29e23@virtuozzo.com> Date: Thu, 12 Nov 2026 14:17:01 +0100 Message-Id: <179448942112.4060562.12042466360723083159.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2160; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=dyv3YOAnF0S8iThec4hwkvng5Ny+ZsS86Zk35mFrkv4=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq9bxPiYNvM372jC5e7jA8qRiIyddO/jPGkaagJ Q/hi2ROh+uJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavW8TwAKCRBRlgpH+WFc KoR0EADGDjRzIj7qbbF7X882/lyFWmCKNgwLCautYB/OYByXj+3XyMKgkl4Xy4XQI5wysuSnpMc YLxGeMK13RKYN04m58jUU1dlP22mk+y591z9xlFd2u5NKIqyMqNhGQtuqgi/S/ZJuerAFxky9gO fQasJiAZEkswAKdDLqy10yItt0uALoyEOZ/Lapjm1ZLCrmPDafLbcgHF47Ra/uL7PY+Vfy4E2Oi mkB5rGbM4fWZyNnVkatQpE7V4PUrHlIlEECsD/zhG7SnxjlCwt76spBEWdwtVnwIA1H6rkhxCpk 4Y05ILxlXq5VOB6fcvUpO8hfevH6TgzcVHkWVvUiJsK2M8eNG2g/LBev3nA1MI49gzYTScuEnwI FQydpESBf+jopmSHZOeSm96wK0hlqrFbAOucMW3hP0StbrB8v3jzJAOS//Pq8/xQL5weOWmAfoe Zor0mulICvWyPYDRKmRWteFWdx6S69sqMDrDvqsIUnGilpnjh1fE7fyQ+Y4IsLXx5cr4GkLhuuA kfcz9gNdPdJBNTBfxDCztSNM7bd96SHrrgbqPLbMaLq5wxfWS8y2/e/w7ceZXlvFdgjRMx+kIgV 9V1zAz530e11+lsYR+GLWbOYmSw4M5ro5YyeMG6oDxCXcpuUekP2tdkSMjB9NLSP/t0r3IacRF4 hwSBgatpF0wzBWg== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v5 2/5] ve: Introduce override_ve/revert_ve helpers X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v6 with the changes below. On Tue, 10 Nov 2026 18:26:49 +0100, Vladimir Riabchun wrote: > This field is not supposed to be inherited via fork, so report > a check for this was added as well. - Item 6 of the cover letter reply: rewrite this sentence, and say in the message that ve_capable() now uses overrided_ve and which VE switches are allowed, refused, or skipped. The sentence does not parse. The message also never says that ve_capable() and ve_capable_noaudit() change, or what override_ve() does for a CT caller. That is the part a reader of this patch needs. > + /* CT tasks are not supposed to switch VE context, this is a breach */ > + if (new_ve != get_exec_env() && !ve_is_super(get_exec_env())) { > + if (ve_is_super(new_ve)) { > + /* Don't cry about it, this event we may allow. */ > + return ERR_PTR(-EPERM); > + } - Item 1 of the cover letter reply: return the current override (old_ve) here, and ERR_PTR(-EPERM) for the cross-CT case below. ERR_PTR(-EPERM) here means "go on, just do not switch the VE", so the caller has to tell this error from a real one, and patch 5 does that twice with PTR_ERR() != -EPERM. Returning old_ve gives the same ve_capable() result: overrided_ve stays as it was, and revert_ve() writes back the same value. Then any error pointer is a real refusal, and the "this is a breach" comment no longer covers an allowed case. > + pr_err_ratelimited("Invalid VE override: %s -> %s\n", > + ve_name(get_exec_env()), > + ve_name(new_ve)); - Item 2 of the cover letter reply: do not print ve_name(new_ve). new_ve is the creator VE of the overlay. It is pinned only by get_ve(), and the CT may already be stopped and its cgroup removed. ve_offline() frees ve->ve_name with plain kfree() and no RCU, so this can read freed memory, or print "(null)". > + WARN_ON(orig->overrided_ve); - Item 3 of the cover letter reply: WARN_ON_ONCE. If this ever fires, it fires on every fork in the window. One trace is enough. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel