From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 58B4C81634 for ; Thu, 12 Nov 2026 13:18:31 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACDH77K009422; Thu, 12 Nov 2026 16:17:08 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACDH77K009422 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="imHS7LvP" Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACDH64o009406 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 16:17:06 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACDH64o009406 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-c40aa03ded8so475586366b.2 for ; Thu, 12 Nov 2026 05:17:06 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErHFHMrrdAk7XaqaJSDdeGeauUOzBjDJN3EUoqcFPsFcN7vogL9nLHdETNIxlC0xd64YLErCFA==@openvz.org X-Gm-Message-State: APuU4Z9BPiSZ27VJmMVRvpEwFJJEpprAJ2p2DbVQ+ueZfxsc4O9O2kcY IWB2Qden/WHnlteCafJACDuxWIbu8HI+3NacRJmLW+fcghneMualky2mF5iaTiHG8OUZZZrKiCb qc2ZdS4FzVxOPxd2/7oRXsX57uvi6baM15vDAMM+cO9Hj/JRaI3hH4g== X-Gm-Gg: AYBFou19WMxO9h7kWEQLMgqJNAN117nxKrddiYQbyKa0N04sbnwRjdlJgyfmAn6+PLF kMrg4qmMA6mP/n4alIg2ENqHF5WDPWuqrcdjwgkrGYREJUq026cQFY35iEa4qNA6UVUcdXMvZhI PaDBH9/XgaxX7xKFA4sRS3aBkcAFn8PaahqU0P+ZQjvI6OXRtJeQVprz2kAzItfexK1e4Mn14eT vwZiMvrH42x8J3CUEHA4RzQ/1Y6rtE+PL2+HzRynNiqmBZx/oIb0wYQYQN9MigAn2SwUHo/ceF0 jTXDALWpQoW9CUYtUL/e5hFb0T8lY0CU323rOoT1QyzzXiMUg9cVjIc42FuCYUhj/NWr47PelGK inmbWNBxjAyIvuq/y X-Received: by 2002:a17:907:2d0b:b0:c40:b59:1b with SMTP id a640c23a62f3a-c5066d40383mr449180166b.44.1794489426001; Thu, 12 Nov 2026 05:17:06 -0800 (PST) X-Received: by 2002:a17:907:2d0b:b0:c40:b59:1b with SMTP id a640c23a62f3a-c5066d40383mr449175666b.44.1794489425522; Thu, 12 Nov 2026 05:17:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794489425; cv=none; d=google.com; s=arc-20260327; b=ezJxBpBmcvEk/aqoAupwlWjByT8ZE1ZcjXcGDiINSDgpKqckm47jtBg/pFQ+5tgwIE flxxEuMBDrk5sQyJreYMF5MdXhKcWJyuhNF8sfOLN/A57U9m5qXwn7iTenMVVuZIiKcs MHEdiEqwRwykl/5olzYRJerDB0ifc22ZvYfp9w+vsUShiiUbwTe/Ds5HGtVO9uhvzBTx +gj+6MVDOfxPVHxIxM+AAjzteP1rzhY00TmYSnZRA26CyRxLS8KnVmNBPIhlPhG4WBLn raq9OqzLv+q3Fi7Ay8zhpNm+8SOpIFDIEvmPGmJ7k6w7Z2UG+lVIbB2K2DxivqQ7BMQP Gpew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=7kElVYdIA81XDWSHB4Qh30quKbrbndfkwhB82ykMEI8=; fh=Q8xrIeKEv9kNt0kBAZ24Zoq+O3GjFEiuW2jIo3+yJG0=; b=kEwrws0QU2f4vkV85kISQD8chSwHFyu8IRMGfoYS/IzRq+OxEGstGEuNcRLY2odQQq SqQG+W9l57gHLWIO2otvyzxQSzxQodxs2ME6AZ3gauw12RcRzVW8OSpCvFUpodhDYKCJ ucQnIKn/bKdwVnDrXsXRG4edGn/D+qu6Q3FVET0mAwWywaXud2P6m0QzKS3fOMb1nC0d p6B+tUSa4n3kAuFc2PRNzgBOqMo+TQpQMCqNpGrnFeesdfpwyB79vgxpqNMirL6/VDI0 NArs6TM9jAQcysgUD8CULWWoiXnsHcUo+1Fl/ZcALGAucUeWrU5qEm3MYSH5HZHhUIye SrPA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=imHS7LvP; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49835f172f7si16591791f8f.209.2026.11.12.05.17.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 05:17:05 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=imHS7LvP; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=7kElVYdIA81XDWSHB4Qh30quKbrbndfkwhB82ykMEI8=; b=imHS7LvPnEuQ yHgC5QJOn2R/Gv/Cc3nPWSWLq6TUcqt89rPefkpPELcVsG0Ud6TbGyU+O5QfrbodYa3FAZTYZwYMX wSw+VVTUgSPQevtFXShCWuiI3kharczVBcJ3NBNQT63I3KSnxG3jAGQBoSlC8bXdje77uVAfA4LNX E/cS0tHMtO94KzBSLZuBCxTwyGzKPiKPpNVuhViADInKM/lfwMC6oR+zYiLhQ1pzG9aUJV6J0kv0A c/lMbsCb0EtTyHXTePE27KO22VedR1BuIfuUVkeTWe0KrdNvilQMgWB+/TvyBcClaoFwX6WvBGQzX qetQ7wK9RsNzWmfRyX8fRA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRUbg-00HHgf-0Q; Thu, 12 Nov 2026 14:17:02 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Vladimir Riabchun In-Reply-To: <20261110-ovl-use-orig-ve-v5-0-f3f2bdb29e23@virtuozzo.com> References: <20261110-ovl-use-orig-ve-v5-0-f3f2bdb29e23@virtuozzo.com> Date: Thu, 12 Nov 2026 14:17:01 +0100 Message-Id: <179448942112.4060562.12799497421042932533.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3137; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=S2d4D5XozVThgU0/JS08TuWuy4qOE5N+wTHqnX5Uch4=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq9bxOQk/qipl8OB6/v4lQeWPn1Ch3vVHqFhw4c dZV0leGXMmJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavW8TgAKCRBRlgpH+WFc KmhJD/9OztqZ0fsyb0hLQyPRDFdoLXGyaiTph89rQswfz4aln7f0y7CKvzK67u+i8Unb8+T5a50 tO5+zHoI60cVuqBhtpu8E0qAgP2kA+zOGklbGW04g3BEip3S2QeZWM36DBu3IQbXH5r3z84dfBl VFc0wrzGa7GvrnNrqonzb/gPjE5ylf9zhedyBqZ6+p06TmEF2nXl10MrCh1ZOBQf5LuHW6srD1E pRhrJTzFAL0hdE+PrcsD91Iuq7oBIagBQxonM0b+fUhK3tGCoBrNb85LL7+QkEc4lsV0bc0E7B8 p4GcExeGkP24+Aq8Ny18XAHxn4tyg9/+S05lay+4hb/45bTWUntCsibdm8CCcJ+qN32tiLxK3dF bglwOxXSy9rC6Wj3uhKkJNXDnYydOOvzEQyd1OjVSQyBJn6DtIVMMtjfYlvi3qg350PZawDhk1r yz5GOhd6L02V71ax5unyR2WKHbsQoqr7k/FhcArRLbpjNqhdllEpF2ZdWBMeWSvnikafIpX6OPo HdO4cnLcmlmR3e3v7v17VrygPwWZ3BeEGZQMy/me+llB3aSWQCgwavKcU/9a2LrU31qlmhmuHJt QiJKkUE8AE626Hc/k3L6AW0xMKoCgmjVLcWO4vYZ6l1/BEA3NNBagGYwW5lZXbNIMnT+ehPtbpN KrK4YCbR/DS8A1w== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v5 0/5] Fix kernel crash in overlayfs X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v6 with the changes below. On Tue, 10 Nov 2026 18:26:47 +0100, Vladimir Riabchun wrote: > Vladimir Riabchun (5): > ve: Remove STOPPED state > ve: Introduce override_ve/revert_ve helpers > ve: Defer ve creds drop until ve is completely destroyed > ovl: Keep creator VE in overlayfs superblock > ve/overlayfs: Override VE together with creds The approach works: the criu oops is gone, the "CT stopped while the overlay is still in use" case is closed by patches 3 and 4, and a CT using a host overlay (GPU passthrough) behaves as before. What is left is small. What to change for v6: 1. Patches 2 and 5, code: a CT task asking override_ve() for VE0 gets its current override back (no change) instead of ERR_PTR(-EPERM). Cross-CT returns ERR_PTR(-EPERM) instead of -EINVAL. ovl_override_creds() and ovl_revert_creds() then test only IS_ERR(). Change the comment "Cross-CT mounts are forbidden" to say that using an overlayfs from another CT is refused. 2. Patch 2, code: do not print ve_name(new_ve) in the "Invalid VE override" message. 3. Patch 2, code: WARN_ON_ONCE instead of WARN_ON in dup_task_struct(). 4. Patch 3, code: the two "ve isn't running" comments in kernel/capability.c now mean "ve was never started", fix them. 5. Patch 1, message: restore Pavel's Reviewed-by from v2 (the diff has not changed since), "stated" -> "state". 6. Patch 2, message: rewrite the garbled fork sentence, and say that ve_capable() now uses overrided_ve and which VE switches are allowed, refused, or silently skipped. 7. Patch 4, message: drop the blank line before Signed-off-by. 8. Patch 5, message: add a Fixes tag for ec01a90d0ef9 ("ovl: replace capable by ve_capable for indexing feature"), fix "swich" and "Stroing", say why cross-CT use must fail, and limit the "compile error for new users" claim to ovl_override_creds(). 9. All patches: add a Feature line. Patches 1-3: "ve: ve generic structures" (as ed9325c6f4ce6), patches 4-5: "ve: CRIU support" (as ec01a90d0ef9). 10. Cover letter: the "v2:" link points to the 20 Sep two-patch series, and "reworked completely after v2" is wrong (override_ve() came with the 22 Oct v1). Mention that cross-CT use now fails, and name the Jira task for the backing_file gap (item 1 below). 11. All patches: add the Reviewed-by of Vasileios Almpanis, which he gave on the v5 cover letter; the v6 changes above are small enough to keep it. Separate patches, not needed for v6: 1. backing_file_ctx.cred = ovl_creds() (read_iter, write_iter, splice, mmap) still switches creds without the VE. Nothing there reaches ve_capable() today, so no crash, but it is the same class of bug. You said on v2 it would be a separate task; please file it. 2. Optional hardening: a WARN_ON_ONCE(!fh) returning -EIO in ovl_create_index() would turn any future creds/VE mismatch into an error instead of an oops. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel