From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id F27A38017D for ; Thu, 12 Nov 2026 16:37:47 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACGaUja010535; Thu, 12 Nov 2026 19:36:31 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACGaUja010535 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="RVFH8Ipm" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACGZo4D010485 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 19:35:51 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACGZo4D010485 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48fbcf023dcso2678630f8f.2 for ; Thu, 12 Nov 2026 08:35:51 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErEnsMfCyZaFTZkOWtVIqG/Cj7Fd39HRs5ueV01TdyQnAIX5+beDUUoU/hdDYXRBrHY4crlxDw==@openvz.org X-Gm-Message-State: APuU4Z/GAPAenxaiQ/51W07gIs1qTZPe2v6fXM3SgU+/RQZqjZavCJIn Jjwc5PBrdYNVe03V2bdpTGthi4/ZKpaKrAF5tKQwy5vH5unAfW4lRiJtKph7SUNOlSKiecZ9Vcf fQIeYWDhktxftwLEqjgQEwPgLnmrbySu7FaLs+tWT3Zw/OF/XTj2eWg== X-Gm-Gg: AYBFou1JbM+uOzJpVYNlwb+TNI53YyW1Ffty6ULFkpZ4KVwW+QzIdlrM+SGrMMUuECo uejkgVzFGLSJxvcL0Tp3NF0cjQr/aUdO6DsiDv6EH/DR6r+0liGPN4heoGgu9STMIB1uWuEuqyO /GnDEjXPO2xN3WpZcYU/mz02ZJbutEC3q8Ej2sUCItDLZTBScHVLo7Mm4ccGjfQzWYwHxassFuB ON6XCorJ9AxSwRBiDzRBYFbmbrMbg2yKHd4R8nK3lVTaL+ggI5vKMUYVojr83WbWTYEFIqgrriE E5jw+oUY4BuUACnKqJLg6j9LcwWxE/PLlO6HyUq5FkKHfZzzxxDJ9qbdsQB73kPHHS3nN3QX/Ka m+FGFymfpGngcq46m2A== X-Received: by 2002:a05:600c:c167:b0:4a5:dc5d:20f7 with SMTP id 5b1f17b1804b1-4ba09382f6fmr117125025e9.14.1794501349278; Thu, 12 Nov 2026 08:35:49 -0800 (PST) X-Received: by 2002:a05:600c:c167:b0:4a5:dc5d:20f7 with SMTP id 5b1f17b1804b1-4ba09382f6fmr117120165e9.14.1794501347110; Thu, 12 Nov 2026 08:35:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794501347; cv=none; d=google.com; s=arc-20260327; b=sE8XaBllzqor6P29WQnQjC39lLhTccyxXNyujzuutgt2h8hZPD+RywWPdawYWjyYEJ 07Kv131J9hZW0Fp5NgyEqgrFFm6FzH3XlOksDI7eOBXh89iF7DIbLSlPX8X+6leAmkU/ 1hqWivn7UI3FsKmLDjY3DdgYbdK8nRcc+t1AgwaVCW10IMyWRxiezmA/rLZagCzthupA AL8K58oJnVYwaCtAXCDc2ffEZYO0wP/d8GGLI81ShSM4Lh0MI3eyM1v5ChvXqi78lsoc GMwHKWDR6gWRe1j63wkAkjzokMlg5Kx4RGw/1fNj9C8pIq+5FWOTwhRQ7MXtsnDOGSTZ zUkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=AKMEiPS72u4JhQD0FSqX06T2uxfRmCothms4n+pry0I=; fh=Q8xrIeKEv9kNt0kBAZ24Zoq+O3GjFEiuW2jIo3+yJG0=; b=c1NOV9zMSEF/OOmosfzTSAri7Pe3ONOc19uLmI6D5JOifAxJq1akvt6RGhO/N4BeAU WN4tfYWUv9GcEacSximGN4a4EVGDL91sauEtvbvGEybj6fv6YiYqNubS+Xb6ecMVgZk/ ZC8pX2rAADzvpwFzVv3yqtN/92sKrZtt/IECinpcFvehrW2tQeZYT22r6InvuwORMBgz b2VCSB+P7VssxIUmQCnGOIdgHxw8ilFD6+ygauhE2mAn9TA6cvqX2ceOE2df0ENjKPFP ELovbB2I0n3XGt3Y8MsoG4BhgZuJndZaO3ytjrcN01rmnjINLMBh2+mP38Xudy7bYIT/ wo3A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=RVFH8Ipm; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c6482b4b6si72444f8f.340.2026.11.12.08.35.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 08:35:46 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=RVFH8Ipm; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=AKMEiPS72u4JhQD0FSqX06T2uxfRmCothms4n+pry0I=; b=RVFH8IpmZQa2 iY7hmtUfLaCGcCyJtaN+tzhHR98wLwYa36qJfT75Sf5GlCPyTtS6eXm7fx7Mosi9gAhFk/2NKa7iK HxcsxE9Z6V6CIv9hex/7Vk6PskZdAK+qyrk1+Hrt3dNXWLPaS46p/i/TFNoOS+wD1LneoznObnNoc Q1bAiuYgFSJBTIsbNDiXVEQ4KIBPO8Mjk3/Vv61FroUIF5OW3K10dL80XVcBLOOpZUe4FPyH95wxY abNFSzf2/lVgCODmGhtVOVvl0b0wycGPY7gNSeFE1QbncemvvOy9tFLXA1WercVNBYPTHpalBerN2 AYLKEtiBAnfi7g+VxoV2mg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRXhx-003SjS-1Z; Thu, 12 Nov 2026 17:35:44 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Vladimir Riabchun In-Reply-To: <20261012-ve-printk-irq-v3-1-efc95fd5c78a@virtuozzo.com> References: <20261012-ve-printk-irq-v3-0-efc95fd5c78a@virtuozzo.com> <20261012-ve-printk-irq-v3-1-efc95fd5c78a@virtuozzo.com> Date: Thu, 12 Nov 2026 17:35:40 +0100 Message-Id: <179450134078.4060562.10923430280586713728.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=606; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=UOHnU8oWwbAG7CCA8VH6KStA9Z/GG9sXpiz0FJZaGvk=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq9ere3BT1Sri/YvhwjgnRCn9IYf5G4zEXRmqXc N0D0HExTwaJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavXq3gAKCRBRlgpH+WFc KrVWD/44j6GXsQClqSYzEAyfFewWcJp8d929xxOGQ4HgHjb8/1zTBnRPqQMwtFZbTMQsSV+y1lg Ni+u5iOxnABnKjSQ6KIH+8SS28CENqaMg7UCzmBmoWILrgqu3zJl8UPFcVaMrZTW1GvVcevDnjs lQsEU9D9z3+NExEND5isR41M+4oa0o0i0hvxtt4mf2HrPwcjEk+/z3CGpTn3oZLJhZ5dncr6C2h dhWeExoCB2Im90vny4Niy2HIoTVqdHBEIpuD7+XE87cXvrgho5rQOfJqTUOEQxE89qGjLChKyF4 Zm/UZDFau2N9LfkREkBWPww010LQCT8yPvD8txy59CNCPY3ynHCgttXSqVVc4w0s2AKRPmhazYy m7+2b0tn+NfsfiZLrSS6ph4PGgc8WXM6SLM4q/AcgG1SBFTIV6dWGmWqH3kHb4bG8SRGG6FRE4a Dlv0NTaR4jTFovr5WR15oGUU1RmcgrWOw2gEUuxlp90ysHXkiYMjLmNsUVNkhEZh2wcI89tqe9l y29FaYIxC+g3hKBQ2octkdiI7LggK7gKc7ieynXlJJvuCp5OaTuTeC/z3NDChdbEDV8NdEfsznU JHb19wQmcWq+f1xgKTs+Syw0GKYZ79mXr215ZMU2eilpBJ5iG/JGUpcngDLUG5ePMzlCJWIKVPs 2yOicTrW0KJhJNA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 1/6] ve/printk: Add sanity checks in ve_printk functions X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v4 with the changes below. On Mon, 12 Oct 2026 00:52:28 +0200, Vladimir Riabchun wrote: > This patch adds dst sanity check and reorders VE_LOG checks > in if. Item 9 of the cover letter reply: say why the condition is reordered, or fold the reorder into patch 2. Why: the swap changes nothing by itself. It matters only because patch 2 puts WARN_ON_ONCE(!in_task()) between the two operands. The message should give that reason instead of restating the diff. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel