From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id BEC07803BB for ; Thu, 12 Nov 2026 16:37:58 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACGaaBo010548; Thu, 12 Nov 2026 19:36:37 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACGaaBo010548 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="G12Pg7u7" Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACGZmYb010467 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 19:35:48 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACGZmYb010467 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4ad3d35e899so36593625e9.1 for ; Thu, 12 Nov 2026 08:35:48 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErHOElDVPA6Pfnlhdb30FQ0MBHN9DXrxe7b9V/bbVQimmvxrzSbUaie2rTceAzgMv+v0TUkGQA==@openvz.org X-Gm-Message-State: APuU4Z+gybFJdBfGOdgqZStF8CIwJBXT/ZNxsNvbeD4KDD59Lw2sJws/ 16ZKyJzXmDhERHlP+DkyGuEStKcAW1kyBgxH1NPE28fOW/Ndnx5yrkC9irwsepKiAEtZkXHhugJ GnJe6JJ+LGnRr54Er2kKUzdz70MQ1ox/FEUnCTAWu/pzjst0A4HtZuA== X-Gm-Gg: AYBFou1a5mBQQfVxH3PqiOTHXOF84M5dwpbwbTm6d4sVukLMHl2WxXyUybmE2bNSUTF sbeFIBezf5dK+GGS79hptRbp35ipvOmvo2JTNTjt00AVt4eyz4PRUEFnoNfiskZWLdFhJ1qiCq/ UrmGWQkiPe3eQ/5qKzTynvJ5WsEkDR82UPRq9GREJDfrzGpOGdpxDNylf4UI32r8/apbxAIoeJD 1u7O3dWuTbnbZmMTPazdc35nzP3Rh2mWx5h2t8Fx4snnKHJn+YLrfafFTVNoIKKglPvyd4V6dUj z+ysQip4LzAfRRf4Mia1PkqD3MP7/OYkBnPmK5UkQkDaCjgKMrG65PTd4ereo6WoIKWSgLpRjA8 a7ZIhZ57n+lzVkQWz X-Received: by 2002:a05:600c:4f12:b0:4a2:191f:7cb8 with SMTP id 5b1f17b1804b1-4ba09365bc4mr128432225e9.17.1794501347975; Thu, 12 Nov 2026 08:35:47 -0800 (PST) X-Received: by 2002:a05:600c:4f12:b0:4a2:191f:7cb8 with SMTP id 5b1f17b1804b1-4ba09365bc4mr128431715e9.17.1794501347559; Thu, 12 Nov 2026 08:35:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794501347; cv=none; d=google.com; s=arc-20260327; b=hZ77h/RKSrjrPA0Xf2dAMAdk7UOe4E3fz2VcybxncSKSN+clpCJmerVToqLxVFSNiY LM069UcuaMyNuF57s9KOR/uIMx0BzuMJUIkEIMROn5/cwg5CGlY0JdzkEdDKLlU+M8fu zDkqfBIU7zh5R8AfZarOF4j7/9SI3uqgzDdLf/RH2p21q+1l0yq0HsdJYHDrSJCHqz/O OMfe/s9iURzKSQnW563h/PyiC7EBF4VGgsYpG30yZ7tV7o+6kh4ZS4fQMYMkslZK4H1z SRjfptyv5jKsdDQcfC27ByXOMUc+hu5LFvT1zzCUh1uCpGYZj5yzDJgzOe3lcEF/KAgw T3dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=iuD9J4DXdzSczRT3qZhteCDf5HBzf0BytBOBISyb2sc=; fh=Q8xrIeKEv9kNt0kBAZ24Zoq+O3GjFEiuW2jIo3+yJG0=; b=P4qnoVrrseZsNASmuP2B3nBMUbtzaHI5AE5vXXmOZRsYpr+e+IZ2nN523MQjCThN6W 3XKB3vBZFq9o4vSQ204VNc9i+1E0zkd+3q5FnLCxUjS254W1gbpTYBNTmzgckjRw243v Pko9TsE1mW7mdXg0kJ1Mg+LQRk36zl0Lj40CYOwpK8kpEYRQWn2bedIIgh89lSJnMbg+ CoGHulTOI0Z/RG4E74MIGVx/PUyN8JWVdoJFGmXxsJHM3rJA+9ao24Ma7FVpzAVdTKd/ RcEBQgB7DOHP28KXiEcNuriPF72uuRqGJHxIV2AK9UokujIRDcEJ8Nrk1fVR6Z2dlAMn IQmw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=G12Pg7u7; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c631227b3si83119f8f.82.2026.11.12.08.35.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 08:35:47 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=G12Pg7u7; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=iuD9J4DXdzSczRT3qZhteCDf5HBzf0BytBOBISyb2sc=; b=G12Pg7u7OYDL XuGp5FIdeZwE1dpvrnCaRitzoTRmk0O6TWwcKCMr2Z6v0Pn4UeeUULXPcUSNrfrR1zubGDE/FkjEN CYsy7ETN/AZpBkt8CS0K/7V3gZQBFFHmVfMqd4er89IQ3RZDAYhO4jXjl+2ViB9azL0lk+ZPRBTIL tuoUYYBKQ7oDm2Sicqu6c7MuX5QdVYyjnFfPVbBzsdufQnbI374oJZsJ9W9+uya8S3Lp34+sn/spb 8oxjked8JtsjAx/IvEFOith9Ju4vCJEvdCWZAhpSS8CcUFPf5RXAn57M9Hmod9ttNYtaVt8gYEcWo O6rGte+ibA7sHnaaXo1n5g==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRXhy-003SjS-0X; Thu, 12 Nov 2026 17:35:44 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Vladimir Riabchun In-Reply-To: <20261012-ve-printk-irq-v3-4-efc95fd5c78a@virtuozzo.com> References: <20261012-ve-printk-irq-v3-0-efc95fd5c78a@virtuozzo.com> <20261012-ve-printk-irq-v3-4-efc95fd5c78a@virtuozzo.com> Date: Thu, 12 Nov 2026 17:35:40 +0100 Message-Id: <179450134078.4060562.3011087073695195504.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1438; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=fLE5iFgcI141q6jyXW5pGkkPOP7jXDkAya+bN4NZAXQ=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq9erguGo/WS4ftqZ0amYfcfp1twiUOA8vI5IyY EQx8uEfhvCJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavXq4AAKCRBRlgpH+WFc KgGZD/4/8gYhf6kjCi7YjGWb9MHGL8sRDwmYiz1OCSvofKzFqP4Gdwjvd7X792o590SlE/4SAl6 ITIjCiG6GDy0KJiUkdNTVsIIY5M+2HKd5Fh+gop3c8Q3DptvEgkgKb+RR0Th2jTzfJHWKS3H02W YnlLPxHMJV2x/ttoaBjcAkalxc/QEh442wNsEawZsYD9w/aK9kW03yWq2PqMmP7G6S8j4mrqNBM 00ytDE3CNspit7opztSMfOHALCC0m5TsJCUBlOnbwAiv+PmYSuoE+1rLYGLj+qLQs8+LEFXAPV/ kAuJaUKEs3HnbeOwRa+jc+k5kF5GZFCITuxSeGP1fN1fB48gNTftMGHugU+H6+cfHO6sS9tQJHK 0Zhvp0JiW0lJRYvV9Y+Srx/zje2YzGFOW9CxNJIJSG5m4X+a+slK4KfQmGu6bSDxxskUQzdDeYA 1+3soG/Lj3KQCIpAVoEHvCuz/J1i2+OpEy21bMMKGxReH8A6LadmDyBA9HisBa5BskLaPTSNxl0 h80TLpp4ahJ1JrCcvd+dZdFCubfWgoz1J3zElDUEfcgtyPJeJIruONNbFgfmqEwfcmR6qtHaK5f 2iHn4soOLK2/5HoXMbBeTrEQgVLR2t3lABhXfsca9i3Q5q77xTVF6w9HGLDXPcliZn41nUFXFhU RqBIkpIJ15PDtCQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 4/6] ve/printk: Fix time virtualization X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v4 with the changes below. On Mon, 12 Oct 2026 00:52:31 +0200, Vladimir Riabchun wrote: > The usage of get_exec_env() in ve_timens_add_boottime_ns can lead > to time travels - a printk from IRQ might use container time for > printing to host dmesg and vice versa. Item 4 of the cover letter reply: describe the real broken case and the records that stay unshifted, and add the Fixes tags. Why: the shift was applied by whoever formatted the record. A CT log is read only by tasks of that CT, so "vice versa" did not happen. The host log was formatted for the console by any context that flushed it: a CT task's own printk, or an IRQ on top of a CT task. Host console lines then carried that CT's uptime. The code is fine. But records stored while the CT has no ve_nsproxy, before start or after stop, now keep host time for good. Explicit-ve writers such as netfilter can reach a CT log then. Please say so. The Fixes tags name commits 1249fbadd45b3 ("syslog: Virtualize timestamps in the data reported") and 8b42370ae936e ("kmsg: Virtualize timestamps in /dev/ksmg output"). > struct log_state *ve_log_state(void); > +struct log_state *__ve_log_state(struct ve_struct *ve); Item 2 of the cover letter reply: drop this line, __ve_log_state() becomes static in patch 3. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel