From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 9A775803BB for ; Thu, 12 Nov 2026 17:28:17 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACHQudw011126; Thu, 12 Nov 2026 20:26:58 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACHQudw011126 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="EyH7vKRM" Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACHQtoh011112 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 20:26:55 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACHQtoh011112 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-c42f98f354fso93037466b.0 for ; Thu, 12 Nov 2026 09:26:55 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErHHS825q0Z4YicdOAiQdrv+iPHGSIX1w6W4vkpUn3JxCVe6LkczzFeY0UT9AbYci1FmVwyVvQ==@openvz.org X-Gm-Message-State: APuU4Z+0rBs/7xlu/XjA+DE+aASX9SWilSuVPb6xAmqWxFOePkQo/TSj HutVpEHVIWDyHYRlMl2ssi2F7UybutszlyK7i0fYk15WTCNu5CFzaqGSdrqPmNslfVXZeNHZnfu 4a1eiKcAp/wLRYPJ+u2Ozdq+owDROhdpjPhjDTdKts6Wmgd4hOZsHcg== X-Gm-Gg: AYBFou3hnKeYRaYLydJeapxsu4F4IL+OKbeS93m4Nkg0wb1dbsNsgD3mrM4TK8DUYDY 0CZkUzyZ2b0nhO57kgXOzkg7ALIiKX1DU3PswFQhcFjsTRIgKuCDNTCvMihalwCZssD8NKTOHA2 vkTq4EKFnFmhYwZkZHuWv8ubSR6LrluwWh3Z7WbPpSeKRUPFlfgukHz/Pjs744XF+hzoSLpe+o2 Y1r8Qsi2DVrfOQ9tdQFWAkNrV7hfwTOr7WeHGmYHH8G0zTx2i69YdabFbWkcGd6bN37yCr0YnlS 1zamtTIQ4qrnB96Uaz6HHW+LrEzLAEdYpr5sfOHNdrexDq0GAgTVakPdula4hkd4SdPC9PJgdjY EVWvDDCIvqGrGJtQu X-Received: by 2002:a17:907:2d9e:b0:c42:102f:15d3 with SMTP id a640c23a62f3a-c5066cd4006mr541655366b.34.1794504415470; Thu, 12 Nov 2026 09:26:55 -0800 (PST) X-Received: by 2002:a17:907:2d9e:b0:c42:102f:15d3 with SMTP id a640c23a62f3a-c5066cd4006mr541652066b.34.1794504415055; Thu, 12 Nov 2026 09:26:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794504415; cv=none; d=google.com; s=arc-20260327; b=eDAqcuiVcEelII7OUEOsXhw3im6qu6Co3JV2qgRqEQonrYhUptH6dPRRO05Y2hgD6X CtLaTOq8QO179wLdRK0KOQ0AyvG9u+XTTtXk7va76xAW6M0Go8ERiLBlLihNi7HyeuZH /gkbl1re04x6NRBxjm2gorHCxyO0AQsn9e7PiUEMfnpu0BQ7oX0D88SmdUYnWeXHA+V6 ATaw6kubva+3DXAwuMym/sxGloXXKa3qouhd/Ij35YdjL3syspBHkEolfKNxvsjVbE0o 1B1XYUxmZ1Ov7dkvoy3h01ijSedjq6IN3NRytmKeQ+YxjUoAXaiDLk9BMbI28mwR7+OS gg8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=OxOun2S5kCKwbNHFkHCoeSGj9zUC2RAxYOcQqQPdGRc=; fh=CTF2GHyV+XdzB5TROrdG4fdLri6JSHNOBC+LNuNq5bA=; b=mzQ+tBhmvClI/OKFgxU4CBIS1Fj9r913AB4hw6OhG6/LWLBtBbGX8FW/XQ38k0ASAv fh7VSln4Gw5WKq0CeBcRRZuq0yfXdl/QbGSa+cbnuhYFkfcN46fNE1HH247e+uFDThWF EyCLJpAQaZ6nqQ/C4kDiN3BV/DvJzsoxibAHgGV66Po9zBDhQ2tr81LBdiNp8zzmfb7t 7jD60y5pVvIf3IEzCek8RSuTZLAvMI/0El9dCS7s0ytB8naMwpufnXflR9SkS+RR4oeQ lyitNfXsJe10G755jZwswuiicdcXjur9qfugjyi/pHQq+oKED0NFfndDJ+9lwYbSWVOv zGiw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=EyH7vKRM; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c63122092si355705f8f.91.2026.11.12.09.26.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 09:26:54 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=EyH7vKRM; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=OxOun2S5kCKwbNHFkHCoeSGj9zUC2RAxYOcQqQPdGRc=; b=EyH7vKRMRKKV gRddsr+9w1f5WZ3QAxK2CLDfFY6K5g5w1CIq0jMbvGflUasQZg6FyUfAi0DKNFIJQi7IiUe7znn19 qacHZ7ypA/KY0tJVAdO+i4R0Uwg4ggd9KXKBGtw8De1NdMjQJMWrS/ztZ5oJsQVo+jwbCoEG8RR1r 74YYqdNNSpSO5645nQAG86QYbzvCn0qyxs0P8uwmj5GtNhFJGyIo+XFMYTvEsvgjbEhQ6NXISDoDi qvbYPskbY0V9aPq2jbtS0RDO4GD90Ciekgxvv6EO5N59adAUBeQC/b0qIU/Ty6MAEx6jDo/oW4A2d GR/x5Fp2nR9fjexPJM6hrA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRYVR-004Qiw-12; Thu, 12 Nov 2026 18:26:52 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Eva Kurchatova In-Reply-To: <20261106030306.16014-1-eva.kurchatova@virtuozzo.com> References: <20261106030306.16014-1-eva.kurchatova@virtuozzo.com> Date: Thu, 12 Nov 2026 18:26:51 +0100 Message-Id: <179450441149.4060562.12778470791653323060.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1967; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=hK8rlnTxS/zo4VHlmHNgUkedeQ/0CSEEhICbH+bXZ5Q=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq9fbd+H+0GPxW+piP8dJUtl/wGV+anUJn73IIC Mcnpe9apkOJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavX23QAKCRBRlgpH+WFc KsvWEACiS9zNwZwR3TltY9CUMKplo3zgCgXvzyWiYxluXtgVjZZ0/v9Jnhe4dBIPz8G42YUr2Kp Em2Ax7d+GfVFCbg8PFgQuPi/eAuuNVyMYiTlPXrt/ONZ3z2pjcjs/yxpwhlj1gCNsT2ljk61kod KzBG1HPPvb72mVLJ7xxT9wIa4WQqpsaOqjWjQFUX6AYgh7ADYcR69lG/yLolHOg7mIJcCHG0DlI dYqLiK2FNSZOFD5rUHUPDUQEIr+FZruTrSTBRXLXyQGWb+QuCsXeK2MEGUH3IJCjgUXFw1xeVEi zdepJn0/VnjSMRCMmsJ2ifdbpg3AGtmv7XUoKXltHhh3aQoaRLJHPRXYUkjhzM6YVueERWx2qxv 5E4f9CIcdMLcCAhQJuNaYK+vuhw1e7Yka6uX/2pivKs9sX6avfh5qFOTiAEob568fNJQrUYdWId Iqqd9h5+6FlIJxpSu1WpN4MH4h0MpaEYLManFVczQXdWgdnk69BNPMUyzPgEWyeD20eZz6yP+Cj Qzy1i053yc7irxqbUYxZszSB5JKYrPU+AQ2nXHt3Zz9ciOm/DACNDzp8lX0lOivXQcYnSFbNi3H 3XJzCU7VBVRHGbrJdPuVfWpa+brxPS12umR5WzzobO8XwaR2sxELnMqw3B/VaXLCYm4MbjHE99n lw9wRswFtSfZ0uA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 0/8] ms/mptcp: stability fixes X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On Fri, 06 Nov 2026 05:02:08 +0200, Eva Kurchatova wrote: > Paolo Abeni (8): > ms/mptcp: fix retransmission loop when csum is enabled > ms/mptcp: move the retrans loop to a separate helper > ms/mptcp: move the stale logic out of retrans scheduler > ms/mptcp: let the retrans scheduler do its job > ms/mptcp: explicitly drop over memory limits > ms/mptcp: implemented OoO queue pruning > ms/mptcp: being below memory limit is a likely() condition > ms/mptcp: avoid pruning for OoW data The backports themselves match mainline. What to change for v2: 1. Add mainline 8ab24fdebc369 ("mptcp: close TOCTOU race while computing rcv_wnd") and da23be77e1292 ("mptcp: allow subflow rcv wnd to shrink") before patch 5. Both are Cc stable and come from the same 7.1-rc7 batch as patch 1. 2. Cover letter: say what the series fixes (endless retransmission with csum, receive stalls under memory pressure), which patches are only prerequisites (2-4), what was left out of the mainline series and why, and how it was tested. 3. Patch 3: fix the rebase note, mainline also moves only "stale" out of the bitfield. 4. Patch 6: name the two skipped mainline commits in the rebase note. Separate patches, not needed for v2; I created a task for each: 1. Mainline 7538fa33bb2f6 ("mptcp: fix subflow bitfield misuse"). Our tree still flips close_event_done under the msk lock only, in the same word as bits written under the subflow lock. https://virtuozzo.atlassian.net/browse/VSTOR-154927 2. Mainline e2ab913f68c7d ("mptcp: do not reschedule the RTX timer for fallback sockets"). After a fallback to TCP the MPTCP retransmit timer keeps being rearmed and fires as a no-op. https://virtuozzo.atlassian.net/browse/VSTOR-154928 -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel