From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 53DDB803F7 for ; Thu, 12 Nov 2026 17:28:22 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACHR94x011149; Thu, 12 Nov 2026 20:27:10 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACHR94x011149 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="r+YxBwh6" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACHQurc011120 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 20:26:56 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACHQurc011120 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-490a0e72578so10231f8f.0 for ; Thu, 12 Nov 2026 09:26:56 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErEa2j71y9+a8TiuuEUGi2MZR6lK4HawjS1s5+7Wd/Jr6jGRmZkqABe58sNdWq3Pl7yQ3g3AEg==@openvz.org X-Gm-Message-State: APuU4Z9oid79yKVplzTkM/3umwXAu9asg0BsoPhUZttLjo1H9Mo5cLGQ pgYGAWwSoS0eLnTtRuLMHCmdy2gu1aLd3ELAPqqRUV3s2pU6acjzZkGpDQ/Krh5F6iohA3jv9r6 6VOyeQUW2c7Sexi3fPCuPc/rkq1VaZYI0S2Wk/4kdQH6BImRX4pi/hg== X-Gm-Gg: AYBFou1UklwNQlgm5i6K/PXTefpoFfFM0dI0LlcEZZX4d7ajnW3rliBDujsFUvepdiY RlsedGGmUCuLHeP2VEKgv3YhxcrcVfZocxfzyYihA3EwKTmN/zvZbBH5bcayh58Iv4ZBqiI9VGU nHmv1k7P5vthy3GqmKsMWusG1J8dS1LsOD2J7otRhSLuSlv7YwzA94xsAWDD8Nt35NYP7iwkXKM L2Z8BcNm9xvtccuhW+o2Sc4J7gt75Q3sG5ERxLAzA3F79B4OL2hzUsc+NtakO2au7re3mJSSVsZ jU/eCecre3/74mQUHb0SzZDgLqmozM7DN4uuOzhRGMVej3fMw9ImP+4SklnslW+UbMwrE2UZN4B vPoh2/orlIB0a1swH X-Received: by 2002:a05:600c:3544:b0:4a4:de70:2ad4 with SMTP id 5b1f17b1804b1-4ba0938e165mr124466035e9.22.1794504416058; Thu, 12 Nov 2026 09:26:56 -0800 (PST) X-Received: by 2002:a05:600c:3544:b0:4a4:de70:2ad4 with SMTP id 5b1f17b1804b1-4ba0938e165mr124464795e9.22.1794504415117; Thu, 12 Nov 2026 09:26:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794504415; cv=none; d=google.com; s=arc-20260327; b=P1NuOu34M4a2VCncIaVmBiT9HehUODZN8aekFEJDr+SrIiKFauul5nZoRZvhOnyooq Pf82Prw5W03h44PKpSEAGmry919pOW4R7DzTdQE40GBDe8ErREPsE59hl6yEgt+Dd1DP T/6kWOk2dRJz9+Bowbp8tS0IZk5YXvbtNUuLc3ZUwMTnDwBB2S1B6o173F6dFy0c6TM6 9CnKDV3TvBXBOthCztkig//IPWWc4C6lmIgnV0Uj2vJiHdqJ0CS+M12h4h+rLNWt0omF DhxtVp35HhWOVU6opsVUucRKzxxQJqFG7CBUe43DG52BoYH153zKBrllWxsLzDJn8C+4 u6AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=1exDJyFcpNdQlYyA/vSBCkjNTU1+XaoT5HOJnQmoDFI=; fh=CTF2GHyV+XdzB5TROrdG4fdLri6JSHNOBC+LNuNq5bA=; b=g1R3nrHTdX0Sn0VYLoGnDEvlgJNigs+8Px7AOLcl4VhVXsJik8t3o5DnGY3liiHsP0 x/fpoyO2478XZgVVY74bjUL95ja5OoOT1T26h1lAiH0A2XOIt/cdZDPKRgdO1og7CwW/ ISXTo/FO1hvmXuFROCPEXlzByPEzr3VcchOF2hX0A9QPt+uZd7xCQwJCKJ1FBWp91BQF U+qUpXIP8gfQcniCo6/us/3z6+emUBUINwdQN86Wbckq5QmhUgsP5H9TtuJqRtR+Ba5U NKL0l9jZeyXPfS3UNp6i5QqhyxY15F9uULa4tyj1UPQ+x3NVJc4i0wDfOhRK76zr2/lw iEmg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=r+YxBwh6; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c64deb526si332403f8f.425.2026.11.12.09.26.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 09:26:55 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=r+YxBwh6; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=1exDJyFcpNdQlYyA/vSBCkjNTU1+XaoT5HOJnQmoDFI=; b=r+YxBwh6ftBZ xAdxqVQuxuMsWNtvXvEGiE2Ux8DUHkxlCYbx2nJpDKNLqTST7C6KdvfiEDCgZn1FbcR+y7psoNqom jzlfkFBM2BfBvQ+Q9dtICo6Y1g3MRgPv8lEnl2XMObYx+EvHdF/5LryRCDiP5YYzmooiMBq83xQo/ ZzoeNzitzWFXPaUnLdPKx10M+w4vYW4+Cc/yxXOP1XZwUfUjOo8ni5mzAkwnbitB4kNGW97/gPsJo xHpPXYsID6wPPFnRDrWNxN8VKCEHoBKg0dt9U3fRrrAkl2UTklaIQ+EF+7mS5AYbk4UsBTWV7Pj7h QC/aPbajGBRHr9FcJspDfw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRYVR-004Qiw-27; Thu, 12 Nov 2026 18:26:52 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Eva Kurchatova In-Reply-To: <20261106030306.16014-6-eva.kurchatova@virtuozzo.com> References: <20261106030306.16014-1-eva.kurchatova@virtuozzo.com> <20261106030306.16014-6-eva.kurchatova@virtuozzo.com> Date: Thu, 12 Nov 2026 18:26:51 +0100 Message-Id: <179450441149.4060562.18117105069990731447.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=980; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=FwM1kKTm92KR32F74rfk3FcRowJ2xMyRGMCBPuygFtc=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq9fbdym3uLvVMkTxmxHBjZj2T3epeFIvTh088u 8GKMAvAsuqJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavX23QAKCRBRlgpH+WFc KhmXD/9DKKnVMPj0N0T9hT8TdksPPuoWnllw1SBv9aK0u91yXPcLNM6wFGqN2Hchj47PwVv2XJJ 63Y/x7HxdLO0OrReUPcAoP9z3NjckrI6O6E8ExiIbnJjM5/kUfSI7IfVodko/za0IWRINiZOHyI YHJSIghreg7pFNy4qFaJvJYzOyHw3bgztzK5ijR7ezfoSjRbAREnEacE91crRMcR3lTstJViDC5 mYjDOaDTj3bNxe0lPdsH3HPEk6ITIkgFcWh00KYPvmbbASMFByDDGG1lO4B6i3nxjM67zH5bjiL 7zRIfwl3219YdMGHyjWUUE7RNEVkORa4ngOC733s6+icWdmeXx7f7pj4Yi+cozsIJfitOL43RUP 8xs6kFGMaxfrX7SaFj/0PkPngZnyoPv24wO4h/2a8A7cJ+ECIrtOQv+sJf4Qh6w9+xFqp7u/dYM 0jeneQFHzIawgv7i4uKrkwnfSqsl8ISKjwS8ANqNMTSZ539jZTiX5IJB9gPpAYjZD1jOttvOE/F xVN43NMM/b2BKXgsyGg6Er6iIktegYlKbhcTySKg8ugyrjzlWWsmmx4EXx831CA4yue2LgxP+He 6cJU/a874Jue3icb8CCCOI3n/VY2GFQFhWGW0oulsF8SZKPlBRiGQAu/eXN3KHoihcOv9t5yDR4 WTcrV5soupQtaHw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 5/8] ms/mptcp: explicitly drop over memory limits X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On Fri, 06 Nov 2026 05:02:13 +0200, Eva Kurchatova wrote: > Over memory limits, drop the incoming skb, relying on MPTCP-level > retransmissions. Item 1 of the cover letter reply: put mainline 8ab24fdebc369 ("mptcp: close TOCTOU race while computing rcv_wnd") and da23be77e1292 ("mptcp: allow subflow rcv wnd to shrink") before this patch. Why: our tree lacks both. TCP never lets the subflow window shrink, so data that TCP has acked but that is out of order at MPTCP level inflates the MPTCP window we announce. A peer that behaves correctly can then send more than our rcvbuf holds. Until now that excess waited in the subflow queue; with this patch it is dropped and only the sender's MPTCP retransmit timer brings it back. Mainline had the two window fixes two months before it started to drop here. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel