From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1] ms/selftests/xsk: properly handle batch ending in the middle of a packet
Date: Thu, 12 Nov 2026 18:34:02 +0100 [thread overview]
Message-ID: <179450484251.4060562.6216874279107252008.b4-review@b4> (raw)
In-Reply-To: <20261106145505.132348-1-eva.kurchatova@virtuozzo.com>
Applying with these fixes on my side:
- Rebase note: 3ab77f35a75e moved the code to test_xsk.c, the move
to prog_tests/ is d1aec26fce25. The note now names both.
On Fri, 6 Nov 2026 16:54:56 +0200, Eva Kurchatova <eva.kurchatova@virtuozzo.com> wrote:
> Rebase note: applied to xskxceiver.c, which mainline split into
> prog_tests/test_xsk.c in commit 3ab77f35a75e ("selftests/bpf:
> test_xsk: Split xskxceiver"), missing here. The code is the same.
3ab77f35a75e created tools/testing/selftests/bpf/test_xsk.c. The file
went to prog_tests/ later, in d1aec26fce25 ("selftests/bpf: test_xsk:
Integrate test_xsk.c to test_progs framework"). The note now reads:
Rebase note: applied to xskxceiver.c. Mainline moved this code to
test_xsk.c in commit 3ab77f35a75e ("selftests/bpf: test_xsk: Split
xskxceiver") and then to prog_tests/ in commit d1aec26fce25
("selftests/bpf: test_xsk: Integrate test_xsk.c to test_progs
framework"). Neither is here. The code is the same.
Separate patches, not needed for this one; I created a task for
each:
1. 2233ef8bba81 ("selftests/bpf: test_xsk: Initialize bitmap before
use"). send_pkts() and receive_pkts() in xskxceiver.c still use
DECLARE_BITMAP() without bitmap_zero(). Stack garbage in the bitmap
can make send_pkts() return before sending anything, even with one
socket, and the test then fails on the rx timeout.
https://virtuozzo.atlassian.net/browse/VSTOR-154851
2. 88af9fefed41 ("selftests/xsk: fix number of Tx frags in invalid
packet"), the other patch of the same upstream series. It only
matters for TOO_MANY_FRAGS in zero-copy mode with an odd
xdp_zc_max_segs, so it is needed only if the suite runs on a NIC
in ZC mode.
https://virtuozzo.atlassian.net/browse/VSTOR-154852
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-12 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 14:54 Eva Kurchatova
2026-11-06 14:57 ` no-reply
2026-11-12 17:34 ` Konstantin Khorenko [this message]
2026-11-12 17:34 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179450484251.4060562.6216874279107252008.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=devel@openvz.org \
--cc=eva.kurchatova@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.