From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 012F4803F7 for ; Fri, 13 Nov 2026 19:44:12 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADJfuPs019440; Fri, 13 Nov 2026 22:41:56 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADJfuPs019440 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="AHKlHMNK" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADJfl5P019417 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Fri, 13 Nov 2026 22:41:47 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADJfl5P019417 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-490c1867460so693665f8f.2 for ; Fri, 13 Nov 2026 11:41:47 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErFL7W6ktNd+wMObicpXMjuyodi3fJsKRCVNJoElBxDP8lYXUhYmXsIRk/2E4al2RpeYv2n9iA==@openvz.org X-Gm-Message-State: APuU4Z/iCvg97k5+UUtkBAVf7WvaeEQoPN1ZKd3QiwC+IFWF+LPx5YZy xfR9y6AEkNFIgxywS0un5lgUY/zNhrX1l+w3S1X6l62XssVFt/1OYE5RMv2X7QK8z28XiPMKSxB W8D6W3jlnl7q+O381HE0oofen/59uxbfj7Pq8T2S8NE7Z8vGCDXs4ig== X-Gm-Gg: AYBFou0Ezzhi9a0biFCb5ty2DUj8XZxZEAry/q6QCnfZjlAsqhhBCsakwV4HCndVQ9H 5uomN4EvSf7cio6KG3ZHiP3MNaRXkVFIF2Y3uueSQwhhSXPXM11l23BRW9uPMB12l8EcDNiZieB oxLqUnJapJlnSEDAPuH7sRPeUYf8cmN7Hum6WmcwO+MGGrOb+AVh20ZVuUhVo9/l6X2aveNxLvu 46/+GjJDm4j8ti9KzPZp4W8FpjOda02fONIP5s5DzSFNf3mxz8LrhG80DNZ5GjIjyuJh9oHtXkG qHrGVwkd1H34mz725dA0tSJWx5ZsotkAHFP7l/maqI4dwSictcNIGAQy3r1jBDfYbivp05VYH9V 8QG3kLDOaIB6CvReS X-Received: by 2002:adf:e008:0:20b0:48e:6f76:de98 with SMTP id ffacd0b85a97d-49c71e3e1c0mr6191430f8f.9.1794598906859; Fri, 13 Nov 2026 11:41:46 -0800 (PST) X-Received: by 2002:adf:e008:0:20b0:48e:6f76:de98 with SMTP id ffacd0b85a97d-49c71e3e1c0mr6191412f8f.9.1794598906357; Fri, 13 Nov 2026 11:41:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794598906; cv=none; d=google.com; s=arc-20260327; b=Si3A1oyX6DZ15paVlZka1MUsSNn8O/1I0iF7VHpIjjJeer2zt8rpZl+E5B2QZZIVhB BJHyS0xd5aF9B+5q+NKBE1bWzDVSBdRDau/TK3A9TmNlAdsMhQcp4sjVDleMIFoL1/uy gmpIHx6JMLlX6l0JK2/SQI5J/HSneQ8AIK9Q0jTMzR8zshGw+lM3DYXQdc8Msc3BvH76 Igkqo1ZFZhlDkY/nP3IqvAXDIzae5880F45tQms/jKvv252uDiJ6VJciX5CeaORQMJnx Fbl9acTvTYb4pGSM/rDSA+L5wDvXoktaeRj8qS9qVc2kV4OIt7kExiS/PSgdArwJ/QqH mNQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=rsTzpIeeu73YKwlZSc3jQGi2JWz6EhRzxWlT4PmPpuc=; fh=D+fpfNE3eS/JDEf1ElWXHuM/4IOsf9Zyu3iteEH/Ms0=; b=UY6O46K4zih5dzaYQZasZ6wuxa5umNBmXPFRyX+iseGhWwPY+Oi0NVV5++N4m5Epxu PaVOoqgAihiv7H5l0I34W/aa8CTpJwzYKLqj0Z/RBihg15/XMUU58o4+OXAPjI9Se+Dd zBj/QSGdbLhK4a/hKtadVUo74tnBdqh5Rn/D00ETGQuaOhn3DsWO+BiuTpn7QpYS0AkF 9+3mkO1RTJqVHtI88/yjyQwJodt+d3mJ2chkZqSqv5NoNciRqCfn6+5LFK1cegL0LiVq Syi6qSox2AURqmaWxDXcogE8m7xxQCiQAJp0tWD7xSi9R1xBf4ckfeVxZ7TIqVkbaq+t lWig==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=AHKlHMNK; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c64fd6a84si7266898f8f.473.2026.11.13.11.41.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2026 11:41:46 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=AHKlHMNK; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=rsTzpIeeu73YKwlZSc3jQGi2JWz6EhRzxWlT4PmPpuc=; b=AHKlHMNKPWt6 EUSqASmrtvUU1/c3cW9y3s5NU36c19cJBd8MEbYzyBiE1GjwskHe7i7HykqvNKZ8hhuewt9Jies+J IQsgnXJVWhslYitZIb9o2VW9fqmSJL/1/txXpsdKNOLJBYNe8B90yA8Y/5A9acLLkFzsfAsAMCoZM Ad/JwmFe6tlIbNCRWX97mjpSVZzZCENnDVNsXprY0iSpvHeQRp5bNcmsto1WdCpFp7IPAeM6u+wZK kENWqwtVKho3to5HeOmerfYduPQUJfB61yuQT53OwWJJVlA07vJkTeFPykATNnLbiJlimy05eKNBS YJ/tY6W4FytP7ycejs1TPg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRx5T-00GMcb-06; Fri, 13 Nov 2026 20:41:41 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Pavel Tikhomirov In-Reply-To: <20261113-pr-ptikhomirov-vstor-154129-aio-pseudosuper-ring-v1-0-7d35d143fdc3@virtuozzo.com> References: <20261113-pr-ptikhomirov-vstor-154129-aio-pseudosuper-ring-v1-0-7d35d143fdc3@virtuozzo.com> Date: Fri, 13 Nov 2026 20:41:41 +0100 Message-Id: <179459890134.57567.3765669749365305224.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1953; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=qHHiDY16x+YSmlhdf6MqkR0PyzGlrTCTZBm6bdVJDKU=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq92f2sBqqp+icFMn42NQFUfHP7C7+yVA2NufM9 pOShjRtCw6JAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavdn9gAKCRBRlgpH+WFc KkQpD/0TUqqVD1B0ApgOzkKyCkNPazv9gWsXdVc6oP4UfFaqxLMXlT6jSByonu0qvX0ksMTAfmk FTtWBPMGWfUwW3CC3bojoV3IlkGlmjN4+JWJBbDhpReDdTSGPfll3rYcfGCdj28dYl+MjNyRXId Tgo+r+NfGpHtOjd0jDtZ/tq7tli8t3P7AlWY6+QMzTuWCdrRGe+AaFU6BM4S+y5jGdNFWQkh1rC xWcMSVD3I708CE5QH2LlK/Y/hs45RJ7AFsa9A6TMlYKL96auBB5z76prkCcmdQZ1haCdxAsdl0Q X3Xv6UBp4tb1kMC8bztXX/IQMu+rIeXYQbjsxHTBYgJz98CFXh2tjjjO1Qs7ifIBVljjhi2d8JK z/dLh3Xi3RaSED33zUh0fExvG5ZsnkN3DxcHNMMG8b1tgD7vF3kFXVHwwe71DREKlxb3dNUhgVI qPIEjCnAT+mon+0m/6SPzDa7BR3W+X9kywvQdqZ1zkBuhSQ/zmE4/noHbwuF5TT+1PokeDbjoDc TBzXIdGO4ilCCTTnGuQ80LaMAnrYontEqNKQCUkZi5g7sEXTAVHx8sECe5rIp1F13rYTVvS8f7N d1Ot31p2Jasv3jB5MnN3sbeuuH6fyzdEg7Bl+8HUGwiHZfVrKJFlXHl+LL1h31gUQmThVIIQGqp zMqaHIbx9k3PF7A== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 0/2] fs/aio: fix CT migration with AIO to a node with more CPUs X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On Fri, 13 Nov 2026 16:08:43 +0100, Pavel Tikhomirov wrote: > Pavel Tikhomirov (2): > fs/aio: restore the AIO ring of the dumped size in a pseudosuper VE > selftests/ve: check the AIO ring size in a pseudosuper VE The ring sizing is right: with the CPU heuristic skipped, CRIU's (nr - 2) / 2 gets back the dumped ring for any page count and CPU counts, and the host, running CTs and restores to a node with fewer CPUs are unchanged. What to change for v2: 1. Patch 1, code: a restored ring below this node's minimum must not lose slots in the per-CPU caches. E.g. mark such a context in ioctx_alloc() and let put_reqs_available() and __get_reqs_available() use ctx->reqs_available directly for it. If you keep the cache, the commit message must state the real bound instead of "slightly less reliable". 2. Patch 1, commit message and comment: the VE is pseudosuper not only for the restore. vzctl sets ve.pseudosuper on every CT start and clears it just before it execs init. Say "while the CT is being started or restored", or similar. 3. Patch 1, commit message: say what fails without the patch: CRIU's restore_aio_ring() reports "wrong aio" and the migration is aborted. 4. Patch 2: read the CPU count from /sys/devices/system/cpu/possible, the mask the kernel uses, not sysconf(_SC_NPROCESSORS_CONF). 5. Patch 2: do not leave the VE cgroup behind when FIXTURE_SETUP fails after make_ve(), and use ASSERT_EQ for set_pseudosuper(). Separate patches, not needed for v2 (I created a task): 1. vz misses mainline b44341e39d856 ("aio: avoid request count overflow in ioctx_alloc()"), which touches the lines next to patch 1. https://virtuozzo.atlassian.net/browse/VSTOR-155110 Details are in the replies to the patches. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel