From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 65A328017D for ; Fri, 13 Nov 2026 19:50:55 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADJmZXC019516; Fri, 13 Nov 2026 22:48:36 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADJmZXC019516 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="wE/BR6J+" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADJmYBI019496 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Fri, 13 Nov 2026 22:48:34 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADJmYBI019496 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48e0461e040so1111650f8f.0 for ; Fri, 13 Nov 2026 11:48:34 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErFzDEEDVblAQbRzPIO6QU/XcCmVbe3nLcVvP2c+jhguMiNQhdbyoBS4vNkNAcf/apdmSElI0g==@openvz.org X-Gm-Message-State: APuU4Z/8yPX6pEDdivFZkrXidyUFruwwUB8uNAVfC060/26VkMHo6/o8 pSsFulJ7aqdHkZ49ArhEWMpPD0FKdTL3WDlVvJdxKHmpT+UAr8hs0RdvTN05M3wPtD55pAl8Wkr k+yAGJdWeHYNZv+fXXhLsyRdirV2QbChbccpOmzBU2DKhZ2v9X2cNeA== X-Gm-Gg: AYBFou3CE7Z4Ct/HXCTzF0GrCij/esZ7+rcLDIPkPheefW6StG1JNYk94oUHM48b077 FIx5irbOPnQXIDI4y7MShfaDsTwfrDKOKDWuyuYoVoui298ukBWzcPqh4p4M2ORTCBoEGUc8qlP DlhH7D7spbIEZ3SslNA/74Q14NEmQcjWzD/MV1hANrhDwCY5w9pKk2WHlqL+c3IytO5DK2nWRaW VQVEHoW3v80MC9SwPGUTyY9rOZboguXJIOVmIo/pQSoZQluPz3+NVY+anMI4j6d/a2bbLpHiR2+ oao8jYyxiGvYfA9V56AfV+3R1EEQq3rwYcCjXx9/IY0L2NXqvG7wENqIjkuYG+UNAgWTUMgJ2Lc oIGdImhw3CBvc3iHG X-Received: by 2002:a05:6000:25c3:b0:49d:7e8c:e8a2 with SMTP id ffacd0b85a97d-49d7e8cea6emr3361467f8f.33.1794599314061; Fri, 13 Nov 2026 11:48:34 -0800 (PST) X-Received: by 2002:a05:6000:25c3:b0:49d:7e8c:e8a2 with SMTP id ffacd0b85a97d-49d7e8cea6emr3361423f8f.33.1794599313584; Fri, 13 Nov 2026 11:48:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794599313; cv=none; d=google.com; s=arc-20260327; b=bpr7i8Krp4JyxLosKF7TBZ5F2Fkg3u7PvUm1rKdugWSRLzdLMkrCG3CqBODxWUZBNw n2stX+OdCWDKht04xsh7LAyBv56GYupW8sKxZGPkFnn/eJmmCyPs9oLgCg7rPUIY6j9i GxAx7GVPBoErTIjbZYwilbdJJp75Of1+uQgrjfc5gRa9TDpTiA2PwI4DmnJSmlUXlmVY 6sEUzVnPGl2cbVGWktJ/MuLMg75CT1vzxSm2z7qe24MQ3JelINqT2moFhprqhHTIU8Tb bjYWHAGtvuaa1OoSXnbXhz7q7Kl+Whbb6ukUdPpxmZMHxVdUdE3m6063vk7edUpqjDac ExEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=Ct48qcCfNSEgY7fYJu34FkH7zDONaPHPJrVtgxyDq2o=; fh=NNIHAR0oQq9xcHtG6fvuNrouibWQy9PtHjAIRR7/XzE=; b=Mr3pgp7pAKcd3qZtjmlVN97MSB9g8mmWOnJDwsj6/8KbD7kYTDXQp9B6XfiSCR3p7O acXA68YA8vUZX3vBsELRmIAApnkKuhgdFmtdO7fYmvZwTZKzu39cV2seOfmp47avJ8QU r4+3gMq/r/oBDcJ82iu7ZgJC7/aHQuQoB1aUADGO4e073bTyD7ib7k51RVDt7d7hnJmm cq+TEySkOh4gK7pC4oC9sBUfRhgIya8TBeCX3G1xe7YBOCp+SWtE60YGVsce/blI/TCs R/vipJHf0f3BWSO3biYo/5LNGiQgFuigCYVNJ4Kk8jNnw9l053QrBRGtYYJWGnKZ/6xp +RUQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="wE/BR6J+"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c6482b55asi7613898f8f.339.2026.11.13.11.48.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2026 11:48:33 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="wE/BR6J+"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=Ct48qcCfNSEgY7fYJu34FkH7zDONaPHPJrVtgxyDq2o=; b=wE/BR6J+txS2 zNmR0VP6PC0DJUZYYKoThLIckThUW8bfT9JwczsZ/nmSq+JthjyGx0n+8gcxy0/U2MSLcxysfG2r/ iQQYQrYLmLOP1OgGUswbSHSeDhC7mFW6ySyuqKx9BOnh/K0elcv00e1+3FyncKsywJlHBpNx7LuwJ Xf7fuOdIbDrUPA9fCtQGXGU/qltOAl+XEFCsPTBNPtpyaXRh9GZi/rMMPjC7lyIdVcTLDjU9OyEXN TGw5k+xea9A5zhnI/Xm0DNUYKRy59Jg9GPNxNQuYf/tPuHdDXxHTd3EcLkgaqgOj0uaZ4eYqKro5Q S5GtfqLYaCXLhPpkNaAeJQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRxC2-00GU0E-0s; Fri, 13 Nov 2026 20:48:28 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Andrey Zhadchenko In-Reply-To: <20261113111126.793039-1-andrey.zhadchenko@virtuozzo.com> References: <20261113111126.793039-1-andrey.zhadchenko@virtuozzo.com> Date: Fri, 13 Nov 2026 20:48:27 +0100 Message-Id: <179459930734.57567.988092059411650557.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1847; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=++AAJPkHLHhyaVvb39VZBAJPrVVR7rYfvJop3PQOWMU=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq92mMTpIWtmamEp76sDGHFpePjOKENncrNIt2B wZFX1mvlNaJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavdpjAAKCRBRlgpH+WFc KtwLD/98TyDSVW+qXr/jc0WChbZDgn4cZnZBcjZ9HMWVg3YbWeIVurHCw9u6zKu7a51V0KAFpN+ sn8Ob0XdG75vnEVFrV1uPjh3eAK1x8BJTJzyNXga8pJpQixw5xmGcTa7qWCCrrothkZVQW2XPBG dRPs00jrPxD9HlYnotCCPu+D8jOs+pcwzoVmiCVWNsfwflNp1P8Q9hyJc8xiTezhASgy5Rzizmg CZH8C9GwRHnhPg5gN9QaLQaMiyFO6CNFWcd8JAL+0uJXoBdofEczV53OESSFlP+wbCUzLuhUOfz na5JAXbr7KBVJvAQlyJXc4lP1I/J+Xi4O/GCTT3Nbdti2lY4FKWeHuVdTL87SNl0fSS/J8DFteL JQ5/Iruhwh/YTZd9BQFRhPksYF0BpgK0i/5IXos3ch4jtAPJbyx76uCDRhGeRZLS7hGtHV/U90/ TVaTnyyCgyrP+lxxEbDdFhr+MjHGIrQDEFVUazwDY49Ws1aWyXJNp3Bt5r1j2MCMZB2zUZXCwd5 wQnHwRTZFPCyJd/HDmH/eCRFN7OgGHI+wU9M8/d7uamoVF79lQ0mIZlUX0Va3TBdO74KbigVvO0 RBjDwPju5vc6pjGKYjSd+LGiMIZEBS8EILb7lF9VHrcUivmSXmgiGOI72VdolRCk4I6QIfsm95L zFtVrzUDBQmBIMw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 0/8] dm-qcow2: per-qio fast path X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I have reviewed v3: no objections to the code, but a few texts need changing, see below. I can change them myself when applying the patches, or you send v4 - your call, Andrey. Either way I am waiting for Alexander Ivanov's review. On Fri, 13 Nov 2026 14:11:18 +0300, Andrey Zhadchenko wrote: > Known limitation: fast path reads are not counted, and nothing pins > their cluster between the L2 parse and the data submit. Main kwork > may discard the cluster, free it and reuse it for another allocation > in that window, and a fast path read then returns the data of another > guest offset. A follow-up series fixes this: > https://virtuozzo.atlassian.net/browse/VSTOR-154659 All v2 items are done. The writer count closes the failed L2 writeback and the discard that frees a cluster under a counted write, and I found no code defect in v3. What is left is text: 1. Patch 1, commit message and the comment above __handle_md_page(): a second miss does not fail the qio. submit_read_md_page() inserts the page again and issues a new read; -EIO comes only when that insert loses a race again. 2. Patch 3, commit message: "either the fast path sees the entry cleared" becomes "either the fast path sees the index locked". 3. Patch 5 and the cover letter: VSTOR-154659 is resolved, it is the write counting already in the tree. The read race is VSTOR-154939, closed as Won't Fix. Say that it is accepted, and name VSTOR-154939 instead of a follow-up series. 4. Patch 7, commit message: add the md page read on a cache miss in parse_metadata() and the read splits in process_read_qio() to the list of sleeps, and say that punch hole waits for direct I/O on ext4 and xfs only. Details are in the replies to the patches. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel