All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v2 0/2] drivers/vhost/blk: support VIRTIO_BLK_F_WRITE_ZEROES
Date: Fri, 13 Nov 2026 20:55:17 +0100	[thread overview]
Message-ID: <179459971758.57567.14094572419799603412.b4-review@b4> (raw)
In-Reply-To: <20261113082744.2334476-1-alexander.ivanov@virtuozzo.com>

I can apply it with these fixes on my side:
- patch 1, commit message: the hang needs vhost_task workers; the
  reason for the work item; dropped the VHOST_RESET_OWNER sentence
- patch 2, commit message: the VMM paragraph says what a large
  max_write_zeroes_sectors costs and that our QEMU does not advertise
  the feature yet

On Fri, 13 Nov 2026 09:27:42 +0100, Alexander Ivanov wrote:
> Alexander Ivanov (2):
>   drivers/vhost/blk: fix a flush hang on requests completed after worker
>     kill
>   drivers/vhost/blk: support VIRTIO_BLK_F_WRITE_ZEROES

The code of both patches is fine. Details are in the replies to the
patches.

I am waiting for an ack from Andrey Zhadchenko.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

      parent reply	other threads:[~2026-11-13 19:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  8:27 Alexander Ivanov
2026-11-13  8:27 ` [Devel] [PATCH hci-8.1 v2 1/2] drivers/vhost/blk: fix a flush hang on requests completed after worker kill Alexander Ivanov
2026-11-13  8:34   ` no-reply
2026-11-13 19:55   ` Konstantin Khorenko
2026-11-13  8:27 ` [Devel] [PATCH hci-8.1 v2 2/2] drivers/vhost/blk: support VIRTIO_BLK_F_WRITE_ZEROES Alexander Ivanov
2026-11-13  8:37   ` no-reply
2026-11-13 19:55   ` Konstantin Khorenko
2026-11-13 19:55 ` Konstantin Khorenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179459971758.57567.14094572419799603412.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=alexander.ivanov@virtuozzo.com \
    --cc=devel@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.