From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id E6C80803BB for ; Mon, 16 Nov 2026 17:10:23 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGH9BQ8029053; Mon, 16 Nov 2026 20:09:12 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGH9BQ8029053 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="Y/QZtol/" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGH985w029036 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 20:09:08 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGH985w029036 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4a339a24cd1so103286f8f.0 for ; Mon, 16 Nov 2026 09:09:08 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGzoZ3Jqt8/hMMrGxsmcb5sZQ8jD7cYFZ5H7QPuFDzOrbQsz3RSVlBVgGaXlrve4rvz8GBmvg==@openvz.org X-Gm-Message-State: APuU4Z+5GwoRiFELAg7b33+6e6XDJq7asAe1D0jm/OKDMDQSf/zA+Ktp X+pAZHkPKudcpHG+1BsL86Z+a6cq1dP6ISFERDCqFr7Rz+9U3OIVzTybtj1r/x1fYtPHLJLjfG2 RmmboLMcnIhctRvrWZA9s5PEf/cxgHgFp3xraYrPqkbhu/Zvr9DLcJg== X-Gm-Gg: AZFdTZfDZE29rP9IsCKoldDcjRtrIex4IdoXjkaMGVJdBta95DkZhAHHaXlQaP9BN63 uOTRhvNTsUINFJ3YtPW8OI8vlTvZVTdxQC5oNfz/T/vuRa2aje/33016f+91QGIbhukq9IpdKUj RpI/PMj6jJxkbZlGdw8fEQ6JdDe+xPcYudaeuMZKXOla844Tj24IFY9Equh0D56Qj7IHRJUcIh5 vugqfsX4VtwtCNyZCf+p5gClUqwSyz+xZKSMVexO9kWKpBbb6CXHpoLncitEvDkPH+C8yNGvekI zELBW90LUnVJwULa/QHDSe5Lmlnn+bguuvBZKWSQNnrOTGCnrjbzdYf8RJknaK2ZSgBMKF47503 bN8RdRdK1hy9x6Ev5Gg== X-Received: by 2002:a05:6000:29cf:b0:497:9e2a:b1e with SMTP id ffacd0b85a97d-49c712ac8f8mr13898509f8f.9.1794848948143; Mon, 16 Nov 2026 09:09:08 -0800 (PST) X-Received: by 2002:a05:6000:29cf:b0:497:9e2a:b1e with SMTP id ffacd0b85a97d-49c712ac8f8mr13898457f8f.9.1794848947613; Mon, 16 Nov 2026 09:09:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794848947; cv=none; d=google.com; s=arc-20260327; b=nBxdDcY5jcb+o+ulIw1Y3aGebPaVhoKqHq+tWvaa7NpBsvJWGtiX6MNSE82Ux13mSe PqKlI7C4o/U1VEdEuNHZdI10w6CdbQ5Z6NYS452G5ib1xBeXEnuuSf0scJixKWQPPBbF 67VfcomUdVPW1phC8ililmRVvpObYdgU4G5yWhf/JSOBgp+mLzhDJR5VQcV5WKxwBw04 JzAb+yKdE2W8Fvk3KlWIuMZrn/j9qdyKdUie47y9XBModj1J5yjwEk/glY2qcYD1+wze QdAGO8so3hgJNw6oJK0Dpx6KWqYvWoD0uO2NC9vwLSPmWtv9ovXTdYj43bNYrYtN2JOy XsGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=zLwiu2P9T99+wJwPkBoVVAdLyby1CrcJX0WVuzTjf50=; fh=CTF2GHyV+XdzB5TROrdG4fdLri6JSHNOBC+LNuNq5bA=; b=Zxrt5mN/oPGTr5qtISMq/Ofi+rD/8OpP7YQyjMM8Oe1HXSX4zo3dkIPGOhKUHI9nc9 EuohgFKm0hSzhgzUyPV5f6ynCeCoyNqhzFR4OL548q44wuYEzdgiPmYLbHB1+d9qnz/b RhjmRavlyNzTSEYvb0bzfKic0iocwr4JtjliICwAeX95mDO5AYGo9BVl/+Fb5jfN9qHf wDwhrQxMB/h7lLltYIjyk3bQnBGNUH0C8RvPolypHrflMsiOQO9FqImqtHM4MDaT7NPE tdKflAirAqFW3iADrJgWqisd5tR1MlLZpyhASIHOTG2R7B/42qjEx0j53F5YhExobKVJ 9wNQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="Y/QZtol/"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c6312278dsi22497705f8f.74.2026.11.16.09.09.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 09:09:07 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="Y/QZtol/"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=zLwiu2P9T99+wJwPkBoVVAdLyby1CrcJX0WVuzTjf50=; b=Y/QZtol/Bxi5 ljGRipWkhM9WKfThb5VtlLWqYYqoJmonBfZLac0shAhevLwXm0MGIuVJjghLeplqhqg+BLE3CB16h H/dG5f5HYqCP9egllaIiSlbGiuG7ll/hUd4S6lYtHmxOQEX/v5tiIBNnTwq7kUN6dod5SiFrOvehM yQKPc1/Wy4a6QAuGigMBWwaIrFsKfSeC8oePfNt4EmD+4t5alZgVvyTo+49FmKiF6x44JV569BRjh 0rmJHWOd/VhdkhzjhQVC5g9Shz9HiFg+PxXA9ihF8jdH1tQ5Nff1k+uu9lztoWhFXR7ADptS+l56x egoDo3LjuWnKOcnISueHxg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xT08J-007YjK-2w; Mon, 16 Nov 2026 18:08:58 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Eva Kurchatova In-Reply-To: <20261116035204.564416-1-eva.kurchatova@virtuozzo.com> References: <20261116035204.564416-1-eva.kurchatova@virtuozzo.com> Date: Mon, 16 Nov 2026 18:09:04 +0100 Message-Id: <179484894400.861498.16940306217017869314.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1928; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=NPOS12+jmdwNVGQyEgW2lNc2q8juuvGQgriUvIXkEm0=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq+zix//Z+Ne07iW8+FIql0nwcsnqabwsIllz3k LhJIGQJonWJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavs4sQAKCRBRlgpH+WFc KupZEACTm5rMRkZEOB/BoRIqhgGtGCT/W7H+lIqIlGqCmxAw9TUE8dBoVc2lABYWIUiCYKpGG/o +KErQMaCbzG3iI41in0uY3IWLQF17Tt9V4BPR4xZ8Q26r0/AUQQ6m+iux4T+ug2lgetdgR4Oq8u RdaCjbMmIQRJJUnP8dnjmMSAjCp76OWwZaR6bm47CcJgDzANLXrC+jbPS1frnXToAMvCvB3jJhO I/FRoOUq31qg9XGMJ3Jaqv5QCLe6pWRaHQumloia5Vj8ocfI1l0XXG0CADdqAB9feI9L866yohr cjWIgz4BDmQS4icMKUa4SMv4Y77ADZaEgwNI8XMg4D7wNS7kcMuKo+/aPIM1TbzXpeti2lCtj7T C0C9KJhi/EXDmAb+285ZL7WY2HrU6qPFrHZ3iTMSAdyRj4C0EmQsyOOm/I+HOmhCjmCZOLac4id PGf957Tsc2uSpZtbjKVXac8KvubmADTWS0tGxAb3EHTMxH2YILyGJpn7YoJ3/LKvbtaVU3TISgc NSHeORHnGB4E0G72n53qcVtCfgnHHGMqP0Z6/4TAFwtxiI/arkPiEMjfSVfoAp3O9qTWSsCeO+s XafzJFPhaA/FZpuo/Auq+DB/JT+SXyeH3ypxFzuVzLpU37Jlisbz0EMerKAgAsYUEP1z3MKzgYC 2KD6XQp1HaALusQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 00/10] ms/mptcp: stability fixes X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v3 with the changes below. On Mon, 16 Nov 2026 05:49:07 +0200, Eva Kurchatova wrote: > Changes in v2: > - Add "ms/mptcp: close TOCTOU race while computing rcv_wnd" and > "ms/mptcp: allow subflow rcv wnd to shrink before the drop over memory > limits". The backports match mainline and the rebase notes are accurate. What to change for v3: 1. Add mainline 2834f8edd74d5 ("mptcp: cleanup fallback dummy mapping generation") before patch 7. Without it, a drop by patch 7 followed by a fallback to TCP silently cuts bytes out of the stream. 2. Patch 6: say in a rebase note that mainline 0e24d17bd9668 ("tcp: implement RFC 7323 window retraction receiver requirements"), which it sits on in mainline, is not taken, as in 6.12.y. 3. Cover letter: item 2 of my v1 reply is still open. Say what the series fixes (endless retransmission with csum, receive stalls under memory pressure), which patches are only prerequisites, what was left out of the mainline series and why, and how it was tested. Also bring back the Jira link, name the base of the rebase, and close the quote after "allow subflow rcv wnd to shrink". Separate patches, not needed for v3; I created a task for each: 1. Already in the base: when sk_rmem_schedule() fails in __mptcp_move_skb() (tcp_mem limit, memcg charge in a container), TCP-acked data is dropped even on a fallback socket, and the next bytes take its place in the stream. Mainline removed that drop with 9db5b3cec4ec ("mptcp: borrow forward memory from subflow"). https://virtuozzo.atlassian.net/browse/VSTOR-155321 2. Four Cc stable mptcp fixes this tree lacks: 42064de57fb83, f3ef03357396d, 85c580b0d8590, 0981f90e1a05. https://virtuozzo.atlassian.net/browse/VSTOR-155322 -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel