From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id A6EBD8017D for ; Mon, 16 Nov 2026 17:14:58 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGHDlig029150; Mon, 16 Nov 2026 20:13:47 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGHDlig029150 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="HNcHI+G0" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGHDbvY029121 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 20:13:37 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGHDbvY029121 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4ad3d35e899so26945785e9.1 for ; Mon, 16 Nov 2026 09:13:37 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErEiZRcXTheGZ+LkkHKPMMfn8hQFIOggxIXFyStUd5JUUI7z99pKSp93xcLeDs+JYnBkn9BiHA==@openvz.org X-Gm-Message-State: APuU4Z8B+eaip1L9daXkZsKE6ONarz3iEgzMyIC1nYFYe/9FB2EddN4E ionGP+Xd/w/y/kLofW9Ptq4rcUinY1dWUKIU/2UXiG+AHa/yaV5SO7rdhA5cjBvDLFGIHx2SoQ6 Mk/IC7k7VqWk7jWiXQReh+7ZifLDMiWOkFC71rPYa68bZRynVd3ME6g== X-Gm-Gg: AYBFou1D9MGHArSUZoNpN8zFxpVgklMGACZv3PmU4GKrpkvhanSInQev6kvsl7W3GOh zsfD7nVN9aI3+BJKc6hY1bs3QoKb2wkNGRqO/FC3NCHQTWegxSNafoPal6H9dNsYCXblJexlWyR UupSaOUvvr7w14ZzBmY3LiR7J2Z31DyyVwFQyshGNgOn8Vkk9TRqoVnMAm/jDGlvCAua2fo1OHq HuzCLTyncvpBfdJ5ZUmDM4J21tZv+Xqs3MsLiWGB2jPjURNn0mUAveRqtbiSp2NdSeW9ZRQUjda D5+BBCnkA61x0tzNzUFVFudB0roUfUWNfqdu9rBkw4nMp16I9e5R0JquAy/BrUXPO1j1gBF2lWo ungn0t44Imky2Oltx X-Received: by 2002:a05:600c:628c:b0:4a5:26b8:4507 with SMTP id 5b1f17b1804b1-4bb55a7f827mr244378275e9.21.1794849217433; Mon, 16 Nov 2026 09:13:37 -0800 (PST) X-Received: by 2002:a05:600c:628c:b0:4a5:26b8:4507 with SMTP id 5b1f17b1804b1-4bb55a7f827mr244377855e9.21.1794849217033; Mon, 16 Nov 2026 09:13:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794849217; cv=none; d=google.com; s=arc-20260327; b=YzEc4B+Zg4OB1mz4iwcQXR9wZ40UrWiLoBHGiehVUvh5zEeNAvc82DZfWQm+AFBP92 7nV2Gah+5QuXJ2qlminYTCtbokoWzOrrmL8hHnmTLnhiXLzJQsODGQoOz+KOYG3zAK8K iNyIHR18s1VSJ5vhTlc6T9tH9QgQbbF7S+nj0/husXeeENHaunyMSWyXZKTW9SAn0hs4 7A5TRQ+NC69b8K03h9FycXwZZ8JTz69UpsDIZgN0724g0mIwo1BqtshP2iW8puSgnYjL +20ksIAikCpuTKLD1z6MVgQM56N+SdBz5jpio3EQedjw58Az9xs9iSooO2P0WyTh6WpI +XLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=bVfURQiw7P/xkO84o7tNDUaXwOLaeia9VxZvwHzDi4o=; fh=e1cf8n77z2da+N1ymO/d91hfoJ+J/34ch9kWx7ws6zY=; b=gzdQaNyhekvSmqHutqqGKouWfp045xOU+8rtr2cVjnlZsqct3kvB15GqkogjqVDlWb u1LUPs5FoK93rXn2fD+L9nS+2IHHl+Hp0lG1onxM79D06g2pWyDtRGywStWceVoDqGFD dbsPugPum47WZVoeNjGenQgcCsMQNEN6SQ2Yu+0HXJ0zTCPLdje2SOy1osuzGVddKyIA vM+o6yjBRDI9kMsn3ErpcfYYAlZG2GoMeT/jNfbWqI485VqBoRLugtBYuXRpvEY13er+ oowEYHI3mQSRtn1RY/M8qc0mwF9Y+J8Fn7XtOaoMqZFCbvfeeZi3UTmN71NTpBV29d2M zi2Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=HNcHI+G0; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c64fd6582si21615295f8f.458.2026.11.16.09.13.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 09:13:37 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=HNcHI+G0; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=bVfURQiw7P/xkO84o7tNDUaXwOLaeia9VxZvwHzDi4o=; b=HNcHI+G0CnNB 1lUL6u4Z2RVJwh7MrnpMFkdNOmYZnXLivuHADbLdv9mJrmjfPyDV0q0qLuguix+v8ZYfpZ1kYdD7t 7eCeCOPhZuWhLIr3JyUNDlCAcA5FGYKXW/Fz0vf7TImzryTASkfoqvvhCyMeBH17hueyJuWTZpb9E ylwUHQjhlzbVrrta0ydcksEfDxV4SJ9RVVQAxNnShOjI2xTjC4g3+cjr9TWUXy4gCiVTvP0TcbCXf 7tMCfyWzhff85kEHFZz3Jwe1CKfD7GKVXDRmSEVaxFa2cfD//Y+D/UlhMXVgjz6WrcYTb1XLQSRBZ IbS7JuGRB1WYcDJkjF/cRQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xT0Cf-007dR4-1f; Mon, 16 Nov 2026 18:13:28 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Mirian Shilakadze In-Reply-To: <20261116061256.54472-4-mirian.shilakadze@virtuozzo.com> References: <20261116061256.54472-1-mirian.shilakadze@virtuozzo.com> <20261116061256.54472-4-mirian.shilakadze@virtuozzo.com> Date: Mon, 16 Nov 2026 18:13:33 +0100 Message-Id: <179484921366.861498.1846806750783027661.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1297; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=URiTlQoypIP3m/qlitxUZTdMRBOGwQ6c1r+LKg28bA8=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq+zm/4ELVKSiM6AHV4UHXNWuf0BGL9Z6D4JyIb Fj9fnZEZMmJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavs5vwAKCRBRlgpH+WFc KiAYEACfaPAHHmyJX0S/hTJoI5PIt0i0fkiNdCO4LOhkz85vLieiGUCfXf/J180URdTZF4BUuSZ VbH8fBfTZ6K8FLom9ZNwxLyuTRQ+klDr4PAwjuFuIKEi4vPR15v/zIyzek1x8KnVSY9tNrcx0gP 9VrP6EF0mk89xWXcHjtr6rThV9Juy8IO4jzeQwZqbdYq5R2daekrLeHG/fy9NHTjIds96DDp5T0 QIsIwPjvcVTBtY1K1N/X3I46c3JPIeH/RTjszuyzB6TIE9jvw2exdYIjhtEwnK1KkWOcmGmLInz KJJ7oK0JoTIqnH+d2voSMXPwPVFfXeEifGCbE/cg49K5V4gYSDmRh3AWOxllVGY+yjByGDVCpRg VAPIsPR6avI9qx1h2RoXrIzWMd+CpBwCMkYNVyi4YHTERfyatGX3IPdqVcjt4asHXM17VW0ECOY 7Dj1RSl+J7HZ1cahrZmGAImrFiYqyMPtugqaIqEFM9GrxH7QvEsJ0EN3wfSY6e+Gj8Qxs53Xof/ u6Un5+WhE1sQQe9LvSLxFpVqUBogP8E+6eX8AYv75sgL6oL3062m4G14dmecDlvOUfuwffEolYP iwqvw5Ltnsk8nLCRuqZubhqldMf7xr13IVcvp+kaH4dgoCkz5ICVkjf+yJDE8/vfml462622i7q 3144Cv5i9baa0Dg== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH vz10 v2 3/3] selftests/ve: test locking a mount from the host X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v3 with the changes below. On Mon, 16 Nov 2026 10:12:54 +0400, Mirian Shilakadze wrote: > +TEST_F(lock, not_recursive) > +{ > + ASSERT_EQ(0, mount(SRC, DST, NULL, MS_BIND, NULL)); > + ASSERT_EQ(-1, setattr(AT_FDCWD, DST, AT_RECURSIVE, > + MOUNT_ATTR_VE_LOCK, 0)); > + EXPECT_EQ(EINVAL, errno); > +} Items 1-3 of the cover letter reply: - Lock DST without AT_RECURSIVE first and expect 0. - Skip when not root, without user namespaces, or when the kernel lacks the lock bits. - Check that statmount() reports the locks lock_mnt_tree() raised. A kernel without the feature fails this test with EINVAL too, the unknown bits are refused before AT_RECURSIVE is looked at. That is one of the two tests the cover letter counts as passing on the stock kernel. FIXTURE_SETUP(lock) only asserts, so a run without root fails in unshare(CLONE_NEWNS), and in_ct() turns a missing user namespace or missing feature into a failure. The sibling ve tests SKIP when geteuid() is not 0. Patch 2 says statmount() reports kernel-raised locks as well; a mount copied into a new user and mount namespace shows them, and no test looks at it. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel