From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 4D616803F6 for ; Mon, 16 Nov 2026 17:21:15 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGHK0an029382; Mon, 16 Nov 2026 20:20:01 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGHK0an029382 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="lwIemV+L" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGHJwQF029378 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 20:19:58 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGHJwQF029378 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a1fdde384cso17609395e9.3 for ; Mon, 16 Nov 2026 09:19:58 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErEd/SErYnBcwNyQgGlfa+LY+65GfnicIocxvdydkuEJa/somWmuiJY9pTmLRpwMb7kq5kuGJQ==@openvz.org X-Gm-Message-State: APuU4Z8uNeH2Z//euMil/8zqCbex2N0HviPN7/e24lpQECRg9zGdMauW dmNM2mR52ckYmLQGyyjTOPxjW6X4FLqYLHvnWwgLwvNzsemxqUweWbgXgpfIfqAkR0z9evGTw4I iMQl7RFDBINXhT7ZTe+3O6BOQnMH7o5F88/otb3u4SxsJPOrOj0KOcQ== X-Gm-Gg: AYBFou2um09XLQRec95/sUS1uOqgja4G9gTNHt9t2Kbcl14XUHuSzhJkVHl1LjnimsL 3fPLygHSYgVok77pESvyQPBS4ibjNDq+dCkIfwwkkn4mPZ9nSAeX+29uKgxKCq/qDsbUpaRUqVJ xmhXLxb4hzncyswWpWfNhoumKCX1NQUhMi3733dDt5hPZyfiYIDapxgiqw0aEg6XANXemNBCu+k Kg8ubQaFPIg59vZ1YM4qZ38h9ig9xXFjjPQSt3ZePpe0RVm9xUVoS8rwoHjVVGPCiQnVNYp+Qwt HQeJaBOQJnnl81qp+HbSN8XBxLd+zDOHILW50ET0eDAlDcjSkgYf6Uh9978eNKmQM4VKKjyp97E ILFL4ZDjZVGDOZv2C X-Received: by 2002:a05:600c:1f90:b0:49f:e701:51c8 with SMTP id 5b1f17b1804b1-4bb55a57b96mr232364295e9.9.1794849597679; Mon, 16 Nov 2026 09:19:57 -0800 (PST) X-Received: by 2002:a05:600c:1f90:b0:49f:e701:51c8 with SMTP id 5b1f17b1804b1-4bb55a57b96mr232363955e9.9.1794849597232; Mon, 16 Nov 2026 09:19:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794849597; cv=none; d=google.com; s=arc-20260327; b=NxcJ6T8ybKNundgnrZf+5pXDgsdqurFLjVz8Ezy3gd3tpathbw5VXWHE/4NJJDM4Mj 70H1QruU8hcSq8Ka+rML5/nCfxrx4isoJckgbJSlEikxQLuUHZxWwuM3ukiRbZ1CgZ7y /iYyikncSzdp6UILVzHsoeTXXV/Scw1iLgw+48+wgNxuOQsTdWowRDR1CPPixUfDIrrI 1k4ALwxJ14hKuu0Cxgrf6bLe5vec+ZYyReO1t/IXKfJXJhW5DW3dMc+dWe/4Xan34TXh CnETKGCgvatV9FB+lVl+6K90EbChFRkLkurYoUi2BHLO4pa41wBS9ItYvn+HyZ2J9Sli Q76Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=uHDA+PgHOgzlfHFzlzM3R+HM/1LamokLAY6b73dzN/Q=; fh=YDx/sgeCfUIZ9eyfBjqETg92hV70ladS2omuMPCV2do=; b=nb75SwVVktt8rAM8JE1HKp+8jPWOYA+vHkZJEKYk8BrC/SOtKDqwwCeihKnx2K8jHt 0ceaE8TfKNI/D2YXr7IijSLXr7MFw5WndEIobEPeD73BZ7i2nXoRxGmV2lejn5N4asK1 ES/4tBKY11GU1xwZOwvHmu4Dcvv4wUYDV1onapp0Edc++Ms1Gkh5wEmmmG/NjJwdYyLK v61gv1Pm1GEsFF1qc2pGjC02TOO3PWJ8+T/VbOuAYx9PjsKNe6/VwOmymi3xHpiY+jkv m0R6yjRqP4vSbt7sJ0cuh/vo4ygLuLfwsP2oCY5WprZGyXAbaSWKgAzYtu4YyYaY/ZSA j0lw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=lwIemV+L; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c636eddb3si22745577f8f.176.2026.11.16.09.19.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 09:19:57 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=lwIemV+L; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=uHDA+PgHOgzlfHFzlzM3R+HM/1LamokLAY6b73dzN/Q=; b=lwIemV+LacWK gJKbGz8R6KTQl6QVwRySiB74QpjFjqNH/iu4b7NgKHq1GOXdoP0pR3JaBzRk8oE5li4hrrbJXwqHt VZBOxId1YyyOSaY0QRZ8kCzpz61kTpukj+vKoa4yDS6zGrFdtooO3hgF7zDe7lVJmweyFd/hN/XRb 2Ckt+IzaufVJhm2T4dvX7rqvDgY/76oFyIZN5H5k3eFyGUlqrr0A1E1l1dpGulJv2IjC1DcA0ZmDn KwV46Ltn3qLEA1Nuv10F1eGAWHsV6nQcD2FV/SLltE3ue4BEDvidKM5ZijvH1RLVQYhqGlSchbxzX BW05+dM7/32S5jdDu2J2Jw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xT0In-007lgD-2B; Mon, 16 Nov 2026 18:19:48 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexander Ivanov In-Reply-To: <20261116100522.2867539-1-alexander.ivanov@virtuozzo.com> References: <20261116100522.2867539-1-alexander.ivanov@virtuozzo.com> Date: Mon, 16 Nov 2026 18:19:54 +0100 Message-Id: <179484959467.861498.10599182174861519391.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1048; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=gDcIDZtdfATKqX2qd5RfeXV+r7UaWNN/yXDPLlhrRDU=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq+zs8Jvw/ro57CS1NGVTE+I2IO3klAo4ikjeCF jldA+1cQ0OJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavs7PAAKCRBRlgpH+WFc KgAiD/95i3+n+Z1MLS4VpzjG0H9zLzp7J+ULPYzkBeZIdm28pnjbCuR1pyBiBtE/x4EgVMs/gOQ VbCr+SJcaTI2jUmsxi0CnrqBqVw8Wc+7uDhlMrZ0gRao1wUuor2ZG4pimTUcSCO8lN438SGXu/c +pX3jpAauq+6/UXKm6rAxzmV3ET2myuHuJPZdEb1pP6UIfUok1IVKcyNj2G4EAskVoEnbPlcyNW kmg3BUA6MUbg/0BFlfH3Eeyn1qml+0h1wzsUdi5OBR3Zj+p/cbFYdaaGVhbzzeUWmd6917eLTB3 Av801bYPlPtC1WepcKqqVxfpJbeQsjmOowGKSktrpKHUz1VfVnRIiRg5uOAHKAbzQkRir1DYwm4 48MZJvSzD0VWDbKhJYGZjz5W7XAzf4XCXA+5sBL2KbSHhzqSf6C2pEQefut2afVwX2I4hGv1eix E6LvxEgpGqYjl2u7MtfnesfVatclhHpeqxP+1urJ58gyqH2Ie5qBc+P1yzU5lRWvesRxuq1yB1k il0ijOiYMU1lveqfJeNc1kozNTH44g1gg27IQ0VfI2FVgQsYqd+zqnin/hU2ER5YK+juvoZJqaB HOyJUHTVL6wsnp3etm6p+NHWHZL3ASQGm5DqhXSNdeyc+8Sc7NsfI3J99Lu6wo9P7hjqArGwW8e Ynoxjegr6GUdKOw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1] drivers/md/dm-qcow2: set header_length to 72 for v2 images X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying with these fixes on my side: - subject prefix "drivers/md/dm-qcow2:" -> "dm-qcow2:", as in your sibling patch and most of the driver history - added what the bug did: the walk ends on a zero word of the header, so v2 extensions were never seen - added the new behaviour: a bitmaps extension in a v2 image is now checked as on v3, and a malformed one fails the table load, while qemu warns and ignores it - added Fixes: f625cc9e0c22 ("dm-qcow2: parse bitmap extension"), which brought ext_start = hdr->header_length; 2a728299abdb, which Sashiko named, never read header_length for v2 On Mon, 16 Nov 2026 11:05:22 +0100, Alexander Ivanov wrote: > Set header_length to the size of the v2 header before the version > check, as qemu does. v3 images overwrite it from the raw header. Bitmaps need the autoclear bit, which only v3 has, so a v2 image with a bitmaps extension is not valid anyway. The stricter check is fine with me, no code change needed. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel