From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 1/4] ms/mptcp: reset rcv wnd on disconnect
Date: Tue, 17 Nov 2026 12:29:43 +0100 [thread overview]
Message-ID: <179491498385.113083.14777877272115177985.b4-review@b4> (raw)
In-Reply-To: <20261116180419.685520-4-eva.kurchatova@virtuozzo.com>
I won't apply this version, please send v2 with the changes below.
On Mon, 16 Nov 2026 20:03:01 +0200, Eva Kurchatova wrote:
> Rebase note: this tree lacks commits 2834f8edd74d ("mptcp: cleanup
> fallback dummy mapping generation") and d2000361e4dd ("mptcp: better
> mptcp-level RTT estimator"), which add the lines around the mainline
> hunk, so the reset goes after the other counters.
Item 1 of the cover letter reply: apply this on top of the stability
series and drop the note.
Why: 2834f8edd74d5 is more than context. It resets msk->ack_seq in
mptcp_disconnect(), and this patch resets rcv_wnd_sent to match it;
mptcp_set_rwin() works on the pair. With only this patch, a reused
socket that falls back to TCP before the MP handshake keeps the old
ack_seq against rcv_wnd_sent = 0, and for an ack_seq in the upper half
of the u64 range mptcp_set_rwin() takes the raise_win path and sets
tp->rcv_wnd to U32_MAX. Before the patch both values were stale but
consistent. d2000361e4dd does not touch the hunk context at all.
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-17 11:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 18:03 [Devel] [PATCH hci-8.1 0/4] ms/mptcp: backport cc-stable fixes Eva Kurchatova
2026-11-16 18:03 ` [Devel] [PATCH hci-8.1 1/4] ms/mptcp: reset rcv wnd on disconnect Eva Kurchatova
2026-11-16 18:09 ` no-reply
2026-11-17 11:29 ` Konstantin Khorenko [this message]
2026-11-16 18:03 ` [Devel] [PATCH hci-8.1 2/4] ms/mptcp: prevent race between disconnect() and rtx Eva Kurchatova
2026-11-16 18:08 ` no-reply
2026-11-17 11:29 ` Konstantin Khorenko
2026-11-16 18:03 ` [Devel] [PATCH hci-8.1 3/4] ms/mptcp: close race between scheduler and state change Eva Kurchatova
2026-11-16 18:10 ` no-reply
2026-11-16 18:03 ` [Devel] [PATCH hci-8.1 4/4] ms/mptcp: fix bad accounting in __mptcp_subflow_push_pending() Eva Kurchatova
2026-11-16 18:10 ` no-reply
2026-11-17 11:29 ` [Devel] [PATCH hci-8.1 0/4] ms/mptcp: backport cc-stable fixes Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179491498385.113083.14777877272115177985.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=devel@openvz.org \
--cc=eva.kurchatova@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.