From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 56826803F6 for ; Tue, 17 Nov 2026 13:52:10 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHDooTr009692; Tue, 17 Nov 2026 16:50:51 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHDooTr009692 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="H63mR3Yc" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHDomp1009685 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 17 Nov 2026 16:50:49 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHDomp1009685 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-49337a224a8so3146164f8f.3 for ; Tue, 17 Nov 2026 05:50:49 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErG7Jbz23erLnVDHMtWbt58AVFV2s+GA/GfCjFrIavGwQHH7l9C1azouJ/LjyncmJLBaLXeVxQ==@openvz.org X-Gm-Message-State: APuU4Z9XOO4M4ZQBXRH1uew7Aou/8hAGsA4/mlYbLNmiJYGAf0EiilZr qFVI7BtZ1BA/3wyuQNeMGPs6LT4Tkjjm2jE7wqaFAPsE6bcryuqubTSzDgiMi9C7xFzEzQzmIpr soP8nl7SOXez6ys5b6qUYxfyyxMGaAV+2uqmMk1XD7QP0M67FXJaXGA== X-Gm-Gg: AZFdTZcVMi49RQ1kD+QmhIzHIJur75eJZwcnw4ozfgJLmHgzM135TPkeNTfEVfz5TX9 qbnXdbNbg4r/QOuJl/4VbnjuN4UCvY8iCqFOm1LaCO+UYJmNvMmPunDXIi83iABgrACaLFX0U/n QGFWNY9i8KWNZpPIvLBotCvyO+tauFMvyGKPvvReC8zhtho/Jicu1QkB7ANQ8dsAo1Bar4yHE80 u0ElljDYb4ROXM5tAYsF93zI/vBgpHQd+fEpKpelSitgXqQVCJ5YdZGDjbhKJS/XBfyi0WQyb0z vrwW86yqAUINTt2muWSHvIeHnpBIn0bxMYhC4fSnUeVN/eR9qy2AhcLBMJ0V3ZGp2fDHJKamnG+ 4ydXQmsqr718q2eDA X-Received: by 2002:a05:6000:1a8c:b0:4a2:ee0f:4fa3 with SMTP id ffacd0b85a97d-4a2ee0f504fmr8545965f8f.8.1794923448571; Tue, 17 Nov 2026 05:50:48 -0800 (PST) X-Received: by 2002:a05:6000:1a8c:b0:4a2:ee0f:4fa3 with SMTP id ffacd0b85a97d-4a2ee0f504fmr8545889f8f.8.1794923447982; Tue, 17 Nov 2026 05:50:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794923447; cv=none; d=google.com; s=arc-20260327; b=ewlncsbcKQKVrx2n1rjHcufGBvVHymPJUby8qZxhlRUl7znAucKtmLHso2g9CBJyDf RPc1LCxmkXK75la1Md/FHeAGYuyxWU6QU7KyG8eh1sUip1874MyPG5zBFSv6ZnvwM6Md KDBz6VpoFRU5Qmizol3kXoNKnuIkucFTLZ69XJRQg6LVPYQX3GJTj8PAAwe0sUQa9fwT aLqh5CzO2vcxvlJ0D3IRm+IFSJYo0jtH8nlemOC3C8xK/ZrehVimdBNNMDGEN5Uslvwk FOrm42/7teRVvZSL4XZVndNhz1VUtVlZz0Aj8MSBhvcjs14UszTgL0ZB7QPhLJdcv+ZV 6HaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=eqz5uJrSz9UhXexkXRQAeM5cQdGAnRmWykIcyvWnyS4=; fh=YDx/sgeCfUIZ9eyfBjqETg92hV70ladS2omuMPCV2do=; b=kXg1xhcWcT1vLRQn2Zbc7JQzID89MUZI+m+6vmiwkdhxqh7cKo0nG5FKTSrweqvpPq bRSslGn3H/b5rN3IqG1OCt9wdSa9dEZrT7Qu9kLfAqeJkUiJkU823tgho3weU2nkzZZf cqOybyMV2/s1DndQn2IdhvM0sZ23mdALzMsqoH9O39X/DH4XYiNYj1jb51htLpfavSyp cnUf2Uxpu9uHNbKbfChNKtL9iFptpEWTffrDJRH9UNTrQs4fomqWHyYlOtQh9RvyXGCw lSwA384t6htrNDDjmyZQRUc7wGkORXQra4rAQvqTbpjdgMhrFdXQIuYTFBgNHn4eS+Fm 7QNg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=H63mR3Yc; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c63122497si29125287f8f.146.2026.11.17.05.50.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 05:50:47 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=H63mR3Yc; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=eqz5uJrSz9UhXexkXRQAeM5cQdGAnRmWykIcyvWnyS4=; b=H63mR3YcC94k UNLefbBCEd70sW3XWaSU4ib15fU0R+K0w2hjrolQPsPM5ypYmXujC6aijo8ASVQ2AF6Wq2KF5RE/9 cf3+TfCxAbt3vXVO88+bAiTWCCQ8UC4mgUGiSPbgz2E+5yqqSVlTXt0kMh6Wvvv2Kk1HRVZQdbvJv UOWGBuwgwTCa7f3PgK5p0cZ0M/7td1T9yE3JgEO1nx9ENgci8P2l0nxzTZ6XOR1cFOyU8ntPcAW8F UXp43eTpitiXAcmQiAHOdNHj6GiNNsflaXZtC3GT0+lmqziA8c9deNBmU0XwIe3HAtjf0//gy+YYI 48Ae8Jh8UiPSbz0wzKQB0w==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xTJVu-00DTKe-1u; Tue, 17 Nov 2026 14:50:37 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexander Ivanov In-Reply-To: <20261117100904.3071306-1-alexander.ivanov@virtuozzo.com> References: <20261117100904.3071306-1-alexander.ivanov@virtuozzo.com> Date: Tue, 17 Nov 2026 14:50:46 +0100 Message-Id: <179492344616.136195.11233301242407029938.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2046; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=5qjhfz8woZ+EmovMeKsGEkwHTRQPfy2NwMC46aqEQKU=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq/Fu2sdNMFNsqHUQ/ztKni1KgnVciXRlLRoyGk xVZSkW4ijyJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavxbtgAKCRBRlgpH+WFc Krc1EACB3gDVmBS+niF49j/VATQjRwRJWgOCO15ZZt2734fNPsC39QYVHAz3yt+5fj1Z7x5OAGC 2LqUU0rOZNXdnc+Cfc48rLNbIt0oaKxqSEmbKzoGco0lDaZaJjiNzg6ACbnBNh8rr1iMZh1X2Xl rYOqQubaHKv/L6VI03leGC+up07WqQEpmGXbBUNuvEZNHfLcV9z2NDQGCB7EDpqg5uizXWEO0+a aSl7coQLeSdSwBnTxGRvzByQEwI35f8tMGC1W7c4ZmxeaCrLjon/WlRoDKG/AJqgEbyy/AcAUWZ oHLdvlgmBixdImUcP1jkYPb55bjUHv5P82hPALrUmGq3ADPracikWH1uuT31ev8s0U7COHfIIFz szLzDLxZIiCv7GTWPzBUApiY6ZDqaKYwfpiG/geGNeOHUxD2XGgoMcgUxhVpnP5GpIBJW2N5nVj dYifthtAWcwFxpKtevXdn+iKQLsowqHHAdtnObN2G+RyicQus6+GMTSmoptdgLUrz8sX/fpUYdT 4DAnXzKBuR5TuhEPF5vlWKpBXucGkp0AQIiOW9Epww5UukCojbWFUX1hPvrRnrWRqZLhB30j0CS CpubmUM95oJX/vBMdrOl+UCM8ipIHyAOGhKlAtEF1uHa8+GTHS2yrp4uK9TN5FS/ur3TawSNTCl hgsGyumHhWuHNFA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 0/2] drivers/vhost/blk: support VIRTIO_BLK_F_WRITE_ZEROES X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v4 with the changes below. 1. Patch 2: take the shape Andrey asked for in his reply to 2/2: one REQ_OP_WRITE_ZEROES bio per request, no zero-page fallback, no chunks, no vhost_blk_retry_zeroes(). 2. Patch 2: keep the request checks: the feature negotiated, exactly one segment, known flags only, alignment to the logical block size, a read-only backend, the range inside the device. 3. Patch 2: keep the cap at UINT_MAX >> SECTOR_SHIFT and also reject a range above bdev_write_zeroes_sectors() with VIRTIO_BLK_S_IOERR. 4. Patch 2: a backend without WRITE ZEROES (limit 0) gets VIRTIO_BLK_S_IOERR, not a fallback. 5. Patch 2 message: say that the VMM advertises the feature only for a backend with WRITE ZEROES and sets max_write_zeroes_sectors from it. 6. Patch 1 stays as it is. On Tue, 17 Nov 2026 11:09:02 +0100, Alexander Ivanov wrote: > Alexander Ivanov (2): > drivers/vhost/blk: fix a flush hang on requests completed after worker > kill > drivers/vhost/blk: support VIRTIO_BLK_F_WRITE_ZEROES 1. I agree with Andrey. Once the VMM advertises the feature only for a backend that has WRITE ZEROES, the zero-page path and the retry are never taken. My v1 ask for small zero-page chunks goes away with them. 3. num_sectors is 32 bits, so a guest can ask for almost 2 TiB, while bi_size of one bio is an unsigned int in bytes. This check is needed, not optional: without it such a request wraps bi_size. 4. A Linux guest then gets -EIO from BLKZEROOUT and does not fall back to writing zeroes itself. So the VMM has to keep the condition true when it sets another backend after feature negotiation. Note on dm-qcow2: it has no REQ_OP_WRITE_ZEROES today. It does not set num_write_zeroes_bios, so dm sets max_write_zeroes_sectors to 0 and the VMM will not advertise the feature on it. The feature starts working on dm-qcow2 only once dm-qcow2 handles WRITE ZEROES. Thanks. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel