From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id A2158803BB for ; Tue, 17 Nov 2026 14:50:24 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHEnBTS010089; Tue, 17 Nov 2026 17:49:12 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHEnBTS010089 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="A/OhtL0U" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHEn5BI010076 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 17 Nov 2026 17:49:05 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHEn5BI010076 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48e00f3929bso603828f8f.0 for ; Tue, 17 Nov 2026 06:49:05 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErEcHcJtllY3qJavOAoPTNsOphDOBSMXuZ93Zlo3bt8CXH1eBU3gZyqLpUhv7QWeCHbwHAa9qw==@openvz.org X-Gm-Message-State: APuU4Z8WN4RKmR2pyV0xUYO0XJju4hMUBCndu7tYXa0KYQ4MI4x1PF+L kT3vGPeYRuv/GcJEqPBb2P+AY04ASE2lq1+Bh5WxcflFqpUeJvOhVLF/ssM14GXxMlXfZpJqbKM df5vKG/gnIU8iKgiB0UOJH7AgKy8UXmKxc7NApFMV3TdW+LYAqHhCrA== X-Gm-Gg: AYBFou1Nn5outhzC4nwh7J2E4pO+gdNDyivWUoSTb8K0nDGVOGFfj8RZ5v05HAdKWCM 19cMxocKTRUZj/GG1CeEQw2+WHZo2NFkC+BvB7W5BHTCS6SIHrDpGlrESS9NCi8Fs+skVKWG4Dd cs5m/oburkK9erPK+jdayS3It9bow4BbfkTsGp4cg1oZqlvvhfQhLfgy6Y5lwrFospB6T6Jkadd rpwM2s4RawcHLGAIrINy3OVKhXxWuYNdigATvdoyxAVV6L2uwIRKRUyqOOi8kwf+u8YH0r/4yNZ j04WcyxQoUg8rE68e+pJCMQm7NphHkFll8BHNbIvWvdj7wfEtsCqfwEX1WkrXJvsiRUo7d72ozU J02VPzuKJvFLnqk4s X-Received: by 2002:a05:600c:b99:b0:4bb:5d38:259f with SMTP id 5b1f17b1804b1-4bb7838bdaamr61857055e9.12.1794926945343; Tue, 17 Nov 2026 06:49:05 -0800 (PST) X-Received: by 2002:a05:600c:b99:b0:4bb:5d38:259f with SMTP id 5b1f17b1804b1-4bb7838bdaamr61856745e9.12.1794926944909; Tue, 17 Nov 2026 06:49:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794926944; cv=none; d=google.com; s=arc-20260327; b=cj4Ux9gfq1JcoAgyyYAREMc/ItV2CuDzvi6+8jsq/29Rg71j8ejZaooiX6IRwhjSOi TCE6BHtmwUa35ZCe+HgMsIDBQU+LZ0QDKeUENN6gbnCJq0wyqiZpoZpJJ41tb/8tD1oo mWSYcUOXfRWk4VIsR7vthiO+3a2nfCu/n2mmu3nlD7MeAslHROB4psk5AbJdX4sKwHWZ DvNNeF4WaAai27sQNqx9RJOj4IjPSo9SkkVFyAG/IekzWjmr6aWhm+FSGoNiEoizdAKs ovaKGevz6L0BlncJtuDxd68nVTNHyg5bUKIdE8fgWHc05sKcYKPGsxwWn6N9IREuXl6c 8g2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=R1Ac7iti0VA+rVhv0ho5OmQsOak+8yyoNtPG1kHl9SM=; fh=Q8xrIeKEv9kNt0kBAZ24Zoq+O3GjFEiuW2jIo3+yJG0=; b=jUW+CLCAOZr30idRx+O0Mc77gdOPkM076l/x975fETP2KLsbVGYqcFiY+oW2GPS2Xm ISdszase8iDr52z/gAFGfGIGCvdr1ojpeCR8PhIi4wDUqqd7CBL0BAop8KKOiKjS3oCB 5KUMInyQRLleX5n/D2NWcIn5gaVixd7QYJveZSCixvwZj9PZS0fEOfVxo1J09YsUFXkt 6CPNnjE5GN+9qjpwx8IrPJ7AAXG+GW2Iw5XHT6KaLfSk0wH+VaQAlMUDxL1fWXEbJ+4S dkDn6Doj6lr7dq9FG981ie9f8lhztegjlcDjufIwh7l8l3PCC39JBS3oPqc48zLpYytm 4srw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="A/OhtL0U"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id 5b1f17b1804b1-4bb78429dd7si79769715e9.6.2026.11.17.06.49.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 06:49:04 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="A/OhtL0U"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=R1Ac7iti0VA+rVhv0ho5OmQsOak+8yyoNtPG1kHl9SM=; b=A/OhtL0UKQef Uvir0zX87AHQrIDkSEoNMgYagIiWFOCQyjdn5Yry0V/dzkop6a+bXZvwFZFACrSnShoHY1dqPaBb2 rQcGmYiiW7W5TjMvY+n07o4U+/8yvOB+Ptz+NePloqNaZDJO1fpwTNHtpibbYvzESB1Y/Jtxpy86k OYfX4XFeqRaos+pc8gfMNmt46Ld3QZcYTbFNowbDRtT2IyUSiqCoRz6Ki3YiwqU8Ko5TIKfSaKyJ2 OdGLTCwzlKJNERWySPaNq+X08hLVcndXSN1MdX7XOPefSMHVHGpPu5sfVaHgMHIXSqDef7LnWm/wZ LWWzfIPJtUkAV7/FjgEOgQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xTKQJ-00Eabz-0r; Tue, 17 Nov 2026 15:48:53 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Vladimir Riabchun In-Reply-To: <20261116-ovl-use-orig-ve-v8-0-dfe427bfd902@virtuozzo.com> References: <20261116-ovl-use-orig-ve-v8-0-dfe427bfd902@virtuozzo.com> Date: Tue, 17 Nov 2026 15:49:00 +0100 Message-Id: <179492694070.994824.11702311984402867249.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1871; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=kKWNOdojL+0f6+rQ3eWmukhQN7ClVldTgEF6JIBmMfI=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq/Gle7cwgMspm7EQ9+BSYtXhfRjia9UXlMdeRM y505wl53TOJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavxpXgAKCRBRlgpH+WFc KtYmD/9IcFmoUowOVHPZ+TbceDLvCfCA06C3hvqLmnKlILRwV379nhqspZI3CJ0w2MCBR1s+3eo 3t7VgHQwXwjGYzHAZR417mWfAcPDNNiNtfsaVgu710iHczE5pA2KEv4Kz8GBeuMTs0ldH29Khd1 mzQ7U4Sso8IFeUNnSF0N/oTbJggDuo2DyPCsYpwJCKfxRX0dhGktBo0ECvRb4EeMmHncOlL19S3 E16OarhMDluSq5lJNforjfwkUb3SBK73AKvFXbRKB/lzMTlDKmotZOADSUscZN4yaeDShMGQpIR xZ04j5u5tbntNMG1atRMQGMtyshjg3Y+O1jG9/+oF6/lVLDv+tu5ISTsQm4b4oYIqn/Vl6MhOtd v0Mkl4OEv51ZiiiaQc8+v2/0bZtQNG0s5l5MQJiVIiHxrInxDynuL4aMZQ1d1GC4KPJbiJpIiAZ cl166Upgb1MhkOkVhdC6/N6GEKrp8lCExdtA0k7EseWh22PHuGUd9+kd6KxpuHMoVMe4d09ySjI 3oQchpCVzASLOt2dexxLPeoXGLgMmVKT9X6vRQv2BSVM/QUrV/HLZSLePBTolhudJapVYrInYlB XLAUAtA69LLXRWStwJRTH4z3bpzRzqqirgAXwIAfoMcA824IWRSgpvcMhtBlL1izzgA4KlFz5lp 0tdw+mAVXLHCz/w== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v8 0/6] Fix kernel crash in overlayfs X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying with these fixes on my side: - Feature lines: "ve: ve generic structures" on 1-3, "ve: CRIU support" on 4 and 6 (instead of "ve/overlayfs", which does not exist), "fix ms/overlayfs" on 5 - patch 2 message: "ve_capable and friends" -> ve_capable() and ve_capable_noaudit(), plus one sentence that override_ve() refuses a CT task any VE other than its own with -EPERM - patch 3 message: init_cred == NULL means the VE was never started - patch 5 message: the two mainline commits cited by 12-char sha and subject instead of GitHub links, first paragraph reworded - patch 6 message: the compile-error sentence limited to ovl_override_creds() callers, with the ovl_creds() users named; "returns" -> "saves", "would be handled further" -> "will be handled" On Mon, 16 Nov 2026 20:20:38 +0100, Vladimir Riabchun wrote: > Vladimir Riabchun (6): > ve: Remove STOPPED state > ve: Introduce override_ve/revert_ve helpers > ve: Defer ve creds drop until ve is completely destroyed > ovl: Keep creator VE in overlayfs superblock > ovl: Fix leaking fd references in ovl_copyfile > ve/overlayfs: Override VE together with creds The code is fine: the rebase onto the ve_name fix, the plain ve_name(new_ve) print, the out_put_real label in ovl_copyfile() and the "true" from ovl_lower_positive() all hold. The texts above are what was left from my earlier rounds. I did not add the Reviewed-by of Vasileios Almpanis: he gave it on v5, and patches 2 and 6 were redesigned in v6. Vasileios, if you are fine with v8, please reply with it. The comments "ve isn't started" in kernel/capability.c and net/netlink/af_netlink.c stay as they are; "ve was never started" would be more exact, but it is not worth another round. Thanks. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel