From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 91D498017D for ; Tue, 17 Nov 2026 15:07:49 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHF6XPb010215; Tue, 17 Nov 2026 18:06:33 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHF6XPb010215 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="ea/PDFCA" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHF6V0v010211 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 17 Nov 2026 18:06:31 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHF6V0v010211 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-4a339a24cd1so822268f8f.0 for ; Tue, 17 Nov 2026 07:06:31 -0800 (PST) X-Gm-Message-State: APuU4Z/pXcbkRVs1886DUElpRD8pV/79o6OKcyxcp2VOoSA6GrUfgnap HypJCzTiUfN5ZQqeRfyK5ztcbcvdjeVoJKl1pz8tAFx/SC84EDEwialuVarLToCqbOHCEtlzEKO +CHWlLDhH1CuIfsHPofCxK1bUKQhU8d775kP9i6sQXM0IxGm8VE4tyA== X-Gm-Gg: AZFdTZfT8NjDkglKI0hWG4QfG1scIiE+MWbxDBAn6YgVZJRZdf6LCX2AD78xGdCCkWt uPbLcYALqt22eMIfAhd0lEuSU/VMttO3PTueGNJl1z6xTiKEtWnCAxGdBC8BgT+6uMNh+xqIHZr nliCTAGJO833qdXZXYGiV+y2m9lSywm9WPNEvRQNdS9lVXTMirkU8uiZ4NSdbNnnnCm4Xg8gkNd PDFQ6W3rHAYDD9I8nG/6T2XZxTVCucBRraDXmJDexvJuTnrchB+1+cjoRvGIGNhih8sYNHtA26U 11ui4Xw3avXcR3Afd471x6TqoUUBY+9uvul7JZtEJT/LKS8X4xG4YJKK7EMmQ1R2c71IHhsalXb 0atneYWEucYmM9MKI X-Received: by 2002:a05:6000:4918:b0:493:2eb8:e7fb with SMTP id ffacd0b85a97d-49c72ab0a38mr28359451f8f.41.1794927991248; Tue, 17 Nov 2026 07:06:31 -0800 (PST) X-Received: by 2002:a05:6000:4918:b0:493:2eb8:e7fb with SMTP id ffacd0b85a97d-49c72ab0a38mr28359385f8f.41.1794927990639; Tue, 17 Nov 2026 07:06:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794927990; cv=none; d=google.com; s=arc-20260327; b=keptpvknYlfcZB5itlAwRtXpLSpL8lspgIhlvrnbhwN8x91ZaLUepzSpbcUWioEkk/ taVo6T7HCQZ9wfjLLaqeL14bKaGElw3C7/2ILpLx0U6sdtZfo46NAh6zDSiOsWNyaVNa F7uRc+izIU8WKeCeyEgkbG6hCfsubZ7ep82jWcMSKKHJUhoKr87WU/7NOTx5VoWqcsWd J1yDrd31MbWYwWfQ+IWB/yqMiWJDbY8bzrwJNNKEVwTd9YvwFctOmHDvG/PPUGscfPx8 JB2NyMcfhN2huUMo+9rloGMj8FFbg1iYzGiBEGld2XnBf9r2lcNAbNNrAnXqfpGc+MGw eQ3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=eF8I1bHstzmbdwOxFdu3HL+ybwk69kyaL+MKLaPo530=; fh=9a32gKL5KKeaohQjBh2D3pG89qkyVDxjDGg4yWgrCuo=; b=dsvLtOUenkuZO2EbjdjHolhXqjscxwdrXiOG1fatBH+KWEDtLRD8Kl16ljo2pkOAPY nql//AVULy9B18inYSKF94BNTepYJKI1uC1oEeAVKWwJv05Ja/0Ij4ifYW4AKq/62/Sx lRHotVve+nGZBfjgLfk3ImMsFe/sI+y6O8NwF6X9i9ELHEOPaqyOpw4KVD6AU5Q0KcPM VudXhw53tjfjVtVFgjtZwW+jkTh/mNMgNXrl1A9ZqoQoWfOh3ReWdOh5YQe2XmcoGELO 1EdLXfOHpw2P9WdiISaqvkOyvkHtQUX6ZqEpBwJA9xMdcRea05KdwEZCLvFcF1FLh/+g t8OQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="ea/PDFCA"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c63122563si27587784f8f.96.2026.11.17.07.06.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 07:06:30 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="ea/PDFCA"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=eF8I1bHstzmbdwOxFdu3HL+ybwk69kyaL+MKLaPo530=; b=ea/PDFCA0dPW Vz4bW4GlxrWShUKZQPAfyRc3xUek177OXhaHshl/O79j9q8DNrEIcYHAEpNoZYo3MZQwp3U5aSF0l ANH2bye/k/IZh5w7W/WHTQ1LvJa/5p6Pop6265FuHCwRk6u7w2d4f5xLLInIPUZQzfANRkiKXXhaw SsSeArrfP/rB7ZhaZ6yTHXvNpqHEoJmG6ajiLoYverICHahR2MmRIXUh1JLtSagY+/ugz1Ewqhw2i 5nyf9r1bOKZ/z5jPv0oIYUNn6NXWUodHbj43WFdCRQAnSsjUziWzVpiH4UUR2h/VTE4PJYaiTuqG3 QftLaG3ZKSGkvjJPYgN9kg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xTKhA-00EuZX-1a; Tue, 17 Nov 2026 16:06:19 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexey Kuznetsov In-Reply-To: References: Date: Tue, 17 Nov 2026 16:06:27 +0100 Message-Id: <179492798753.994824.6796451394598992855.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1059; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=4uoPCc0UzTaZei6frNJKGJW3Xow1C/Tp71o6Ohvghnk=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq/G10AjvOpZHkjYgwX7Dv38sySuFhBCHCevkw7 WumfpQLbjaJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavxtdAAKCRBRlgpH+WFc Ks/GEACPBpdVREp/B/6bdXjf0FLpsTsUuMdS+vKrK5H6lPkPcmKeSq1v8ZJvCFjJNWhappQCTIX Wa/BKRVi5fhnJ8Ak48Bu2fSk93bFOd98hZNLjun1GBv9j4frYpYAnn/wPf4MILGsftOt+tFjNto 93f8AmP0TmEUfVV/jHxuDctH2TY2HnV8FBu7YbX1h+9uvp0RqnySU+tsobaZbd36pAOisTN+DWS vHp3FcRk1vIWQl/8ujEHXboSmTzeU6s1TBL0GiNpLptuweZc0efq+usLJiWCWCyaK3yOljbopJS yjiTjutPcvwh1WVjBbBx79ICKLAIANXlJZS2nMKBWpBr97tCF90fsUb11GaVotjUS0fEJk/GY7b U30EtKQngkdoIEtgvaocAS0dj2jl2xP1LTjTKvtp5OJsUT5I+r1GW/1Y0woWJEa4F6tLUKGfWaP vxoMSeEifnNQ/I0g2m4frBsLIYJpvI3lIQG+5UkTSTI5JX1zHH75LzxDLRZJoFVsJ4wQdOx1jqf X9xT1uToXFvQZ20XOoG/6P5cVFpup9e37LetKb/24L22WRLgTzz9HnOsloRemJGaNnH74wQbdP5 +yjga7Mljh0bgidp0+eSCB75UYanzw5Vh9POpVLT4p3ZiQXeGZEhTspp2nuR6NHVVhsBFS5dhzi oQFpHW4ipRSuHog== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: azaitsev@virtuozzo.com, devel@openvz.org, kui.liu@virtuozzo.com Subject: Re: [Devel] [PATCH hci-8.1] fs/fuse/pcs: fix problems in logging X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying with these fixes on my side: - message: a list of what changes in the logs, after the first paragraph - "Affects: #ASUP-3693" -> the tracker URL; "Feature: vStorage" added On Tue, 17 Nov 2026 21:25:58 +0800, Alexey Kuznetsov wrote: > These fixes were done in user space long ago, > but we forgot to do them in kernel: print correctly > formatted client ID and show correct origin of > error. The message did not say what changes in the logs. I added: - NODE_FMT prints an id with PCS_NODE_ALT_MASK set (the kernel client, the origin of every XID) as "K" instead of 2^63 plus the id. - The IO error line in cs_response_done() adds the id of the CS the request was sent to and the chunk uid, and drops the ireq pointer. - The cs_stats id column prints the raw id itself, since NODE_ARGS now expands to two arguments. The code is fine. Sashiko's remark on the (unsigned long) casts does not apply: vz10 builds no 32-bit kernels. Thanks. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel