From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 852D3802A5 for ; Sun, 11 Oct 2026 20:59:44 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69BKwO1B008791; Sun, 11 Oct 2026 23:58:26 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69BKwO1B008791 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="z4JPFm5j" Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69BKwKrB008787 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Sun, 11 Oct 2026 23:58:21 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69BKwKrB008787 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3ab2395f104so922941a91.2 for ; Sun, 11 Oct 2026 13:58:21 -0700 (PDT) X-Gm-Message-State: AFq9FYLQ6c5gtuV9j/8XN61nGqnJCP2aFX+fENbbPv8vtCGIpjYz9yLx 9e4k8fjMVMD0IXDRHg/ZrOz4DvlHhw6hCq2CCwvSgMjK2VdBJsIHBJbcUuuRu37FWKNqZYTWb74 tHOdDS1Gaisua/LijpPF+mAYIaf48Bkp7XXz19nkCjya6oYL2l6ENIg== X-Gm-Gg: AYBFou0HPrJVq5CAY0P9/3r+I4Feej4GD4AOKBTkm+Hm97FrzWDSBeJ0LHk6Oh3fon1 qTIawDBSS+5hGWiqvH35lQzqq4Jp9nXIcJ+i852RtZc4++g6KtIO4fwLTRPj7+HGk7IPgX8OFK8 +/MCNTv/sG7X/3rJsxKMa2bym74WcBW2ZyqvVBDX3sMPGiJItS7RKBRIj9H3Rd6dRBpbvGGWxYf pyZhUK3c45FyIKr2YE2gFKbxsKehncnZUclsy9HQnrdEyUZRPUHLWr/r2NSvPH3aWUnxiGkSdOd L2+odwLvNfrtu5ZWElORs/sgv0yL19oVWD78MLCM7/0OWhZ5FroND3SnScrtjLKj1Xoeg/ytWJM oglwN6TwCC9uNXJZASWvTmu0AxkldoBxjctdQArt2+giSU6IheT8cro/0c3csCyqxeBMRRE1g9w 2vKEbM8743Rq/bXlbI5Zt+V/5r0YtK148i X-Received: by 2002:a17:90b:2681:b0:3aa:ff61:9504 with SMTP id 98e67ed59e1d1-3ab3a9127f1mr5949309a91.20.1791752300248; Sun, 11 Oct 2026 13:58:20 -0700 (PDT) X-Received: by 2002:a17:90b:2681:b0:3aa:ff61:9504 with SMTP id 98e67ed59e1d1-3ab3a9127f1mr5949302a91.20.1791752299592; Sun, 11 Oct 2026 13:58:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1791752299; cv=pass; d=google.com; s=arc-20260327; b=qdKZDz3xEcs9CubawSrQGZ3HAgcSbn1TnMcBrbQhIS9XA4fMB0fSgWW56mlM49SKDS KqmZRDhiQwZJvebSXcUdZY/2qg4phUXdHot4AX86gxtLtwhsVlHKM62CKZn+B2fyHIVg PCzbJ4uc4L+1KEMnrIGh3tO9DOvceppfJjqrXpoXYDqpn6VCD5aNJe0tk/vIjruYCNFv CBCWzF8BsEJEdlJR2NTzW8wbav/rAVdn3ZoWcPXIFKLWVzsmPzlmcmTSveAYLlzcbCbs cfEC6c1GUyNpnouCYwJrYFHXh27psmTgLpGuOushQSsNtI++RpwVFnETgLyqGw5S4H/U Le9w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=mTS2cSSodWVDqomC9J+4ynoXqjzHGVGKLycT1oqgGdQ=; fh=x+sEwlPrYjdnvyPJZgDx54RG2HGIpQh28bviCAKous0=; b=Kyp3Q1tMVn/ijqayq5S/jkA/zPeV3x7FTUwMzLz2+hmC4N5PyHFGxgNfdSR8BToN6H BKzB55Uy02xrdMcv1hs5vmHI0QVb0nJcLM9nByii1YnZPWzjdDZYkjql8/VN1koDzBYc ffn+yfWY6ovWYPt90blk8pdNM15Sc+jKDr95+997Ie7jloAOTN9q2zzbzEkoq5Wlm38p mPDm6P59KUyduw4To00K0922aYC7l/hj1pA8yjpQRkTwHFUL6FPSD9VWxjmH2XyGNBIZ ivebN6LamGTK2O1Lyn7NwkCS2I3TvtbQVIH91VR20zeNVG+xpPqnNirSzE8zdKUOykhI yd/Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=z4JPFm5j; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c201::3]) by mx.google.com with ESMTPS id 41be03b00d2f7-cd3da0c44dfsi12760906a12.396.2026.10.11.13.58.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Oct 2026 13:58:19 -0700 (PDT) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) client-ip=2a01:111:f403:c201::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=z4JPFm5j; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oLw6J+8QtXWokCEVnZecdzrpCiqDVlA48aLUD4cTmc0gnDbtdS0+9FOsRyoonKF0ZZ4YOAtzgS0J0HTMDHwvrykmYKYhcHv9BzFp8fzI/Tzafmys3Wy4AlNTifpolNp/M/svQFJNIpLevFodiqZBYnCR+uRIoZXg4+qjEF7QbkL4vR77mlR4W0/X6JIgPKhCZgg7c3lTNP0ZuH6P3VEoPc+mjH2Bfd2pWAgN44ExiX1mw2BJfoDhH0rFJxLYsOwNw7SnqF2njbHuEI8RmfYcszUKbrm6kGBgLylfgIU4L7ipvLbru9A7jUAZwt4WtkTnAS2JXT3tcy92HzQpCUokcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mTS2cSSodWVDqomC9J+4ynoXqjzHGVGKLycT1oqgGdQ=; b=eJ235bbDxI+DsXjm/ZwTq95kgGvb5pt7OD5kQ20vy3jcEV/BYQ84uWROOR2hb6ubitdpjXTW4XKkenD/FrRoSY8BypxCebcUNXSTP0h6T+v7LBv+8kCpPbKPdNhzCw7dE40Q5IMuCz9zADc2jrCmV+uKlpDLbKWd/Hs3TkL3zSW0tbitYd5rtbs67nM8/cVdeySeVjD3aPE/j3bSVzWC7/cmacAoA6L2U0ouOlEIZRi/hx3XnfHdX33kgc3V0isG24wbyOcseykdV8obLzMqfnJ4TP/xMXl3RGc+R5E3phTP6S82RdlVg9XYtCmTS1M7SFumFXtvL+YHAbwJ/sLeoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mTS2cSSodWVDqomC9J+4ynoXqjzHGVGKLycT1oqgGdQ=; b=z4JPFm5jz1QbjeXZ1b06j5eolfRT8ydjqa61t8VvzmiOT/UxtRVZwe+1BbmPMZVPpUNSVRC2gMUiOlXi6fGPCGKaD3uN6h9wkf96OtokL0VyVAtvkdToVFCoSfHtaow4tWZeAOym+LZeIML8PZFKuwYXGsfyTmynFi73Mvkb8+ERvLQubY0L2N30x+Enkn7vBakFMnCTrKL7pvVUWdu0FJjeUPdubFwRFhDp6C/RZ/cjs30HiDzzwN3gKTxrj4MSwemp0krUEsjZ5B0KlAsXEehDg2ui8bAjWihgHb+vKccEVac5Q3PT42edTYCnP50J8Dce1G4rEO4SnWLsGgw4yw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from DB3PR08MB8962.eurprd08.prod.outlook.com (2603:10a6:10:43f::15) by AS2PR08MB9546.eurprd08.prod.outlook.com (2603:10a6:20b:60d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.10; Sun, 11 Oct 2026 20:58:16 +0000 Received: from DB3PR08MB8962.eurprd08.prod.outlook.com ([fe80::da44:b0e3:f6ad:8f8c]) by DB3PR08MB8962.eurprd08.prod.outlook.com ([fe80::da44:b0e3:f6ad:8f8c%4]) with mapi id 15.21.0496.010; Sun, 11 Oct 2026 20:58:16 +0000 Message-ID: <1d260ebb-4f88-4018-9182-44d1c6e1ef26@virtuozzo.com> Date: Sun, 11 Oct 2026 22:58:14 +0200 User-Agent: Mozilla Thunderbird To: Konstantin Khorenko , vasileios.almpanis@virtuozzo.com References: <20261006-ve-printk-irq-v2-0-db1dc4f6ed07@virtuozzo.com> <20261006-ve-printk-irq-v2-1-db1dc4f6ed07@virtuozzo.com> <010701a11339d6e3-9ee22174-c14e-434c-91b4-dad05d12065c-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <010701a11339d6e3-9ee22174-c14e-434c-91b4-dad05d12065c-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: ZR0P278CA0119.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::16) To DB3PR08MB8962.eurprd08.prod.outlook.com (2603:10a6:10:43f::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB3PR08MB8962:EE_|AS2PR08MB9546:EE_ X-MS-Office365-Filtering-Correlation-Id: e80a1857-ef0f-4579-6497-08df27da5ef3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|376014|1800799024|23010399003|56012099006|4143699003|261009223027099003|10067099003|22082099003|18002099003|6133799003; X-Microsoft-Antispam-Message-Info: N6L2hzqFVC+u8wE9S1kvgv3HDiilpi9uDKwauPd5SFNqUjA7k2o3IJpKdob39n9krDEo3ucYQdHbsv+xA7Y6q2G8uLbB7XCR2nOd9dI04K/wXr9slwlsAK9SWGDR0Qp+xZAy1TII0ZqTTq0wkZgGh1X5xYa87Pc3TaQvhxd46X2csVPhWbUsE60Q6rDpqv13YGvN46K975pGJQqWbqY6udfwWoVPHdvDM1AIpKUlUt//CMZbNNd6HmnN7kNFHf0O0zIgCePT/M+NyAIHf1rwhNi0YFXGn8uUbkPKnGb8hAUKstAj1JKzY0VufoCUMbL43UcO5J4HObqpw+4LsgdhGM4vL0zGewzHScq3v9KTiJV+A03bbIcaQ2DqXm9K+foTBJAtWlMs71++KpjaphslMCcW+MMchfQYEl6E/kQhegKpoAXTL0gPXucBWZU29zoUHaSqh1zuOqtlzU8aFzXT8cw13QOIEg6tuO+q8OMUqHlAZEv/CMd1J9/SrbBBd6ZutG3mhgHlW9MKZCdDFBLsGb6l5WNhoNEbVtyL69rpPnj1RIapKGmqH0/Z0LTK7W5BFxn18/G2vHQHISGfziQw1BB7lC5EDeWjH7RTQjWam48DzImkBlqY7/iVdLlSCAXDAcOe6b0IIMUwPihyWw32cpvou7AW4ozEb9Sue/W0iLI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB3PR08MB8962.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(56012099006)(4143699003)(261009223027099003)(10067099003)(22082099003)(18002099003)(6133799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUVVS0NzNER3c1JVNFRNUkZIV01rUWF3bjNyRlNOQVJpcjJ5YnV2ZzFXVjdP?= =?utf-8?B?OGc3eGNZcWo4ekE5WW9CQUdubjhWa0xOd203dW5LQWw1MGYxOExFbXowbjJ4?= =?utf-8?B?dGFHbXYvK2puenhsWXNHbkNiSkNzNWovQzlFTWV4ZjQrK3JpRGNMWFpzVzVT?= =?utf-8?B?QTJ5S0tFYityUG5hTTdFVXhnczZwY0NqSE5QYTl2L0Urd0hMMC9ndnNqTi9C?= =?utf-8?B?QkFLSzVwSzQzR3BBSzhtYzhkZ09QUVVLTC9QQU1aYURsaFdNTStjMG9GWU9p?= =?utf-8?B?eDFWdlB3UkRka0F5djYzM09xMXNLS29nZUsyREFyS3FFQVBaRitqaU9XRWRw?= =?utf-8?B?azRzS2RlWkxGSFFIMGVRcUdoTHluWXEyS211eWJYS1Q4Sy9GZnNZY3hYOVFT?= =?utf-8?B?eVlITW13cjAyUm5BSUw5OXdjZUcxa2xwSG9Ya2xrcFR5T0plYW84bXlPS2Mv?= =?utf-8?B?aTUyQUJiME1EUGJHRmF3a3hXcnZBL1RkdnVMTGtzeFlzMEd4SVZsNVBJSm5r?= =?utf-8?B?MUc5dWhnZE5RbWJ0SElLMzFqMnNhRWs1M21JNW10UkZuRmRTblZISUxIb3hQ?= =?utf-8?B?YXhmSnpGWTB0RllkWWVmRjNQZ0VWcm94UmpmODJ1SndEdEVjajU3TlNJdzNq?= =?utf-8?B?ZXgyQ1ZNblBkVU5VL0lvdjNHSU5MdkFhNXVLNWd2QWxFV3VTaHdSQ2tLeFgx?= =?utf-8?B?UGphN3BHck5lb3BlUTNnRnhXVi9uUjdzdjhRWUlQa3RwNnYxZnBQQzR5K24w?= =?utf-8?B?bHNUWjBMTHNodTdGQ3JBSGxtbjBpTVVGUkd4WDhYV3Zsck4wL1VRbTZqTlFC?= =?utf-8?B?YUpwbVl0UGRKdksvazhRZnFQRmRDUEEwTjJUbk9NMktvRTRiQVRlNi9jWm1N?= =?utf-8?B?cFBZaTJsOVl6eUM1RUUvbXJyaklxVmZrUmEwUHZjNnJteUtIUm9UNHVzY3Uy?= =?utf-8?B?SlowZWFSQ1I3OW5tUnNpbit1QlE2WWJWei9PbGhvSDBoTURZb21ya1lnZE4r?= =?utf-8?B?NXZWOUdEQUh2NzR5My90dXhPRlo0eWJDVDh6eERPOTlxRG5kOUduaTBmcjQ3?= =?utf-8?B?R0V1MUlsN1NOQTc5MG9WZjIweEFpZXRFd1FXOTIyVXhKT1huSkYrMGtxQmoy?= =?utf-8?B?ZG8zRkNTbFBsUU5wZmErKytqVitZVTNUTFpNdy9HUkRyY1JkbkZsb1YvWlBJ?= =?utf-8?B?eEprc21CM2lWTHFnY2pQTXErcFVxcEVhdjk2d3BrZFFhWkdzWU55T2UvMVY0?= =?utf-8?B?U3dvQ3VaOFIweUdLSld4VGVQVWVJakxkZWJNTzFZbGJGSlJKeHNVWmI1WllL?= =?utf-8?B?dWc1OVYzWDM1QzdRVDJVNE9hZEIrTnhhNk56dEZkcmNDMEdPdFpUZmlqSFRS?= =?utf-8?B?ZER5VW8rWFJDN3Bld0gyQWROYXFQaFlBTExxU2F3ano5T1dpR1FQSTJvcUU2?= =?utf-8?B?Y3RmMDNET3dXdEUwbVgzZjFpUEpKVVNsaWc0N01MT00ydVRwSDZuNjdjTlNs?= =?utf-8?B?ejNubEZRd2l6VzkwYjdNVDJEckdSWklPcStKNFVrQ3Z0UUlmV3RnRUsrZ09N?= =?utf-8?B?czI5Y0NUVU5uTFJBWVZXT0VVYVhlbDNpTjVuN0s2ZWp4WkhZM1V6T2Z2U0VW?= =?utf-8?B?NzlpNkxwRDFrQlhpbWdYQUx6bFZ6VG1COWFvWXZZaituNUErcmRZQmQ0ZXJ0?= =?utf-8?B?RWtncTVFakcvVlRvVFNwRzVyMEtkTi9Zc0grWDVvTVFXSzB1UGxIWUVKNDMy?= =?utf-8?B?Wm9SaHpKaGtCNThIQkV3SmdBa2FWNkZ4anEwbW5OQllnalZKWTFmb0RjWk5R?= =?utf-8?B?dk9EOGgySEhCYlY4UkZpb053NUYzSGlrZXRPNmhxUGJjUlNIeFc1cHc2ZkRk?= =?utf-8?B?ZElOaW9tNkdjU1N1VWFZVHJjbzdCdElwcmwwYXphaWU3TTNEOVl2VklpNG8y?= =?utf-8?B?bHRUSE44MUd0c2ptK1o1WEdvYkNGN045TDUvcmlmWDJkK2phZzJTZGI2T1Vs?= =?utf-8?B?MmQrMG52cXNnV3RMWEx4NHk2RUtna0NCam9SajhVOEVMOWgydjcyWGJTZFNF?= =?utf-8?B?U0NNN2ZpYzhHY0xpaVB6dkxoVEg4SzAzYmFTQ002dGovUGwwaG4yamNQcHZK?= =?utf-8?B?SVJ2c3hOcHlTcVoyZ1ZOeUhMVThMbC9vSENEVWdQMTY2bkRPeHdkQ0diUXZh?= =?utf-8?B?aHFoMzFXMFZ3QzN3cG5FdVZxTXNrNjhNbWJ6a2dwYWJUNUJvZEJDZjFPaUtl?= =?utf-8?B?anIrbW56eFZHb3FhSlV3elJMTDhLNi85Z1NieFRCZ28yVE14RTh2dkxYQ0o3?= =?utf-8?B?NkFyMzl1bjZqTVpaSW8wejQ2Y1JDSkFoS0RESFprendDb1BuRGE4bnpUcmR1?= =?utf-8?Q?G1wW4eVjLQeYqgqI=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e80a1857-ef0f-4579-6497-08df27da5ef3 X-MS-Exchange-CrossTenant-AuthSource: DB3PR08MB8962.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2026 20:58:16.0514 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C4Q/IB7OIN7oTafqMEqugPY9ifMwMk/vaaPwSvgJdwvmR3AgwxQgSCbcmec7bTCCLdnr+FgUJLLQMyiCUFTTjoBrCFx3qdw9sDUJS/AU+Y0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9546 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 1/6] ve/printk: Add sanity checks in ve_printk functions X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/6/26 23:58, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Low] printk: ve_vprintk_deferred() raises non-deferred WARN_ON_ONCE() on invalid dst > -- > > commit 57d6a4cedde45a78dd9af42f6ddde31d3e97b8fb > Author: Vladimir Riabchun > > ve/printk: Add sanity checks in ve_printk functions > > This commit adds a WARN_ON_ONCE() check on the dst argument in > ve_dev_printk_emit(), ve_vprintk() and ve_vprintk_deferred(). It also > reorders the VE_LOG test in the second if statement of each function. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-146839 > >> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c >> --- a/kernel/printk/printk.c >> +++ b/kernel/printk/printk.c > > [ ... ] > >> @@ -2567,10 +2569,12 @@ static asmlinkage int ve_vprintk_deferred(int dst, const char *fmt, va_list args >> va_list args2; >> int r = 0; >> >> + WARN_ON_ONCE(!dst || (dst & ~VE_LOG_BOTH)); >> + > > [Severity: Low] > Can this WARN_ON_ONCE() in ve_vprintk_deferred() cause problems in > printk-unsafe contexts? > > ve_vprintk_deferred() emits through vprintk_emit() at LOGLEVEL_SCHED > so that it can be used where plain printk is not safe. The warning > goes through the regular __warn() path, which prints via the normal, > non-deferred printk. > > If a caller passes dst == 0 or a value with bits outside VE_LOG_BOTH > from such a context, the warning could recurse into or deadlock on > console or logbuf locks: > > ve_ratelimit() (lib/ratelimit.c) > ve_printk_deferred(dst, ve, KERN_WARNING ...) > ve_vprintk_deferred(dst, ...) > WARN_ON_ONCE(!dst || (dst & ~VE_LOG_BOTH)); > > I did not verify that any current caller passes an invalid dst, so this > is only a possible problem. The warning fires at most once. > > Would it make sense to drop the check from the deferred helper or use a > deferred-safe way to report a bad dst? No. Replied to v1, same issue: 1. dst == 0 is actually a bug 2. WARN_ON is not printing anything himself. No fixes needed. > >> va_copy(args2, args); >> if (ve_is_super(get_exec_env()) || (dst & VE0_LOG)) >> r = vprintk_emit(0, LOGLEVEL_SCHED, NULL, fmt, args); >> - if (!ve_is_super(get_exec_env()) && (dst & VE_LOG)) >> + if ((dst & VE_LOG) && !ve_is_super(get_exec_env())) >> r = ve_vprintk_emit(0, LOGLEVEL_SCHED, NULL, fmt, args2); >> va_end(args2); > -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel