From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konstantin Khorenko Date: Fri, 21 Aug 2026 18:37:03 +0200 Subject: [Devel] [PATCH vz10 17/32] mm/memcontrol: add missing inline to the mem_cgroup_fill_meminfo() stub In-Reply-To: <20260821163718.187766-1-khorenko@virtuozzo.com> References: <20260821163718.187766-1-khorenko@virtuozzo.com> Message-ID: <20260821163718.187766-18-khorenko@virtuozzo.com> List-Id: From: Eva Kurchatova The !CONFIG_MEMCG stub of mem_cgroup_fill_meminfo() is declared "static void", not "static inline void", so every translation unit that includes memcontrol.h without calling it gets an unused function - an error rather than a warning once CONFIG_WERROR=y, as x86_64 defconfig has it: include/linux/memcontrol.h: error: 'mem_cgroup_fill_meminfo' defined but not used [-Werror=unused-function] Add the missing inline, like every other stub in the same #else block. Fixes: 7710faa9d4f0 ("ve/proc: virtualize /proc/meminfo in a Container") Feature: procfs: virtualize /proc/meminfo https://virtuozzo.atlassian.net/browse/VSTOR-134732 Signed-off-by: Eva Kurchatova Signed-off-by: Konstantin Khorenko --- include/linux/memcontrol.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index d47c3de71a49..2772a7750fa4 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -1559,7 +1559,8 @@ static inline void split_page_memcg(struct page *head, int old_order, int new_or { } -static void mem_cgroup_fill_meminfo(struct mem_cgroup *memcg, struct meminfo *mi) +static inline void mem_cgroup_fill_meminfo(struct mem_cgroup *memcg, + struct meminfo *mi) { } -- 2.47.1