From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konstantin Khorenko Date: Mon, 24 Aug 2026 16:35:28 +0200 Subject: [Devel] [PATCH vz10 v2] selftests: netdevsim: mark ethtool-features.sh executable In-Reply-To: <20260821164137.813192-3-eva.kurchatova@virtuozzo.com> References: <20260821164137.813192-3-eva.kurchatova@virtuozzo.com> Message-ID: <20260824143528.456165-1-khorenko@virtuozzo.com> List-Id: From: Eva Kurchatova The script is listed in TEST_PROGS but, unlike its 14 siblings there, is not executable. Nothing actually fails: run_kselftest.sh falls back to running a non-executable test through the interpreter from its shebang, so the only effect is # Warning: file ethtool-features.sh is not executable in the log. Still, the warning reads like a problem, kernel packaging installs the script 0644 where every other test in the directory is 0755, and running it by hand needs an explicit interpreter. Set the bit. https://virtuozzo.atlassian.net/browse/VSTOR-139651 Feature: fix selftests Signed-off-by: Eva Kurchatova Reviewed-by: Konstantin Khorenko --- Changes in v2: - commit message only, the mode change itself is unchanged. v1 said the runner cannot start the script, which is not true: for a test that is not executable run_kselftest.sh falls back to the interpreter from its shebang, so nothing fails today. Say what the patch really buys instead. tools/testing/selftests/drivers/net/netdevsim/ethtool-features.sh | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 tools/testing/selftests/drivers/net/netdevsim/ethtool-features.sh diff --git a/tools/testing/selftests/drivers/net/netdevsim/ethtool-features.sh b/tools/testing/selftests/drivers/net/netdevsim/ethtool-features.sh old mode 100644 new mode 100755 -- 2.47.1