All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
Subject: [Devel] [PATCH RHEL10 COMMIT] dm-qcow2: forbid unaligned virtual size for images
Date: Tue, 25 Aug 2026 12:41:58 +0200	[thread overview]
Message-ID: <202608251041.67PAfw2b774881@f0.sw.ru> (raw)
In-Reply-To: <20260819000745.28823-8-andrey.zhadchenko@virtuozzo.com>

The commit is pushed to "branch-rh10-6.12.0-211.39.1.16.x.vz10-ovz" and will appear at git at bitbucket.org:openvz/vzkernel.git
after rh10-6.12.0-211.39.1.16.9.vz10
------>
commit ad515b7f0e026dbec6cb947562e21f7f014543c7
Author: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>
Date:   Wed Aug 19 03:07:45 2026 +0300

    dm-qcow2: forbid unaligned virtual size for images
    
    There are a few places where we do to_sector() conversions which
    may cause us bugs when the image size is not aligned. For example,
    advance_and_spawn_lower_seek_qio() advances old_qio to
    to_sector(end). If end is not aliged, it may round down to the
    same sector already set in old_qio. Thus we will endlessly loop.
    
    It is OK to forbid such images since QEMU rounds up virtual size
    on qcow2 creation and rejects unaligned resizes.
    
    https://virtuozzo.atlassian.net/browse/VSTOR-139407
    Feature: dm-qcow2: block device over QCOW2 files driver
    Signed-off-by: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>
    Reviewed-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
    Reviewed-by: Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>
---
 drivers/md/dm-qcow2-target.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/md/dm-qcow2-target.c b/drivers/md/dm-qcow2-target.c
index de1fb628735b7..2877de6f11c12 100644
--- a/drivers/md/dm-qcow2-target.c
+++ b/drivers/md/dm-qcow2-target.c
@@ -541,6 +541,7 @@ static int qcow2_check_convert_hdr(struct dm_target *ti,
 
 	clu_size = 1 << hdr->cluster_bits;
 	if (hdr->size < min_len || hdr->size > max_len ||
+	    !IS_ALIGNED(hdr->size, SECTOR_SIZE) ||
 	    /* Note, we do not extend L1 table: */
 	    (u64)hdr->l1_size * clu_size / sizeof(u64) * clu_size < min_len)
 		return -EBADSLT;

  reply	other threads:[~2026-08-25 10:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19  0:07 [Devel] [PATCH VZ10 v2 0/7] dm-qcow: lseek improvements Andrey Zhadchenko
2026-08-19  0:07 ` [Devel] [PATCH VZ10 v2 1/7] drivers/md/dm-qcow2: fix lower delta seek window clamp Andrey Zhadchenko
2026-08-25 10:41   ` [Devel] [PATCH RHEL10 COMMIT] dm-qcow2: " Konstantin Khorenko
2026-08-19  0:07 ` [Devel] [PATCH VZ10 v2 2/7] drivers/md/dm-qcow2: keep seek parse window within limit Andrey Zhadchenko
2026-08-25 10:41   ` [Devel] [PATCH RHEL10 COMMIT] dm-qcow2: " Konstantin Khorenko
2026-08-19  0:07 ` [Devel] [PATCH VZ10 v2 3/7] drivers/md/dm-qcow2: fix seek constant comparison Andrey Zhadchenko
2026-08-25 10:41   ` [Devel] [PATCH RHEL10 COMMIT] dm-qcow2: " Konstantin Khorenko
2026-08-19  0:07 ` [Devel] [PATCH VZ10 v2 4/7] drivers/md/dm-qcow2: fix seek skip to the next L2 table Andrey Zhadchenko
2026-08-25 10:41   ` [Devel] [PATCH RHEL10 COMMIT] dm-qcow2: " Konstantin Khorenko
2026-08-19  0:07 ` [Devel] [PATCH VZ10 v2 5/7] drivers/md/dm-qcow2: scan lower delta in one pass over empty L1 entry Andrey Zhadchenko
2026-08-25 10:41   ` [Devel] [PATCH RHEL10 COMMIT] dm-qcow2: " Konstantin Khorenko
2026-08-19  0:07 ` [Devel] [PATCH VZ10 v2 6/7] drivers/md/dm-qcow2: seek unallocated L2 entries in one pass within md Andrey Zhadchenko
2026-08-25 10:41   ` [Devel] [PATCH RHEL10 COMMIT] dm-qcow2: " Konstantin Khorenko
2026-08-19  0:07 ` [Devel] [PATCH VZ10 v2 7/7] drivers/md/dm-qcow2: forbid unaligned virtual size for images Andrey Zhadchenko
2026-08-25 10:41   ` Konstantin Khorenko [this message]
2026-08-19  8:54 ` [Devel] [PATCH VZ10 v2 0/7] dm-qcow: lseek improvements Vasileios Almpanis
2026-08-24 14:38 ` Pavel Tikhomirov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202608251041.67PAfw2b774881@f0.sw.ru \
    --to=khorenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.