From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 6C2098015C for ; Sun, 20 Sep 2026 17:47:37 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68KHkNnZ028049; Sun, 20 Sep 2026 20:46:24 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68KHkNnZ028049 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="hnd5Aw/d" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68KHkFIX028026 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Sun, 20 Sep 2026 20:46:16 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68KHkFIX028026 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-486f3dbf7d2so1845393f8f.0 for ; Sun, 20 Sep 2026 10:46:15 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBw36ISHxn9Gtf0znFNa+JTHjwNmLYsj1DawBlhj++9vBF4BQ+eILXEC2yW8Kny9g7/zLiZnaQ==@openvz.org X-Gm-Message-State: AFuF++kn+3VT7q34IGVARaAlpG8LIcfppmu7BG/LtECTsb+v/Y7JXC8H d+W/goE8IQE8+CkSFTulp13fDrXGDPg0KPPW+eOjGmcuyrEML9bsTxHHaag5Z8KIwVQigIvOGa3 2JPR5WJZGynuvWLfj2BSueIqoA+8wOfRpC8fVWKFbP1rROwbo0giLIw== X-Gm-Gg: AYBFou2K0E5dx680xrjLCRK1gW6uHgRfPgShsyM9uKcXSUvpPZAICHPqxDblTVvq97T oJYVUjSHZeXNtKhNvffxxgFP+A21lH9xsU3yi2nV52L6VAHyV54am++UQ2XVKPZHRuTZo1qNU5S riC7eABEbb5D32CGt1n/Ngzxn6rwyV01iKK0rVe5U8irM55lolbprAZlLTWqT70O/fwNYiQVAtG kL1E5a6zLgiUAYGmpypwo0q73muXDPoWGl6AXyt1632iJ63TgNZNAM5fiu95XC1N5k6+DnX5rsx mcV9gTj5/HPyQbuqn48B0EovM35sHa4FRYvoWxsSqqIGhB6UqimTNk2KS7IqzqIRk0a6Hh/l4Rh pMV+HvU0Db17oUlG6vnLAATlafQlG X-Received: by 2002:a5d:584b:0:b0:487:1575:ebe2 with SMTP id ffacd0b85a97d-4871e36e068mr12191594f8f.44.1789926375577; Sun, 20 Sep 2026 10:46:15 -0700 (PDT) X-Received: by 2002:a5d:584b:0:b0:487:1575:ebe2 with SMTP id ffacd0b85a97d-4871e36e068mr12191569f8f.44.1789926375043; Sun, 20 Sep 2026 10:46:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1789926375; cv=none; d=google.com; s=arc-20260327; b=R4BgNen5amrX0q0hlPq+mbAYpobq0m4aM8GjDjRakmqO5uRAwHG2TquiaFwlFhAp/i 7u1mFW9jDZqcAkdi4PJHCkXXzQ4lrWud5egpYQFrJy2AD+eoGFhguNw3x7LsEOp4/s/9 fWT1lYHCwRiYmuBMkzEE1/A9YrHXLZ+vvbeNJSCkz9gRoiCcCqZNhF6cAVgWXHKBEOb8 a5DzRczSrVlNCskFF0ZYQFjtGrN9ER0cTVwafCJwWg3olL5LXa8rcqlPvYABTG54wqmc 5M8GWZdofhdjMBoea51RYoq5d/pMQcUnH8cR83oplBE9xnnEnCeU+8vX1FYLHRh7fAVk uQNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:dkim-signature; bh=Eby5AhSaSmhUh2dqX1fA+l3M4U51DaaTTAFB9nG5gvs=; fh=4dppuILCfGifWHfxjIIA1BWoKQtGs1EMopxlFiqV6no=; b=fKgjJmy0b6iLhXz6JGXr5+s8g3OdZ0gCKc4TBL9ajcnuoy671AdU07T3ctEN9XGRZU yrVw0wzlDiIHhWxyZkMr3uZ9g5jFjDER3onOHn4haP3lHpuXRiueD5ecKkVCs/Rdnb4M KdM+F7eXeK2Rvx8qK6qk9S6B/w6lLIX/XXxcAXQNdaD3lTTswXo6n+QD6PiQJHPCo7xu nN9/S9y7bd696NKOjiJfnCcrZvTXQVdyaQd5tKtGzfhOHd2kKjIWipczkAv+HrKNnGvi gtpNJOtNR7I2ZHwuZQ5PCxw+h9ocPROEnPuKGHS8IluvHb/8eU5ZmDBM7f+/Q25YpsQe vviQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="hnd5Aw/d"; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48724589aacsi9143958f8f.185.2026.09.20.10.46.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Sep 2026 10:46:14 -0700 (PDT) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="hnd5Aw/d"; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Content-Type:MIME-Version:Message-Id:Date:Subject :From; bh=Eby5AhSaSmhUh2dqX1fA+l3M4U51DaaTTAFB9nG5gvs=; b=hnd5Aw/dDTD5qVQWFWe hU2mibwD4ypk4aVSm+2SJU2BZXCeIuOvStomAFrCJgkn/6UUc2XNZDA39fZ5Qv8tvJsLnEleWsBNK P/P2qIFy9A8y4du7q8hXWqNKYs7y75JufcsoKz+XwYl/Ascy3bEWsm5nn4v0vuPT+0XPkcpOBKl0g LTGZ8Ixq7I7VNNZ5bQIMPgh8+yeF3EjuZTMmBdceZ0e2So2N2LfirZg47tbllDVavSMPzhsSma/0w CiG5TL11EvWHYzqkmFxzbPXOB2wA3xASnKKoLCSp+oOcCvG/76WlZEfFw+RPa00UXGxGKxSzOizci 71pXC6fzcB0HZAA==; Received: from [130.117.225.5] (helo=dev012.aci.vzint.dev) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1x8LZN-00E3NU-2Y; Sun, 20 Sep 2026 19:46:07 +0200 From: Vladimir Riabchun Date: Sun, 20 Sep 2026 17:45:41 +0000 Message-Id: <20260920-ovl-use-orig-ve-v1-0-b3e63f6ff80d@virtuozzo.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAMUbsGoC/yWM0Q6CMBAEf4Xss0doiQX8FeMDlBPOGGp60pgQ/ p2qj5PdmQ3KUVhxKTZETqISlgzmVMDP/TIxyZgZtrKu6kxLIT1pVaYQZaLEZEdfu3PXuPxAtl6 R7/L5Fa+YvVBbGtz+g67Dg/3728O+HyAxQeR8AAAA X-Change-ID: 20260918-ovl-use-orig-ve-2dc365976202 To: Konstantin Khorenko X-Mailer: b4 0.16.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 0/2] Fix kernel crash in overlayfs X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org When testing CRIU with containers with docker images, we found an easily reproducible kernel crash: [ 2300.870181] BUG: kernel NULL pointer dereference, address: 0000000000000005 [ 2300.871537] #PF: supervisor read access in kernel mode [ 2300.872577] #PF: error_code(0x0000) - not-present page [ 2300.873595] PGD 800000010a18f067 P4D 800000010a18f067 PUD 10730c067 PMD 0 [ 2300.874900] Oops: Oops: 0000 [#1] SMP PTI [ 2300.875742] CPU: 1 UID: 0 PID: 5419 Comm: criu ve: 0 Kdump: loaded Not tainted 6.12.0-211.39.1.16.6.vz10.x86_64 #1 16.6 PREEMPT(voluntary) [ 2300.878057] Hardware name: Acronis OpenStack Compute/Virtuozzo, BIOS 1.16.1-1.vz9.2 04/01/2014 [ 2300.879684] RIP: 0010:ovl_get_index_name_fh+0x18/0x70 [overlay] [ 2300.880859] Code: ... [ 2300.884128] RSP: 0018:ffffd32582e0f7c0 EFLAGS: 00010246 [ 2300.895807] Call Trace: [ 2300.896397] [ 2300.904435] ovl_create_index+0x82/0x260 [overlay] [ 2300.905406] ovl_copy_up_workdir+0x30a/0x330 [overlay] [ 2300.906427] ovl_do_copy_up+0x10d/0x2e0 [overlay] [ 2300.907387] ovl_copy_up_one+0x456/0x720 [overlay] [ 2300.910736] ovl_copy_up_flags+0x81/0x110 [overlay] [ 2300.911740] ovl_create_object+0x51/0x130 [overlay] [ 2300.912719] vfs_mkdir+0x194/0x250 [ 2300.913470] do_mkdirat+0x14c/0x180 [ 2300.914223] __x64_sys_mkdir+0x46/0x70 [ 2300.915019] do_syscall_64+0x7d/0x160 [ 2300.922814] entry_SYSCALL_64_after_hwframe+0x76/0x7e The cause is that overlayfs does some feature checks on superblock creation using capable/ve_capable and it stores current credentials. But ve_capable check result depends on both current creds and current VE. Later, overlayfs switches credentials only, leading to unexpected feature disappearance. https://virtuozzo.atlassian.net/browse/VSTOR-143259 - non-CRIU repro https://virtuozzo.atlassian.net/browse/VSTOR-142405 Signed-off-by: Vladimir Riabchun --- Vladimir Riabchun (2): capability: Add new helper to check specific VE capabilities ovl: Keep creator VE in overlayfs superblock fs/overlayfs/copy_up.c | 2 +- fs/overlayfs/namei.c | 2 +- fs/overlayfs/overlayfs.h | 2 +- fs/overlayfs/ovl_entry.h | 1 + fs/overlayfs/params.c | 3 +++ fs/overlayfs/super.c | 7 +++++-- fs/overlayfs/util.c | 4 ++-- include/linux/capability.h | 3 +++ kernel/capability.c | 15 +++++++++++++-- 9 files changed, 30 insertions(+), 9 deletions(-) --- base-commit: 3851feefb321d7dee9e57cbe7926410aa6dd043f change-id: 20260918-ovl-use-orig-ve-2dc365976202 Best regards, -- Vladimir Riabchun _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel