All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Konstantin Khorenko <khorenko@virtuozzo.com>, devel@openvz.org
Subject: [Devel] [PATCH hci-8.1 v3 0/5] selftests: netfilter: make the suite pass on a routing host
Date: Thu, 24 Sep 2026 13:06:05 +0200	[thread overview]
Message-ID: <20260924-b4-prep-netfilter-v3-0-e6a17b8f193f@virtuozzo.com> (raw)

The net/netfilter selftests fail on the hci nodes for reasons outside
the code under test: a new network namespace copies ip_forward and
send_redirects from init_net, so a routing host with redirects turned
off breaks nft_fib.sh and conntrack_icmp_related.sh; a veth name left
behind in init_net by another test makes br_netfilter.sh and
nf_nat_edemux.sh add their pairs into nothing; rpath.sh fails instead
of skipping without nft; and conntrack_resize.sh expects
nf_conntrack_expect_max to be read-only outside init_net, which vz
virtualizes on purpose.

Changes since v2:
- patches 1 and 2: the messages said the sysctls are inherited from the
  creating namespace; they are copied from init_net (devinet_init_net
  in the default devconf_inherit_init_net mode), which is what matters
  inside a container. Reworded.
- patch 3: the comments in br_netfilter.sh and nf_nat_edemux.sh retold
  the commit message over four and five lines; one line each now. The
  "90 lines later" in the message is "much later".
- patch 5: the comment is reflowed; the commit reference in the message
  is wrapped at 74 columns so the commit-msg hook accepts it.
- Reviewed-by added to every patch.

Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
---
Eva Kurchatova (5):
      selftests: net: turn ip_forward off in setup_ns
      selftests: netfilter: let the router send redirects
      selftests: netfilter: add the veth pair from inside the namespace
      selftests: netfilter: skip rpath.sh without the nft tool
      selftests: netfilter: account for a per-namespace nf_conntrack_expect_max

 tools/testing/selftests/net/lib.sh                      |  1 +
 tools/testing/selftests/net/netfilter/br_netfilter.sh   | 17 +++++++++--------
 .../selftests/net/netfilter/conntrack_icmp_related.sh   |  6 ++++++
 .../testing/selftests/net/netfilter/conntrack_resize.sh |  6 ++++--
 tools/testing/selftests/net/netfilter/nf_nat_edemux.sh  |  9 +++++----
 tools/testing/selftests/net/netfilter/rpath.sh          |  3 +++
 6 files changed, 28 insertions(+), 14 deletions(-)
---
base-commit: b3bd8f01bee9ae791ea9c5f89c94a64c49614062
change-id: 20260924-b4-prep-netfilter-edf816137359

Best regards,
--  
Konstantin Khorenko <khorenko@virtuozzo.com>

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

             reply	other threads:[~2026-09-24 11:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 11:06 Konstantin Khorenko [this message]
2026-09-24 11:06 ` [Devel] [PATCH hci-8.1 v3 1/5] selftests: net: turn ip_forward off in setup_ns Konstantin Khorenko
2026-09-24 11:06 ` [Devel] [PATCH hci-8.1 v3 2/5] selftests: netfilter: let the router send redirects Konstantin Khorenko
2026-09-24 11:06 ` [Devel] [PATCH hci-8.1 v3 3/5] selftests: netfilter: add the veth pair from inside the namespace Konstantin Khorenko
2026-09-24 11:06 ` [Devel] [PATCH hci-8.1 v3 4/5] selftests: netfilter: skip rpath.sh without the nft tool Konstantin Khorenko
2026-09-24 11:06 ` [Devel] [PATCH hci-8.1 v3 5/5] selftests: netfilter: account for a per-namespace nf_conntrack_expect_max Konstantin Khorenko
2026-09-24 11:09 ` [Devel] [PATCH hci-8.1 v3 0/5] selftests: netfilter: make the suite pass on a routing host Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260924-b4-prep-netfilter-v3-0-e6a17b8f193f@virtuozzo.com \
    --to=khorenko@virtuozzo.com \
    --cc=devel@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.