From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 35419805B2 for ; Fri, 25 Sep 2026 13:21:56 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68PDKhtF025431; Fri, 25 Sep 2026 16:20:44 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68PDKhtF025431 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="hiR5sqaM" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68PDKXVT025406 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Fri, 25 Sep 2026 16:20:33 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68PDKXVT025406 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-487038bc9b8so569694f8f.2 for ; Fri, 25 Sep 2026 06:20:33 -0700 (PDT) X-Gm-Message-State: AFuF++kDUUc3UZXYsLPZGfTUBUH+Y45UvBDOCtdwittexE/x/fPwOmws nBKgTYW8WUw88rsmU1u9mPpx0Fpak6VJSI4OzTuCPCr8tKEt+9KTFTgxqA2QWMG8IgFuf3c2xCR INCsJpAZHPG4kyCeix2O/g7M/+ll6+Zxo6pHfHFtup0FV+RuCnUKwXQ== X-Gm-Gg: AYBFou27OJ/T+N3pL6imideee6vweePj7scMRUGvy0GxabljmHhX+qWUVDWT3MuWMQV 2zCAIVqDOrAHcbEeH+bb0XkcrBIkh56roqDLiLtn6lA9TUE6TVDcGhQaT9EypKWIkKObBr+2khq O6kZkYpeQFd3d/ojfLNa88AjNy/iQxO2l19XMOT6ziXijxx24ct2FaMLdMgUEpHzXiytiQ2g4Rp K2LrfA6uHoiYYQ/9hH+5Iu1kw7YZWT8rP0wdulcDT7+7jpESZVqE8B871MYCclFiizisMI3hAAq 9v/WNvErLtpjMIIxAAeyK9vWsQsbz713xf1FTLguvhj3IO5cI640qvVFBfe0pcxZ5mM7GyrcDdN RVAqDR7oBQ0Q9EoLlX7qejMPD X-Received: by 2002:a05:6000:481b:b0:486:f97b:6412 with SMTP id ffacd0b85a97d-4887db3c08amr3796627f8f.46.1790342433001; Fri, 25 Sep 2026 06:20:33 -0700 (PDT) X-Received: by 2002:a05:6000:481b:b0:486:f97b:6412 with SMTP id ffacd0b85a97d-4887db3c08amr3796562f8f.46.1790342432393; Fri, 25 Sep 2026 06:20:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1790342432; cv=none; d=google.com; s=arc-20260327; b=cBUXlbvNXd+hHsBGLQWkeq9sXKM1FNLcsBODCPYO7gr5tnkRnPYrvgCw07RJEBIAf6 JtsrOiLsPeFjPrpDKg8p3K5oWrInbLCOI8VEXwXGqNI0vLph8dwmWPApJfD0Tq2+0DF5 FJ/ZIwaO7SRTNitkrBatXd2wI/P2LntarfQBq/fz/M1FN1ELx1etI83cFr7+G7ORqVm5 /Fcre5v4BwqWxJpeCOgPR653rMrxuCreXZS5/QadikOsyK7u2zdXDk45RO3ow8kMFnSj c0uWlPkr2kX1U83PKCcJaXDwzSaGJ4e0HIe5W1Ozws0nHIq6cDujw5B+nWBbHP+QN0P1 vTyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=/4Gk+GodcWGbYDbzWTH/qxi3IOjH8y0AyAqSxIb7A8I=; fh=WpT6aB7RBAGHZeWZzqAr71yzRFbPTYkPWKsRagLn48Q=; b=sm7rD0vCBGSAdx08B/unPsiuMMxqkezrHVyMSzCdJ8k9zAN9dNy2vG61ebdhHqxhuN RpBvzzORowvkr8H8FLVl1YyUC472WNTP/J2fk9seWfkN7NuG3fg3/SIfeVRLtm9StYFh umM67OzM7U180DrhqU9oHF1irnC8eWoUkBX2fbsdPLbfiNVo4D0W2k5SI/X6iDSheLsP Qbdi9SjYL8P3siHf9jDmyMS6uqSndvGRH7x3XvTerKMaOX6CO3UA6sy2nkjbQO6/9BHC 1aOP1mH5+jECwqt+dO9zkwIxax5uTDPPqJ2yBmdQlbXpDG7wVxRVGeJUIR/guhs93sm4 ZtlA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=hiR5sqaM; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4887a361ad1si4751300f8f.60.2026.09.25.06.20.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2026 06:20:32 -0700 (PDT) Received-SPF: pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=hiR5sqaM; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=/4Gk+GodcWGbYDbzWTH/qxi3IOjH8y0AyAqSxIb7A8I=; b=hiR5sqaM/xKy FtAlWplmW0jyBo3IVqW9DvOP/rgQPIKh44aLjEPmLdb78eqJVcFAWbE7q7PNDewFGCfrbEvviLGl4 GKuA6bpVQR1hKe1zdiAOzBWijIg7N3Q3bvokhp+zYsl3aBMff9ghaSNRNX5KauMwQUaQE2ZKtuPhv S6jy+qGj7OTyCT73KwpV3HhCXleKBtZ+SkKBhw6jvmQYkno6wz1Qy4T8opgGX2If/Ahcpb7uXFoKd 7f+0WN/8avWNoV3iRNtPLbcY7wIrzvNOKx9Pw6qjCi5B1p7HuOzJksflmzJbPdTxGEjSWdUPqZe4a euC5wvNZBM8pA94eg5DVrg==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=LekKit-T14) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xA5nr-008Bis-36; Fri, 25 Sep 2026 15:20:28 +0200 From: Eva Kurchatova To: khorenko@virtuozzo.com Date: Fri, 25 Sep 2026 16:18:52 +0300 Message-ID: <20260925132028.3630224-2-eva.kurchatova@virtuozzo.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260925132028.3630224-1-eva.kurchatova@virtuozzo.com> References: <20260925132028.3630224-1-eva.kurchatova@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v3 1/2] selftests: pstore: skip when no backend is registered X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org An unregistered pstore backend reads back "(null)", and every latter check fails. This also contradicts the pstore_crash_test documentation. pstore_crash_test has carried the comment, but never implemented it: # exit if pstore backend is not registered Fix by skipping an unregistered backend in common_tests. https://virtuozzo.atlassian.net/browse/VSTOR-142447 Feature: fix selftests Signed-off-by: Eva Kurchatova --- tools/testing/selftests/pstore/common_tests | 17 ++++++++++++----- .../selftests/pstore/pstore_post_reboot_tests | 3 --- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/pstore/common_tests b/tools/testing/selftests/pstore/common_tests index 4509f0cc9c91..8f140fa572af 100755 --- a/tools/testing/selftests/pstore/common_tests +++ b/tools/testing/selftests/pstore/common_tests @@ -55,6 +55,8 @@ operate_files() { # tested value, files, operation # Parameters TEST_STRING_PATTERN="Testing pstore: uuid=" +# Kselftest framework requirement - SKIP code is 4. +ksft_skip=4 UUID=`cat /proc/sys/kernel/random/uuid` TOP_DIR=`absdir $0` LOG_DIR=$TOP_DIR/logs/`date +%Y%m%d-%H%M%S`_${UUID}/ @@ -74,10 +76,15 @@ prlog "=== Pstore unit tests (`basename $0`) ===" prlog "UUID="$UUID prlog -n "Checking pstore backend is registered ... " -backend=`cat /sys/module/pstore/parameters/backend` -show_result $? +# No file at all where pstore is not loaded, "(null)" where none registered +backend=`cat /sys/module/pstore/parameters/backend 2>/dev/null` +if [ -z "$backend" ] || [ "$backend" = "(null)" ]; then + prlog "SKIP" + prlog -e "\tbackend=${backend:-}" + prlog -e "\tcmdline=`cat /proc/cmdline`" + prlog "pstore backend is not registered, skipping" + exit $ksft_skip +fi +prlog "ok" prlog -e "\tbackend=${backend}" prlog -e "\tcmdline=`cat /proc/cmdline`" -if [ $rc -ne 0 ]; then - exit 1 -fi diff --git a/tools/testing/selftests/pstore/pstore_post_reboot_tests b/tools/testing/selftests/pstore/pstore_post_reboot_tests index d6da5e86efbf..2edd48a87dda 100755 --- a/tools/testing/selftests/pstore/pstore_post_reboot_tests +++ b/tools/testing/selftests/pstore/pstore_post_reboot_tests @@ -7,9 +7,6 @@ # Written by Hiraku Toyooka # -# Kselftest framework requirement - SKIP code is 4. -ksft_skip=4 - . ./common_tests if [ -e $REBOOT_FLAG ]; then -- 2.55.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel