From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id D228D8017D for ; Tue, 29 Sep 2026 12:49:56 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68TCmSXk026141; Tue, 29 Sep 2026 15:48:29 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68TCmSXk026141 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="b77ojrb1" Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68TCmQt8026137 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 29 Sep 2026 15:48:27 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68TCmQt8026137 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-49e6b5c5f44so63420935e9.2 for ; Tue, 29 Sep 2026 05:48:27 -0700 (PDT) X-Gm-Message-State: AFuF++kAseoC7GOFPjbUkdTOPPDtk4evcQhIX8jmf3m8UtN/6fczXipG 7U3RV8qtLgVaSAkj6s3maMGZmIV0w7Y1PeC5BH4fMEK4OlM83Z9cCQTjfwBKBKNsKWswzrI5ySv VtOpRL07rXQN5ARnv6b/FLrpD3tLRB/cFPTPBZ35EUvglzLqP9KwsmA== X-Gm-Gg: AYBFou0bfVn6wTemBR/n5s69rb+VeEt+ZK8DencFIKJETaQZUcgTjMRdca8mrGYrSoO vcGQIhIr03d8fJK2OccsA4j1j+qwc7/WTp6if9S4OBk2ZnCnI8Bhbl+A7NyF7OiiwnwDc7rNBmJ knGYYCfHlYdjBRF2uNFY/E5qrDlJjtYOjE/pNKPQQqjDmD3px8QSBBzRGuV8NSaOhlKkpEfH6AV /h5+QWix3tZiraErmTj/3LfKhWgVSI3RC2T9Y67KjXUBn++eJmyWC6hFlTlzCFNpGbEb35iA8h2 FDH6IgHNV0vvEt+dFF+gam/jPKjJwWAIkpdrtvgs2+pk1tyb1Ho1DpWU1r7W7JosIOinQYDM3Al jMHk/H80ZQ6xU5SyX3GKTLxs91A== X-Received: by 2002:a05:600c:6287:b0:49d:827:e5b6 with SMTP id 5b1f17b1804b1-49fe7babaadmr259302585e9.20.1790686106361; Tue, 29 Sep 2026 05:48:26 -0700 (PDT) X-Received: by 2002:a05:600c:6287:b0:49d:827:e5b6 with SMTP id 5b1f17b1804b1-49fe7babaadmr259302055e9.20.1790686105673; Tue, 29 Sep 2026 05:48:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1790686105; cv=none; d=google.com; s=arc-20260327; b=di78EyO1LO+gLhqD11PvTxiPEmNQkkN2v0U65wRfLc3jT1Mwn98gDU9+mdDCD2Co8x diL4QJLqBhR9T7V3EGLRTXUjTKmaxedVD6GeItlWFZd1VqYO6J7dI6BXzwZd+q1E7qdA /YxEmO7+EXhFZhwCXjgLzKNEhE8W4iLPHZCAqCpJej6PVbbhxb5ew/m2oJHLPf7+tGNl 4ZFQ7K7nExn7JnfOS2vOHGwlnFvPh6OQ4s9wUuNsy/x+9qo75CP6t7VuKE5oFxma2zol BNVlVa6IbvJrz41sB5m66gzAFNYSYv5WgwHbgcUvPBYteW7K/pnRTVW4DQk7KqQcal7N gqgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=3PBvA59MfbzdD5Io8YgBhAwZMQAUKd5n81CXxlHdA+k=; fh=WpT6aB7RBAGHZeWZzqAr71yzRFbPTYkPWKsRagLn48Q=; b=J6PTNQKzs0yJOJn2PtEW2u69jE3659N6267O9aiEd5xXFgOiSlLmYs9mP+GtJy8v7M XznTLdBZS5Ys6J+rV0DRDb9pJ0/2Bp7nzawp+mAUs6c6dNC9TQzZ6CcP4O24moGrOsxX FrV4kHTAC45bSnnH5+6LDyTESZucwzjL5dU0gzTVmtwX5VuA1vcBajsFY/EQnL8X6BmP pjw6CYH0lYCWI0qClhN7JLMAKoYU3N1DsIfR+45SlZxeO/9OMLvpSjz/b9UpZ0usV2lZ g/tiIhFN/EPMq+nOPgOn+UHjBMxz6unJjXfXMHWespHA5wD/s5UKpJZUFG0tWQog9RT8 jXUQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=b77ojrb1; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id 5b1f17b1804b1-4a012685692si20711585e9.0.2026.09.29.05.48.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2026 05:48:25 -0700 (PDT) Received-SPF: pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=b77ojrb1; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=3PBvA59MfbzdD5Io8YgBhAwZMQAUKd5n81CXxlHdA+k=; b=b77ojrb1HsS5 1Wt+k1RNXkDXNX6dITNrnkUvCq0714yZMg5SYVG7V/Hvl1dGzKvDRpiCLUuwCy0NRkv9JpN6srPw0 WrALEPBzM7w6wO6yh8d1+gF5tUy0d+9Y9oUw5RCZBYtbv/QMYtqkl/od7/YwEI3lUI5i+2VHIu3BX IiK64B/Oh87D0QhsY+gOUqBSBp+kCCR5pZgjkjWr3d/3QbgOH7r03x7e6yTgixqP6bge79IqHCBR9 sw8JMt68C0UjgGOfH4vyuZm13IyrxhNpOdYkfONCqGbJZ8LyJ5nfUDqR7s8FzKoI/CN/BpHAUJWTc 6O8bXNqqYeS9d+sjbLpA2g==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=LekKit-T14) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xBXCs-00C1Rx-2x; Tue, 29 Sep 2026 14:48:15 +0200 From: Eva Kurchatova To: khorenko@virtuozzo.com Date: Tue, 29 Sep 2026 15:48:21 +0300 Message-ID: <20260929124822.770587-1-eva.kurchatova@virtuozzo.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1] ms/selftests: net: reduce txtimestamp deschedule flakes X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Willem de Bruijn This test occasionally fails due to exceeding timing bounds, as run in continuous testing on netdev.bots: https://netdev.bots.linux.dev/contest.html?test=txtimestamp-sh A common pattern is a single elevated delay between USR and SND. # 8.36 [+0.00] test SND # 8.36 [+0.00] USR: 1767864384 s 240994 us (seq=0, len=0) # 8.44 [+0.08] ERROR: 18461 us expected between 10000 and 18000 # 8.44 [+0.00] SND: 1767864384 s 259455 us (seq=42, len=10) (USR +18460 us) # 8.52 [+0.07] SND: 1767864384 s 339523 us (seq=42, len=10) (USR +10005 us) # 8.52 [+0.00] USR: 1767864384 s 409580 us (seq=0, len=0) # 8.60 [+0.08] SND: 1767864384 s 419586 us (seq=42, len=10) (USR +10005 us) # 8.60 [+0.00] USR: 1767864384 s 489645 us (seq=0, len=0) # 8.68 [+0.08] SND: 1767864384 s 499651 us (seq=42, len=10) (USR +10005 us) # 8.68 [+0.00] USR-SND: count=4, avg=12119 us, min=10005 us, max=18460 us (Note that other delays are nowhere near the large 8ms tolerance.) One hypothesis is that the task is descheduled between taking the USR timestamp and sending the packet. Possibly in printing. Delay taking the timestamp closer to sendmsg, and delay printing until after sendmsg. With this change, failure rate is significantly lower in current runs. Link: https://lore.kernel.org/netdev/20260107110521.1aab55e9@kernel.org/ Suggested-by: Jakub Kicinski Signed-off-by: Willem de Bruijn Link: https://patch.msgid.link/20260112163355.3510150-1-willemdebruijn.kernel@gmail.com Signed-off-by: Jakub Kicinski (cherry picked from commit c65182ef9df6bb96fd85b56a2bcdd18d64c4d3b5) https://virtuozzo.atlassian.net/browse/VSTOR-147735 Feature: fix selftests Signed-off-by: Eva Kurchatova --- tools/testing/selftests/net/txtimestamp.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/net/txtimestamp.c b/tools/testing/selftests/net/txtimestamp.c index dae91eb97d69..f13615654970 100644 --- a/tools/testing/selftests/net/txtimestamp.c +++ b/tools/testing/selftests/net/txtimestamp.c @@ -206,12 +206,10 @@ static void __print_timestamp(const char *name, struct timespec *cur, fprintf(stderr, "\n"); } -static void print_timestamp_usr(void) +static void record_timestamp_usr(void) { if (clock_gettime(CLOCK_REALTIME, &ts_usr)) error(1, errno, "clock_gettime"); - - __print_timestamp(" USR", &ts_usr, 0, 0); } static void print_timestamp(struct scm_timestamping *tss, int tstype, @@ -599,8 +597,6 @@ static void do_test(int family, unsigned int report_opt) fill_header_udp(buf + off, family == PF_INET); } - print_timestamp_usr(); - iov.iov_base = buf; iov.iov_len = total_len; @@ -655,10 +651,14 @@ static void do_test(int family, unsigned int report_opt) } + record_timestamp_usr(); + val = sendmsg(fd, &msg, 0); if (val != total_len) error(1, errno, "send"); + __print_timestamp(" USR", &ts_usr, 0, 0); + /* wait for all errors to be queued, else ACKs arrive OOO */ if (cfg_sleep_usec) usleep(cfg_sleep_usec); -- 2.55.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel