From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 9A0D980776 for ; Fri, 2 Oct 2026 21:28:07 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 692LQij7026174; Sat, 3 Oct 2026 00:26:46 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 692LQij7026174 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="CoA9gzJ/" Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 692LQiUY026160 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Sat, 3 Oct 2026 00:26:44 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 692LQiUY026160 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4a0284121c6so1428215e9.3 for ; Fri, 02 Oct 2026 14:26:44 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBzEsfCQldI1nQ3q+x56oXlX3JKMrfzAwzM0CgnZvkGA2/fTowg8WWiZnJJJxSKuv+oFWsdrNQ==@openvz.org X-Gm-Message-State: AFuF++nzr6S5nWsCGDASXIfhY5p+ZiGopsPzHLSj7GhJ2dvz1MLcLw9u 94jW9Rya6qb3zOPXEhgS8bwjSkPSdcs4icezZQPXGOMoFoTlbxo4UMv3YMa0q8IvUG5N66dS8RF VaFn45NApMqA6LuXL12ZeyYE3d9HhuNvvwLu2OKX8j5g3/OmPIkhiuA== X-Gm-Gg: AYBFou3hEB8hEwNzksyFw697eZJTtaAGksR1E+XCIV5bzZRzxEIns6ovlXPTL2SSdKn fHvJCZHMNus1bXqq6zN1TPXO2Q6KJoEd9esvUz0lhYme7G492uDsJXo05HQ6bDDim0IhLWXWQf6 VOfIl6XJdI4vqYCeom79TtGN+7fv5qwv4IfqEuH1pUfjKBQFS6LzAdR1l7bGwXLhBpCa9Japox3 8MpDvgagJ16hdSsfmxL0jc3v3GqQfTxj6YHmzls0kOIJsqmbasfCJAQ7Bq1xOHBpwrrFSNf6agK 9pyKy/t2D2uWfFSDPBr3iCRfylyZO02wnxNJ7c3k1je8nZXVHj5CwFpxS4KSIMd0irFPnECIzOc KHcJIFNqyURCZFem43ynsjtffmTGpbw== X-Received: by 2002:a05:600c:4705:b0:49c:fc6e:a3da with SMTP id 5b1f17b1804b1-4a1680ffb88mr8889835e9.25.1790976403976; Fri, 02 Oct 2026 14:26:43 -0700 (PDT) X-Received: by 2002:a05:600c:4705:b0:49c:fc6e:a3da with SMTP id 5b1f17b1804b1-4a1680ffb88mr8889705e9.25.1790976403484; Fri, 02 Oct 2026 14:26:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1790976403; cv=none; d=google.com; s=arc-20260327; b=RNPEs/7ZjRou6MMGyTxDforMBspJrnNc3GnMKoLT7gDEFyKy2k32HjHAXSEN7OtZQc Tw/MXeMNfTeFiZoqeYFmmg6R2ccLsIBIMNmWSFt+NDEC271KUsEjYVuvhuuRjCMHMVtq Uov34X8Ko7rE5VatOL0T7fPv2xQ6NSIga1RjjixIywqmSTo3WE/ytxhj7bP0S6WZec4r FvN23Yh8KU9zreRPX+GNGSmR0nxIVu2FBd1bVBGbp/0OxW3tkWGl9quVST99W/z1ysqs wuVafe+64LkJoTbOQ/jXdcy/IjZlN/48Cuz8ckWlexbgklgJ/yYPhdwD1cGiktKdblgY QJDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=9/eAv5ZJUiHIgCPsZDCkRUiNid5/Zxw1jfsl5Ua4B9A=; fh=vUECVpjOjIdz431s8bRiKYBdScEDOVhPZlDu2AQ+txg=; b=Y6BicjNagbwiY03gqVVUB9LVjm5KyjLJaPFsS6vv/PxUGwZjxzwVtxyuBxxG1kkfMO Fg2tjyas7UiDbo9ckGxCkVK+9ntGss+QqXfOPe3XuUus2fc0iTOAJPFoDov7hpKgaLpP xsZeq6N3AzI1WXq980El4LsgLRJ+2XMd+q/E+BaSlbMLlGhMpxvzBf+X5z0nVKAdHoYQ TRavkCUYgqOYBmzEBsFfvsWO7/rlSU5tNTQs0FWizG9eEWeMvcgkRry4t9n00wijga4u ODDAEXuSVslFjPIviTbtCFnnvkcQlu1bInh4uhErYd7u8xSjRvUjoGL1DYHSSnays/w5 M0+g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="CoA9gzJ/"; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48b5b43fb79si6268671f8f.415.2026.10.02.14.26.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2026 14:26:43 -0700 (PDT) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="CoA9gzJ/"; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Content-Type:MIME-Version:Subject:Date :From; bh=9/eAv5ZJUiHIgCPsZDCkRUiNid5/Zxw1jfsl5Ua4B9A=; b=CoA9gzJ/LdVvZ+AyLsm 9iOvdZyxFae8MABUeF1AQwSzq17TVOwSEIuPrUMMyUE6az6nbjMbHgU5prQV28texrH9wwQqTdae+ Wn35+VNGRGOcsmv1eyxDPEhh3RDUzMesWkoFVo91fUn/rmWVlIPnAVDOHVMOTkRRqp+jSLTxrreDb 4WjXtBMRY2yjsCG+ce3laJG7qdfJ4EVEQ0AgLYOMCI6uXnH/js+gUdljfZBUpN2P5b8j6EG1NTK4C O8wDFtTRQJOW2SHNjHyTGyrrgjxU2vOtbaXFOlTRLUF3Tmz8Rz1WUgyuIMkm21dNGPPMkURChmtng 7lJPwWdhwYTpyZA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=192.168.1.87) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xCkj1-00GcBK-3D; Fri, 02 Oct 2026 23:26:39 +0200 From: Vladimir Riabchun Date: Fri, 02 Oct 2026 23:26:10 +0200 MIME-Version: 1.0 Message-Id: <20261002-ve-printk-irq-v1-1-cb55896d455c@virtuozzo.com> References: <20261002-ve-printk-irq-v1-0-cb55896d455c@virtuozzo.com> In-Reply-To: <20261002-ve-printk-irq-v1-0-cb55896d455c@virtuozzo.com> To: Konstantin Khorenko , vasileios.almpanis@virtuozzo.com X-Mailer: b4 0.14.3 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 1/6] ve/printk: Add sanity checks in ve_printk functions X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org This patch adds dst sanity check and reorders VE_LOG checks in if. https://virtuozzo.atlassian.net/browse/VSTOR-146839 Feature: ve printk Signed-off-by: Vladimir Riabchun --- drivers/base/core.c | 4 +++- kernel/printk/printk.c | 8 ++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index ebc6c5570a4d..2d233ffb5661 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -4945,12 +4945,14 @@ int ve_dev_printk_emit(int dst, int level, const struct device *dev, const char va_list args, args2; int r; + WARN_ON_ONCE(!dst || (dst & ~VE_LOG_BOTH)); + va_start(args, fmt); va_copy(args2, args); if (ve_is_super(get_exec_env()) || (dst & VE0_LOG)) r = dev_vprintk_emit(level, dev, fmt, args); - if (!ve_is_super(get_exec_env()) && (dst & VE_LOG)) + if ((dst & VE_LOG) && !ve_is_super(get_exec_env())) r = ve_dev_vprintk_emit(level, dev, fmt, args2); va_end(args2); diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 8940b36e790b..efe2c3279c85 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -2535,10 +2535,12 @@ static asmlinkage int ve_vprintk(int dst, const char *fmt, va_list args) va_list args2; int r = 0; + WARN_ON_ONCE(!dst || (dst & ~VE_LOG_BOTH)); + va_copy(args2, args); if (ve_is_super(get_exec_env()) || (dst & VE0_LOG)) r = vprintk(fmt, args); - if (!ve_is_super(get_exec_env()) && (dst & VE_LOG)) + if ((dst & VE_LOG) && !ve_is_super(get_exec_env())) r = ve_vprintk_emit(0, LOGLEVEL_DEFAULT, NULL, fmt, args2); va_end(args2); @@ -2567,10 +2569,12 @@ static asmlinkage int ve_vprintk_deferred(int dst, const char *fmt, va_list args va_list args2; int r = 0; + WARN_ON_ONCE(!dst || (dst & ~VE_LOG_BOTH)); + va_copy(args2, args); if (ve_is_super(get_exec_env()) || (dst & VE0_LOG)) r = vprintk_emit(0, LOGLEVEL_SCHED, NULL, fmt, args); - if (!ve_is_super(get_exec_env()) && (dst & VE_LOG)) + if ((dst & VE_LOG) && !ve_is_super(get_exec_env())) r = ve_vprintk_emit(0, LOGLEVEL_SCHED, NULL, fmt, args2); va_end(args2); -- 2.52.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel