From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 15D3B802A5 for ; Tue, 6 Oct 2026 21:55:31 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 696LsGpQ028144; Wed, 7 Oct 2026 00:54:17 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 696LsGpQ028144 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="NnlBxbrD" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 696Ls9gC028111 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 7 Oct 2026 00:54:09 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 696Ls9gC028111 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-48b028d93c5so1951632f8f.3 for ; Tue, 06 Oct 2026 14:54:09 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvByJcex2iFRqZH5a7OMlS6DmwK+sbz4vYgdBXIfbBayCXbMbwY1A2zFLClQPv/Ph5TilbVSSzg==@openvz.org X-Gm-Message-State: AFq9FYJXLR5tG1tmgvAtTOhmICgJFWoU5AQGhk2B3p4cO2CTC9QGzMC1 MZtOgU5cn4+3kzxR6nYrpu+u/bmgyL4UVBg9bI8dOH8dKpomYg2bcKSjW/wHMhgvMD8iQ87VY0H yzqXx5EJEzjCSWYvObo8LIL1UTDTRhkC5Uind7KCXfj7vefQFuxAQug== X-Gm-Gg: AYBFou0kKpHs2Qr8WapKTmPTmoP3s6ZcZYCgkRGLpYEFebEQQTqa+LGZHdh/qlMEVNr KNfWh3DW3gD/bFiVuusp08uaYVtpyy9Q48u5yjgHMNzfxMZb28OdruqvLo9sIVuiQhhZZl1yYv2 xgg+ZMeOTifJuRL+RNSBvNvROboghiDIL77Sk9Z8wGKbu6779BlSeNQiW+Dp55WmCfneZlZhynl 2Gtx2cZiFC5SPLVeBG4AXeEUHqE/ev5PdCUMh0Sn/LZMZbGnhblh2i52GRkb0YvHsYB5DpQx/vq jsZ7bArmyP/G4jiYI30kqhvNaVG3MqsCs4lrP5/DwXM68lAuGvC8AWupzCwh7UQypYKWba08NkL MDY53lvbkwKjrSbte8GZBvC1NRT9j X-Received: by 2002:a05:6000:4312:b0:487:1646:8740 with SMTP id ffacd0b85a97d-48c7278f1e0mr1138647f8f.29.1791323648844; Tue, 06 Oct 2026 14:54:08 -0700 (PDT) X-Received: by 2002:a05:6000:4312:b0:487:1646:8740 with SMTP id ffacd0b85a97d-48c7278f1e0mr1138630f8f.29.1791323648334; Tue, 06 Oct 2026 14:54:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791323648; cv=none; d=google.com; s=arc-20260327; b=PS2KaIcywj7pytTpZRBREFZ1xbxFdqCe7DsGFFhLodYGFekXy+n6thlRfW0xYXSQDD UiXbq6AraOrdyKLjFSpk3EL90sXO0L7vWLMzNlZY/MgN3YIfw6Ju7PVP8+chPq4LXTvU i9x9uqwY3uDikuc8cPISXjAnAxJn++7aBPYyUbez8UN93ZF5TYkGtjaLIM6xnytgMVjU wBTX1FS7zYpBaZ26zoUeKVkXtWUNo2iN7tYNiOxeDgo1iKiYpf4skZpkEuT0LZW0mai6 EIDwHxnQR5SQjCkJHxmoTErCjO4w3+hAXoEZ7Cx3r2Uhbr77Qthsm4j8Il68PpiJHx29 5b4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=9/eAv5ZJUiHIgCPsZDCkRUiNid5/Zxw1jfsl5Ua4B9A=; fh=qxDc+R3aPG8cEdp5mmd3IFOllj1eLCwZHAcc+Tf/KXA=; b=UJ9o/bPhR8+eAJ4ZVXYg9yTD9tjAytWtY8c2Ei5LYnCG++3YKWOrFAFeHHYBzAFztX roBys66MTM+eVY2osecJ+K5B7IZ3M6Bcec5397Grf3K1k6/mWYtI1zc5LPRNZGw1eoPG B6FnjLXLhyiXxqOHk+p3Sr8ZX5JbhXjVR59smcWtMLMrGv3WSYxPHbyuDfmiX6ZHB0qk FUaYtiaW25QcA1o11RzFVLriFLKDhkp9hI/0yurgAW49Yi6EZi8o4KjjSn2I4pq14Azi XSnSBmlIC2aoji99SOOZdAy3B147+48Wo2U0X9KFPvUsa6OynH2jP6U5huCff/zy6STC Mqgw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=NnlBxbrD; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48c724bf7f4si1321455f8f.491.2026.10.06.14.54.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2026 14:54:08 -0700 (PDT) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=NnlBxbrD; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Content-Type:MIME-Version:Subject:Date :From; bh=9/eAv5ZJUiHIgCPsZDCkRUiNid5/Zxw1jfsl5Ua4B9A=; b=NnlBxbrDPPSawmZtx4F arQiV0AQGU0J2l0DJ1aBfCCprY/8zX4mC33dYUjRzBW7cAjIaxR21mX8SRmmafYBCCr9lzMsdigW2 pxmSr0i83FJh5ZH3r++GiOdu1vHTHIVO8P0CyXzdssWkUuX6hAVSuylwzVSVOdIUV8EFGWYNGcokc UKVsYAVJaEZAjHK9yKlwogDNoGErZP1HWOSipBJpL+aqmehDxxfn8Sr/5bHpNNf3Xw4h6xhhLmhIJ jrlZvZnFpiU6j8b8e6vCO2xYcsllVofBL/wIstOCxTiRQ4p+Kyzuq+3UZYE22/+dW9y0xBDUnRkRT vD/nGNXfgBLGdRA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=192.168.1.87) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xED3e-004Dgb-2P; Tue, 06 Oct 2026 23:53:57 +0200 From: Vladimir Riabchun Date: Tue, 06 Oct 2026 23:53:52 +0200 MIME-Version: 1.0 Message-Id: <20261006-ve-printk-irq-v2-1-db1dc4f6ed07@virtuozzo.com> References: <20261006-ve-printk-irq-v2-0-db1dc4f6ed07@virtuozzo.com> In-Reply-To: <20261006-ve-printk-irq-v2-0-db1dc4f6ed07@virtuozzo.com> To: vasileios.almpanis@virtuozzo.com, Konstantin Khorenko X-Mailer: b4 0.14.3 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v2 1/6] ve/printk: Add sanity checks in ve_printk functions X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org This patch adds dst sanity check and reorders VE_LOG checks in if. https://virtuozzo.atlassian.net/browse/VSTOR-146839 Feature: ve printk Signed-off-by: Vladimir Riabchun --- drivers/base/core.c | 4 +++- kernel/printk/printk.c | 8 ++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index ebc6c5570a4d..2d233ffb5661 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -4945,12 +4945,14 @@ int ve_dev_printk_emit(int dst, int level, const struct device *dev, const char va_list args, args2; int r; + WARN_ON_ONCE(!dst || (dst & ~VE_LOG_BOTH)); + va_start(args, fmt); va_copy(args2, args); if (ve_is_super(get_exec_env()) || (dst & VE0_LOG)) r = dev_vprintk_emit(level, dev, fmt, args); - if (!ve_is_super(get_exec_env()) && (dst & VE_LOG)) + if ((dst & VE_LOG) && !ve_is_super(get_exec_env())) r = ve_dev_vprintk_emit(level, dev, fmt, args2); va_end(args2); diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 8940b36e790b..efe2c3279c85 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -2535,10 +2535,12 @@ static asmlinkage int ve_vprintk(int dst, const char *fmt, va_list args) va_list args2; int r = 0; + WARN_ON_ONCE(!dst || (dst & ~VE_LOG_BOTH)); + va_copy(args2, args); if (ve_is_super(get_exec_env()) || (dst & VE0_LOG)) r = vprintk(fmt, args); - if (!ve_is_super(get_exec_env()) && (dst & VE_LOG)) + if ((dst & VE_LOG) && !ve_is_super(get_exec_env())) r = ve_vprintk_emit(0, LOGLEVEL_DEFAULT, NULL, fmt, args2); va_end(args2); @@ -2567,10 +2569,12 @@ static asmlinkage int ve_vprintk_deferred(int dst, const char *fmt, va_list args va_list args2; int r = 0; + WARN_ON_ONCE(!dst || (dst & ~VE_LOG_BOTH)); + va_copy(args2, args); if (ve_is_super(get_exec_env()) || (dst & VE0_LOG)) r = vprintk_emit(0, LOGLEVEL_SCHED, NULL, fmt, args); - if (!ve_is_super(get_exec_env()) && (dst & VE_LOG)) + if ((dst & VE_LOG) && !ve_is_super(get_exec_env())) r = ve_vprintk_emit(0, LOGLEVEL_SCHED, NULL, fmt, args2); va_end(args2); -- 2.52.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel