From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id E0E0A8017D for ; Mon, 12 Oct 2026 13:28:32 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69CDRMd3022933; Mon, 12 Oct 2026 16:27:23 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69CDRMd3022933 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="oi+ewiLa" Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69CDQukb022861 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 12 Oct 2026 16:26:56 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69CDQukb022861 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a013ea30c0so13028575e9.0 for ; Mon, 12 Oct 2026 06:26:56 -0700 (PDT) X-Gm-Message-State: AFq9FYL2XmWlcr8iKntOVGKSbxZEAXPBQs9sS69Xy7FNOILgrwAjY5JE 79uiDL7HQUTSHFC4P94e47Lp/ob1p2isY3hsS4iXaOJVJOpIZ0NKClS0Tm46DFosNvCSTu20EfR 9jP1EdOr8mQQ/SJ9bqqAr19HVxLktC96C8EF6zNkmCodJhmvKpnTQxQ== X-Gm-Gg: AYBFou3FGptrl2oBaZuIful9o9ZnEp9k6on9V/84N+Upevp2bGszIBFqpYW69xP74c+ eHosqQKE916G8WIt5KMsn670sXJSMOctdTCTAN+6LqXRv6npS5kwZFnugWhW8raECYnZzg0dsf7 9VJw8AHxMGs4jjmPGa485M/epjzxTJ7WTAtHIJko5mZdCDeOg6KpTtHfMfOgFXQ4C7iy+2oqkcG err285M8Xx+RnubixHf2qyyri84Oja/Gdn4jxbOHkBd1OXfkIWpoVFP4Gt22srgg4iGkGgH2aNJ LdCTkX3jmKEPhBhDJiye/7W5Bs/1nYMI8mTiQ8u/0SWoY2shc+7/LtWj9UaRvmZ+kkwETIrJ2g0 3LYlKsVRgdjkAyShq/M+wAaqJelhC X-Received: by 2002:a05:600c:4e12:b0:4a1:7f8e:6e5d with SMTP id 5b1f17b1804b1-4a18e4a393amr190942435e9.6.1791811615873; Mon, 12 Oct 2026 06:26:55 -0700 (PDT) X-Received: by 2002:a05:600c:4e12:b0:4a1:7f8e:6e5d with SMTP id 5b1f17b1804b1-4a18e4a393amr190941655e9.6.1791811615229; Mon, 12 Oct 2026 06:26:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791811615; cv=none; d=google.com; s=arc-20260327; b=laW+J8C3eYOSUj5HGhMheUk6c/U6JuGR9lLkw2xhoc+2mLN6WRPlbuLdVsdoSY5nqJ uoCLbJ9v1WU9MByZbyvaGjOY1uvqI1KhV4eLKymmxeWl13RQi4oRAEo2R/v0U0iJX1oG kq4q5s5StLzbQe71FgRSOTlao9DVlZVpP49Osy8QljNjWaheNFPyLiOB25fQEzN4OBUp B3t725wRVVZhdUqzt6o3YPkPvaPoiIEnABHLscHuh33GmTOGNUqdD9nZNsEycUK4JQqS CY3RbGH558wjSlNLS0yxirk7IfuR+7lB1w0DcYPnFPdhwou91dCkUNUwkFwxpbb2O8aL z7rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=2p2b9RxcRMJabfaJ5Svw0SnmypEXzqX8smn6c3HPyIU=; fh=M+TyAUhAp4+t7uzAVeqNdLHW5eNz2FQXSv4TjrRhpCk=; b=mIvVHGaZI4L+J/1SIkoI4aN43esgmdaIUQs6Ildjdgw2JCe4hU/zaZeU85NPXwewGP llXfgy9wmCFe1CgWawua+eXSmDxJkTJdiJA+JobUvlSWHVrnr9DDD5caA/+TARM+3zRc xcy2GNL8G0RD8mUixINbDSAK4y7uALFgyVSsETD2JGWRTCVNwYffaVY24rqLYNOufwje /RBDmLfMkeycmyl78JzDwNfxnH4pZ6HJwpqbs85tmqr3GDDEZyt23Q9zZvNnkKtbDQHF W+iEMFRbmpySE1fxmc2YN0yqnZsQsUY+AQ0XzojXSRisYGVgS6aCPJrMC4a/cD2o0MdB tExQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=oi+ewiLa; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48db9ae60e3si19658420f8f.339.2026.10.12.06.26.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2026 06:26:55 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=oi+ewiLa; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=2p2b9RxcRMJabfaJ5Svw0SnmypEXzqX8smn6c3HPyIU=; b=oi+ewiLaShbo Wsv9NhzJiCmNS6uBh4GLdNqjHNjYttAGLhiDUnVOlURvY8VoCej4UajCiJZyEYQSoxZNKYHE+3Fp2 ezS5iQbTkcETO75UQsC+zxky/75hsRH70tawzTYDxThMauJBYVT/W39KowSshK7fb3xlRtq/coe6u lH6jFCFVuvJVeVGeFUQVngcl8C+c7deMLc7mkR9Lrn1/NWPnq0620hysKw4x43itcvx8P8IJPqgPo DAF0ABD0BOKpHnqxcNrd8BlNsuRN8Orf4526mmRPmK0WqFXKojBPnGgiv8ZAeY+4S9kARdJPl6aza KeIEbFhvT1JnkayhtehOaA==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xGFzw-001WAY-2L; Mon, 12 Oct 2026 15:26:46 +0200 From: Alexander Ivanov To: den@openvz.org Date: Mon, 12 Oct 2026 15:26:42 +0200 Message-ID: <20261012132646.41494-8-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261012132646.41494-1-alexander.ivanov@virtuozzo.com> References: <20261012132646.41494-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v4 07/11] dm-ploop: take bat_lock around md page lookup in ploop_llseek_hole() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org ploop_llseek_hole() walks the md pages tree without any lock, while resize inserts new md pages into it in ploop_add_md_pages(). A lookup racing with rb-tree rebalancing may follow a stale pointer or miss the page and return -EINVAL. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-ploop: ploop target driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-ploop-map.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/md/dm-ploop-map.c b/drivers/md/dm-ploop-map.c index 92ceadf41b42..691284a239df 100644 --- a/drivers/md/dm-ploop-map.c +++ b/drivers/md/dm-ploop-map.c @@ -2772,7 +2772,11 @@ loff_t ploop_llseek_hole(struct dm_target *ti, loff_t offset, int whence) while (clu < READ_ONCE(ploop->nr_bat_entries)) { if (id != ploop_bat_clu_to_page_nr(clu)) { id = ploop_bat_clu_to_page_nr(clu); + + spin_lock_irq(&ploop->bat_lock); md = ploop_md_page_find(ploop, id); + spin_unlock_irq(&ploop->bat_lock); + if (!md) return -EINVAL; } -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel