From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id E03598017D for ; Tue, 13 Oct 2026 07:57:07 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69D7tuP4010043; Tue, 13 Oct 2026 10:55:56 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69D7tuP4010043 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="elMIl8vt" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69D7tSr9009962 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 13 Oct 2026 10:55:28 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69D7tSr9009962 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-48b02e93a1eso2018826f8f.1 for ; Tue, 13 Oct 2026 00:55:28 -0700 (PDT) X-Gm-Message-State: AFq9FYJfq+0Q98EAatRs103X5/DAqBCw9FnGcXsvRYX2VF4opQ9H9WdI OdK/2nOvZZKaJbNYob7NWqHDyH+JJmlo9qfh+LqOpLGPa8gZk/4Q3u413Whh+MYR3OmSOzf9CG/ KV9DDn9oDDsh5leE3zcnh+2und0SL/9eUpLtDLnuI2o/cw8pFfGgO3g== X-Gm-Gg: AYBFou3Vj95jZ+Kb3I1y9Xg4wPtYTt5EjIOSMNg2OmStaHxJbuROmac3NXw8p8uvsFT 8OD5OeQ9BqZklrK/lo+9GJP7a32TaVMPjdH07WwZ9W9Mk/hznaompE0F1C/UPhpz+9RtIWlUdcA jxg/l7Nq7I9YgAtWaq+I27EFuNJ0t9c/M4JdsTobJGzbAswmO9Qyb1qkieI/dSFzR7dUPsRelQ6 7pSdxnxCJKeNCGV2YY0k2AcqHfzPJo1cxMk+wAx6gfhGphKVDUvS6ELoBkHuHLWM9yy19u05Gcf KNyxkNdUJsbOBkGVyjiDu2ZcxGH3+j7cnx92rm3qr4Wmz+HWMGAFTv7knQDrZml/nNvgbJb4pU3 FuRk40KVWxZBKGJV2kgquAm8s9Sr1 X-Received: by 2002:a05:6000:491c:b0:48b:f50:1a57 with SMTP id ffacd0b85a97d-48dbaadcf71mr21067352f8f.12.1791878128365; Tue, 13 Oct 2026 00:55:28 -0700 (PDT) X-Received: by 2002:a05:6000:491c:b0:48b:f50:1a57 with SMTP id ffacd0b85a97d-48dbaadcf71mr21067307f8f.12.1791878127827; Tue, 13 Oct 2026 00:55:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791878127; cv=none; d=google.com; s=arc-20260327; b=q+TG13dB6qY9OHsWVnc2+SK6YmzhUslT3WlIZeVdAJf8mXQfIGLdeKxAxkF8sz/yrG XAyYcmBhJ5++gmoi95fIMv9Zxbp0tSPnAE2Lgu9Kg9BBCcftLMxbJ0IyGIScLBnkpLzw Fm/QLPMMY7kojgwEe64Cn7h1Ib2EUxuVFx2ye6MHzJq91SPpyTl7VoEsuMQHdA6N57e7 1YCuwumr2eZ2EajRQ4Kru4ksKkSBo8gcejC6x4tIHUE3eX+kn4kA282e1BC1ZjTpDV/6 U32eIpVQJQqxSzGkX0PPWRxK6wJxBpvYEw0jRIQexRJQT401bZC3pBva+5WDzMqT9yEl 9xgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=2p2b9RxcRMJabfaJ5Svw0SnmypEXzqX8smn6c3HPyIU=; fh=M+TyAUhAp4+t7uzAVeqNdLHW5eNz2FQXSv4TjrRhpCk=; b=MsOeDviC0QJIaldOaBLeXJjt0JsnCmUJ6X69qh6mKo9ZqnJBs5din+MPopnI1tt1/5 NaOxKxyGVQjJxy0knt87WkyBQfVpEF53kQyX8KOCS488hpq1pWanbVcaoLcBWgaLfcYV umXLr6zBY3GRjNqXsvL/OCTAn1j/VXPGrrbdr1+cDsLHSdks2MzODjesMiBMajU4giaH 4jWQYszQ09Y9HgerHC/yVvle9cvEND2fnS1c3eL/LSdSfRzltV3gNStNvpO7rUSpTwig vY6+yBjN2PZnGgN5H1f7iXU72pUh1pgocfSk+bzYSAenMGrCxBB/JYvVAiwPYRcoDJr/ A7qg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=elMIl8vt; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48de0c85486si3704521f8f.312.2026.10.13.00.55.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 00:55:27 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=elMIl8vt; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=2p2b9RxcRMJabfaJ5Svw0SnmypEXzqX8smn6c3HPyIU=; b=elMIl8vtHecr 2gK4mlRc2YcEnORc7cVCwh1z1oDti1SUxyiyPg6A+QCdVXoLoiLZfvMFN1sI14g2zkWpjmLGPCUh9 bcgE7/3Ax6MFhpSByhUWuR892te5QWlTHcGravIBoUHpd0Dd/vtreCRkh4G900WvcBAIRSSmbMzTJ XGK1HBWoCIbDfIUDHpokjh2wykcRljU0yY7xbnowmH4Md3iYIygV2pVkA7U840/QougZ0niS22xDb 1qGfcZJZd5bMpQZxX/rCPHedZZnRoTmyhxbWJPXGS57SdW556tJAx3a3h/SdbBp0gI3acQmeVhLuA QK6jFaS6G3dhGcT7rkYG6Q==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xGXIh-004zlI-2L; Tue, 13 Oct 2026 09:55:17 +0200 From: Alexander Ivanov To: den@openvz.org Date: Tue, 13 Oct 2026 09:55:09 +0200 Message-ID: <20261013075513.90618-8-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261013075513.90618-1-alexander.ivanov@virtuozzo.com> References: <20261013075513.90618-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v5 07/11] dm-ploop: take bat_lock around md page lookup in ploop_llseek_hole() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org ploop_llseek_hole() walks the md pages tree without any lock, while resize inserts new md pages into it in ploop_add_md_pages(). A lookup racing with rb-tree rebalancing may follow a stale pointer or miss the page and return -EINVAL. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-ploop: ploop target driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-ploop-map.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/md/dm-ploop-map.c b/drivers/md/dm-ploop-map.c index 92ceadf41b42..691284a239df 100644 --- a/drivers/md/dm-ploop-map.c +++ b/drivers/md/dm-ploop-map.c @@ -2772,7 +2772,11 @@ loff_t ploop_llseek_hole(struct dm_target *ti, loff_t offset, int whence) while (clu < READ_ONCE(ploop->nr_bat_entries)) { if (id != ploop_bat_clu_to_page_nr(clu)) { id = ploop_bat_clu_to_page_nr(clu); + + spin_lock_irq(&ploop->bat_lock); md = ploop_md_page_find(ploop, id); + spin_unlock_irq(&ploop->bat_lock); + if (!md) return -EINVAL; } -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel