From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 4454880726 for ; Tue, 13 Oct 2026 11:17:35 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69DBGNkm012500; Tue, 13 Oct 2026 14:16:24 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69DBGNkm012500 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="q2mO/1Jp" Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69DBGBR4012447 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 13 Oct 2026 14:16:12 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69DBGBR4012447 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-3a7845604d1so15682081fa.1 for ; Tue, 13 Oct 2026 04:16:12 -0700 (PDT) X-Gm-Message-State: AFq9FYKr4RoZm72YslyA+5uNf87R7/6gsQ26sxdx6pqkzmFnFMernzRb vbMVyFtJJQtWaaKateO8J6pHqOpw3luSihMV8smVauCSI/+gEox0kdnoeoAGv0vJPq12ySpelE1 Ady2wboiybC7E4fSBCEcx3bSuvZrxZAO4T2TQdKQMR+8qePdAlNuE1Q== X-Gm-Gg: AYBFou3VVE0Uzg5EeE1Wg+JRNBT1vL9NnpciV+eDHsm0TQtA73Cw7zVd8d74nXUHtJx p2y/V1OC2Et1Mn5NK6MI0i5zzOytb+bUgV9xdFItaBA2IWM/dw/7w0DS3cb23YkCsiUe6zoa7Jv D80Oxa5oG00hd/iC2XiVuMS77fY3vtPPt+2YSQZqEVmvGdzav64B65qCcHoLXVadaaQh36w5L+l 0rKp4/Yy9ZU3dZqBbMOwW9jhxow9dcr2GnkcEmU4qWmf6rXDvhTbT3+QKNzNAfUvvqiJI9588/z RMqidbOVZ2eLQ7wrqXEbu0oabeK1VoXkpMNGuHkJhjgGBMitJGi5zH0Q/Le16F0BJa2zAX/WP5g i00tsMxFbREFkUdLPGssfcDEoo4c= X-Received: by 2002:a2e:be85:0:b0:3a4:850c:5900 with SMTP id 38308e7fff4ca-3a9c53534fcmr29157321fa.11.1791890171618; Tue, 13 Oct 2026 04:16:11 -0700 (PDT) X-Received: by 2002:a2e:be85:0:b0:3a4:850c:5900 with SMTP id 38308e7fff4ca-3a9c53534fcmr29156691fa.11.1791890169944; Tue, 13 Oct 2026 04:16:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791890169; cv=none; d=google.com; s=arc-20260327; b=olwSWjp2fUufK9aOZcgJv/R/pQT1Tq6YgF44kmZZRKP2+ZGkeNDOFgZUc5sA1fJQhs 8TV26LAaHJiy1KhdGSxlve83jWnmT8cawL1m7KgNpqMCLDnLSNoDLdA6WOrdLBIPtWwr srYDbe9/+mR2Bf/FUsP3/cwi2fq2dqMdV6aRvRygju637IM7uuK7JgznfRYD1OR8Akoj LeR/rxdvcsLLIjABaP4O29o1m+75ujXeyJU5x8ECZaGBMO67S0woCXZ9diK0ZpCgZ5F+ 1taU51cvlMjSuoAjivycbUUwYu3Il/g4ERxFGbm4w1P31SAkan74gJn3/PI0z7Z/O6lY b5Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=tj9oV5sudd4onI61vAo7lfIUu5DtFQHB0f29SE0KHMo=; fh=M+TyAUhAp4+t7uzAVeqNdLHW5eNz2FQXSv4TjrRhpCk=; b=CQDsMt/o5EOb+yLmR4hagOsfo0VSfiomgZfIqObt1UioPcQJbrkF8USkwLnQ0G0/0a SS/bth9CX7GYA63hIaaPgAaC4906UbkzELxZbLi/TPy/HdzDajHtcjJPbjIEWPLbRPBp C5zFsJqUkcQtI/I8x+WWVWWJmDAmE9XzDAIyi9PmyaLOjUoGxQAD2nyPeYqtMvucMu7W fEyesNwOs//ZOaG99s1DU/gj+zM/b9WbOhf9oqZECfOrdbV6sI8Dv4CD6UcMP1ui21jB oQXCCiNf1aftouV71UTEgnqITuzKB07vW4xhY7YDgXrWOE+df8PJx00GjCFVr6i6MRsI BF8Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="q2mO/1Jp"; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48de0c16614si4814115f8f.462.2026.10.13.04.16.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 04:16:09 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="q2mO/1Jp"; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=tj9oV5sudd4onI61vAo7lfIUu5DtFQHB0f29SE0KHMo=; b=q2mO/1JpereN +oSkN/XfY9g0Xl/BC1UTuNlDvprxgi0w7hG+YurY38ODt+sAyzfUCj2qZJ9akJlg+Mvx4mqj9H8d+ fJk82z89cc/dkKFSjck8qW6jAHLuMYR5dUdk+JkxJnyGzC84eJJjrbxKl+8nheTBENGluWLVNfbJP 3OwObSaacU18lnPgGIc4LUvYSzKWa5BJLEG741GMsSmoZ3O9o0riTJ8Hx6kW3fADSfjM1vIsOnyNh VngB2lz/APCNJ95HD1moq5MyA1CikWk/Y+KJuxjSO5RDD1gSSy0SeAMbkUHU4S/+GOutoQLgNQ2yN KxxwoHoQqsOOxMEV1zzjBg==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xGaQw-008pMQ-0K; Tue, 13 Oct 2026 13:15:59 +0200 From: Alexander Ivanov To: den@openvz.org Date: Tue, 13 Oct 2026 13:15:54 +0200 Message-ID: <20261013111604.142989-3-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261013111604.142989-1-alexander.ivanov@virtuozzo.com> References: <20261013111604.142989-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v6 02/12] dm-ploop: fix lost wakeup in ploop_allocator() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org ploop_allocator() checks prealloc_size and kthread_should_stop() before setting TASK_INTERRUPTIBLE. If ploop_req_prealloc() sets prealloc_size and calls wake_up_process() in between, the wakeup finds the task running and is lost, so the allocator goes to sleep with a pending preallocation request. Later requests for the same size return early without waking it up, so the request may stay pending forever and waiters on dispatcher_wq_prealloc hang. The same applies to kthread_stop(). Set the task state before checking the conditions, as the canonical kthread loop does. set_current_state() implies a full barrier, which pairs with the one in try_to_wake_up(). https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-ploop: ploop target driver Signed-off-by: Alexander Ivanov Reviewed-by: Denis V. Lunev --- drivers/md/dm-ploop-map.c | 44 ++++++++++++++++++++------------------- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/drivers/md/dm-ploop-map.c b/drivers/md/dm-ploop-map.c index 48466435dd19..92ceadf41b42 100644 --- a/drivers/md/dm-ploop-map.c +++ b/drivers/md/dm-ploop-map.c @@ -2347,31 +2347,33 @@ int ploop_allocator(void *data) struct file *file; for (;;) { - /* we do not care about exact number here - risk one extra schedule wrt taking the lock */ - if (ploop->prealloc_size) { - __set_current_state(TASK_RUNNING); - file = ploop_top_delta(ploop)->file; - current->flags |= PLOOP_PFLAGS; - ret = ploop_preallocate_cluster(ploop, file); - if (ret) { - /* - * threads requesting prealloc must check - * if size actually changed - */ - /* ENOSPC is only for fallocate */ - pr_err_ratelimited( - PL_FMT("failed to allocate space: %d\n"), - ploop_device_name(ploop), ret); - } - wake_up_interruptible(&ploop->dispatcher_wq_prealloc); - current_restore_flags(old_flags, PLOOP_PFLAGS); - } + set_current_state(TASK_INTERRUPTIBLE); if (kthread_should_stop()) { __set_current_state(TASK_RUNNING); break; } - set_current_state(TASK_INTERRUPTIBLE); - schedule(); + /* we do not care about exact number here - risk one extra schedule wrt taking the lock */ + if (!READ_ONCE(ploop->prealloc_size)) { + schedule(); + continue; + } + __set_current_state(TASK_RUNNING); + + file = ploop_top_delta(ploop)->file; + current->flags |= PLOOP_PFLAGS; + ret = ploop_preallocate_cluster(ploop, file); + if (ret) { + /* + * threads requesting prealloc must check + * if size actually changed + */ + /* ENOSPC is only for fallocate */ + pr_err_ratelimited( + PL_FMT("failed to allocate space: %d\n"), + ploop_device_name(ploop), ret); + } + wake_up_interruptible(&ploop->dispatcher_wq_prealloc); + current_restore_flags(old_flags, PLOOP_PFLAGS); } return 0; -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel