From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id E76578017D for ; Tue, 13 Oct 2026 11:17:49 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69DBGbjG012530; Tue, 13 Oct 2026 14:16:38 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69DBGbjG012530 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="wFI0rIVl" Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69DBGD3m012462 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 13 Oct 2026 14:16:13 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69DBGD3m012462 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-c34edc241e2so195828266b.1 for ; Tue, 13 Oct 2026 04:16:13 -0700 (PDT) X-Gm-Message-State: AFq9FYJIzFM1ziJcuR/EHg+h0Jt1PdQvhnBfWliovp6C2k2V6p2EcNZA pIzNIhObvJgA2S2b4X0GpjI36Vc+eK/VKtjEKQw7p0wpVolXJ0m1DUYhr849Yc49lyNtatJmF4N Ei4i96OwQiIZk0sRmqY11388DZKuKpz4hEhAytG0cz8Hun2hWl34/CA== X-Gm-Gg: AYBFou0EsFAE8ArZ4wcByBjcNoXVyMt8pcGGZL0PaE0FjaTVb11YNG5Nj8loHJ2fCbb qOKHQg/N2lVllHrQ2kwExpjK5WHfXlPyGSVrDjM88gs8GQ02P2J+4Sz1WM6OgfDIgmE/6oIujdO CVnpP2OLd6QrU+yahBhzg2pM/107SJ8Ldelpz7DrBFnKbhToCh1rXr+NSGx7cI5ryAhcfyXHBY/ ZgS+A09gGROhY1t0FvW8uzVM+7EFv4XVZHS4bkJYpiejWuW/3bbx61Jp34kJ0k3NOby9WTh4alK v0s3Ww/bQTl8qBcu586noGoSvA49QJXFuo/QUchJvx8qu/TDFUdDnWweEEAxzjmFtdgjh2sFVXB 6T561D8ExGV7XFsZQ4T/wJ4jjFhbF X-Received: by 2002:a17:907:1c9e:b0:c2a:c793:bdfd with SMTP id a640c23a62f3a-c31a9ffe1e3mr1293466066b.21.1791890172794; Tue, 13 Oct 2026 04:16:12 -0700 (PDT) X-Received: by 2002:a17:907:1c9e:b0:c2a:c793:bdfd with SMTP id a640c23a62f3a-c31a9ffe1e3mr1293450666b.21.1791890170779; Tue, 13 Oct 2026 04:16:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791890170; cv=none; d=google.com; s=arc-20260327; b=JKr7SDOfztDnG6qR3OipOE912Kg8613W96233WTvXqdN5PZ8lTslmY0pArvfkOas4Y PbQZL+HUkpmS+I3fZQgFnbVaCtf8MJRzfjmgxdEjjft7gpVIi1mqH2fOO9mZi0HAFGyE plkx2yp0TZP7GzRxyF4yDmy2Xu++JzC1I+13QiZQhWATirl+Fl2XjfWqMFgQqBW8qq48 IU2tIzusZwdiD/S+IX6mCBDdsYwETrG2+RBTOCWxegE/0asnP0/TVCnxBPW1KnyKF7/7 4f4ytm5cDklqVnwn4BIiBCqSf2H86+6m5ItBIY2Bzz/tHYFDB91/LDu1OCYM31+NOE2W eWxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=S5QUIifMVuW+KNmnsUSGD5keveOqhz2JhJaix7xxq2g=; fh=M+TyAUhAp4+t7uzAVeqNdLHW5eNz2FQXSv4TjrRhpCk=; b=KYEwo5Cy8qsFF/z8EvKrr9ZDFTCj+BEcq/KRQ0F18rG8i1OTUFnLJcYeMfAJH8M2da H4Fn+H8lEhpRX0zEjPHI7i/lddYlY0mOgUNTP06YaAZ1XYzsJaee/DbEc4cKM8Q9+4GV XtfOGq33/zT/tqcDrVUAAE3wJ256QoWGuUVFULnJjsuaY1kbsfBhMQNPxGXaFK8dfWDZ /cLf1+Htv5bMVjP08QtPfRQU9PWQUVXQ9QJ9ozB1MVkYZm0UoGgmRbpoeMasY2JZGpP6 xoLE2R7TskcOtJo3SK/G1VMd0dI7f2PlJ0y3sf47umdUQiQXFcfj8lCyNHfEUtrubkpd d+5Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=wFI0rIVl; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48de0f7afb6si4462569f8f.110.2026.10.13.04.16.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 04:16:10 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=wFI0rIVl; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=S5QUIifMVuW+KNmnsUSGD5keveOqhz2JhJaix7xxq2g=; b=wFI0rIVl0hVY aOOi36L9qcwFRqwkC654S2zpDt2MeYFIrsW5CNS6uiiXIisVeN/Gg1oB4vgIRW7RRmG2SjoYK8Bif KwqwdB/74VO4cyYStuf7NQkmJhEeGYMszzLZZ2qp49i40MT/KJ6GMeQ2wKFD/YM43FqTe1DlGOoFZ BacaFodUIa0cKR0K61CKC0evaK50KluTQD2V+tzGCkDf+XhmZOremlhdcxiDShpyo7julREZm6236 Edrl0lRxVtDRb1456iL9gqolwNhpxbgY9ljyhjTb8tKaKh3QQHvraSAPlJ8isNOlFvKVmT4U9nslt UNekWmSzYfn3T91PYzwDIg==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xGaQw-008pMQ-37; Tue, 13 Oct 2026 13:16:00 +0200 From: Alexander Ivanov To: den@openvz.org Date: Tue, 13 Oct 2026 13:15:57 +0200 Message-ID: <20261013111604.142989-6-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261013111604.142989-1-alexander.ivanov@virtuozzo.com> References: <20261013111604.142989-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v6 05/12] dm-ploop: set delta is_raw before applying its mappings X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org ploop_apply_delta_mappings() takes is_raw from deltas[level], but ploop_add_delta() sets deltas[level].is_raw only after the mappings are applied. So a raw delta is handled as a non-raw one: its md_root is empty, ploop_md_first_entry() returns NULL and d_md->kmpage dereferences it. This has been the case since the driver was added in commit 6ddad5a4d226 ("dm-ploop: Add ploop target driver"), i.e. raw deltas have never worked here; this is not a regression. Set is_raw before applying the mappings. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-ploop: ploop target driver Signed-off-by: Alexander Ivanov Reviewed-by: Denis V. Lunev --- drivers/md/dm-ploop-bat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-ploop-bat.c b/drivers/md/dm-ploop-bat.c index 4fc99400a0a4..3427d1a90d81 100644 --- a/drivers/md/dm-ploop-bat.c +++ b/drivers/md/dm-ploop-bat.c @@ -512,6 +512,7 @@ int ploop_add_delta(struct ploop *ploop, u32 level, struct file *file, bool is_r if (level != ploop_top_level(ploop) && nr_be > deltas[level + 1].nr_be) goto out; + deltas[level].is_raw = is_raw; ploop_apply_delta_mappings(ploop, deltas, level, &md_root, nr_be); deltas[level].file = file; @@ -532,7 +533,6 @@ int ploop_add_delta(struct ploop *ploop, u32 level, struct file *file, bool is_r deltas[level].file_size = file_size; deltas[level].file_preallocated_area_start = file_size; deltas[level].nr_be = nr_be; - deltas[level].is_raw = is_raw; ret = 0; out: ploop_free_md_pages_tree(&md_root); -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel