From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 76CF3808A3 for ; Tue, 13 Oct 2026 11:17:39 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69DBGRoC012509; Tue, 13 Oct 2026 14:16:28 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69DBGRoC012509 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="fGmFzTIh" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69DBGC5C012449 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 13 Oct 2026 14:16:12 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69DBGC5C012449 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-486f9d150c3so1706012f8f.3 for ; Tue, 13 Oct 2026 04:16:12 -0700 (PDT) X-Gm-Message-State: AFq9FYJxaSzOuUbpD0eu+YoHMpZgKyOXsM5wHLllAdKpyyNBIBsWxRy5 JiVdk4O4iaKxCGfgOQFkq+Pk8AoxziImh8aRYqx87imxXjRNLCp3yYTsWrfkv7LJArDDF+1e3CD sKFscQC3pkOYPaN9hHRJqUuywlwl8q7lbDhm8DSRyIXgmzl+SEthwxw== X-Gm-Gg: AYBFou0/+f+GqP5reqnPTIt4iJLA2XzTc7HfWS3L2dTfFE8HAdTs1cd5SuFh7GA7RVZ E06c2TBZ1nPUTexlUFbuQ5dtzuEZnIYci4WkU9CryaR/HSgv7DkFKDk2LsSv810HwASJha7GFYw wIuH3rkBHnyFak6fosnWv57Q4C5JxyUcw4K6QZWPzNd6stidmynI6+hMa4JuxmBl4FabDNTQ3TX bENp++fWl9lYScOnOTQSOC5e70PcDEzpfJKkAvQZ8WUdMVbedRZiXmmKlZcBBzf2eTU47QlhO75 Lurkqpx84cr/68I9eVa6pL1toqS0TwWYI8hIdi7vsjmlZCWktMOECyta6c2YaEhuwTuCcc40ghx SnSP84c0tZQJ0ECMfNJ2qdktvprk= X-Received: by 2002:a05:6000:240e:b0:48a:f215:c67b with SMTP id ffacd0b85a97d-48dbf3d8282mr21093367f8f.37.1791890172150; Tue, 13 Oct 2026 04:16:12 -0700 (PDT) X-Received: by 2002:a05:6000:240e:b0:48a:f215:c67b with SMTP id ffacd0b85a97d-48dbf3d8282mr21093277f8f.37.1791890171331; Tue, 13 Oct 2026 04:16:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791890171; cv=none; d=google.com; s=arc-20260327; b=XbvCbTr27+50cLe277k2VFGkfbhBXhFnwdabLf0gW7NW29EJLyn8EsVHxDJyncsFZ7 q1BydL8vwwdNvPsaeLb4oyaBgvnnWMmNeArHovfbv1GN/NCbDKDG59k28rQic4LVM7Hm suuELl29UnYcI4ET3Tf8prNRo+t+furY+yT6B5c/sFFobwzfRhttMrgOaA9EAVLtvjme 9ia+PBhVzlq2MekQpNXM0JwJkK0VXL1YhksJCIzKdyaSSNScRSODz6ih4DMaCmch73wl a4kY3U2cP0RLnk5AzQ+F5QDF22EK1RYyUE7+9KuCNBq/CUCGHSDx2xzwmbb9xm20BJ+g QEmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=2p2b9RxcRMJabfaJ5Svw0SnmypEXzqX8smn6c3HPyIU=; fh=M+TyAUhAp4+t7uzAVeqNdLHW5eNz2FQXSv4TjrRhpCk=; b=KPnps57mJWrNOyWz4xZ/Pn6rAx0cRKEtHDk5D4nZXpmofiQu10kG9d+KNHIG+9jntu LRpKszvbGW+MX8EFZLTG+XyYKcOznEWulXmWbw/GMjoYOROx0TYtHpMRayRpw0REHn9y +RGj4Vt7itFFWUzen8b6AZ56/pbti06HD1/tyUaPjiwVZ1bq3FYqiZkLshWL7YfkooCy II9T5soh03Qp5b0hdYiGGqEYT/A0TKq2CyPNgf0aG7nOPleqmhZPPgB4+abbGNbBoaip 8rPK9bUQX3of5RCv1kbnhFVRle9IL9mMgvDAM2Aix6khPebQ4tJEl5nsQvAxGSHk/V6L nr4w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=fGmFzTIh; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48de0c08612si4750946f8f.371.2026.10.13.04.16.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 04:16:11 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=fGmFzTIh; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=2p2b9RxcRMJabfaJ5Svw0SnmypEXzqX8smn6c3HPyIU=; b=fGmFzTIhpEd1 l5zZ3LSWSLYCpdPY8aUW8onwozeF45o9Bwj9CpZjgQO1BBvjXUz2GHhAWjDzdgvSaabf6ZO/Ak3PZ n9ScPS/d2IbB3YkYiP5yvrJ4trpD4tosQYCVoSh4l4mO84H3QrbndvfNX6d5fBhKMKPVbJTr5htiD G7tkLwVApC2uvhF7Fry22h57TnEaQih/jecT38PE2PQt/1sXwizvQQpVpi7oRHbADC1zSnZxfQFs3 VRctzU20KcG7kEE4W9YRT5Ldpuk+DC0Y6ILQ72c4U6XkCCHzVfnBodPJLlZueSqQIcnsGV0OQqahx FRfBaNwCS2vDXFd8FNstYQ==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xGaQx-008pMQ-1g; Tue, 13 Oct 2026 13:16:01 +0200 From: Alexander Ivanov To: den@openvz.org Date: Tue, 13 Oct 2026 13:15:59 +0200 Message-ID: <20261013111604.142989-8-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261013111604.142989-1-alexander.ivanov@virtuozzo.com> References: <20261013111604.142989-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v6 07/12] dm-ploop: take bat_lock around md page lookup in ploop_llseek_hole() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org ploop_llseek_hole() walks the md pages tree without any lock, while resize inserts new md pages into it in ploop_add_md_pages(). A lookup racing with rb-tree rebalancing may follow a stale pointer or miss the page and return -EINVAL. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-ploop: ploop target driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-ploop-map.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/md/dm-ploop-map.c b/drivers/md/dm-ploop-map.c index 92ceadf41b42..691284a239df 100644 --- a/drivers/md/dm-ploop-map.c +++ b/drivers/md/dm-ploop-map.c @@ -2772,7 +2772,11 @@ loff_t ploop_llseek_hole(struct dm_target *ti, loff_t offset, int whence) while (clu < READ_ONCE(ploop->nr_bat_entries)) { if (id != ploop_bat_clu_to_page_nr(clu)) { id = ploop_bat_clu_to_page_nr(clu); + + spin_lock_irq(&ploop->bat_lock); md = ploop_md_page_find(ploop, id); + spin_unlock_irq(&ploop->bat_lock); + if (!md) return -EINVAL; } -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel