From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11022117.outbound.protection.outlook.com [52.101.66.117]) by lore.virtuozzo.com (Postfix) with ESMTPS id 5AC2680B93 for ; Tue, 20 Oct 2026 16:30:55 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GAG7sNSpQxYw0bVkYpaX6VAiqiS6vud3wSZcGxeWKzrktOAg0jrJFcqY1ST1YlClV6X0lfcy7Kjxf5n+9kRya+TEC3V+2XCQFYaPqstOf7a9+WfW2jtcuZQPJ6hWl+Qaa0vcIqnhoCFwLY1o4xoJeYOxzv1dYGP0j2SbuhitRtQ6fuhQaVRn8RnCrRdJW0OlMoE5ypRz36ml2y1JjjTSRxMrlmKe0SE3JydBezYhB8/4jIQNWkbhqFNtVYKTPotrk29+9jtnbkwVTc3Z+7H+2o6KW4bQ6V40wc3qDcKJ/CEbsFKvXPzzxaCKq2EeVfPjcaVP7TzJwLcuhsz36ls3bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Vl2nGLsOdR1rT1rPPRP1wtRiv7O73Djt8igMcAzGVY=; b=YeOsAnnQE7TNdbSC+C+/5Aost1itV8MGGrvw2UQNem2DyBfu6mocQ/MlGd+oWfGiQ9G3hD49DzzcEogrX1bjNhzgPhjIPgKfFJ3iYX9jIbGXMzHCAkXwiAyI6BZp54bAivv8tz14tC4V4InzLTbQHTguLTXNqmtMP+Lhp2dGb4otZ6ETmJVBKURCHdPEmlhN3eZYtmKz9qJ1uvezQAizuPr7Sql6CQn/g+a/kS8R3NglKiDsbkb3OBehfGUOwmWL9K3a38eRWenzgcjR41361d3ruOexhY46y58ZCBOmpjNz7M4Z79sco2SumUhZgvbmMS5JEVIOSjeqw4vR46t0pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Vl2nGLsOdR1rT1rPPRP1wtRiv7O73Djt8igMcAzGVY=; b=aRmGaY0L13vGk7+ssh/rBZPi/xXYXxE37aQtkDjk65b1Q9bwpT1S7EFOcqq3KJ9anJIxUvYNBqlbknCLlYcxuPuIBpCDC6X6qskyPM5OKrMHnn+JHMnHXSWLtVjydtk7F6qlW9uK29Hc9ngw9Kbj5qglC+OeTTGD9trt1fu98gWnGIZa05OTqKL61651JIwR00zew7rBgsH5pYu66hhtO6kf3t8kLLVBVzsG9b2a0EVQTGZji4zWZBN/d5zOXwN5Hx16mRRKJR9NIrFunCebxQGZhVEvp8bA0IDGoE249wetAp1hQc3vILVvIU6m+R6b+c1ryJgfj7MiYoITirbB0A== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by VI0PR08MB10683.eurprd08.prod.outlook.com (2603:10a6:800:208::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.14; Tue, 20 Oct 2026 16:30:53 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0546.012; Tue, 20 Oct 2026 16:30:53 +0000 From: Andrey Drobyshev Date: Tue, 20 Oct 2026 19:30:41 +0300 Subject: [PATCH QEMU HCI-8.1 v4 01/31] VZ: migration/cpr-exec: fix Error leak in preserve_ram() Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261020-vfio_v1-v4-1-83a5668230e5@virtuozzo.com> References: <20261020-vfio_v1-v4-0-83a5668230e5@virtuozzo.com> In-Reply-To: <20261020-vfio_v1-v4-0-83a5668230e5@virtuozzo.com> To: svt-core@virtuozzo.com Cc: Andrey Drobyshev X-Mailer: b4 0.16.0 X-ClientProxiedBy: VIUP296CA0056.AUTP296.PROD.OUTLOOK.COM (2603:10a6:800:34b::14) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|VI0PR08MB10683:EE_ X-MS-Office365-Filtering-Correlation-Id: 759b50a7-0beb-4920-b69c-08df2ec7818a X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|366016|23010399003|1800799024|10067099003|5113699003|22082099003|18002099003|56012099006|38350700014; X-Microsoft-Antispam-Message-Info: JdeAVyywLdNeItue67di975XCp6Vu3+HO8w8q5xxeC8WN1oqKvIvBQapxj6h6CYLAH7Jv/kTPqVdUvsvhPlcIXQw5rwzcrFliAfDl3j+WXp25f9LBsRQ3aywX0fH9yFCJ0dgbpNH8S3/o2ClD7Mm2gaVBWIBE/Puo9BO2ppHLgqG8+rUsG1CE1AICO/4duRgRz/QmWp+ciVQxuQpyMOl7P+bFYHoSKt912y1RPr5cnpE7RQqw/RXuue5uhmJmUDHMshVz5GuQn+h4aoBk2VhZxSGKwe7JB8EZVYKJgi78QmMaVflUlF1G/krTiX1jiiD0tBhzhwYoIK5ShR9lt66FFIxNTzUjD5QYgmHEq+4/cp+alDhRxXvNzrguIlQoeSz/Q43sON2fTVyN+TtO2lddqbJbVznxcyOEpcP6PsSxl3inAeG5nhtCr1REcBnoYwUc71b7jsyAotejFKNrnDD10ZVREYOcPi0E6KOF34olSzdLGwShRxNGlS5T3MqCGvyQ6jBDNnGCT+1EVpHkRN50+dpJ/EboO0vBvurGNzwuI5MO2BUVq/fbLABw/OgWhI3C3e1Sbbe8stkLIHy+RJAaHzuX7A1cvWEviq4Ltx7FPmIgS3eTtNsi1rtefaaXwIVIjLWB99B/medXIlS4OEGMemiY8KOBwNnb8kO90S7M3eK14QHRHyomWA7r/cbTaRUiw8zjr4S/DpRla7Ke1nnau5xIPqAirb+al4nbxsg9ME= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(366016)(23010399003)(1800799024)(10067099003)(5113699003)(22082099003)(18002099003)(56012099006)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUFEUS9FaXBoV1lXMm9pOEhmOVlnSjQ2djdPRTgwemt6V0xDMCtvNkFYcnBx?= =?utf-8?B?MlhRUUlRa2tXeTh5RjQ2QWVRdnpmNzBmaUNXSFl0YW1Qc1RiY0lnVHlwUFZP?= =?utf-8?B?S2hKMEIzd2dyMVRlcFpMUHpYS1ZheStmSVZyV0FxWTE4QnNybXVIZmQ4c0hw?= =?utf-8?B?RUFSVDB6bEZwM1RKZUloTE45dW9qcWZlcDE3M0dHTXkyb0pYSTVvUnJ1cmZ3?= =?utf-8?B?dzhBVlZKSTNmaUFwNnRicHdKNm45emxCU3pBYlNoZTVDeWgwSFlzN2JSN2JH?= =?utf-8?B?VkFvc1d5K25WT1Byd2JydGI0NjlvdE4rSHdJWTY2UmppTGxiYy8ydWFQR3FB?= =?utf-8?B?ZGlKb0lmcU5pU1RGTWhuamJDRmZnSDBOMm1GU2tkTTljSDBrNjc4QkI0c2Ez?= =?utf-8?B?a2hwbmhQMWhyVWV1RU1YNjB3M1p2bldJbFk5MzBGTHQ2TDhiQTM4Q2hUNnhs?= =?utf-8?B?U1Nlb2tjQ1NFZ2VvczZMZzJja3hLc1NiaVFNTHVuK3Z6NS9yNFR2eG9nZmlS?= =?utf-8?B?VE1vWUtLQ29kS0IreldmYVU0cWt4MERTZC9jZ1JZMW5icloxRC9tVW9qNG9W?= =?utf-8?B?RWlLdVBCUEVsUGdHZkhUcTJSTFdTc2NZVEdzM3JEM0VVNXRTak5RQy95Yjgr?= =?utf-8?B?TjJrU2NpWWJwNUZNZm1tN01ZVjNHRTcxZm1YZk5kWUU0aFd5MHBGTTNidHMv?= =?utf-8?B?WHJKUXlXTUMwVStKZlZVM2dYVVZXYmNTa25ENlJjOUlUWnNtajZUdWJ0eGlu?= =?utf-8?B?bWhDdUgwQ3ZRRVl4OU1SSHdVOEZBeE1HYWd3clg4ai9rUXEvZ1RFRnpPMkM4?= =?utf-8?B?TkRxZHdJQ3N5THhJc1RPNmI4SmdyaXpuVzZ1SitoTVFPNXBycE5EYVFXdUZm?= =?utf-8?B?NW1kQWdRV2hDRCtNN1FJcmI1NDcvZW5HZmZBWWRPMi9yVTJwd09kK01zZldM?= =?utf-8?B?NHpqR1lDcDdQV0ViWThkSDFRcTkvSUhoVjV4OVJyZTNJWWwwMis4M3FIQmYw?= =?utf-8?B?SnBPVXVSbUJkczBhWEQwZkkyMGNiRmlCaDZWVm9BZzlnZjFPSDFFSEVVZ2xk?= =?utf-8?B?bW1oOVVCS3lCRkZIbURZbmVVSGhyRDE2a2dFOEsvaEUwRHI1cm5qZDQ2YXRz?= =?utf-8?B?SkUwWGVDRUFOT1puZTArTXNQWHJ0dEI2eFhrVW4zV0JCZmw4MFpYUGZmK2Z5?= =?utf-8?B?TmZXMllyVkJlOE9iQmcrQnplZzJ4QjNYT3lkU3lTdVRVdFA4MDNEV2VQN1Nw?= =?utf-8?B?ekJqU3VTdFM5ZFF1VG5oQ2V4VGZ1Q2FFR2ZxZ0ovTytRc2RSSWtzSWljVU9K?= =?utf-8?B?NHhaSENUWFFHK0xaajc0amU3SHRkRHBGK2pIdmdvVHdNTnVEU1pQNkJtbmgz?= =?utf-8?B?eEZxa1gxV1JJRlRweDhoNXlrTlVSOG1FN3NpM1RqRUh0NUo1OHlqcGRSV2k2?= =?utf-8?B?UWdESnlSblM5aDVaMlBheUU3L0VGcUpJd2ZiVWk2M1hMNmVFS1lib0RTa1Vl?= =?utf-8?B?UDlFVGRrV1hHTWRhOEJheGFWSG0vVFdBVE9JTGYrZTBTVVljVmpGNWR0RzFp?= =?utf-8?B?NWlMeTFiQW5jb1ZwK3VlWXZtUW5NcW12WTJBTkNYUzcxSENBcjVveURJV3NB?= =?utf-8?B?NGdET2pwYmI1T1dzeGMxRU4vRGhJUjdjTEdaRlNSMUZKOXJhSHFxczd4ZWw3?= =?utf-8?B?SDNWM0MvV1JLcldpcmR2QVRzbXpmaGVFMG9oOHdzUjlFeENPK2NtUlQ2WjVI?= =?utf-8?B?alVvcXE1bzQvb3RSelhRNUJrZzRhSkJWM0RWdWpJODFuZVIzWUlTUW9WQmQ3?= =?utf-8?B?dW56M1FJcXBoNGFXSEUvVmFBNE1pODRsZXV6c3B0ZWFFQ1hJdklCVGFKOG1u?= =?utf-8?B?Ly81SUdSazFxenlLcjRLWXFST3NiU0lTbTRvRW5ZVDBjUkFqdEltU1hCUjAr?= =?utf-8?B?eGZkbkVxMzBwUk5ZQkJSNjBnK2dPTXNlOGtZdUgyOGxhdzNLT3dUbEVCenI4?= =?utf-8?B?MFJjV2hVTUF4VXVhb2I4ZVV6VzhvSE95Qnl5YlVSMTVmOGh4MUthakw0cmw3?= =?utf-8?B?ZzhzemRVU1VmTURJQXUxZ0xsMHoxVEtnSTZWR0hpbGJjOFpHU1JrQzlET0hO?= =?utf-8?B?L05admdPRXYvL1ZBZ255L1lpR0IvWC9Uam1GcGZJT0I2am91dFlHaFR3N25y?= =?utf-8?B?T2pUYnRFUVA3a1VyZHRPYXdPRCtYOHlYZXJDYmNFM0pIL0x5aTNRUTRyNmVv?= =?utf-8?B?V21XSzFsVnd5SytLRWRzSlFkZ1owMERBQXM1dnBYRjgrN3pEQnpCTlE5SEsv?= =?utf-8?B?OHBIV0pHN1NTTEUwL2FaTWIxU3NkcTVsaXdXZUliSkVvaHhwR1pvcklTeDZK?= =?utf-8?Q?8JUAA/1l+ngqUV0U=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 759b50a7-0beb-4920-b69c-08df2ec7818a X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2026 16:30:51.7568 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yNPPMxsazr4jVfm9xUoVKhLmd+IJIphxy5Uc6t8Bw3gwIFpRwqOtvMuu08xiF5/T0S5I73H1u9OSJ9zylm813G1f6TBuD/Z1ggTGsA75ubU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR08MB10683 migrate_set_error() stores its own copy of the error, so free ours. Fixes: a3745506daf9 ("VZ: migration/cpr-exec: mark saved RAM blocks with MADV_DOEXEC before execve") Signed-off-by: Andrey Drobyshev --- migration/cpr-exec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/cpr-exec.c b/migration/cpr-exec.c index edace3f0bd8..9fd3515753a 100644 --- a/migration/cpr-exec.c +++ b/migration/cpr-exec.c @@ -148,6 +148,7 @@ static bool preserve_ram(cpr_ramblock_t ram, char *name) error_report_err(error_copy(err)); migrate_set_state(&s->state, s->state, MIGRATION_STATUS_FAILED); migrate_set_error(s, err); + error_free(err); return false; } -- 2.47.1