From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11021085.outbound.protection.outlook.com [52.101.65.85]) by lore.virtuozzo.com (Postfix) with ESMTPS id 3E07780B95 for ; Tue, 20 Oct 2026 16:30:57 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uPE+6vbs/PfANuntPk8bqC7LzxFEgPvzjpFje85s5vDJvz+mLjWEaMKF7rE6vfMFPiAOsqVVv50Sr0LMC5vA3q3NrKYqjYa13B+E5EgaTcRySEgOIGyWT/8S78Ct3LKrE0BXVAsVvfesqhPtR7D0XQr5g61K4FKpCDSKt5u/73XxcfadAI+PRrVp1c0rsjtWUnqO6h1uWaNs5Y/xjYJsafr5CkpPGJx602zdj1zauO9FwvJT1fCYhWcgmlDrep3pmHhWiAb8IvHMCRe38tmVuN4MztnW/VZQ+o4M+Ejw9KeUpagQuhZqHEwYGnGH4ZqNlmXDYuQAmnI/H7Ew09+8Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sBXEm7dRQH8VVAcJVzQrPCEhv5ljw3vQk/oYPYvyXFk=; b=GKq/yRmT+vwZ4+b0E45+3gysHb74s7rFl7FHOK5HKwqjzTbIFz05/3p2WSpjJ/H1APhzX7PxRfxb5rIXFeSBLI+O1GR+GV92t+7AwbSfesl4KwzbuI6U+VlKXtWRGSwTsqEh4CAbKkUgRf1Uk3QUfeOjUGzejJEv2OUN/aizz7hMzSqya8JEHW6d5hABnbgu/cpGfbN7h9xJFxGDdXP5BPvNDu60zAa5dWsuko1yPsCBQMspLnja2bFsngiWy7KFpMoYFU1ZCVN9h7GTCFMLiHXjxiq0qk2baBQm+kCP3LN/zaCKEhH1CuRAwro/m1zc6vPYQ4j9IGiXjlOkUP/HoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sBXEm7dRQH8VVAcJVzQrPCEhv5ljw3vQk/oYPYvyXFk=; b=Y2S6Y56QmYd9wmD0VOOnuDQwj8GyBUSQsr0aZDC65Wxr9050jBy6LVi7N7qqC5kVnMOZgJoPivrM7hGpDM265cHIirZE3okFZpM7b7zVwdgBT7bBHFLNQsmUqnVEwT18/2guhvABVSrMLI6b3CO/I6zGX7QAbO10Jd1NHKlSN6OWQRbVaoVPdJx36WXnQIjAB9J8XmNLHadFEDiCEY28DAyZKzVsfX3kQtDdSXxBGM2cMBLmujt/n5pHnsz+qmEP0cIdplAGNEvuSMhwtMEPb/sEMB9V1tOukcFIyzk6IyXDV3T8uYLBuntTf4DEOJlvbxyXd4GATX3YUWd5arOMQQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by VI0PR08MB10683.eurprd08.prod.outlook.com (2603:10a6:800:208::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.14; Tue, 20 Oct 2026 16:30:55 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0546.012; Tue, 20 Oct 2026 16:30:55 +0000 From: Andrey Drobyshev Date: Tue, 20 Oct 2026 19:30:45 +0300 Subject: [PATCH QEMU HCI-8.1 v4 05/31] migration: close the CPR state if the outgoing channel fails to open Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261020-vfio_v1-v4-5-83a5668230e5@virtuozzo.com> References: <20261020-vfio_v1-v4-0-83a5668230e5@virtuozzo.com> In-Reply-To: <20261020-vfio_v1-v4-0-83a5668230e5@virtuozzo.com> To: svt-core@virtuozzo.com Cc: Andrey Drobyshev X-Mailer: b4 0.16.0 X-ClientProxiedBy: VIUP296CA0056.AUTP296.PROD.OUTLOOK.COM (2603:10a6:800:34b::14) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|VI0PR08MB10683:EE_ X-MS-Office365-Filtering-Correlation-Id: 49eccddc-2cbe-4052-e9f1-08df2ec7823e X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|366016|23010399003|1800799024|261009223027099003|10067099003|5113699003|22082099003|18002099003|56012099006|38350700014; X-Microsoft-Antispam-Message-Info: RQIFIbklFIq5RNWK3KAboAOGC3+UUVeplbzNCFUe2A1zXyjayGe7Hg0tAG9NMGOaUfOo3rbDIwGArapupLNQ1kNEMNz1H8ZgPIJ6qUuLCn+2wHUkXzPGC5OuozqXkaSiF4E2YlUfUTCT1YQhJOTl8QkxX/HdAuSoBPil3SSNmGWiMlFVqQVU/pekftCM7Gi7K+ejJ1xy6z1999HDvvLENBOW18rCCmPnHXNZCjp0MVHxc41jdd4XmnzSilxy+ArGVda5FsNJtk8vVlAl4S0IrjwcFCD1HUveWt+hni7y5g8EyShkkGiCD5b1HIDBgp/aVO2OFClQAoVD19XvRvgZ2Qd2TXtrrm4gQBPNbyB1fNc0CkTk1xns3UXnJl6oxOVpEtPS2QUaaUAUb2SHxfTPeoyDGYPTv/+2UhOY3qoHrrxbn8NOH4/QXvRof30LuZD5rj6A+ShoprGLURbAzqMeBG3blkz4s7mSpKMYP24ZpKYLtBITmBhsgF1CLpCBppBYtbGyQ1Oz/wMxj/5CRKI6OiXiAWwalv6Qg8Vxtf6hCcfK1hxqAbeISBqcZpIFVjuphojhSslE1kWNAObzcFYVWTDCdQGc9LOPgbkXNquQRJJZAf2SH1BmO5JAK3kRBU2AshjzLPVTCgSERcK1k+CU8DbaCoJobuIkK9pWpUBu6jthfxPagYP+EG9F638MblZv5C9wRzfKHCPxUxXIZ9SdEMfw5I928nmxyt0DoHR4vw4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(366016)(23010399003)(1800799024)(261009223027099003)(10067099003)(5113699003)(22082099003)(18002099003)(56012099006)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bm5yZHZmN1NaMVhhWUZ3NUhwWFNwTmt2d09BaGV3YlgzRjNPWWdERHBJZmdX?= =?utf-8?B?bTJnK1FjOXNiNDNqdWNXcXl6N29YR2l6SDI4YURldllucUpFNDVwdGVucElQ?= =?utf-8?B?MUVWdVJmWWl0MVhNR1Bwc1BLRmxBV3pjelV4ZSswbnFDZkl2aE44M2s5OWFH?= =?utf-8?B?U0cwOE5iUHBENDdCSUN6WW1sbExzMkwxZzFCc1crUjZTNFp0NWtSdHRPajRM?= =?utf-8?B?UzlzT0RCRThZN0J3eWdxbnl5Y3lTcFJUTlpxcmUwM0NjRE1Fb0x3M0Z2OVpV?= =?utf-8?B?OHVXQTBSclM2ZDZsTUFNTEtWQ0RXMTVYclJ0VzI1YmF6ck4vVk9QSHdTV2J3?= =?utf-8?B?YlF6eW9IYUtZaG84WEFTYkZORUZEd0oveloybXVCbndTRjJYNGZVNURnL1dR?= =?utf-8?B?OCtSVmlMMWQyTnE1VEs4alJ2ZlVBNzNaYnJnVStxR0ZlQkZRNEdJYXFlYll2?= =?utf-8?B?eU1iTFhQTXIyb0RoTm52VGJVUnZpWGFrMzk3dWhJbTB3UUFaTFo2Z0Z5RUV5?= =?utf-8?B?Wit5NDl0ZnQvRTc1QzJlYnlFTzhlMS84S3ZMVVdBUUdIQkFEanhhaS94cFdu?= =?utf-8?B?Q2p4K3k3UFhIWURGckhmc2hmNUxlZURPMFQ0UXpjQm0xckNYSWRHTHFXWG5u?= =?utf-8?B?N1JNZTU1WXo1QkF4emdaVi9WSmxFTER6Z204YU54NENTMUllaTUxcklqbmxw?= =?utf-8?B?Q0xUL1Rldk5hSloyZmdoanAvMVExNVVwNjQ1c2VqWnJVby9panhIZG10ajBR?= =?utf-8?B?amJBTWF5bGxNeDJuakhqR3BmNUVDVlM3RnlGbWdyM3AwUGFhMkkvSmZrenN4?= =?utf-8?B?SlFFSXFPR2NMc1JhTWpkQitpazlnN1N4REdzcElDL25OMWRPMitUMlNPR3V1?= =?utf-8?B?cWlWZXU3TTB4N2pwUEx1dTZxY1YrTDYzaWNwMDI3VU5BL0lQbUNIdjIvSFpJ?= =?utf-8?B?Z2UweWNtdVZOYldFODU5dDR0N2xHdFF1VVM5SlpBV3I3NWlNNjJXdU12WStu?= =?utf-8?B?TmxqRWVZUmR6RzJGL2wvUFNWa3hTTi9SbE82Sy8yQ1F2L08zUDY2MExVei9U?= =?utf-8?B?TkpWenR5UkpiekkweitoQThaK09VbDFPUUp6K2g2Q0tta0kyaGlSaEhvZGtm?= =?utf-8?B?ZVdJRHFpQkpPcVdCekNwcVpvQkMyKzc3QnByKzZ4VCtkYitJUDFNZEV1b0w0?= =?utf-8?B?elpiZ1J3V2hyc0lXcy9xRElEc0N6WVNHai9HRlY2Z1lRaFU0cHBSVXAyOTN4?= =?utf-8?B?dXJ1US9EYTVZaVhJREN0VUM1YUhFcXk3WG9GMGZaRFArNVBNTE1KQ1NFUFdH?= =?utf-8?B?bmU1MjRMYU9zQ00zdE9VZmNKSVF0ZkxpNDNwRHY1dEZxdGM2cktWdXdXUlBq?= =?utf-8?B?K1ZXL0lTNXUyOTNWcGhlY3FwY29qdFR2RTFCNGhrTVpPSG44YktjcFhtM2hO?= =?utf-8?B?YVJBMlVEK3U5ai9VL1c5VC9BQWNtdHlkalQwc1ZsZks3em9pNFZVTkh2Ni9V?= =?utf-8?B?akxDdEM3UDVWWnlmeEUrOUhXcDZ3ckY3Sk1Zc1RPT3dvWE9lcEJNZjE4WVdH?= =?utf-8?B?UXNLRVM4QU1oZ0VoV1dtak10R0U3ZGVPcDBuTW1jem1nYm50QUVTN3YrcFdo?= =?utf-8?B?QWVscStzY2pxSXk5aDhtbUJyRjhmdnpwbkFTL1BGN2lOMy9GWHNKWG5rQUdV?= =?utf-8?B?RGpyYzZYeHBCRXVGbjk3ZnV0ZEJ2L0U0R09MdmNid3dzWVdobXZCeUNvQ0c3?= =?utf-8?B?N0JuOG5PNC9Qald4V2xJRi8xMHU0bjBuMHVkdjk3MnRKdEM2bG1nQ09NWG9Y?= =?utf-8?B?OUxPYzYxMFpnbEVvdkNzUlJaczBjTnMvaWVPRGNpOXNUd1Y1WkNWc1pOWm5n?= =?utf-8?B?N05SN1VwNU9IRVRxT3hYdk5yb3lINXdxdGhxOU9URnp0eFpYRnJ1RGFTUFBs?= =?utf-8?B?SUtTNGZ5VU5vRWlJUzZsMXdJc3dFT1FBWm1objBHU2VWSmRobGhlRkNpRFNi?= =?utf-8?B?WW9wKzZtbFVvQWF5VW1waWp6L2czTktneGdpOFdUU3B6UWhuNnFxcXQrWmFj?= =?utf-8?B?TEg4V3NRWWhBdXp5UW9VMmtadHFDMjZvMERFZkhlbFNHSGR0WW5pMktiMUtB?= =?utf-8?B?cnpqMmZUNlkzTGRiL1NHYitTblRQSzVpUW1rRDdYcTN1cUxSMVJEQzY1cWJG?= =?utf-8?B?TWJSS3FQWXlFV3hXOE1GeU5aY0szcG5VVEZpUml6SXhCcTJ2emxmMzZzMS9i?= =?utf-8?B?cTI2VEE5d3VBV3NZcmtlS1E2L3p1Ti9iWU04N2RzUlRjNHFPc1hrK2lkczBB?= =?utf-8?B?RzhrdXhhQS96UjdBUGhDQ1dDdGRqUHlRUmI4UDVlTzNNUUR0cG9CQngrVlo1?= =?utf-8?Q?/QXiwwIALVJ07tJQ=3D?= X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49eccddc-2cbe-4052-e9f1-08df2ec7823e X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2026 16:30:52.9288 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S+bR7cwicBBiUdvTuFVYWp0zAGl/eiUAi1CcYcD/xPsrsBBeKNKZEDFfbVPh4fsfFzvk8l7CnHLisB+q/BYkccFMEI0xTwDwJwX9YVwVfsc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR08MB10683 qmp_migrate() saves the CPR state before it opens the migration channel. If the channel is a file or an exec command and it can't be opened, qmp_migrate_finish() returns right away and migration_cleanup() never runs, so the CPR state stays open: the memfd for cpr-exec, the state file for cpr-transfer. Close it there, next to the yank instance, which has the same problem. Fixes: 624e6e654e11 ("migration: cpr-transfer mode") Signed-off-by: Andrey Drobyshev --- migration/migration.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/migration.c b/migration/migration.c index 39f70328fc7..132f0d403b7 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -2412,6 +2412,7 @@ static void qmp_migrate_finish(MigrationAddress *addr, bool resume_requested, if (!resume_requested) { yank_unregister_instance(MIGRATION_YANK_INSTANCE); } + cpr_state_close(); migration_connect_set_error(s, local_err); error_propagate(errp, local_err); return; -- 2.47.1