From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11021103.outbound.protection.outlook.com [52.101.65.103]) by lore.virtuozzo.com (Postfix) with ESMTPS id E8F6C8045D for ; Fri, 23 Oct 2026 16:54:26 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QHYVbUaMGpuVd46DB6J6x0cYvYmFVSzzgZ48ZDseyhJdKx6e8FtKZWWGAcD378CxEOx/+JthPfJJLJnbvsLsYE9mxZS0/LsoL9K89/dtADLKUQKdQJ5H0P/A3vLHF/ofRQEnNNf2/2O/GVV9rey+qm9Wqul/oKU5Xf53tjyVpKmjhN58uFLCfp6sIHNFjZGjRcfqmuYjSzTqODTGaNkNExQ8Q4vnkGL3X94hsyAP48nZxjWlcONhqCOm2i7u3kep/FBlHq3d7zsoBKGDrpdgtDreWkxueThoffNdLek0hzGL5shr9r5yuP0r7b7zpjRnH3kioGR0EUk8I4mDlRtQ9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PDGLMIXGNIPqV9guanyCgDYEJ0jcxC6L5Y9yQ72o2Vo=; b=vBezKl9M/gxYFp2gvr8sv/78+Z4VTKTNvNdajYBlR691YFf4kbvjy3zsJCHBKi6jt3a4E3aTSRZCvOv+bjkeLKOiD0SxF5QSI3tOj8SwDOgDhr2LkoblD/HN3rKUL++wdsYcZa+vPD9nGTttncZqpFUiF8Qn9btIrtiHsteMZBNKDaGsgwqKN2ZMa2F3gzGvaEs34EdKGttIIvLcK2URfc+coDkhEVaUvC79hFQhCDPg74zv0xfrDaOdYFAuwX20x2UkNkP3kbtXJwg3cVGBucqqqBjBupPZtfeauPqaSIUuMp/qTmu4PF5FRFpx9sw6NcAJugKvajjJyKNkqGcPgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PDGLMIXGNIPqV9guanyCgDYEJ0jcxC6L5Y9yQ72o2Vo=; b=f5sklYaMxXQqsB8e2RUivaGp49iVLKfSKV+qUNbcpzz3CmEEdnEPQCjM7Ff6czMU6v0AebwBmlqbCEQz85qO21yxarg6WlUgi/505DDMTJjDIfYYhBZl7WnKhkBkeipnpFnf9Hmv4cfyeyMV9MKzKfKKtWCXa1sqyit6CcBF5AtpTLqOyPaHjMoXf5p8RC5DRMDMD6uCX2cvykEIaD3FnDsCbeoaZbLnzlDePGLFzaX8RhenM/V9/x7g+NW1p518Lglvm1fgs4yng0cW+7njjDw/hzpjfYBcS+MvVpLv5vwP30pXB9tV7eAebnHpN35+LtXYwBXjwt/wxBzNtqleQg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by DU0PR08MB7519.eurprd08.prod.outlook.com (2603:10a6:10:321::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.15; Fri, 23 Oct 2026 16:54:24 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0546.017; Fri, 23 Oct 2026 16:54:23 +0000 From: Andrey Drobyshev Date: Fri, 23 Oct 2026 19:53:40 +0300 Subject: [PATCH QEMU HCI-8.1 v5 03/36] vfio/region: create BAR dma-bufs with O_CLOEXEC Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261023-vfio_v1-v5-3-ba0bf3c6d122@virtuozzo.com> References: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> In-Reply-To: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> To: svt-core@virtuozzo.com Cc: Andrey Drobyshev X-Mailer: b4 0.16.0 X-ClientProxiedBy: VI1PR0902CA0027.eurprd09.prod.outlook.com (2603:10a6:802:1::16) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|DU0PR08MB7519:EE_ X-MS-Office365-Filtering-Correlation-Id: 44f8aeea-2c98-48ce-9d02-08df3126464d X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|52116014|1800799024|376014|261021123027099003|38350700014|56012099006|261009223027099003|18002099003|22082099003|261021121427099003|5113699003|10067099003; X-Microsoft-Antispam-Message-Info: W7buPMHJq/0shb0n4EuBVZ4EA9l9oa1dt/3GVElxWmWHQZj7MZdttxA7xO96PKxRgqHSBv5CpNVi3eJ4MBbVtcynF/DfdPH5G5+w/M0XCcpSUnmLXnENJUaDbursiK2py8GUFM5gVtzPb9GzOF4xMLrEVCT8/S2TdXVZ1jnAq6F+iilLJz0OvG+d3JSMh8tZhkt4kZlZFutAjQtSq5AWy5NZ2RRA4UCg4Jo7GTZjWE/ZW7S+iWWARt91by7pnhopA+1Fz+xUYi3p0UbpBgAUctAx2VU0viMs3WGnLy8lZreBEg435QhoGn7N2ao0KZUKG+WZZlIh0lU5xy6JNajTSbA1a4Jay86xOSzUvC6T6P6CDQFfGPdKj1+10yc1aAkPmtl4oSj6YJDbf+yvyq09BZBqiPCxPjXTpEmFObEbPF0hez1B0yB+j8ngbeXbEWVSHyAaFT9baLMi4aSyLBxk+pxm33973K+YNTQwzSDUggaqtG7/q4R/tWZSxc/bhjDrjfZdzs5o+u0M4R6QkuHmmE6YQz67V7yblr6CUomYV19fTvGRT1DT2fxZiXUe/Vo9BjiSJphrWv+UhHzZXRlpinda96XBiU1FJhlx7VFJoY0DUiK9Vcv/9TK1btJ0BxhmsZ4tR3XQpL1XXAgmpS58J3KrxgPZzdPGy9ApQDTh4rPiQNHKmPO+g/VIkE6ckynQDR3OzxREVvkodf7XtiaHi48JMypmNtc0AiIU4/+T7HU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(52116014)(1800799024)(376014)(261021123027099003)(38350700014)(56012099006)(261009223027099003)(18002099003)(22082099003)(261021121427099003)(5113699003)(10067099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eFdHMmVRcG9XdTJ5anAzeTFVYmkrNjFId1QzTU5xMkNkZjZrNjhvZFdYNUhH?= =?utf-8?B?WWhtR01EcmlVNmI5cDk4REJscllNM2lLRkdqOWlpc2NGTVA4eC9vR1hidGdV?= =?utf-8?B?SFFSMlJZRzNabFlYbTJ4M0FXRXJiTFZKYk0yZ0R3a2FxalpXdGF4RHlqazhI?= =?utf-8?B?NSthZWtXUjN6aXBTRXBmRTJkZVZjQmhEYm44LzB4R0xtcS9JZGl4YjdHUVl0?= =?utf-8?B?cDF5R2ZRemY0MDFPclVxMXF5MExsY2FIZ1p4b2UrTUk2aVd6ajJqcktKVjlQ?= =?utf-8?B?ZEcxNGNlQjI0Z21WdnRqaUZUUEZpYzh5WktWb3BJaGpJZ1NrYnkvWlZtZVdJ?= =?utf-8?B?eGovTlVROUdyT3ZtSXN2UXFRY0NBVk5QeEdLck9keEladUgrRzZ5NXlIbmZi?= =?utf-8?B?N29SZ0FyM0taNmQwek9wbjB3b0NYNWIvVjBqZGNaWFp6YXdBNW1WeUcrYjY2?= =?utf-8?B?R3JYalhWN2RmeGJNUHNJVUZGTFZTZEdCRHI2bDBINGRtNDVWWmxIZlRaNUd2?= =?utf-8?B?ZWdpVFVJL1RQMFJVQStZYXBTMklJdEV5aFpqUC93MDJFY3BtRzM3NE9xTU5P?= =?utf-8?B?aHpnZ1lxVzMycGIyNmMyNDQ5TFk1SzhYYzI5VFJxRlJNam81NlhUY0g1c21v?= =?utf-8?B?TVBqT09FSm5XWXlmdlR2czFEUkd3WmxHZTNENzFDdVNyMi9jN3c5QzhFdTVD?= =?utf-8?B?eFZPeFFtS2R2RXQ5bGxyR3p0SmJVNDNLdmp0cTdHK1R0MWh6Wkp3L0VNRFVr?= =?utf-8?B?YXA3MndjMTVKWnpxWUpBVU1sQUZtbHcxSHlWZjFYMnlKaDhER21CNUJnZUVi?= =?utf-8?B?Rlo2dVBLd2NqKzVGc1JkMEZxRWNmeWRaNlVCbW5MTUZ3K3A0RFROZnpDNkNB?= =?utf-8?B?UUNBSjk2TkdRM0hxWFJXZ29hcmZlV01hV0dPR0dTeXJkV1ZpdzEvZWxiT2ls?= =?utf-8?B?VFJXdUlwYzRBSnVjeVVicmVFMlRpeXBCZFk5NnJCRVZSc1ZiWFZxc0kwUXlh?= =?utf-8?B?aWxqS01tU3J3Y3FGV3hEcnR3aU0yeC9LdFFGNjJKYmdKSDkxeG02RUYxK2Y2?= =?utf-8?B?TE5VY1BWQjUralVtc0g3RHB2VGY4NFdtTk1NOUQ0Nk5nTk90N0FsRFkwUVFT?= =?utf-8?B?cE52NVBWdytoZnVDUmV5MmlvbHB0TVRqVnRScStmWENyWmxQdHRXYi94Q3Zw?= =?utf-8?B?elVtZkk2Y0FaVUgvRWxDUVhneEhJK3JXOFJkT1ZPQzNRdjRrSDZ6d1NnaG43?= =?utf-8?B?b0xYVjlacURkVk81VUlwMmRmNFhDTnlSODU2VVYrMzJ3TDZBQzZRSEtqejdT?= =?utf-8?B?b1lkRG40YTJ6dytkVEdzN29laGh2Rlk1QTBodVVDbVRMZEN4L1RwZ1JZcWQ4?= =?utf-8?B?NWFqcWw1OGxVVnpEMzhobGlqN1RNci9SMEFBZzhuemsxc2traDJ1MU54a3RJ?= =?utf-8?B?b01Qc1YyRkxibDc2OFRBelFEN2NHU2ZhNVozY0ZlZnRBcEh2Wm94Z2pMWUdQ?= =?utf-8?B?MllQcUUwODNNRGd2UG5OMHcwbDNpTHpDN2hQTlZ2QVJhbXNyekhKbGNYV0U4?= =?utf-8?B?dXVGSzBoRUpxRTM3SkNROXFJL05OMS9pZSt4UnZ1TlZkN3ZIZ3ZtdUF6aDhT?= =?utf-8?B?aWd3QkRPbTJyRG5HcTAyNXpITlJPcFRKcjFKb29FelF0eW5uR1FHRUkrSDl2?= =?utf-8?B?c3BRbk80citLaDZFZTRkWVRad241YW5qVEN2OUxZZkMvS1cvK09GVzl3WkZM?= =?utf-8?B?VzI5RXdndkJOMnJTbm9pM3NmMWpHd2JST1M2eEVtMFFiMXlwOVducXBTV1p1?= =?utf-8?B?UnVRUDlSUnkzTmFxcU4xUWE5Q2RFZXZrSGFnQzIzUzBsalV0aVZNb2w4cXA2?= =?utf-8?B?bEZManUwZnd0ZDZaZGVlOXVKd2NHcGp5ZkVodEtqekt4Y2Y3d3hRVExZaUd0?= =?utf-8?B?YzRLWjlsV2djY0NkYWJ5bVlvV0pUMFdoNm5tUFlkYnZXODFUMG5TblVGRjcr?= =?utf-8?B?NDlyZmQ5UWpLcWZvRUNSQ0UrdVhjWXJRR0huRmVZYW5MM0pUdmRZdHU3Q0ps?= =?utf-8?B?S1Avc09MZlVjSGlkYktBRUlEbTlxbURpTGMvOVZ5emV3YTNQUjFBZmNhVEhS?= =?utf-8?B?NjZNbVA4NTN4L0N6S2oxN3ZhR1ZYOFJueXFvb1h5TFFyTXZhREJkdDdaY1d2?= =?utf-8?B?TTI5c3NJZnNQWnBLVkhyTkczMm01K3JOdjdrV0J1OWxPckM3NkQ4czZXN1Ur?= =?utf-8?B?ZitiMmJwOEtiN1VlSVRpZzlxZXVJT3U4N0lJQ1p1ZVZTOHd5cHRHOEJRZDBk?= =?utf-8?B?TGdVdHFRVXduODI5THNya2M2RFI1QU50WVFqeHVZYmV0aVlwemVzS2YrbEQ1?= =?utf-8?Q?kv38cxyokfsc3/5U=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44f8aeea-2c98-48ce-9d02-08df3126464d X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2026 16:54:16.9468 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZWISViOQmsHFxX1khkYJGY0zO/5vUJBqWfL3RrYhNCpYFdZiS4B5eO47raRt2VqCewMnzt+jjcf8huYoTVo0MJ+nmsCjTsAY5PwC+iMGQMk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7519 The dma-buf fds are created without O_CLOEXEC, so they leak into any exec'ed program. With cpr-exec, every update leaks one fd per mmapped BAR, as new QEMU creates its own. Fixes: 96163e0dbcb4 ("hw/vfio/region: Create dmabuf for PCI BAR per region") Signed-off-by: Andrey Drobyshev --- hw/vfio/region.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/region.c b/hw/vfio/region.c index 1deaef12fd0..b0332f27fcd 100644 --- a/hw/vfio/region.c +++ b/hw/vfio/region.c @@ -258,7 +258,7 @@ static bool vfio_region_create_dma_buf(VFIORegion *region, Error **errp) dma_buf = (void *)feature->data; *dma_buf = (struct vfio_device_feature_dma_buf) { .region_index = region->nr, - .open_flags = O_RDWR, + .open_flags = O_RDWR | O_CLOEXEC, .nr_ranges = region->nr_mmaps, }; -- 2.47.1