From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11022100.outbound.protection.outlook.com [52.101.66.100]) by lore.virtuozzo.com (Postfix) with ESMTPS id A250F80474 for ; Mon, 26 Oct 2026 17:49:35 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EFsjVgz2jYNwawbM6bJ2r23L7pPHussG9k4wbt17H/1/Y6HusqFforeB+svbBK0rTnH3cvRkj9aN1mUp0ml6SD6euPPQ7/gPxvGdbcfy0LRdVjkk3JyG5INLPkro3mUc/gqt8684h4aQWUFXwa/xMibgMZd02zquJq0/jh5e/mg71zx2xTBFnz4M+8N56cKZyU7wjrp8zYHQHT6WuKKnJkLzQcBNu7gk3OP9/5d2f5UX96RFuik33Cs9GR7G5klMvXxVrjP54G+AsjQDbGjcuAtrbSFuv/xojodGNuRjqRV2bKl0GlwvoAwGcKUqFLLDCeG74n51+v1jWklquCZL1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y/iwT/AGjCNcSxrfqAAqOPhHLzc2frHTvZPgaQ+6pow=; b=XypRImo2r+jJqNdzwaZmnFkeqmLaTt8PNTvJcTttEBUA6v3zPWDlZv93czrrH78xxeIX1RwwRdWaPqZs1HA9eCIMLw1dYsYUaKtq0QcZq22Ow9IPzoxdDtd7buxK++7ajW3P8pGTtshdFR+CtKPoT6rVIbqLnyC31U9w81cAlpb3h8EvE3JZ3gRneMRonWy1MrfZOAZUDuF9scf0ZPYJn5FhqBtv1qTbFHrKbUFXIIXDCeTdwklcmubVDrH8mioIsISvbpMFL3XV6mBZLfR49t0QZ8a7JEXOY0als2p53T0odkfxNa9Dx3bFRaDaHX12YRDxN8iq7/dhwawk9Z3rQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 2a00:1450:4864:20::32d) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=openvz.org; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=openvz.org; dkim=pass (signature was verified) header.d=openvz.org; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y/iwT/AGjCNcSxrfqAAqOPhHLzc2frHTvZPgaQ+6pow=; b=iSalRsSg+bdEXwcZYAx/LDTMhFYSnhM73/1kW7KjWK3ekgQWTY6A6AX0v/POe31cqEirZqJrfzNMWTzXB1L+B4anNLHiks0e9vuvSoHMbkOpCEHbrlrBJ0rhL1eZ61W93hr6NxAZizrOSCpcy4jZvSKOY7+vO59JLxNxzpJG+Rg= Received: from ZR0P278CA0149.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:41::11) by BR0PR08MB332669.eurprd08.prod.outlook.com (2603:10a6:2c8:47::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Mon, 26 Oct 2026 17:49:32 +0000 Received: from ZR1PEPF0000E461.eurprd04.prod.outlook.com (2603:10a6:910:41:cafe::d) by ZR0P278CA0149.outlook.office365.com (2603:10a6:910:41::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.22 via Frontend Transport; Mon, 26 Oct 2026 17:49:32 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 2a00:1450:4864:20::32d) smtp.mailfrom=openvz.org; dkim=pass (signature was verified) header.d=openvz.org;dmarc=pass action=none header.from=openvz.org; Received-SPF: Pass (protection.outlook.com: domain of openvz.org designates 2a00:1450:4864:20::32d as permitted sender) receiver=protection.outlook.com; client-ip=2a00:1450:4864:20::32d; helo=mail-wm1-x32d.google.com; pr=C Received: from mail-wm1-x32d.google.com (2a00:1450:4864:20::32d) by ZR1PEPF0000E461.mail.protection.outlook.com (2603:10a6:918::13b) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Mon, 26 Oct 2026 17:49:32 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4a4d7ae1ae9so16327305e9.1 for ; Mon, 26 Oct 2026 10:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1793036971; x=1793641771; darn=virtuozzo.com; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=y/iwT/AGjCNcSxrfqAAqOPhHLzc2frHTvZPgaQ+6pow=; b=fNJhuDolxSGo3fW13eP/FvavZWF36w+edotcY3GpkK0vFh5oeFGDFhIRlqph5qF4hN ncjXNlo/zKrQ2yB6QxnhNWvnE1/9waru5ViKSZGX3Yptax3QQSCI4+UlN5UQyqOnEvqw RXoWHe+XHmaw/SDTMtAnLkIQXjD09u1Vy3jZ2PyJIeYKB7FXvgD3jeuSGI6H21IO0Wyb qPsX8ucilbYraMcD1X8/h64UsIqL3JUQQbOApye0tQ8DIz7jtG+GYM/9/ZC5YDo0GOGt pJsrBCgFsgxAz1oAReq1S7JpPyZAT4cUdmncPNGtcCZKzFQNPkYevwWZX3SPJ1OhyoMY xE/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793036971; x=1793641771; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=y/iwT/AGjCNcSxrfqAAqOPhHLzc2frHTvZPgaQ+6pow=; b=L4czHy3gskXFnraYnw7e+kfkWB1DLHKebgFtkIVOTJVwfZrxucpXg/GqlJSF8u0Ngr WT0n1KFbOxMUdgvMrbh9f+jXYx2v6idLNcYfAgpGicdnPd3G4/1nDTrYE6Vf4Oh8tE2r GE/rKNXq3cFhb/ZanLGa7NcL8V3yltTjfT6oXIiu0GWcqUIIEPo+wtYMj+sHl669Fv+Y 56mJrEB6oDTpIphZgVv4l9F5+6TTJn+WxqIFiIieOXp8obnUfKGA7YoXm/z4WYnwmfZz nOV2xdpjkKy2xymq1r6CutnfmTW5PpFNsgCJUzvCl3N2Px3euFAmuAmpH0gTHDEiTLpC 1bAQ== X-Gm-Message-State: AFq9FYKvqmj1iDQ0yvGZ26+Qqn4jEANbGkXd8aK7f+oSbBdQs4j60har EDqMxiO8um4ttpi8ZdKBx0pv0pLSilt2hyYTm3HZ0ediWfTkZnL3hHD7qSBQfiPaOwlyJlyk74d EOctpIQk= X-Gm-Gg: AYBFou1SveJZ6btr28lT96bo9bm8jbRrWQVZbERQso3kPJTyQjzBN+0L91PbcsGln/g X2lFW0/vYwg2BEun51W98V4USUrKYGlRRHtXKyrx/FEi2wCM9vDmO8xA3VjfrOn5AX/utD4Xf/n RL83c+pIT5AHYHnn7+G28nLVSuVs2rPQ17EAe4I3j6s3a4wL6su6sok8EAbsZuCL2MFSqr7itmz Z7kfiyMxM7JgWJTZWHmLWTPiYf1V/6jDj7TA6mCzFsUkEYRdMi+VXLwW1XF15KBFsm97V3qJPE6 Q2Zf70XkL9rdo4NLkY//brkC0HXwvZzPk31eDS0KpHKSoxJ/xl0u9IiR/DScah62CxINmITKGaC LIVS6POcJl1pnNknKx7MzlVWAe4GFUra28Z2UNGN+bf78zRQdN8dMn1eK7z04vleJQ6P9/2Wx1K eCrzgBbO5yXc4ch0rGIMFGg8UB3iYzBRaSGIjSHilWr84dDKtaubtPMnZo5F/egtmHZADGXecRU RAsy73r+8CDZDbaUKVcNOFvib2kkPY2lAPS1NcS5UmoD7JXxhvodpfHQWt9Ro7W3J9blOPf X-Received: by 2002:a05:600c:46c5:b0:4a2:1364:252b with SMTP id 5b1f17b1804b1-4a35acba20dmr147276875e9.35.1793036971544; Mon, 26 Oct 2026 10:49:31 -0700 (PDT) Received: from athena.sw.ru ([2a06:5b06:b600:300:1a6:7f7f:f573:ba9e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a35a574088sm196211485e9.9.2026.10.26.10.49.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 10:49:31 -0700 (PDT) From: "Denis V. Lunev" To: andrey.drobyshev@virtuozzo.com Cc: svt-core@virtuozzo.com, den@openvz.org Subject: [PATCH hci-8.1 0/5] scsi-disk: fix UNMAP and WRITE SAME racing with inactivation #VSTOR-151532 Date: Mon, 26 Oct 2026 18:49:24 +0100 Message-ID: <20261026174929.685720-1-den@openvz.org> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ZR1PEPF0000E461:EE_|BR0PR08MB332669:EE_ X-MS-Office365-Filtering-Correlation-Id: a7b3eae8-f140-4427-08d8-08df33897db3 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 0 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704161411799003|82310400026|6059299003|376014|48200799018|43022699015|9140799003|61400799027|16102099003|18002099003|55112099003|261026121527099003|5063699009|56012099006|261022075727099003|261021123027099003|10067099003|261009223027099003|261021121427099003|261022105027099003|261026140227099003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?H7G4T3sPoZNEhIq3HepKANNODwF4zMCjavNB0CmKuDBeNy+05VVd/tpQt8dj?= =?us-ascii?Q?vSJ6sQwEpATctVhcnDoj/gClM0z+/HP2CQngxnwS0VPJFaLFujgZx+UYZ03K?= =?us-ascii?Q?N32UeFMeI65C7cFYDs8LZ6fNnjRtea8iqC2dVBmL2rF6xPb+5WnHA64O7Hif?= =?us-ascii?Q?jajPT4I7PQzmob9nNHdgLWn66FzG97G3he0PkhV7cKk7lvz5zDP32VOHTOsp?= =?us-ascii?Q?E77mBEqezcnDCqlTzM2qxrbOmiWeqUN84pO3SnmU1A6Va1TlEOKJzRVeim8c?= =?us-ascii?Q?ko11jTmsCJzkdy8F5phhoGx4PnA1sxIXFod7fbOEiXRZ9dRE1q+f5zvUIS+d?= =?us-ascii?Q?e3aKFgMRHUOd99acC75PRnh6ksJSD0phNtFAdfBWrb2a/WFvYJPQajSzzsLD?= =?us-ascii?Q?S/I+FU7hAteqm7qoLue6XNSkPLlXdflCG+/8E0HtOKb8j7k4KvG/2bN4quPk?= =?us-ascii?Q?kVyx0n70oKdF82eVWYHP0hZ/1GWIifzKAjZmjIW1FXVa/hqqGy5VlS1AN8m7?= =?us-ascii?Q?QzGqUFAU6R2fEMlC6mHmWP+8E0G0aTYV4t2BpnP/Olicgnvu9zz5B22dZCHM?= =?us-ascii?Q?sKlpz8VPdzZ5Nv9CPtafV+/e2NJ2V5+ezblWs7raO51IzgQKSWzYKyNPZ3gr?= =?us-ascii?Q?U3JmZbh26xLYrIe8IQw1gSitJ1ztp9n2aetpvcaCiZmWygZEwBtmIGLQVqWd?= =?us-ascii?Q?Rew27imfPOshGmCMiSkPAtDn2lqTvydB96SziPIQu+vuLBLtz+OKbla6zRfU?= =?us-ascii?Q?xNUed180vdlrVVm1T9DtqjQ8BNw1a1dWeFtkHrgnosMJiCsZsVlbnRmwvEKC?= =?us-ascii?Q?KzYFcjcz/ljR03+qBw6+2i7MYTUy0y6CMq73D+zHzixtK1TesHN+GFBInyVg?= =?us-ascii?Q?xsWxCYwpwUq7BSf923P+u2GrBe8tlS9Pk0QC9ZAihxplozibJ0gEnDvlZ4Vj?= =?us-ascii?Q?yHKeDBB7U4Ipm4owaWb1p9VYL2eGMe7Crg90GUmr0KjVDIxr57+n1BNG+hWA?= =?us-ascii?Q?Dm6p5YMNH6QSmCpcAywCr3XK1A=3D=3D?= X-Forefront-Antispam-Report: CIP:2a00:1450:4864:20::32d;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail-wm1-x32d.google.com;PTR:mail-wm1-x32d.google.com;CAT:NONE;SFS:(13230040)(704161411799003)(82310400026)(6059299003)(376014)(48200799018)(43022699015)(9140799003)(61400799027)(16102099003)(18002099003)(55112099003)(261026121527099003)(5063699009)(56012099006)(261022075727099003)(261021123027099003)(10067099003)(261009223027099003)(261021121427099003)(261022105027099003)(261026140227099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: m2G3R3EK0iensseMi0bFjz9gIgzK7fBFwjL4EtRYZuo1U6NIB41xc4J3OyeHsu4H04lUX9p68vMBpFKZpVDwjzOZqRucw9DEGBbd8z/Sv3mni2riqb4U8YHECyEbnOQvnNYuJG6+gDNsK2pRruTi2ylBwEtPNJPKZn0EiuZFccvgv2EgEE8hu8TzKZ7wpkFqoumsnfU5Uygj1P3bZQTolaVTrSbOZnCjaYc+XftrYQknSFFpAWceu4neZr/7qpb2M4yhDGXHTkNDfDj6cfepTshgrjo+LOx1Pcf4OiCaXC1eGsLQ8IP4usBgBKGGnaCop6mg+HWrCQt+bxz9O6K+ZV/eRixMq3oemVQirb4VitKqVcEbS5qr18h7LSU0uH2FxF2aPCj9tdCjOenVUnK6ogh+1slIbw6bQ4nycCtNpFFd9FEeBPlry5tXIX8pjT8X X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2026 17:49:32.1347 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a7b3eae8-f140-4427-08d8-08df33897db3 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: ZR1PEPF0000E461.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: BR0PR08MB332669 List-Id: scsi-disk splits UNMAP into one discard per descriptor and a non-zero WRITE SAME into 512 KiB writes, submitting each step from the completion callback of the previous one. A drain in between only waits for the step in flight; the next one is queued by blk_wait_while_drained() and resumed by drain_end. When the drain is the one in bdrv_inactivate_all() (end of live migration, blockdev-set-active), the resumed request hits an inactive node: bdrv_co_write_req_prepare: Assertion `!(bs->open_flags & BDRV_O_INACTIVE)' failed. We hit this in production on a guest UNMAP with 38 descriptors. The fix follows the one Kevin did for IDE TRIM: https://lore.kernel.org/qemu-devel/20260421161132.99878-1-kwolf@redhat.com/ Signed-off-by: Denis V. Lunev Cc: Paolo Bonzini Cc: Kevin Wolf Cc: Hanna Reitz Cc: Fabiano Rosas Cc: Laurent Vivier Cc: qemu-stable@nongnu.org Denis V. Lunev (5): scsi-disk: check all UNMAP descriptors before discarding any #VSTOR-151532 scsi-disk: fix UNMAP racing with inactivation of block nodes #VSTOR-151532 scsi-disk: fix WRITE SAME racing with inactivation of block nodes #VSTOR-151532 virtio-scsi-test: split virtio_scsi_do_command() into submit and wait #VSTOR-151532 virtio-scsi-test: test UNMAP and WRITE SAME during inactivation #VSTOR-151532 hw/scsi/scsi-disk.c | 278 +++++++++++++++++++-------------- tests/qtest/virtio-scsi-test.c | 173 +++++++++++++++++--- 2 files changed, 309 insertions(+), 142 deletions(-) base-commit: 81aea91c7f71cba39b4c3340579d45f0256a91d8 -- 2.53.0